mambax7 / smartobject

class/Category.php

<?php namespace XoopsModules\Smartobject;

/**
 * Contains the basic classe for managing a category object based on SmartObject
 *
 * @license    GNU
 * @author     marcan <marcan@smartfactory.ca>
 * @link       http://smartfactory.ca The SmartFactory
 * @package    SmartObject
 * @subpackage SmartObjectItems
 */

use XoopsModules\Smartobject;

// defined('XOOPS_ROOT_PATH') || die('Restricted access');
//require_once XOOPS_ROOT_PATH . '/modules/smartobject/class/smartseoobject.php';

/**
 * Class SmartobjectCategory
 */
class Category extends Smartobject\SeoObject
{
    public $_categoryPath;

    /**
     * SmartobjectCategory constructor.
     */
    public function __construct()
    {
        $this->initVar('categoryid', XOBJ_DTYPE_INT, '', true);
        $this->initVar('parentid', XOBJ_DTYPE_INT, '', false, null, '', false, _CO_SOBJECT_CATEGORY_PARENTID, _CO_SOBJECT_CATEGORY_PARENTID_DSC);
        $this->initVar('name', XOBJ_DTYPE_TXTBOX, '', false, null, '', false, _CO_SOBJECT_CATEGORY_NAME, _CO_SOBJECT_CATEGORY_NAME_DSC);
        $this->initVar('description', XOBJ_DTYPE_TXTAREA, '', false, null, '', false, _CO_SOBJECT_CATEGORY_DESCRIPTION, _CO_SOBJECT_CATEGORY_DESCRIPTION_DSC);
        $this->initVar('image', XOBJ_DTYPE_TXTBOX, '', false, null, '', false, _CO_SOBJECT_CATEGORY_IMAGE, _CO_SOBJECT_CATEGORY_IMAGE_DSC);

        $this->initCommonVar('doxcode');

        $this->setControl('image', ['name' => 'image']);
        $this->setControl('parentid', ['name' => 'parentcategory']);
        $this->setControl('description', [
            'name'        => 'textarea',
            'itemHandler' => false,
            'method'      => false,
            'module'      => false,
            'form_editor' => 'default'
        ]);

        // call parent constructor to get SEO fields initiated
        parent::__construct();
    }

    /**
     * returns a specific variable for the object in a proper format
     *
     * @access public
     * @param  string $key    key of the object's variable to be returned
     * @param  string $format format to use for the output
     * @return mixed  formatted value of the variable
     */
    public function getVar($key, $format = 's')

This method seems to be duplicated in your project.

    {
        if ('s' === $format && in_array($key, ['description', 'image'])) {
            //            return call_user_func(array($this, $key));
            return $this->{$key}();
        }

        return parent::getVar($key, $format);
    }

    /**
     * @return string
     */
    public function description()
    {
        return $this->getValueFor('description', false);
    }

    /**
     * @return bool|mixed
     */
    public function image()
    {
        $ret = $this->getVar('image', 'e');
        if ('-1' == $ret) {
            return false;
        } else {
            return $ret;
        }
    }

    /**
     * @return array
     */
    public function toArray()
    {
        $this->setVar('doxcode', true);
        global $myts;
        $objectArray = parent::toArray();
        if ($objectArray['image']) {
            $objectArray['image'] = $this->getImageDir() . $objectArray['image'];
        }

        return $objectArray;
    }

    /**
     * Create the complete path of a category
     *
     * @todo this could be improved as it uses multiple queries
     * @param  bool $withAllLink make all name clickable
     * @param  bool $currentCategory
     * @return string complete path (breadcrumb)
     */
    public function getCategoryPath($withAllLink = true, $currentCategory = false)
    {
//        require_once SMARTOBJECT_ROOT_PATH . 'class/smartobjectcontroller.php';
        $controller = new ObjectController($this->handler);

        if (!$this->_categoryPath) {
            if ($withAllLink && !$currentCategory) {
                $ret = $controller->getItemLink($this);
            } else {
                $currentCategory = false;
                $ret             = $this->getVar('name');
            }
            $parentid = $this->getVar('parentid');
            if (0 != $parentid) {
                $parentObj = $this->handler->get($parentid);
                if ($parentObj->isNew()) {
                    exit;
                }
                $parentid = $parentObj->getVar('parentid');

$parentid is not used, you could remove the assignment.

                $ret      = $parentObj->getCategoryPath($withAllLink, $currentCategory) . ' > ' . $ret;
            }
            $this->_categoryPath = $ret;
        }

        return $this->_categoryPath;
    }
}