Issues in update.php (master) - Issues in master - mambax7/smartobject - Measure and Improve Code Quality continuously with Scrutinizer

Issues (496)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

admin/update.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *
 * Module: SmartSection
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 */

use XoopsModules\Wfdownloads;
use XoopsModules\Smartobject;

require_once __DIR__ . '/admin_header.php';
require_once SMARTCONTENT_ROOT_PATH . 'class/dbupdater.php';

smartcontent_xoops_cp_header();

// =========================================================================================
// This function updates any existing table of a 2.x version to the format used
// in the release of WF-Downloads 3.00
// =========================================================================================
function update_tables_to_300()
{
    $dbupdater = new Wfdownloads\Dbupdater();

    if (!wfdownloads_TableExists('wfdownloads_meta')) {
        // Create table wfdownloads_meta
        $table = new Wfdownloads\DbupdaterTable('wfdownloads_meta');
        $table->setStructure("CREATE TABLE `%s` (
                                metakey varchar(50) NOT NULL default '',
                                metavalue varchar(255) NOT NULL default '',
                                PRIMARY KEY (metakey))
                                ENGINE=MyISAM;");

        $table->setData(sprintf("'version', %s", round($GLOBALS['xoopsModule']->getVar('version') / 100, 2)));
        if ($dbupdater->updateTable($table)) {
            echo 'wfdownloads_meta table created<br>';
        }
    }

    $download_fields = [
        'lid'           => ['Type' => 'int(11) unsigned NOT NULL auto_increment', 'Default' => false],
        'cid'           => ['Type' => "int(5) unsigned NOT NULL default '0'", 'Default' => true],
        'title'         => ['Type' => "varchar(100) NOT NULL default ''", 'Default' => true],
        'url'           => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'filename'      => ['Type' => "varchar(150) NOT NULL default ''", 'Default' => true],
        'filetype'      => ['Type' => "varchar(100) NOT NULL default ''", 'Default' => true],
        'homepage'      => ['Type' => "varchar(100) NOT NULL default ''", 'Default' => true],
        'version'       => ['Type' => "varchar(20) NOT NULL default ''", 'Default' => true],
        'size'          => ['Type' => "int(8) NOT NULL default '0'", 'Default' => true],
        'platform'      => ['Type' => "varchar(50) NOT NULL default ''", 'Default' => true],
        'screenshot'    => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'submitter'     => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'publisher'     => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'status'        => ['Type' => "tinyint(2) NOT NULL default '0'", 'Default' => true],
        'date'          => ['Type' => "int(10) NOT NULL default '0'", 'Default' => true],
        'hits'          => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'rating'        => ['Type' => "double(6,4) NOT NULL default '0.0000'", 'Default' => true],
        'votes'         => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'comments'      => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'license'       => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'mirror'        => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'price'         => ['Type' => "varchar(10) NOT NULL default 'Free'", 'Default' => true],
        'paypalemail'   => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'features'      => ['Type' => 'text NOT NULL', 'Default' => false],
        'requirements'  => ['Type' => 'text NOT NULL', 'Default' => false],
        'homepagetitle' => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'forumid'       => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'limitations'   => ['Type' => "varchar(255) NOT NULL default '30 day trial'", 'Default' => true],
        'dhistory'      => ['Type' => 'text NOT NULL', 'Default' => false],
        'published'     => ['Type' => "int(11) NOT NULL default '1089662528'", 'Default' => true],
        'expired'       => ['Type' => "int(10) NOT NULL default '0'", 'Default' => true],
        'updated'       => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'offline'       => ['Type' => "tinyint(1) NOT NULL default '0'", 'Default' => true],
        'description'   => ['Type' => 'text NOT NULL', 'Default' => false],
        'ipaddress'     => ['Type' => "varchar(120) NOT NULL default '0'", 'Default' => true],
        'notifypub'     => ['Type' => "int(1) NOT NULL default '0'", 'Default' => true],
        'summary'       => ['Type' => 'text NOT NULL', 'Default' => false]
    ];

    $renamed_fields = [
        'logourl' => 'screenshot'
    ];

    echo '<br><b>Checking Download table</b><br>';
    $helperWfdownloads = \Xmf\Module\Helper::getHelper('wfdownloads');
    $downloadHandler = $helperWfdownloads->getHandler('Download');
    $download_table  = new Wfdownloads\DbupdaterTable('wfdownloads_downloads');
    $fields          = get_table_info($downloadHandler->table, $download_fields);
    // Check for renamed fields
    rename_fields($download_table, $renamed_fields, $fields, $download_fields);
    update_table($download_fields, $fields, $download_table);
    if ($dbupdater->updateTable($download_table)) {
        echo 'Downloads table updated<br>';
    }
    unset($fields);

    $mod_fields = [
        'requestid'       => ['Type' => 'int(11) NOT NULL auto_increment', 'Default' => false],
        'lid'             => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'cid'             => ['Type' => "int(5) unsigned NOT NULL default '0'", 'Default' => true],
        'title'           => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'url'             => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'filename'        => ['Type' => "varchar(150) NOT NULL default ''", 'Default' => true],
        'filetype'        => ['Type' => "varchar(100) NOT NULL default ''", 'Default' => true],
        'homepage'        => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'version'         => ['Type' => "varchar(20) NOT NULL default ''", 'Default' => true],
        'size'            => ['Type' => "int(8) NOT NULL default '0'", 'Default' => true],
        'platform'        => ['Type' => "varchar(50) NOT NULL default ''", 'Default' => true],
        'screenshot'      => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'submitter'       => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'publisher'       => ['Type' => 'text NOT NULL', 'Default' => false],
        'status'          => ['Type' => "tinyint(2) NOT NULL default '0'", 'Default' => true],
        'date'            => ['Type' => "int(10) NOT NULL default '0'", 'Default' => true],
        'hits'            => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'rating'          => ['Type' => "double(6,4) NOT NULL default '0.0000'", 'Default' => true],
        'votes'           => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'comments'        => ['Type' => "int(11) unsigned NOT NULL default '0'", 'Default' => true],
        'license'         => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'mirror'          => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'price'           => ['Type' => "varchar(10) NOT NULL default 'Free'", 'Default' => true],
        'paypalemail'     => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'features'        => ['Type' => 'text NOT NULL', 'Default' => false],
        'requirements'    => ['Type' => 'text NOT NULL', 'Default' => false],
        'homepagetitle'   => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'forumid'         => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'limitations'     => ['Type' => "varchar(255) NOT NULL default '30 day trial'", 'Default' => true],
        'dhistory'        => ['Type' => 'text NOT NULL', 'Default' => false],
        'published'       => ['Type' => "int(10) NOT NULL default '0'", 'Default' => true],
        'expired'         => ['Type' => "int(10) NOT NULL default '0'", 'Default' => true],
        'updated'         => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'offline'         => ['Type' => "tinyint(1) NOT NULL default '0'", 'Default' => true],
        'summary'         => ['Type' => 'text NOT NULL', 'Default' => false],
        'description'     => ['Type' => 'text NOT NULL', 'Default' => false],
        'modifysubmitter' => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'requestdate'     => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true]
    ];

    $renamed_fields = [
        'logourl' => 'screenshot'
    ];

    echo '<br><b>Checking Modified Downloads table</b><br>';
//    $moduleHandler = xoops_getModuleHandler('modification', 'wfdownloads');
    $helperWfdownloads = \Xmf\Module\Helper::getHelper('wfdownloads');
    $moduleHandler = $helperWfdownloads->getHandler('Modification');
    $mod_table     = new Wfdownloads\DbupdaterTable('wfdownloads_mod');
    $fields        = get_table_info($moduleHandler->table, $mod_fields);
    rename_fields($mod_table, $renamed_fields, $fields, $mod_fields);
    update_table($mod_fields, $fields, $mod_table);
    if ($dbupdater->updateTable($mod_table)) {
        echo 'Modified Downloads table updated <br>';
    }
    unset($fields);

    $cat_fields = [
        'cid'          => ['Type' => 'int(5) unsigned NOT NULL auto_increment', 'Default' => false],
        'pid'          => ['Type' => "int(5) unsigned NOT NULL default '0'", 'Default' => true],
        'title'        => ['Type' => "varchar(50) NOT NULL default ''", 'Default' => true],
        'imgurl'       => ['Type' => "varchar(255) NOT NULL default ''", 'Default' => true],
        'description'  => ['Type' => 'text NULL', 'Default' => true],
        'total'        => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'summary'      => ['Type' => 'text NOT NULL', 'Default' => false],
        'spotlighttop' => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'spotlighthis' => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'dohtml'       => ['Type' => "tinyint(1) NOT NULL default '1'", 'Default' => true],
        'dosmiley'     => ['Type' => "tinyint(1) NOT NULL default '1'", 'Default' => true],
        'doxcode'      => ['Type' => "tinyint(1) NOT NULL default '1'", 'Default' => true],
        'doimage'      => ['Type' => "tinyint(1) NOT NULL default '1'", 'Default' => true],
        'dobr'         => ['Type' => "tinyint(1) NOT NULL default '1'", 'Default' => true],
        'weight'       => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true]
    ];
    echo '<br><b>Checking Category table</b><br>';
//    $catHandler = xoops_getModuleHandler('category', 'wfdownloads');
    $helperWfdownloads = \Xmf\Module\Helper::getHelper('wfdownloads');
    $catHandler = $helperWfdownloads->getHandler('Report');

    $cat_table  = new Wfdownloads\DbupdaterTable('wfdownloads_cat');
    $fields     = get_table_info($catHandler->table, $cat_fields);
    update_table($cat_fields, $fields, $cat_table);
    if ($dbupdater->updateTable($cat_table)) {
        echo 'Category table updated<br>';
    }
    unset($fields);

    $broken_fields = [
        'reportid'     => ['Type' => 'int(5) NOT NULL auto_increment', 'Default' => false],
        'lid'          => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'sender'       => ['Type' => "int(11) NOT NULL default '0'", 'Default' => true],
        'ip'           => ['Type' => "varchar(20) NOT NULL default ''", 'Default' => true],
        'date'         => ['Type' => "varchar(11) NOT NULL default '0'", 'Default' => true],
        'confirmed'    => ['Type' => "enum('0','1') NOT NULL default '0'", 'Default' => true],
        'acknowledged' => ['Type' => "enum('0','1') NOT NULL default '0'", 'Default' => true]
    ];
    echo '<br><b>Checking Broken Report table</b><br>';
    $helperWfdownloads = \Xmf\Module\Helper::getHelper('wfdownloads');
    $brokenHandler = $helperWfdownloads->getHandler('Report');
//    $brokenHandler = xoops_getModuleHandler('report', 'wfdownloads');
    $broken_table  = new Wfdownloads\DbupdaterTable('wfdownloads_broken');
    $fields        = get_table_info($brokenHandler->table, $broken_fields);
    update_table($broken_fields, $fields, $broken_table);
    if ($dbupdater->updateTable($broken_table)) {
        echo 'Broken Reports table updated<br>';
    }
    unset($fields);
}

// =========================================================================================
// we are going to change the names for the fields like nohtml, nosmilies, noxcode, noimage, nobreak in
// the wfdownloads_cat table into dohtml, dosmilies and so on.  Therefore the logic will change
// 0=yes  1=no and the currently stored value need to be changed accordingly
// =========================================================================================
/**
 * @return array|bool
 */
function invert_nohtm_dohtml_values()
{
    $ret = [];
    global $xoopsDB;
    $helperWfdownloads = \Xmf\Module\Helper::getHelper('wfdownloads');
    $catHandler = $helperWfdownloads->getHandler('Category');
    $result     = $xoopsDB->query('SHOW COLUMNS FROM ' . $catHandler->table);
    while (false !== ($existing_field = $xoopsDB->fetchArray($result))) {
        $fields[$existing_field['field']] = $existing_field['type'];
    }
    if (in_array('nohtml', array_keys($fields))) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $dbupdater = new Wfdownloads\Dbupdater();
        //Invert column values
        // alter options in wfdownloads_cat
        $table = new Wfdownloads\DbupdaterTable('wfdownloads_cat');
        $table->addAlteredField('nohtml', "dohtml tinyint(1) NOT NULL DEFAULT '1'");
        $table->addAlteredField('nosmiley', "dosmiley tinyint(1) NOT NULL DEFAULT '1'");
        $table->addAlteredField('noxcodes', "doxcode tinyint(1) NOT NULL DEFAULT '1'");
        $table->addAlteredField('noimages', "doimage tinyint(1) NOT NULL DEFAULT '1'");
        $table->addAlteredField('nobreak', "dobr tinyint(1) NOT NULL DEFAULT '1'");

        //inverting values no=1 <=> do=0
        // have to store teporarly as value = 2 to
        // avoid putting everithing to same value
        // if you change 1 to 0, then 0 to one,
        // every value will be 1, follow me?
        $table->addUpdatedWhere('dohtml', 2, '=1');
        $table->addUpdatedWhere('dohtml', 1, '=0');
        $table->addUpdatedWhere('dohtml', 0, '=2');

        $table->addUpdatedWhere('dosmiley', 2, '=1');
        $table->addUpdatedWhere('dosmiley', 1, '=0');
        $table->addUpdatedWhere('dosmiley', 0, '=2');

        $table->addUpdatedWhere('doxcode', 2, '=1');
        $table->addUpdatedWhere('doxcode', 1, '=0');
        $table->addUpdatedWhere('doxcode', 0, '=2');

        $table->addUpdatedWhere('doimage', 2, '=1');
        $table->addUpdatedWhere('doimage', 1, '=0');
        $table->addUpdatedWhere('doimage', 0, '=2');
        $ret = $dbupdater->updateTable($table);
    }

    return $ret;
}

/**
 * Updates a table by comparing correct fields with existing ones
 *
 * @param  array            $new_fields
 * @param  array            $existing_fields
 * @param  Wfdownloads\DbupdaterTable $table
 * @return void
 */
function update_table($new_fields, $existing_fields, &$table)
{
    foreach ($new_fields as $field => $fieldinfo) {
        $type = $fieldinfo['Type'];
        if (!in_array($field, array_keys($existing_fields))) {
            //Add field as it is missing
            $table->addNewField($field, $type);
        //$xoopsDB->query("ALTER TABLE ".$table." ADD ".$field." ".$type);
            //echo $field."(".$type.") <FONT COLOR='##22DD51'>Added</FONT><br>";
        } elseif ($existing_fields[$field] != $type) {
            $table->addAlteredField($field, $field . ' ' . $type);
        // check $fields[$field]['type'] for things like "int(10) unsigned"
            //$xoopsDB->query("ALTER TABLE ".$table." CHANGE ".$field." ".$field." ".$type);
            //echo $field." <FONT COLOR='#FF6600'>Changed to</FONT> ".$type."<br>";
        } else {
            //echo $field." <FONT COLOR='#0033FF'>Uptodate</FONT><br>";
        }
    }
}

/**
 * Get column information for a table - we'll need to send along an array of fields to determine
 * whether the "Default" index value should be appended
 *
 * @param  string $table
 * @param  array  $default_fields
 * @return array
 */
function get_table_info($table, $default_fields)
{
    global $xoopsDB;
    $result = $xoopsDB->query('SHOW COLUMNS FROM ' . $table);
    while (false !== ($existing_field = $xoopsDB->fetchArray($result))) {
        $fields[$existing_field['Field']] = $existing_field['Type'];
        if ('YES' !== $existing_field['Null']) {
            $fields[$existing_field['Field']] .= ' NOT NULL';
        }
        if ($existing_field['Extra']) {
            $fields[$existing_field['Field']] .= ' ' . $existing_field['Extra'];
        }
        if ($default_fields[$existing_field['Field']]['Default']) {
            $fields[$existing_field['Field']] .= " default '" . $existing_field['Default'] . "'";
        }
    }

    return $fields;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

/**
 * Renames fields in a table and updates the existing fields array to reflect it.
 *
 * @param  Wfdownloads\DbupdaterTable $table
 * @param  array            $renamed_fields
 * @param  array            $fields
 * @param  array            $new_fields
 * @return void
 */
function rename_fields(&$table, $renamed_fields, &$fields, $new_fields)
{
    foreach (array_keys($fields) as $field) {
        if (in_array($field, array_keys($renamed_fields))) {
            $new_field_name = $renamed_fields[$field];
            $new_field_type = $new_fields[$new_field_name]['Type'];
            $table->addAltered($field, $new_field_name . ' ' . $new_field_type);
            //$xoopsDB->query("ALTER TABLE ".$table." CHANGE ".$field." ".$new_field_name." ".$new_field_type);
            //echo $field." Renamed to ".$new_field_name."<br>";
            $fields[$new_field_name] = $new_field_type;
        }
    }
    //return $fields;
}

$op = \Xmf\Request::getInt('op', 0, 'REQUEST');
switch ($op) {
    case 1:
        // Make sure that nohtml is properly changed to dohtml
        invert_nohtm_dohtml_values();
        // Ensure that the proper tables are present
        update_tables_to_300();
        // Import data from MyDownloads
        import_mydownloads_to_wfdownloads();
        break;

    case 2:
        // Update WF-Downloads
        $log = invert_nohtm_dohtml_values();
        update_tables_to_300();
        break;

    default:
        //ask what to do
        include XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
        $form = new \XoopsThemeForm('Upgrade WF-Downloads', 'form', $_SERVER['REQUEST_URI']);

        //Is MyDownloads installed?
        /** @var XoopsModuleHandler $moduleHandler */
        $moduleHandler     = xoops_getHandler('module');
        $mydownloadsModule = $moduleHandler->getByDirname('mydownloads');
        if (is_object($mydownloadsModule)) {
            $mydownloadsButton = new \XoopsFormButton('Import data from MyDownloads', 'myd_button', 'Import', 'submit');
            $mydownloadsButton->setExtra("onclick='document.forms.form.op.value=\"1\"'");
            $form->addElement($mydownloadsButton);
        }

        if (!wfdownloads_TableExists('wfdownloads_meta')) {
            $updateButton = new \XoopsFormButton('Update WF-Downloads', 'upd_button', 'Update', 'submit');
            $updateButton->setExtra("onclick='document.forms.form.op.value=\"2\"'");
            $form->addElement($updateButton);
        }

        $form->addElement(new \XoopsFormHidden('op', 0));
        $form->display();
        break;
}
//wfdownloads_modFooter();
//xoops_cp_footer();
require_once __DIR__ . '/admin_footer.php';


Issues (496)

Security Analysis not enabled

admin/update.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

mambax7 / smartobject

Issues (496)

Security Analysis not enabled

admin/update.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like