MetaGen - Code Metrics - Inspection of "updates" - mambax7/smartobject - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88111b...b3fce7 )

by Michael

created 2018-03-22 11:20 UTC

MetaGen B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	395
Duplicated Lines	3.04 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	12
loc	395
rs	8.4864
c	0
b	0
f	0
wmc	48
lcom	1
cbo	1

16 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	19	2
A	emptyString()	0	4	1
B	generateSeoTitle()	0	105	3
A	html2text()	0	4	1
F	setTitle()	12	41	16
A	setKeywords()	0	4	1
A	setCategoryPath()	0	5	1
A	setDescription()	0	20	3
A	createTitleTag()	0	3	1
A	purifyText()	0	4	1
A	createMetaDescription()	0	17	3
B	findMetaKeywords()	0	28	5
B	createMetaKeywords()	0	31	6
A	autoBuildMeta_keywords()	0	3	1
A	buildAutoMetaTags()	0	8	1
A	createMetaTags()	0	14	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like MetaGen often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use MetaGen, and based on these observations, apply Extract Interface, too.

<?php namespace XoopsModules\Smartobject;

/**
 * Containing the class to manage meta informations of the SmartObject framework
 *
 * @license    GNU
 * @author     marcan <[email protected]>
 * @link       http://smartfactory.ca The SmartFactory
 * @package    SmartObject
 * @subpackage SmartObjectCore
 */

use XoopsModules\Smartobject;

// defined('XOOPS_ROOT_PATH') || die('Restricted access');


/**
 * Class MetaGen is a class providing some methods to dynamically and automatically customize Meta Tags information
 * @author The SmartFactory <www.smartfactory.ca>
 */
class MetaGen
{
    public $_myts;

    public $_title;
    public $_original_title;
    public $_keywords;
    public $_meta_description;
    public $_categoryPath;
    public $_description;
    public $_minChar = 4;

    /**
     * SmartMetaGen constructor.
     * @param      $title
     * @param bool $keywords
     * @param bool $description
     * @param bool $categoryPath
     */
    public function __construct($title, $keywords = false, $description = false, $categoryPath = false)
    {
        $this->_myts = \MyTextSanitizer::getInstance();
        $this->setCategoryPath($categoryPath);
        $this->setTitle($title);
        $this->setDescription($description);

        if (!$keywords) {
            $keywords = $this->createMetaKeywords();
        }

        /*      $myts = \MyTextSanitizer::getInstance();

         if (method_exists($myts, 'formatForML')) {
         $keywords = $myts->formatForML($keywords);
         $description = $myts->formatForML($description);
         }
         */
        $this->setKeywords($keywords);
    }

    /**
     * Return true if the string is length > 0
     *
     * @credit psylove
     *
     * @var    string $string Chaine de caract�re
     * @return boolean
     */
    public function emptyString($var)
    {
        return (strlen($var) > 0);
    }

    /**
     * Create a title for the short_url field of an article
     *
     * @credit psylove
     *
     * @var    string      $title title of the article
     * @param  bool|string $withExt
     * @return string      sort_url for the article
     */
    public function generateSeoTitle($title = '', $withExt = true)
    {
        // Transformation de la chaine en minuscule
        // Codage de la chaine afin d'éviter les erreurs 500 en cas de caractères imprévus
        $title = rawurlencode(strtolower($title));

        // Transformation des ponctuations
        $pattern = [
            '/%09/', // Tab
            '/%20/', // Space
            '/%21/', // !
            '/%22/', // "
            '/%23/', // #
            '/%25/', // %
            '/%26/', // &
            '/%27/', // '
            '/%28/', // (
            '/%29/', // )
            '/%2C/', // ,
            '/%2F/', // /
            '/%3A/', // :
            '/%3B/', // ;
            '/%3C/', // <
            '/%3D/', // =
            '/%3E/', // >
            '/%3F/', // ?
            '/%40/', // @
            '/%5B/', // [
            '/%5C/', // \
            '/%5D/', // ]
            '/%5E/', // ^
            '/%7B/', // {
            '/%7C/', // |
            '/%7D/', // }
            '/%7E/', // ~
            "/\./" // .
        ];
        $rep_pat = [
            '-',
            '-',
            '-',
            '-',
            '-',
            '-100',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-at-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-',
            '-'
        ];
        $title   = preg_replace($pattern, $rep_pat, $title);

        // Transformation des caractères accentués
        $pattern = [
            '/%B0/', // °
            '/%E8/', // è
            '/%E9/', // é
            '/%EA/', // ê
            '/%EB/', // ë
            '/%E7/', // ç
            '/%E0/', // à
            '/%E2/', // â
            '/%E4/', // ä
            '/%EE/', // î
            '/%EF/', // ï
            '/%F9/', // ù
            '/%FC/', // ü
            '/%FB/', // û
            '/%F4/', // ô
            '/%F6/', // ö
        ];
        $rep_pat = ['-', 'e', 'e', 'e', 'e', 'c', 'a', 'a', 'a', 'i', 'i', 'u', 'u', 'u', 'o', 'o'];
        $title   = preg_replace($pattern, $rep_pat, $title);

        $tableau = explode('-', $title); // Transforme la chaine de caract�res en tableau
        $tableau = array_filter($tableau, [$this, 'emptyString']); // Supprime les chaines vides du tableau
        $title   = implode('-', $tableau); // Transforme un tableau en chaine de caract�res s�par� par un tiret

        if (count($title) > 0) {
            if ($withExt) {
                $title .= '.html';
            }

            return $title;
        } else {
            return '';
        }
    }

    /**
     * @param $document
     * @return mixed
     */
    public function html2text($document)
    {
        return Smartobject\Utility::getHtml2text($document);
    }

    /**
     * @param $title
     */
    public function setTitle($title)
    {
        global $xoopsModule, $xoopsModuleConfig;
        $this->_title          = $this->html2text($title);
        $this->_title          = $this->purifyText($this->_title);
        $this->_original_title = $this->_title;

        $moduleName = $xoopsModule->getVar('name');

        $titleTag = [];

        $show_mod_name_breadcrumb = isset($xoopsModuleConfig['show_mod_name_breadcrumb']) ? $xoopsModuleConfig['show_mod_name_breadcrumb'] : true;

        if ($moduleName && $show_mod_name_breadcrumb) {
            $titleTag['module'] = $moduleName;
        }

        if (isset($this->_title) && ('' !== $this->_title) && (strtoupper($this->_title) != strtoupper($moduleName))) {
            $titleTag['title'] = $this->_title;
        }

        if (isset($this->_categoryPath) && ('' !== $this->_categoryPath)) {
            $titleTag['category'] = $this->_categoryPath;
        }

        $ret = isset($titleTag['title']) ? $titleTag['title'] : '';

        if (isset($titleTag['category']) && '' !== $titleTag['category']) {

            if ('' !== $ret) {
                $ret .= ' - ';
            }
            $ret .= $titleTag['category'];
        }
        if (isset($titleTag['module']) && '' !== $titleTag['module']) {

            if ('' !== $ret) {
                $ret .= ' - ';
            }
            $ret .= $titleTag['module'];
        }
        $this->_title = $ret;
    }

    /**
     * @param $keywords
     */
    public function setKeywords($keywords)
    {
        $this->_keywords = $keywords;
    }

    /**
     * @param $categoryPath
     */
    public function setCategoryPath($categoryPath)
    {
        $categoryPath        = $this->html2text($categoryPath);
        $this->_categoryPath = $categoryPath;
    }

    /**
     * @param $description
     */
    public function setDescription($description)
    {
        if (!$description) {
            global $xoopsModuleConfig;
            if (isset($xoopsModuleConfig['module_meta_description'])) {
                $description = $xoopsModuleConfig['module_meta_description'];
            }
        }

        $description = $this->html2text($description);
        $description = $this->purifyText($description);

        $description = preg_replace("/([^\r\n])\r\n([^\r\n])/", "\\1 \\2", $description);
        $description = preg_replace("/[\r\n]*\r\n[\r\n]*/", "\r\n\r\n", $description);
        $description = preg_replace('/[ ]* [ ]*/', ' ', $description);
        $description = stripslashes($description);

        $this->_description      = $description;
        $this->_meta_description = $this->createMetaDescription();
    }

    public function createTitleTag()
    {
    }

    /**
     * @param               $text
     * @param  bool         $keyword
     * @return mixed|string
     */
    public function purifyText($text, $keyword = false)
    {
        return Smartobject\Utility::purifyText($text, $keyword);
    }

    /**
     * @param  int $maxWords
     * @return string
     */
    public function createMetaDescription($maxWords = 100)
    {
        $words = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $words = explode(' ', $this->_description);

        // Only keep $maxWords words
        $newWords = [];
        $i        = 0;

        while ($i < $maxWords - 1 && $i < count($words)) {
            $newWords[] = $words[$i];
            ++$i;
        }
        $ret = implode(' ', $newWords);

        return $ret;
    }

    /**
     * @param $text
     * @param $minChar
     * @return array
     */
    public function findMetaKeywords($text, $minChar)
    {
        $keywords = [];

        $text = $this->purifyText($text);
        $text = $this->html2text($text);

        $text = preg_replace("/([^\r\n])\r\n([^\r\n])/", "\\1 \\2", $text);
        $text = preg_replace("/[\r\n]*\r\n[\r\n]*/", "\r\n\r\n", $text);
        $text = preg_replace('/[ ]* [ ]*/', ' ', $text);
        $text = stripslashes($text);
        $text =
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $originalKeywords = preg_split('/[^a-zA-Z\'"-]+/', $text, -1, PREG_SPLIT_NO_EMPTY);

        foreach ($originalKeywords as $originalKeyword) {
            $secondRoundKeywords = explode("'", $originalKeyword);
            foreach ($secondRoundKeywords as $secondRoundKeyword) {
                if (strlen($secondRoundKeyword) >= $minChar) {
                    if (!in_array($secondRoundKeyword, $keywords)) {
                        $keywords[] = trim($secondRoundKeyword);
                    }
                }
            }
        }

        return $keywords;
    }

    /**
     * @return string
     */
    public function createMetaKeywords()
    {
        global $xoopsModuleConfig;
        $keywords = $this->findMetaKeywords($this->_original_title . ' ' . $this->_description, $this->_minChar);
        if (isset($xoopsModuleConfig) && isset($xoopsModuleConfig['moduleMetaKeywords'])
            && '' !== $xoopsModuleConfig['moduleMetaKeywords']) {
            $moduleKeywords = explode(',', $xoopsModuleConfig['moduleMetaKeywords']);
            $keywords       = array_merge($keywords, $moduleKeywords);
        }

        /* Commenting this out as it may cause problem on XOOPS ML websites

         $return_keywords = array();

         // Cleaning for duplicate keywords
         foreach ($keywords as $keyword) {
         if (!in_array($keyword, $keywords)) {
         $return_keywords[] = trim($keyword);
         }
         }*/

        // Only take the first 90 keywords
        $newKeywords = [];
        $i           = 0;
        while ($i < 90 - 1 && isset($keywords[$i])) {
            $newKeywords[] = $keywords[$i];
            ++$i;
        }
        $ret = implode(', ', $newKeywords);

        return $ret;
    }

    public function autoBuildMeta_keywords()
    {
    }

    public function buildAutoMetaTags()
    {
        global $xoopsModule, $xoopsModuleConfig;

        $this->_keywords         = $this->createMetaKeywords();
        $this->_meta_description = $this->createMetaDescription();
        $this->_title            = $this->createTitleTag();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
    }

    public function createMetaTags()
    {
        global $xoopsTpl, $xoTheme;

        if (is_object($xoTheme)) {
            $xoTheme->addMeta('meta', 'keywords', $this->_keywords);
            $xoTheme->addMeta('meta', 'description', $this->_description);
            $xoTheme->addMeta('meta', 'title', $this->_title);
        } else {
            $xoopsTpl->assign('xoops_meta_keywords', $this->_keywords);
            $xoopsTpl->assign('xoops_meta_description', $this->_description);
        }
        $xoopsTpl->assign('xoops_pagetitle', $this->_title);
    }
}


1		<?php namespace XoopsModules\Smartobject;
2
3		/**
4		* Containing the class to manage meta informations of the SmartObject framework
5		*
6		* @license GNU
7		* @author marcan <[email protected]>
8		* @link http://smartfactory.ca The SmartFactory
9		* @package SmartObject
10		* @subpackage SmartObjectCore
11		*/
12
13		use XoopsModules\Smartobject;
14
15		// defined('XOOPS_ROOT_PATH') \|\| die('Restricted access');
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-07 05:26 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16
17		/**
18		* Class MetaGen is a class providing some methods to dynamically and automatically customize Meta Tags information
19		* @author The SmartFactory <www.smartfactory.ca>
20		*/
21		class MetaGen
22		{
23		public $_myts;
24
25		public $_title;
26		public $_original_title;
27		public $_keywords;
28		public $_meta_description;
29		public $_categoryPath;
30		public $_description;
31		public $_minChar = 4;
32
33		/**
34		* SmartMetaGen constructor.
35		* @param $title
36		* @param bool $keywords
37		* @param bool $description
38		* @param bool $categoryPath
39		*/
40		public function __construct($title, $keywords = false, $description = false, $categoryPath = false)
41		{
42		$this->_myts = \MyTextSanitizer::getInstance();
43		$this->setCategoryPath($categoryPath);
44		$this->setTitle($title);
45		$this->setDescription($description);
46
47		if (!$keywords) {
48		$keywords = $this->createMetaKeywords();
49		}
50
51		/* $myts = \MyTextSanitizer::getInstance();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `57%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52		if (method_exists($myts, 'formatForML')) {
53		$keywords = $myts->formatForML($keywords);
54		$description = $myts->formatForML($description);
55		}
56		*/
57		$this->setKeywords($keywords);
58		}
59
60		/**
61		* Return true if the string is length > 0
62		*
63		* @credit psylove
64		*
65		* @var string $string Chaine de caract�re
66		* @return boolean
67		*/
68		public function emptyString($var)
69		{
70		return (strlen($var) > 0);
71		}
72
73		/**
74		* Create a title for the short_url field of an article
75		*
76		* @credit psylove
77		*
78		* @var string $title title of the article
79		* @param bool\|string $withExt
80		* @return string sort_url for the article
81		*/
82		public function generateSeoTitle($title = '', $withExt = true)
83		{
84		// Transformation de la chaine en minuscule
85		// Codage de la chaine afin d'éviter les erreurs 500 en cas de caractères imprévus
86		$title = rawurlencode(strtolower($title));
87
88		// Transformation des ponctuations
89		$pattern = [
90		'/%09/', // Tab
91		'/%20/', // Space
92		'/%21/', // !
93		'/%22/', // "
94		'/%23/', // #
95		'/%25/', // %
96		'/%26/', // &
97		'/%27/', // '
98		'/%28/', // (
99		'/%29/', // )
100		'/%2C/', // ,
101		'/%2F/', // /
102		'/%3A/', // :
103		'/%3B/', // ;
104		'/%3C/', // <
105		'/%3D/', // =
106		'/%3E/', // >
107		'/%3F/', // ?
108		'/%40/', // @
109		'/%5B/', // [
110		'/%5C/', // \
111		'/%5D/', // ]
112		'/%5E/', // ^
113		'/%7B/', // {
114		'/%7C/', // \|
115		'/%7D/', // }
116		'/%7E/', // ~
117		"/\./" // .
118		];
119		$rep_pat = [
120		'-',
121		'-',
122		'-',
123		'-',
124		'-',
125		'-100',
126		'-',
127		'-',
128		'-',
129		'-',
130		'-',
131		'-',
132		'-',
133		'-',
134		'-',
135		'-',
136		'-',
137		'-',
138		'-at-',
139		'-',
140		'-',
141		'-',
142		'-',
143		'-',
144		'-',
145		'-',
146		'-',
147		'-'
148		];
149		$title = preg_replace($pattern, $rep_pat, $title);
150
151		// Transformation des caractères accentués
152		$pattern = [
153		'/%B0/', // °
154		'/%E8/', // è
155		'/%E9/', // é
156		'/%EA/', // ê
157		'/%EB/', // ë
158		'/%E7/', // ç
159		'/%E0/', // à
160		'/%E2/', // â
161		'/%E4/', // ä
162		'/%EE/', // î
163		'/%EF/', // ï
164		'/%F9/', // ù
165		'/%FC/', // ü
166		'/%FB/', // û
167		'/%F4/', // ô
168		'/%F6/', // ö
169		];
170		$rep_pat = ['-', 'e', 'e', 'e', 'e', 'c', 'a', 'a', 'a', 'i', 'i', 'u', 'u', 'u', 'o', 'o'];
171		$title = preg_replace($pattern, $rep_pat, $title);
172
173		$tableau = explode('-', $title); // Transforme la chaine de caract�res en tableau
174		$tableau = array_filter($tableau, [$this, 'emptyString']); // Supprime les chaines vides du tableau
175		$title = implode('-', $tableau); // Transforme un tableau en chaine de caract�res s�par� par un tiret
176
177		if (count($title) > 0) {
178		if ($withExt) {
179		$title .= '.html';
180		}
181
182		return $title;
183		} else {
184		return '';
185		}
186		}
187
188		/**
189		* @param $document
190		* @return mixed
191		*/
192		public function html2text($document)
193		{
194		return Smartobject\Utility::getHtml2text($document);
195		}
196
197		/**
198		* @param $title
199		*/
200		public function setTitle($title)
201		{
202		global $xoopsModule, $xoopsModuleConfig;
203		$this->_title = $this->html2text($title);
204		$this->_title = $this->purifyText($this->_title);
205		$this->_original_title = $this->_title;
206
207		$moduleName = $xoopsModule->getVar('name');
208
209		$titleTag = [];
210
211		$show_mod_name_breadcrumb = isset($xoopsModuleConfig['show_mod_name_breadcrumb']) ? $xoopsModuleConfig['show_mod_name_breadcrumb'] : true;
212
213		if ($moduleName && $show_mod_name_breadcrumb) {
214		$titleTag['module'] = $moduleName;
215		}
216
217		if (isset($this->_title) && ('' !== $this->_title) && (strtoupper($this->_title) != strtoupper($moduleName))) {
218		$titleTag['title'] = $this->_title;
219		}
220
221		if (isset($this->_categoryPath) && ('' !== $this->_categoryPath)) {
222		$titleTag['category'] = $this->_categoryPath;
223		}
224
225		$ret = isset($titleTag['title']) ? $titleTag['title'] : '';
226
227	View Code Duplication	if (isset($titleTag['category']) && '' !== $titleTag['category']) {
		0 ignored issues – show Duplication introduced 2017-09-25 02:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
228		if ('' !== $ret) {
229		$ret .= ' - ';
230		}
231		$ret .= $titleTag['category'];
232		}
233	View Code Duplication	if (isset($titleTag['module']) && '' !== $titleTag['module']) {
		0 ignored issues – show Duplication introduced 2017-09-25 02:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
234		if ('' !== $ret) {
235		$ret .= ' - ';
236		}
237		$ret .= $titleTag['module'];
238		}
239		$this->_title = $ret;
240		}
241
242		/**
243		* @param $keywords
244		*/
245		public function setKeywords($keywords)
246		{
247		$this->_keywords = $keywords;
248		}
249
250		/**
251		* @param $categoryPath
252		*/
253		public function setCategoryPath($categoryPath)
254		{
255		$categoryPath = $this->html2text($categoryPath);
256		$this->_categoryPath = $categoryPath;
257		}
258
259		/**
260		* @param $description
261		*/
262		public function setDescription($description)
263		{
264		if (!$description) {
265		global $xoopsModuleConfig;
266		if (isset($xoopsModuleConfig['module_meta_description'])) {
267		$description = $xoopsModuleConfig['module_meta_description'];
268		}
269		}
270
271		$description = $this->html2text($description);
272		$description = $this->purifyText($description);
273
274		$description = preg_replace("/([^\r\n])\r\n([^\r\n])/", "\\1 \\2", $description);
275		$description = preg_replace("/[\r\n]\r\n[\r\n]/", "\r\n\r\n", $description);
276		$description = preg_replace('/[ ]* [ ]*/', ' ', $description);
277		$description = stripslashes($description);
278
279		$this->_description = $description;
280		$this->_meta_description = $this->createMetaDescription();
281		}
282
283		public function createTitleTag()
284		{
285		}
286
287		/**
288		* @param $text
289		* @param bool $keyword
290		* @return mixed\|string
291		*/
292		public function purifyText($text, $keyword = false)
293		{
294		return Smartobject\Utility::purifyText($text, $keyword);
295		}
296
297		/**
298		* @param int $maxWords
299		* @return string
300		*/
301		public function createMetaDescription($maxWords = 100)
302		{
303		$words = [];
		0 ignored issues – show Unused Code introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$words` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
304		$words = explode(' ', $this->_description);
305
306		// Only keep $maxWords words
307		$newWords = [];
308		$i = 0;
309
310		while ($i < $maxWords - 1 && $i < count($words)) {
311		$newWords[] = $words[$i];
312		++$i;
313		}
314		$ret = implode(' ', $newWords);
315
316		return $ret;
317		}
318
319		/**
320		* @param $text
321		* @param $minChar
322		* @return array
323		*/
324		public function findMetaKeywords($text, $minChar)
325		{
326		$keywords = [];
327
328		$text = $this->purifyText($text);
329		$text = $this->html2text($text);
330
331		$text = preg_replace("/([^\r\n])\r\n([^\r\n])/", "\\1 \\2", $text);
332		$text = preg_replace("/[\r\n]\r\n[\r\n]/", "\r\n\r\n", $text);
333		$text = preg_replace('/[ ]* [ ]*/', ' ', $text);
334		$text = stripslashes($text);
335		$text =
		0 ignored issues – show Unused Code introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$text` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
336
337		$originalKeywords = preg_split('/[^a-zA-Z\'"-]+/', $text, -1, PREG_SPLIT_NO_EMPTY);
338
339		foreach ($originalKeywords as $originalKeyword) {
340		$secondRoundKeywords = explode("'", $originalKeyword);
341		foreach ($secondRoundKeywords as $secondRoundKeyword) {
342		if (strlen($secondRoundKeyword) >= $minChar) {
343		if (!in_array($secondRoundKeyword, $keywords)) {
344		$keywords[] = trim($secondRoundKeyword);
345		}
346		}
347		}
348		}
349
350		return $keywords;
351		}
352
353		/**
354		* @return string
355		*/
356		public function createMetaKeywords()
357		{
358		global $xoopsModuleConfig;
359		$keywords = $this->findMetaKeywords($this->_original_title . ' ' . $this->_description, $this->_minChar);
360		if (isset($xoopsModuleConfig) && isset($xoopsModuleConfig['moduleMetaKeywords'])
361		&& '' !== $xoopsModuleConfig['moduleMetaKeywords']) {
362		$moduleKeywords = explode(',', $xoopsModuleConfig['moduleMetaKeywords']);
363		$keywords = array_merge($keywords, $moduleKeywords);
364		}
365
366		/* Commenting this out as it may cause problem on XOOPS ML websites
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `39%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
367		$return_keywords = array();
368
369		// Cleaning for duplicate keywords
370		foreach ($keywords as $keyword) {
371		if (!in_array($keyword, $keywords)) {
372		$return_keywords[] = trim($keyword);
373		}
374		}*/
375
376		// Only take the first 90 keywords
377		$newKeywords = [];
378		$i = 0;
379		while ($i < 90 - 1 && isset($keywords[$i])) {
380		$newKeywords[] = $keywords[$i];
381		++$i;
382		}
383		$ret = implode(', ', $newKeywords);
384
385		return $ret;
386		}
387
388		public function autoBuildMeta_keywords()
389		{
390		}
391
392		public function buildAutoMetaTags()
393		{
394		global $xoopsModule, $xoopsModuleConfig;
395
396		$this->_keywords = $this->createMetaKeywords();
397		$this->_meta_description = $this->createMetaDescription();
398		$this->_title = $this->createTitleTag();
		0 ignored issues – show Bug introduced 2018-03-22 11:26 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->_title` is correct as `$this->createTitleTag()` (which targets `XoopsModules\Smartobject\MetaGen::createTitleTag()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
399		}
400
401		public function createMetaTags()
402		{
403		global $xoopsTpl, $xoTheme;
404
405		if (is_object($xoTheme)) {
406		$xoTheme->addMeta('meta', 'keywords', $this->_keywords);
407		$xoTheme->addMeta('meta', 'description', $this->_description);
408		$xoTheme->addMeta('meta', 'title', $this->_title);
409		} else {
410		$xoopsTpl->assign('xoops_meta_keywords', $this->_keywords);
411		$xoopsTpl->assign('xoops_meta_description', $this->_description);
412		}
413		$xoopsTpl->assign('xoops_pagetitle', $this->_title);
414		}
415		}
416

mambax7 / smartobject