SmartObjectTreeTable::createTableRow() - Code Metrics - Inspection of "updates" - mambax7/smartobject - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf34f3...88111b )

by Michael

created 2018-03-21 16:40 UTC

SmartObjectTreeTable::createTableRow() F

↳ Parent: SmartObjectTreeTable

Complexity

Conditions	18
Paths	5328

Size

Total Lines	95
Code Lines	57

Duplication

Lines	23
Ratio	24.21 %

Importance

Changes

Metric	Value
cc	18
eloc	57
nc	5328
nop	2
dl	23
loc	95
rs	2
c	0
b	0
f	0

How to fix Long Method Complexity

<?php namespace XoopsModules\Smartobject;

/**
 * Contains the classes responsible for displaying a tree table filled with records of SmartObjects
 *
 * @license    GNU
 * @author     marcan <[email protected]>
 * @link       http://smartfactory.ca The SmartFactory
 * @package    SmartObject
 * @subpackage SmartObjectTable
 */

use XoopsModules\Smartobject;

require_once SMARTOBJECT_ROOT_PATH . 'class/smartobjecttable.php';

/**
 * SmartObjectTreeTable class
 *
 * Class representing a tree table for displaying SmartObjects
 *
 * @package SmartObject
 * @author  marcan <[email protected]>
 * @link    http://smartfactory.ca The SmartFactory
 */
class SmartObjectTreeTable extends Smartobject\BaseSmartObjectTable
{
    /**
     * SmartObjectTreeTable constructor.
     * @param SmartPersistableObjectHandler $objectHandler
     * @param bool                          $criteria
     * @param array                         $actions
     * @param bool                          $userSide
     */
    public function __construct(
        SmartPersistableObjectHandler $objectHandler,
        $criteria = false,
        $actions = ['edit', 'delete'],
        $userSide = false
    ) {
        $this->SmartObjectTable($objectHandler, $criteria, $actions, $userSide);
        $this->_isTree = true;
    }

    /**
     * Get children objects given a specific parentid
     *
     * @var    int $parentid id of the parent which children we want to retreive
     * @return array of SmartObject
     */
    public function getChildrenOf($parentid = 0)
    {
        return isset($this->_objects[$parentid]) ? $this->_objects[$parentid] : false;
    }

    /**
     * @param     $object
     * @param int $level
     */
    public function createTableRow($object, $level = 0)
    {
        $aObject = [];

        $i = 0;

        $aColumns        = [];
        $doWeHaveActions = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        foreach ($this->_columns as $column) {
            $aColumn = [];

            if (0 == $i) {

                $class = 'head';
            } elseif (0 == $i % 2) {
                $class = 'even';
            } else {
                $class = 'odd';
            }

            if ($column->_customMethodForValue && method_exists($object, $column->_customMethodForValue)) {
                $method = $column->_customMethodForValue;
                $value  = $object->$method();
            } else {

                /**
                 * If the column is the identifier, then put a link on it
                 */
                if ($column->getKeyName() == $this->_objectHandler->identifierName) {
                    $value = $object->getItemLink();
                } else {
                    $value = $object->getVar($column->getKeyName());
                }
            }

            $space = '';
            if ($column->getKeyName() == $this->_objectHandler->identifierName) {
                for ($i = 0; $i < $level; ++$i) {
                    $space .= '--';
                }
            }

            if ('' !== $space) {
                $space .= '&nbsp;';
            }

            $aColumn['value'] = $space . $value;
            $aColumn['class'] = $class;
            $aColumn['width'] = $column->getWidth();
            $aColumn['align'] = $column->getAlign();
            $aColumn['key']   = $column->getKeyName();

            $aColumns[] = $aColumn;
            ++$i;
        }

        $aObject['columns'] = $aColumns;

        $class            = 'even' === $class ? 'odd' : 'even';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $aObject['class'] = $class;

        $actions = [];

        // Adding the custom actions if any
        foreach ($this->_custom_actions as $action) {
            if (method_exists($object, $action)) {
                $actions[] = $object->$action();
            }
        }

        require_once SMARTOBJECT_ROOT_PATH . 'class/smartobjectcontroller.php';
        $controller = new SmartObjectController($this->_objectHandler);

        if (in_array('edit', $this->_actions)) {

            $actions[] = $controller->getEditItemLink($object, false, true);
        }
        if (in_array('delete', $this->_actions)) {

            $actions[] = $controller->getDeleteItemLink($object, false, true);
        }
        $aObject['actions'] = $actions;

        $this->_tpl->assign('smartobject_actions_column_width', count($actions) * 30);
        $aObject['id']     = $object->id();
        $this->_aObjects[] = $aObject;

        $childrenObjects = $this->getChildrenOf($object->id());

        $this->_hasActions = $this->_hasActions ? true : count($actions) > 0;

        if ($childrenObjects) {

            ++$level;
            foreach ($childrenObjects as $subObject) {
                $this->createTableRow($subObject, $level);
            }
        }
    }

    public function createTableRows()
    {
        $this->_aObjects = [];

        if (count($this->_objects) > 0) {
            foreach ($this->getChildrenOf() as $object) {
                $this->createTableRow($object);
            }

            $this->_tpl->assign('smartobject_objects', $this->_aObjects);
        } else {
            $colspan = count($this->_columns) + 1;
            $this->_tpl->assign('smartobject_colspan', $colspan);
        }
    }

    /**
     * @return mixed
     */
    public function fetchObjects()
    {
        $ret = $this->_objectHandler->getObjects($this->_criteria, 'parentid');

        return $ret;
    }
}


1		<?php namespace XoopsModules\Smartobject;
2
3		/**
4		* Contains the classes responsible for displaying a tree table filled with records of SmartObjects
5		*
6		* @license GNU
7		* @author marcan <[email protected]>
8		* @link http://smartfactory.ca The SmartFactory
9		* @package SmartObject
10		* @subpackage SmartObjectTable
11		*/
12
13		use XoopsModules\Smartobject;
14
15		require_once SMARTOBJECT_ROOT_PATH . 'class/smartobjecttable.php';
16
17		/**
18		* SmartObjectTreeTable class
19		*
20		* Class representing a tree table for displaying SmartObjects
21		*
22		* @package SmartObject
23		* @author marcan <[email protected]>
24		* @link http://smartfactory.ca The SmartFactory
25		*/
26		class SmartObjectTreeTable extends Smartobject\BaseSmartObjectTable
27		{
28		/**
29		* SmartObjectTreeTable constructor.
30		* @param SmartPersistableObjectHandler $objectHandler
31		* @param bool $criteria
32		* @param array $actions
33		* @param bool $userSide
34		*/
35		public function __construct(
36		SmartPersistableObjectHandler $objectHandler,
37		$criteria = false,
38		$actions = ['edit', 'delete'],
39		$userSide = false
40		) {
41		$this->SmartObjectTable($objectHandler, $criteria, $actions, $userSide);
42		$this->_isTree = true;
43		}
44
45		/**
46		* Get children objects given a specific parentid
47		*
48		* @var int $parentid id of the parent which children we want to retreive
49		* @return array of SmartObject
50		*/
51		public function getChildrenOf($parentid = 0)
52		{
53		return isset($this->_objects[$parentid]) ? $this->_objects[$parentid] : false;
54		}
55
56		/**
57		* @param $object
58		* @param int $level
59		*/
60		public function createTableRow($object, $level = 0)
61		{
62		$aObject = [];
63
64		$i = 0;
65
66		$aColumns = [];
67		$doWeHaveActions = false;
		0 ignored issues – show Unused Code introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$doWeHaveActions` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
68
69		foreach ($this->_columns as $column) {
70		$aColumn = [];
71
72	View Code Duplication	if (0 == $i) {
		0 ignored issues – show Duplication introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		$class = 'head';
74		} elseif (0 == $i % 2) {
75		$class = 'even';
76		} else {
77		$class = 'odd';
78		}
79
80		if ($column->_customMethodForValue && method_exists($object, $column->_customMethodForValue)) {
81		$method = $column->_customMethodForValue;
82		$value = $object->$method();
83	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84		/**
85		* If the column is the identifier, then put a link on it
86		*/
87		if ($column->getKeyName() == $this->_objectHandler->identifierName) {
88		$value = $object->getItemLink();
89		} else {
90		$value = $object->getVar($column->getKeyName());
91		}
92		}
93
94		$space = '';
95		if ($column->getKeyName() == $this->_objectHandler->identifierName) {
96		for ($i = 0; $i < $level; ++$i) {
97		$space .= '--';
98		}
99		}
100
101		if ('' !== $space) {
102		$space .= ' ';
103		}
104
105		$aColumn['value'] = $space . $value;
106		$aColumn['class'] = $class;
107		$aColumn['width'] = $column->getWidth();
108		$aColumn['align'] = $column->getAlign();
109		$aColumn['key'] = $column->getKeyName();
110
111		$aColumns[] = $aColumn;
112		++$i;
113		}
114
115		$aObject['columns'] = $aColumns;
116
117		$class = 'even' === $class ? 'odd' : 'even';
		0 ignored issues – show Bug introduced 2017-09-25 02:03 UTC by Report Bug Copy Issue Report The variable `$class` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
118		$aObject['class'] = $class;
119
120		$actions = [];
121
122		// Adding the custom actions if any
123		foreach ($this->_custom_actions as $action) {
124		if (method_exists($object, $action)) {
125		$actions[] = $object->$action();
126		}
127		}
128
129		require_once SMARTOBJECT_ROOT_PATH . 'class/smartobjectcontroller.php';
130		$controller = new SmartObjectController($this->_objectHandler);
131
132	View Code Duplication	if (in_array('edit', $this->_actions)) {
		0 ignored issues – show Duplication introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
133		$actions[] = $controller->getEditItemLink($object, false, true);
134		}
135	View Code Duplication	if (in_array('delete', $this->_actions)) {
		0 ignored issues – show Duplication introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136		$actions[] = $controller->getDeleteItemLink($object, false, true);
137		}
138		$aObject['actions'] = $actions;
139
140		$this->_tpl->assign('smartobject_actions_column_width', count($actions) * 30);
141		$aObject['id'] = $object->id();
142		$this->_aObjects[] = $aObject;
143
144		$childrenObjects = $this->getChildrenOf($object->id());
145
146		$this->_hasActions = $this->_hasActions ? true : count($actions) > 0;
147
148		if ($childrenObjects) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report The expression `$childrenObjects` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
149		++$level;
150		foreach ($childrenObjects as $subObject) {
151		$this->createTableRow($subObject, $level);
152		}
153		}
154		}
155
156		public function createTableRows()
157		{
158		$this->_aObjects = [];
159
160		if (count($this->_objects) > 0) {
161		foreach ($this->getChildrenOf() as $object) {
162		$this->createTableRow($object);
163		}
164
165		$this->_tpl->assign('smartobject_objects', $this->_aObjects);
166		} else {
167		$colspan = count($this->_columns) + 1;
168		$this->_tpl->assign('smartobject_colspan', $colspan);
169		}
170		}
171
172		/**
173		* @return mixed
174		*/
175		public function fetchObjects()
176		{
177		$ret = $this->_objectHandler->getObjects($this->_criteria, 'parentid');
178
179		return $ret;
180		}
181		}
182

mambax7 / smartobject

Push — master ( bf34f3...88111b )

SmartObjectTreeTable::createTableRow() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like