mambax7 / smartobject

class/adsense.php

Doc Comments +2 added lines, -2 removed lines

@@ -92,7 +92,7 @@ 
     /**
      * @param  string $key
      * @param  string $format
-     * @return mixed
+     * @return string
      */
     public function getVar($key, $format = 's')
     {
@@ -157,7 +157,7 @@ 
     }
 
     /**
-     * @return mixed|string
+     * @return string
      */
     public function generateTag()
     {

class/customtag.php

Doc Comments +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
     }
 
     /**
-     * @return mixed|string
+     * @return string
      */
     public function generateTag()
     {

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
             $criteria->add($criteria_language);
 
             $smartobjectPermissionsHandler = new SmartObjectPermissionHandler($this);
-            $granted_ids                     = $smartobjectPermissionsHandler->getGrantedItems('view');
+            $granted_ids = $smartobjectPermissionsHandler->getGrantedItems('view');
 
             if ($granted_ids && count($granted_ids) > 0) {
                 $criteria->add(new Criteria('customtagid', '(' . implode(', ', $granted_ids) . ')', 'IN'));

class/form/elements/smartformuploadelement.php

Doc Comments +2 added lines, -2 removed lines

@@ -12,8 +12,8 @@
 class SmartFormUploadElement extends XoopsFormFile
 {
     /**
-     * @param $object
-     * @param $key
+     * @param string $object
+     * @param string $key
      */
     public function SmartFormFileElement($object, $key)
     {

class/form/smartobjectform.php

Doc Comments +2 added lines, -2 removed lines

@@ -306,8 +306,8 @@
     }
 
     /**
-     * @param      $form_name
-     * @param      $form_caption
+     * @param      string $form_name
+     * @param      string $form_caption
      * @param bool $submit_button_caption
      */
     public function createButtons($form_name, $form_caption, $submit_button_caption = false)

Spacing +6 added lines, -6 removed lines

@@ -52,7 +52,7 @@ 
      */
     public function __construct(&$target, $form_name, $form_caption, $form_action, $form_fields = null, $submit_button_caption = false, $cancel_js_action = false, $captcha = false)
     {
-        $this->targetObject           =& $target;
+        $this->targetObject           = & $target;
         $this->form_fields            = $form_fields;
         $this->_cancel_js_action      = $cancel_js_action;
         $this->_captcha               = $captcha;
@@ -91,7 +91,7 @@ 
      */
     public function addCustomButton($name, $caption, $onclick = false)
     {
-        $custom_button_array    = array(
+        $custom_button_array = array(
             'name'    => $name,
             'caption' => $caption,
             'onclick' => $onclick
@@ -286,7 +286,7 @@ 
 
         if ($permissions) {
             $memberHandler = xoops_getHandler('member');
-            $group_list     = $memberHandler->getGroupList();
+            $group_list = $memberHandler->getGroupList();
             asort($group_list);
             foreach ($permissions as $permission) {
                 if ($this->targetObject->isNew()) {
@@ -684,7 +684,7 @@ 
     {
         foreach ($this->_elements as $eleObj) {
             if ($eleObj->getName() == $keyname) {
-                $ret =& $eleObj;
+                $ret = & $eleObj;
                 break;
             }
         }
@@ -782,7 +782,7 @@ 
         $formname = $this->getName();
         $js .= "function xoopsFormValidate_{$formname}(myform) {";
         // First, output code to check required elements
-        $elements =& $this->getRequired();
+        $elements = & $this->getRequired();
         foreach ($elements as $elt) {
             $eltname    = $elt->getName();
             $eltcaption = trim($elt->getCaption());
@@ -834,7 +834,7 @@ 
             }
         }
         // Now, handle custom validation code
-        $elements =& $this->getElements(true);
+        $elements = & $this->getElements(true);
         foreach ($elements as $elt) {
             if (method_exists($elt, 'renderValidationJS') && strtolower(get_class($elt)) !== 'xoopsformcheckbox') {
                 if ($eltjs = $elt->renderValidationJS()) {

class/member.php

Doc Comments +1 added lines, -1 removed lines

@@ -237,7 +237,7 @@
      * Creates a random number with a specified number of $digits
      *
      * @param  int $digits number of digits
-     * @return return int random number
+     * @return string int random number
      * @author xHelp Team
      *
      * @access public

Spacing +3 added lines, -3 removed lines

@@ -105,7 +105,7 @@ 
 
         global $xoopsConfig;
 
-        $configHandler  = xoops_getHandler('config');
+        $configHandler = xoops_getHandler('config');
         $xoopsConfigUser = $configHandler->getConfigsByCat(XOOPS_CONF_USER);
         switch ($xoopsConfigUser['activation_type']) {
             case 0:
@@ -151,7 +151,7 @@ 
 
         if ($notifyUser) {
             // send some notifications
-            $xoopsMailer =& getMailer();
+            $xoopsMailer = & getMailer();
             $xoopsMailer->useMail();
             $xoopsMailer->setTemplateDir(SMARTOBJECT_ROOT_PATH . 'language/' . $xoopsConfig['language'] . '/mail_template');
             $xoopsMailer->setTemplate('smartobject_notify_user_added_by_admin.tpl');
@@ -265,7 +265,7 @@ 
     {
         static $randCalled = false;
         if (!$randCalled) {
-            mt_srand((double)microtime() * 1000000);
+            mt_srand((double) microtime() * 1000000);
             $randCalled = true;
         }
     }

class/smartdbupdater.php

Doc Comments +3 added lines, -3 removed lines

@@ -141,7 +141,7 @@ 
     }
 
     /**
-     * @param $field
+     * @param string $field
      * @return bool
      */
     public function fieldExists($field)
@@ -623,7 +623,7 @@ 
     /**
      * Use to update a table
      *
-     * @param object $table {@link SmartDbTable} that will be updated
+     * @param SmartDbTable $table {@link SmartDbTable} that will be updated
      *
      * @see SmartDbTable
      *
@@ -725,7 +725,7 @@ 
     /**
      * @param $module
      * @param $item
-     * @return bool
+     * @return false|null
      */
     public function upgradeObjectItem($module, $item)
     {

class/smartexport.php

Doc Comments +2 added lines, -2 removed lines

@@ -197,7 +197,7 @@ 
     /**
      * @param $val
      * @param $separator
-     * @param $trimFunction
+     * @param false|string $trimFunction
      * @return mixed|string
      */
     public function valToCsvHelper($val, $separator, $trimFunction)
@@ -248,7 +248,7 @@ 
     }
 
     /**
-     * @param $content
+     * @param string $content
      */
     public function saveExportFile($content)
     {

Spacing +1 added lines, -1 removed lines

@@ -203,7 +203,7 @@
     public function valToCsvHelper($val, $separator, $trimFunction)
     {
         if ($trimFunction) {
-            $val = $trimFunction ($val);
+            $val = $trimFunction($val);
         }
         //If there is a separator (;) or a quote (") or a linebreak in the string, we need to quote it.
         $needQuote = false;

class/smartmetagen.php

Doc Comments +5 added lines, -5 removed lines

@@ -165,7 +165,7 @@ 
     }
 
     /**
-     * @param $keywords
+     * @param string|boolean $keywords
      */
     public function setKeywords($keywords)
     {
@@ -173,7 +173,7 @@ 
     }
 
     /**
-     * @param $categoryPath
+     * @param boolean $categoryPath
      */
     public function setCategoryPath($categoryPath)
     {
@@ -182,7 +182,7 @@ 
     }
 
     /**
-     * @param $description
+     * @param boolean $description
      */
     public function setDescription($description)
     {
@@ -242,8 +242,8 @@ 
     }
 
     /**
-     * @param $text
-     * @param $minChar
+     * @param string $text
+     * @param integer $minChar
      * @return array
      */
     public function findMetaKeywords($text, $minChar)

class/smartobject.php

Doc Comments +9 added lines, -9 removed lines

@@ -164,7 +164,7 @@ 
     }
 
     /**
-     * @param        $key
+     * @param        string $key
      * @param        $data_type
      * @param bool   $itemName
      * @param string $form_caption
@@ -192,7 +192,7 @@ 
      * @param bool   $required     set to TRUE if this variable needs to have a value set before storing the object in the table
      * @param string $form_caption caption of this variable in a {@link SmartobjectForm} and title of a column in a  {@link SmartObjectTable}
      * @param string $form_dsc     description of this variable in a {@link SmartobjectForm}
-     * @param mixed  $value        default value of this variable
+     * @param string|false  $value        default value of this variable
      */
     public function quickInitVar($key, $data_type, $required = false, $form_caption = '', $form_dsc = '', $value = null)
     {
@@ -201,7 +201,7 @@ 
     }
 
     /**
-     * @param        $varname
+     * @param        string $varname
      * @param bool   $displayOnForm
      * @param string $default
      */
@@ -457,7 +457,7 @@ 
     /**
      * add an error
      *
-     * @param      $err_str
+     * @param      string $err_str
      * @param bool $prefix
      * @internal param string $value error to add
      * @access   public
@@ -719,8 +719,8 @@ 
 
     /**
      * @param $key
-     * @param $info
-     * @param $value
+     * @param string $info
+     * @param boolean $value
      */
     public function setVarInfo($key, $info, $value)
     {
@@ -728,7 +728,7 @@ 
     }
 
     /**
-     * @param       $key
+     * @param       string $key
      * @param  bool $editor
      * @return string
      */
@@ -905,7 +905,7 @@ 
      * @access public
      * @param  string $key    key of the object's variable to be returned
      * @param  string $format format to use for the output
-     * @return mixed  formatted value of the variable
+     * @return string  formatted value of the variable
      */
     public function getVar($key, $format = 's')
     {
@@ -1208,7 +1208,7 @@ 
     }
 
     /**
-     * @param $key
+     * @param string $key
      */
     public function hideFieldFromForm($key)
     {

Spacing +12 added lines, -12 removed lines

@@ -421,7 +421,7 @@ 
     public function toArray()
     {
         $ret  = array();
-        $vars =& $this->getVars();
+        $vars = & $this->getVars();
         foreach ($vars as $key => $var) {
             $value     = $this->getVar($key);
             $ret[$key] = $value;
@@ -538,7 +538,7 @@ 
         }
 
         $smartPermissionsHandler = new SmartobjectPermissionHandler($this->handler);
-        $ret                      = $smartPermissionsHandler->getGrantedGroups($group_perm, $this->id());
+        $ret = $smartPermissionsHandler->getGrantedGroups($group_perm, $this->id());
 
         if (count($ret) == 0) {
             return false;
@@ -797,8 +797,8 @@ 
                             $this->setErrors(sprintf(_XOBJ_ERR_REQUIRED, $k));
                             continue;
                         }
-                        if (isset($v['maxlength']) && strlen($cleanv) > (int)$v['maxlength']) {
-                            $this->setErrors(sprintf(_XOBJ_ERR_SHORTERTHAN, $k, (int)$v['maxlength']));
+                        if (isset($v['maxlength']) && strlen($cleanv) > (int) $v['maxlength']) {
+                            $this->setErrors(sprintf(_XOBJ_ERR_SHORTERTHAN, $k, (int) $v['maxlength']));
                             continue;
                         }
                         if (!$v['not_gpc']) {
@@ -827,7 +827,7 @@ 
                         break;
                     case XOBJ_DTYPE_INT:
                     case XOBJ_DTYPE_TIME_ONLY:
-                        $cleanv = (int)$cleanv;
+                        $cleanv = (int) $cleanv;
                         break;
 
                     case XOBJ_DTYPE_CURRENCY:
@@ -860,7 +860,7 @@ 
                             $cleanv = 'http://' . $cleanv;
                         }
                         if (!$v['not_gpc']) {
-                            $cleanv =& $ts->stripSlashesGPC($cleanv);
+                            $cleanv = & $ts->stripSlashesGPC($cleanv);
                         }
                         break;
                     case XOBJ_DTYPE_SIMPLE_ARRAY:
@@ -872,7 +872,7 @@ 
                     case XOBJ_DTYPE_STIME:
                     case XOBJ_DTYPE_MTIME:
                     case XOBJ_DTYPE_LTIME:
-                        $cleanv = !is_string($cleanv) ? (int)$cleanv : strtotime($cleanv);
+                        $cleanv = !is_string($cleanv) ? (int) $cleanv : strtotime($cleanv);
                         if (!($cleanv > 0)) {
                             $cleanv = strtotime($cleanv);
                         }
@@ -881,7 +881,7 @@ 
                         break;
                 }
             }
-            $this->cleanVars[$k] =& $cleanv;
+            $this->cleanVars[$k] = & $cleanv;
             unset($cleanv);
         }
         if (count($this->_errors) > 0) {
@@ -1099,10 +1099,10 @@ 
                 }
                 break;
             case XOBJ_DTYPE_SIMPLE_ARRAY:
-                $ret =& explode('|', $ret);
+                $ret = & explode('|', $ret);
                 break;
             case XOBJ_DTYPE_ARRAY:
-                $ret =& unserialize($ret);
+                $ret = & unserialize($ret);
                 break;
             case XOBJ_DTYPE_SOURCE:
                 switch (strtolower($format)) {
@@ -1361,7 +1361,7 @@ 
     public function getUrlLinkObj($key)
     {
         $smartobjectLinkurlHandler = xoops_getModuleHandler('urllink', 'smartobject');
-        $urllinkid                   = $this->getVar($key) != null ? $this->getVar($key) : 0;
+        $urllinkid = $this->getVar($key) != null ? $this->getVar($key) : 0;
         if ($urllinkid != 0) {
             return $smartobjectLinkurlHandler->get($urllinkid);
         } else {
@@ -1387,7 +1387,7 @@ 
     public function getFileObj($key)
     {
         $smartobjectFileHandler = xoops_getModuleHandler('file', 'smartobject');
-        $fileid                   = $this->getVar($key) != null ? $this->getVar($key) : 0;
+        $fileid = $this->getVar($key) != null ? $this->getVar($key) : 0;
         if ($fileid != 0) {
             return $smartobjectFileHandler->get($fileid);
         } else {