Conditions | 30 |
Paths | > 20000 |
Total Lines | 265 |
Lines | 45 |
Ratio | 16.98 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
29 | function xoops_module_update_smartobject(\XoopsModule $module) |
||
30 | { |
||
31 | ob_start(); |
||
32 | |||
33 | $dbVersion = Smartobject\Utility::getMeta('version', 'smartobject'); |
||
34 | if (!$dbVersion) { |
||
35 | $dbVersion = 0; |
||
36 | } |
||
37 | |||
38 | $dbupdater = new XoopsModules\Smartobject\Dbupdater(); |
||
39 | |||
40 | echo '<code>' . _SDU_UPDATE_UPDATING_DATABASE . '<br>'; |
||
41 | |||
42 | // db migrate version = 1 |
||
43 | $newDbVersion = 1; |
||
44 | if ($dbVersion < $newDbVersion) { |
||
45 | echo 'Database migrate to version ' . $newDbVersion . '<br>'; |
||
46 | |||
47 | // Create table smartobject_link |
||
48 | $table = new XoopsModules\Smartobject\DbTable('smartobject_link'); |
||
49 | if (!$table->exists()) { |
||
50 | $table->setStructure("CREATE TABLE `%s` ( |
||
51 | `linkid` int(11) NOT NULL auto_increment, |
||
52 | `from_uid` int(11) NOT NULL default '0', |
||
53 | `from_email` varchar(255) NOT NULL default '', |
||
54 | `from_name` varchar(255) NOT NULL default '', |
||
55 | `to_uid` int(11) NOT NULL default '0', |
||
56 | `to_email` varchar(255) NOT NULL default '', |
||
57 | `to_name` varchar(255) NOT NULL default '', |
||
58 | `link` varchar(255) NOT NULL default '', |
||
59 | `subject` varchar(255) NOT NULL default '', |
||
60 | `body` TEXT NOT NULL, |
||
61 | `mid` int(11) NOT NULL default '0', |
||
62 | `mid_name` varchar(255) NOT NULL default '', |
||
63 | |||
64 | PRIMARY KEY (`linkid`) |
||
65 | ) ENGINE=MyISAM COMMENT='SmartObject by The SmartFactory <www.smartfactory.ca>' AUTO_INCREMENT=1 ;"); |
||
66 | |||
67 | if (!$dbupdater->updateTable($table)) { |
||
68 | /** |
||
69 | * @todo trap the errors |
||
70 | */ |
||
71 | } |
||
72 | } |
||
73 | unset($table); |
||
74 | // Create table smartobject_link |
||
75 | $table = new XoopsModules\Smartobject\DbTable('smartobject_link'); |
||
76 | if (!$table->fieldExists('date')) { |
||
77 | $table->addNewField('date', "int(11) NOT NULL default '0'"); |
||
78 | if (!$dbupdater->updateTable($table)) { |
||
79 | /** |
||
80 | * @todo trap the errors |
||
81 | */ |
||
82 | } |
||
83 | } |
||
84 | unset($table); |
||
85 | |||
86 | // Create table smartobject_tag |
||
87 | $table = new XoopsModules\Smartobject\DbTable('smartobject_tag'); |
||
88 | if (!$table->exists()) { |
||
89 | $table->setStructure("CREATE TABLE %s ( |
||
90 | `tagid` int(11) NOT NULL auto_increment, |
||
91 | `name` varchar(255) NOT NULL default '', |
||
92 | `description` TEXT NOT NULL, |
||
93 | PRIMARY KEY (`id`) |
||
94 | ) ENGINE=MyISAM COMMENT='SmartObject by The SmartFactory <www.smartfactory.ca>' AUTO_INCREMENT=1 ;"); |
||
95 | |||
96 | if (!$dbupdater->updateTable($table)) { |
||
97 | /** |
||
98 | * @todo trap the errors |
||
99 | */ |
||
100 | } |
||
101 | } |
||
102 | |||
103 | // Create table smartobject_tag_text |
||
104 | $table = new XoopsModules\Smartobject\DbTable('smartobject_tag_text'); |
||
105 | if (!$table->exists()) { |
||
106 | $table->setStructure("CREATE TABLE %s ( |
||
107 | `tagid` int(11) NOT NULL default 0, |
||
108 | `language` varchar(255) NOT NULL default '', |
||
109 | `value` TEXT NOT NULL, |
||
110 | PRIMARY KEY (`id`, `language`) |
||
111 | ) ENGINE=MyISAM COMMENT='SmartObject by The SmartFactory <www.smartfactory.ca>' AUTO_INCREMENT=1 ;"); |
||
112 | |||
113 | if (!$dbupdater->updateTable($table)) { |
||
114 | /** |
||
115 | * @todo trap the errors |
||
116 | */ |
||
117 | } |
||
118 | } |
||
119 | |||
120 | // Create table smartobject_adsense |
||
121 | $table = new XoopsModules\Smartobject\DbTable('smartobject_adsense'); |
||
122 | if (!$table->exists()) { |
||
123 | $table->setStructure(" |
||
124 | `adsenseid` int(11) NOT NULL auto_increment, |
||
125 | `format` VARCHAR(100) NOT NULL, |
||
126 | `description` TEXT NOT NULL, |
||
127 | `style` TEXT NOT NULL, |
||
128 | `border_color` varchar(6) NOT NULL default '', |
||
129 | `background_color` varchar(6) NOT NULL default '', |
||
130 | `link_color` varchar(6) NOT NULL default '', |
||
131 | `url_color` varchar(6) NOT NULL default '', |
||
132 | `text_color` varchar(6) NOT NULL default '', |
||
133 | `client_id` varchar(100) NOT NULL default '', |
||
134 | `tag` varchar(50) NOT NULL default '', |
||
135 | PRIMARY KEY (`adsenseid`) |
||
136 | "); |
||
137 | } |
||
138 | |||
139 | if (!$dbupdater->updateTable($table)) { |
||
140 | /** |
||
141 | * @todo trap the errors |
||
142 | */ |
||
143 | } |
||
144 | } |
||
145 | // db migrate version = 2 |
||
146 | $newDbVersion = 2; |
||
147 | if ($dbVersion < $newDbVersion) { |
||
148 | echo 'Database migrate to version ' . $newDbVersion . '<br>'; |
||
149 | |||
150 | // Create table smartobject_rating |
||
151 | $table = new XoopsModules\Smartobject\DbTable('smartobject_rating'); |
||
152 | if (!$table->exists()) { |
||
153 | $table->setStructure(' |
||
154 | `ratingid` int(11) NOT NULL auto_increment, |
||
155 | `dirname` VARCHAR(255) NOT NULL, |
||
156 | `item` VARCHAR(255) NOT NULL, |
||
157 | `itemid` int(11) NOT NULL, |
||
158 | `uid` int(11) NOT NULL, |
||
159 | `rate` int(1) NOT NULL, |
||
160 | `date` int(11) NOT NULL, |
||
161 | PRIMARY KEY (`ratingid`), |
||
162 | UNIQUE (`dirname`, `item`, `itemid`, `uid`) |
||
163 | '); |
||
164 | } |
||
165 | |||
166 | if (!$dbupdater->updateTable($table)) { |
||
167 | /** |
||
168 | * @todo trap the errors |
||
169 | */ |
||
170 | } |
||
171 | |||
172 | // Create table smartobject_currency |
||
173 | $table = new XoopsModules\Smartobject\DbTable('smartobject_currency'); |
||
174 | $table->setData("2, 'EUR', 'Euro', '�', 0.65, 0"); |
||
175 | $table->setData("3, 'USD', 'American dollar', '$', 0.9, 0"); |
||
176 | $table->setData("1, 'CAD', 'Canadian dollar', '$', 1, 1"); |
||
177 | |||
178 | if (!$dbupdater->updateTable($table)) { |
||
179 | /** |
||
180 | * @todo trap the errors |
||
181 | */ |
||
182 | } |
||
183 | } |
||
184 | |||
185 | // db migrate version = 3 |
||
186 | $newDbVersion = 3; |
||
187 | View Code Duplication | if ($dbVersion < $newDbVersion) { |
|
|
|||
188 | echo 'Database migrate to version ' . $newDbVersion . '<br>'; |
||
189 | |||
190 | // Create table smartobject_customtag |
||
191 | $table = new XoopsModules\Smartobject\DbTable('smartobject_customtag'); |
||
192 | if (!$table->exists()) { |
||
193 | $table->setStructure(' |
||
194 | `customtagid` int(11) NOT NULL auto_increment, |
||
195 | `name` VARCHAR(255) NOT NULL, |
||
196 | `description` TEXT NOT NULL, |
||
197 | `content` TEXT NOT NULL, |
||
198 | `language` TEXT NOT NULL, |
||
199 | PRIMARY KEY (`customtagid`) |
||
200 | '); |
||
201 | } |
||
202 | |||
203 | if (!$dbupdater->updateTable($table)) { |
||
204 | /** |
||
205 | * @todo trap the errors |
||
206 | */ |
||
207 | } |
||
208 | } |
||
209 | |||
210 | // db migrate version = 4 |
||
211 | $newDbVersion = 4; |
||
212 | View Code Duplication | if ($dbVersion < $newDbVersion) { |
|
213 | echo 'Database migrate to version ' . $newDbVersion . '<br>'; |
||
214 | |||
215 | // Create table smartobject_currency |
||
216 | $table = new XoopsModules\Smartobject\DbTable('smartobject_currency'); |
||
217 | if (!$table->exists()) { |
||
218 | $table->setStructure(' |
||
219 | `currencyid` int(11) NOT NULL auto_increment, |
||
220 | `iso4217` VARCHAR(5) NOT NULL, |
||
221 | `name` VARCHAR(255) NOT NULL, |
||
222 | `symbol` VARCHAR(1) NOT NULL, |
||
223 | `rate` float NOT NULL, |
||
224 | `default_currency` int(1) NOT NULL, |
||
225 | PRIMARY KEY (`currencyid`) |
||
226 | '); |
||
227 | } |
||
228 | |||
229 | if (!$dbupdater->updateTable($table)) { |
||
230 | /** |
||
231 | * @todo trap the errors |
||
232 | */ |
||
233 | } |
||
234 | } |
||
235 | |||
236 | // db migrate version = 6 |
||
237 | $newDbVersion = 6; |
||
238 | if ($dbVersion < $newDbVersion) { |
||
239 | echo 'Database migrate to version ' . $newDbVersion . '<br>'; |
||
240 | } |
||
241 | |||
242 | $newDbVersion = 7; |
||
243 | if ($dbVersion < $newDbVersion) { |
||
244 | echo 'Database migrate to version ' . $newDbVersion . '<br>'; |
||
245 | |||
246 | // Create table smartobject_file |
||
247 | $table = new XoopsModules\Smartobject\DbTable('smartobject_file'); |
||
248 | if (!$table->exists()) { |
||
249 | $table->setStructure(' |
||
250 | `fileid` int(11) NOT NULL auto_increment, |
||
251 | `caption` varchar(255) collate latin1_general_ci NOT NULL, |
||
252 | `url` varchar(255) collate latin1_general_ci NOT NULL, |
||
253 | `description` text collate latin1_general_ci NOT NULL, |
||
254 | PRIMARY KEY (`fileid`) |
||
255 | '); |
||
256 | if (!$dbupdater->updateTable($table)) { |
||
257 | /** |
||
258 | * @todo trap the errors |
||
259 | */ |
||
260 | } |
||
261 | } |
||
262 | unset($table); |
||
263 | // Create table smartobject_urllink |
||
264 | $table = new XoopsModules\Smartobject\DbTable('smartobject_urllink'); |
||
265 | if (!$table->exists()) { |
||
266 | $table->setStructure(' |
||
267 | `urllinkid` int(11) NOT NULL auto_increment, |
||
268 | `caption` varchar(255) collate latin1_general_ci NOT NULL, |
||
269 | `url` varchar(255) collate latin1_general_ci NOT NULL, |
||
270 | `description` text collate latin1_general_ci NOT NULL, |
||
271 | `target` varchar(10) collate latin1_general_ci NOT NULL, |
||
272 | PRIMARY KEY (`urllinkid`) |
||
273 | '); |
||
274 | if (!$dbupdater->updateTable($table)) { |
||
275 | /** |
||
276 | * @todo trap the errors |
||
277 | */ |
||
278 | } |
||
279 | } |
||
280 | unset($table); |
||
281 | } |
||
282 | echo '</code>'; |
||
283 | |||
284 | $feedback = ob_get_clean(); |
||
285 | if (method_exists($module, 'setMessage')) { |
||
286 | $module->setMessage($feedback); |
||
287 | } else { |
||
288 | echo $feedback; |
||
289 | } |
||
290 | Smartobject\Utility::setMeta('version', $newDbVersion, 'smartobject'); //Set meta version to current |
||
291 | |||
292 | return true; |
||
293 | } |
||
294 | |||
308 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.