SmartFormUserElement - Code Metrics - mambax7/smartobject - Measure and Improve Code Quality continuously with Scrutinizer

SmartFormUserElement A
last analyzed 2019-01-19 04:07 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	35
rs	10
c	0
b	0
f	0
wmc	5
lcom	0
cbo	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	25	5

<?php namespace XoopsModules\Smartobject\Form\Elements;

/**
 * Contains the SmartObjectControl class
 *
 * @license    GNU
 * @author     marcan <[email protected]>
 * @link       http://smartfactory.ca The SmartFactory
 * @package    SmartObject
 * @subpackage SmartObjectForm
 */

use XoopsModules\Smartobject;

/**
 * Class SmartFormUserElement
 * @package XoopsModules\Smartobject\Form\Elements
 */
class SmartFormUserElement extends \XoopsFormSelect
{
    public $multiple = false;

    /**
     * SmartFormUserElement constructor.
     * @param string $object
     * @param string $key
     */
    public function __construct($object, $key)
    {
        $var  = $object->vars[$key];
        $size = isset($var['size']) ? $var['size'] : ($this->multiple ? 5 : 1);

        parent::__construct($var['form_caption'], $key, $object->getVar($key, 'e'), $size, $this->multiple);


        // Adding the options inside this SelectBox
        // If the custom method is not from a module, than it's from the core
        $control = $object->getControl($key);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        global $xoopsDB;
        $ret   = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $limit = $start = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $sql   = 'SELECT uid, uname FROM ' . $xoopsDB->prefix('users');
        $sql   .= ' ORDER BY uname ASC';

        $result = $xoopsDB->query($sql);
        if ($result) {
            while (false !== ($myrow = $xoopsDB->fetchArray($result))) {
                $uArray[$myrow['uid']] = $myrow['uname'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }
        $this->addOptionArray($uArray);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php namespace XoopsModules\Smartobject\Form\Elements;
2
3			/**
4			* Contains the SmartObjectControl class
5			*
6			* @license GNU
7			* @author marcan <[email protected]>
8			* @link http://smartfactory.ca The SmartFactory
9			* @package SmartObject
10			* @subpackage SmartObjectForm
11			*/
12
13			use XoopsModules\Smartobject;
14
15			/**
16			* Class SmartFormUserElement
17			* @package XoopsModules\Smartobject\Form\Elements
18			*/
19			class SmartFormUserElement extends \XoopsFormSelect
20			{
21			public $multiple = false;
22
23			/**
24			* SmartFormUserElement constructor.
25			* @param string $object
26			* @param string $key
27			*/
28			public function __construct($object, $key)
29			{
30			$var = $object->vars[$key];
31			$size = isset($var['size']) ? $var['size'] : ($this->multiple ? 5 : 1);
32
33			parent::__construct($var['form_caption'], $key, $object->getVar($key, 'e'), $size, $this->multiple);
			0 ignored issues – show Bug introduced 2016-04-01 11:05 UTC by Report Bug Copy Issue Report The method `getVar` cannot be called on `$object` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
34
35			// Adding the options inside this SelectBox
36			// If the custom method is not from a module, than it's from the core
37			$control = $object->getControl($key);
			0 ignored issues – show Bug introduced 2016-04-01 11:05 UTC by Report Bug Copy Issue Report The method `getControl` cannot be called on `$object` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history... Unused Code introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$control` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
38
39			global $xoopsDB;
40			$ret = [];
			0 ignored issues – show Unused Code introduced 2017-09-07 05:26 UTC by Report Bug Copy Issue Report `$ret` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
41			$limit = $start = 0;
			0 ignored issues – show Unused Code introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$start` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$limit` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42			$sql = 'SELECT uid, uname FROM ' . $xoopsDB->prefix('users');
43			$sql .= ' ORDER BY uname ASC';
44
45			$result = $xoopsDB->query($sql);
46			if ($result) {
47			while (false !== ($myrow = $xoopsDB->fetchArray($result))) {
48			$uArray[$myrow['uid']] = $myrow['uname'];
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report `$uArray` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$uArray = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
49			}
50			}
51			$this->addOptionArray($uArray);
			0 ignored issues – show Bug introduced 2016-04-01 10:59 UTC by Report Bug Copy Issue Report The variable `$uArray` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
52			}
53			}
54

mambax7 / smartobject

SmartFormUserElement A last analyzed 2019-01-19 04:07 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Duplication Side-by-Side

Filter issues like

SmartFormUserElement A
last analyzed 2019-01-19 04:07 UTC