Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php namespace XoopsModules\Smartobject\Form\Elements; |
||
| 27 | View Code Duplication | class SmartFormSectionClose extends \XoopsFormElement |
|
|
|
|||
| 28 | { |
||
| 29 | /** |
||
| 30 | * Text |
||
| 31 | * @var string |
||
| 32 | * @access private |
||
| 33 | */ |
||
| 34 | public $_value; |
||
| 35 | |||
| 36 | /** |
||
| 37 | * SmartFormSectionClose constructor. |
||
| 38 | * @param $sectionname |
||
| 39 | * @param bool $value |
||
| 40 | */ |
||
| 41 | public function __construct($sectionname, $value = false) |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Get the text |
||
| 49 | * |
||
| 50 | * @return string |
||
| 51 | */ |
||
| 52 | public function getValue() |
||
| 56 | |||
| 57 | /** |
||
| 58 | * Prepare HTML for output |
||
| 59 | * |
||
| 60 | * @return string |
||
| 61 | */ |
||
| 62 | public function render() |
||
| 66 | } |
||
| 67 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.