XoopsModules\Smartobject\Form\Elements\SmartFormCheckElement

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	32.76 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	17	6
A	renderValidationJS()	19	27	2

<?php namespace XoopsModules\Smartobject\Form\Elements;

use XoopsModules\Smartobject;

// defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Class SmartFormCheckElement
 */
class SmartFormCheckElement extends \XoopsFormCheckBox
{
    /**
     *
     * /**
     * prepare HTML for output
     *
     * @return string
     */
    public function render()
    {
        $ret = '';
        if (count($this->getOptions()) > 1 && '[]' !== substr($this->getName(), -2, 2)) {

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

            $newname = $this->getName() . '[]';

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

            $this->setName($newname);
        }
        foreach ($this->getOptions() as $value => $name) {
            $ret .= "<input type='checkbox' name='" . $this->getName() . "' value='" . $value . "'";

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

            if (count($this->getValue()) > 0 && in_array($value, $this->getValue())) {
                $ret .= ' checked';
            }
            $ret .= $this->getExtra() . '>' . $name . '<br>';
        }

        return $ret;
    }

    /**
     * @return string
     */
    public function renderValidationJS()
    {
        $js .= 'var hasSelections = false;';

The variable $js does not exist. Did you forget to declare it?

        //sometimes, there is an implicit '[]', sometimes not
        $eltname = $this->getName();

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

        if (false === strpos($eltname, '[')) {

This code seems to be duplicated across your project.

            $js .= "for (var i = 0; i < myform['{$eltname}[]'].length; i++) {
                if (myform['{$eltname}[]'][i].checked) {
                    hasSelections = true;
                }

            }
            if (hasSelections === false) {
                window.alert(\"{$eltmsg}\"); myform['{$eltname}[]'][0].focus(); return false; }\n";

The variable $eltmsg does not exist. Did you forget to declare it?

        } else {
            $js .= "for (var i = 0; i < myform['" . $eltname . "'].length; i++) {
                if (myform['{$eltname}'][i].checked) {
                    hasSelections = true;
                }

            }
            if (hasSelections === false) {
                window.alert(\"{$eltmsg}\"); myform['{$eltname}'][0].focus(); return false; }\n";
        }

        return $js;
    }
}