JavaScript - Code Metrics - mambax7/smartobject - Measure and Improve Code Quality continuously with Scrutinizer

JavaScript A
last analyzed 2019-01-19 04:07 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	89
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	89
loc	89
rs	10
c	0
b	0
f	0
wmc	14
lcom	0
cbo	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	button_to_function()	4	4	1
A	escape()	7	7	1
A	tag()	4	4	1
A	link_to_function()	4	4	3
A	_array_or_string_for_javascript()	16	16	4
A	_options_for_javascript()	15	15	4

How to fix Duplicated Code

<?php

/**
 * Projax
 *
 * An open source set of php helper classes for prototype and script.aculo.us.
 *
 * @package     Projax
 * @author      Vikas Patial
 * @copyright   Copyright (c) 2006, ngcoders.
 * @license     http://www.gnu.org/copyleft/gpl.html
 * @link        http://www.ngcoders.com
 * @since       Version 0.2
 * @filesource
 */
class JavaScript

{
    /**
     * @param         $name
     * @param  null   $function
     * @return string
     */
    public function button_to_function($name, $function = null)
    {
        return '<input type="button" value="' . $name . '" onclick="' . $function . '">';
    }

    /**
     * @param $javascript
     * @return mixed|string
     */
    public function escape($javascript)
    {
        $javascript = addslashes($javascript);
        $javascript = str_replace(["\r\n", "\n", "\r"], ["\n"], $javascript);

        return $javascript;
    }

    /**
     * @param $content
     * @return string
     */
    public function tag($content)
    {
        return '<script type="text/javascript">' . $content . '</script>';
    }

    /**
     * @param         $name
     * @param         $function
     * @param  null   $html_options
     * @return string
     */
    public function link_to_function($name, $function, $html_options = null)
    {
        return '<a href="' . (isset($html_options['href']) ? $html_options['href'] : '#') . '" onclick="' . (isset($html_options['onclick']) ? $html_options['onclick'] . ';' : '') . $function . '; return false;">' . $name . '</a>';
    }

    /////////////////////////////////////////////////////////////////////////////////////
    //                             Private functions
    /////////////////////////////////////////////////////////////////////////////////////

    /**
     * @param $option
     * @return string
     */
    public function _array_or_string_for_javascript($option)
    {
        $return_val = '';
        if (is_array($option)) {
            foreach ($option as $value) {
                if (!empty($return_val)) {
                    $ret_val .= ', ';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                }
                $return_val .= $value;
            }

            return '[' . $return_val . ']';
        }

        return "'$option'";
    }

    /**
     * @param $options
     * @return string
     */
    public function _options_for_javascript($options)
    {
        $return_val = '';

        if (is_array($options)) {
            foreach ($options as $var => $val) {
                if (!empty($return_val)) {
                    $return_val .= ', ';
                }
                $return_val .= "$var:$val";
            }
        }

        return '{' . $return_val . '}';
    }
}


1		<?php
2
3		/**
4		* Projax
5		*
6		* An open source set of php helper classes for prototype and script.aculo.us.
7		*
8		* @package Projax
9		* @author Vikas Patial
10		* @copyright Copyright (c) 2006, ngcoders.
11		* @license http://www.gnu.org/copyleft/gpl.html
12		* @link http://www.ngcoders.com
13		* @since Version 0.2
14		* @filesource
15		*/
16	View Code Duplication	class JavaScript
		0 ignored issues – show Duplication introduced 2016-04-01 11:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		/**
19		* @param $name
20		* @param null $function
21		* @return string
22		*/
23		public function button_to_function($name, $function = null)
24		{
25		return '<input type="button" value="' . $name . '" onclick="' . $function . '">';
26		}
27
28		/**
29		* @param $javascript
30		* @return mixed\|string
31		*/
32		public function escape($javascript)
33		{
34		$javascript = addslashes($javascript);
35		$javascript = str_replace(["\r\n", "\n", "\r"], ["\n"], $javascript);
36
37		return $javascript;
38		}
39
40		/**
41		* @param $content
42		* @return string
43		*/
44		public function tag($content)
45		{
46		return '<script type="text/javascript">' . $content . '</script>';
47		}
48
49		/**
50		* @param $name
51		* @param $function
52		* @param null $html_options
53		* @return string
54		*/
55		public function link_to_function($name, $function, $html_options = null)
56		{
57		return '<a href="' . (isset($html_options['href']) ? $html_options['href'] : '#') . '" onclick="' . (isset($html_options['onclick']) ? $html_options['onclick'] . ';' : '') . $function . '; return false;">' . $name . '</a>';
58		}
59
60		/////////////////////////////////////////////////////////////////////////////////////
61		// Private functions
62		/////////////////////////////////////////////////////////////////////////////////////
63
64		/**
65		* @param $option
66		* @return string
67		*/
68		public function _array_or_string_for_javascript($option)
69		{
70		$return_val = '';
71		if (is_array($option)) {
72		foreach ($option as $value) {
73		if (!empty($return_val)) {
74		$ret_val .= ', ';
		0 ignored issues – show Bug introduced 2016-04-01 11:05 UTC by Report Bug Copy Issue Report The variable `$ret_val` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
75		}
76		$return_val .= $value;
77		}
78
79		return '[' . $return_val . ']';
80		}
81
82		return "'$option'";
83		}
84
85		/**
86		* @param $options
87		* @return string
88		*/
89		public function _options_for_javascript($options)
90		{
91		$return_val = '';
92
93		if (is_array($options)) {
94		foreach ($options as $var => $val) {
95		if (!empty($return_val)) {
96		$return_val .= ', ';
97		}
98		$return_val .= "$var:$val";
99		}
100		}
101
102		return '{' . $return_val . '}';
103		}
104		}
105

mambax7 / smartobject

JavaScript A last analyzed 2019-01-19 04:07 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

JavaScript A
last analyzed 2019-01-19 04:07 UTC