Issues in about2.php - New Issues - Inspection of "1.12 RC 1" - mambax7/smartfaq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (1b2f30)

by Michael

created 2016-03-30 08:38 UTC

admin/about2.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Module: SmartFAQ
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 */

include_once __DIR__ . '/admin_header.php';
$myts = MyTextSanitizer::getInstance();

global $xoopsModule;

xoops_cp_header();

$moduleHandler = xoops_getHandler('module');
$versioninfo   =& $moduleHandler->get($xoopsModule->getVar('mid'));

/*  Centered heading

echo "<br />";
echo "<table width='100%'>";
echo "<tr>";
echo "<td align = 'center'>";
echo "<img src='".XOOPS_URL."/modules/smartfaq/".$versioninfo->getInfo('image')."' alt='' align='center'/></a>";
echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . " version " . $versioninfo->getInfo('version') . "</div>";
if ( $versioninfo->getInfo('author_realname') != '') {
$author_name = $versioninfo->getInfo('author') . " (" . $versioninfo->getInfo('author_realname') . ")";
} else {
$author_name = $versioninfo->getInfo('author');
}

echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . " " .$author_name;
echo "</div>";
echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div><br></>\n";

echo "</td>";
echo "</tr>";
echo "</table>";
*/
// Left headings...
echo "<img src='" . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/' . $versioninfo->getInfo('image') . "' alt='' hspace='0' vspace='0' align='left' style='margin-right: 10px;'/></a>";
echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . ' version ' . $versioninfo->getInfo('version') . ' (' . $versioninfo->getInfo('status_version') . ')</div>';
if ($versioninfo->getInfo('author_realname') != '') {
    $author_name = $versioninfo->getInfo('author') . ' (' . $versioninfo->getInfo('author_realname') . ')';
} else {
    $author_name = $versioninfo->getInfo('author');
}

echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . ' ' . $author_name;
echo '</div>';
echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div>\n";

// Developers Information
echo "<br /><table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
echo '<tr>';
echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_AUTHOR_INFO . '</b></td>';
echo '</tr>';

if ($versioninfo->getInfo('developer_lead') != '') {
    echo '<tr>';
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_LEAD . '</td>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_lead') . '</td>';
    echo '</tr>';
}
if ($versioninfo->getInfo('developer_contributor') != '') {
    echo '<tr>';
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_CONTRIBUTOR . '</td>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_contributor') . '</td>';
    echo '</tr>';
}
if ($versioninfo->getInfo('developer_website_url') != '') {
    echo '<tr>';
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_WEBSITE . '</td>';
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('developer_website_url') . "' target='blank'>" . $versioninfo->getInfo('developer_website_name') . '</a></td>';
    echo '</tr>';
}
if ($versioninfo->getInfo('developer_email') != '') {
    echo '<tr>';
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_EMAIL . '</td>';
    echo "<td class='even' align='left'><a href='mailto:" . $versioninfo->getInfo('developer_email') . "'>" . $versioninfo->getInfo('developer_email') . '</a></td>';
    echo '</tr>';
}

echo '</table>';
echo "<br />\n";
// Module Developpment information
echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
echo '<tr>';
echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_MODULE_INFO . '</b></td>';
echo '</tr>';

if ($versioninfo->getInfo('date') != '') {
    echo '<tr>';
    echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_RELEASE_DATE . '</td>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('date') . '</td>';
    echo '</tr>';
}

if ($versioninfo->getInfo('status') != '') {
    echo '<tr>';
    echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_STATUS . '</td>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('status') . '</td>';
    echo '</tr>';
}

if ($versioninfo->getInfo('demo_site_url') != '') {
    echo '<tr>';
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_DEMO . '</td>';
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('demo_site_url') . "' target='blank'>" . $versioninfo->getInfo('demo_site_name') . '</a></td>';
    echo '</tr>';
}

if ($versioninfo->getInfo('support_site_url') != '') {
    echo '<tr>';
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_SUPPORT . '</td>';
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('support_site_url') . "' target='blank'>" . $versioninfo->getInfo('support_site_name') . '</a></td>';
    echo '</tr>';
}

if ($versioninfo->getInfo('submit_bug') != '') {
    echo '<tr>';
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_BUG . '</td>';
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_bug') . "' target='blank'>" . 'Submit a Bug in SmartFAQ Bug Tracker' . '</a></td>';
    echo '</tr>';
}
if ($versioninfo->getInfo('submit_feature') != '') {
    echo '<tr>';
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_FEATURE . '</td>';
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_feature') . "' target='blank'>" . 'Request a feature in the SmartFAQ Feature Tracker' . '</a></td>';
    echo '</tr>';
}

echo '</table>';
// Warning
if ($versioninfo->getInfo('warning') != '') {
    echo "<br />\n";
    echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
    echo '<tr>';
    echo "<td class='bg3' align='left'><b>" . _MI_SF_MODULE_DISCLAIMER . '</b></td>';
    echo '</tr>';

    echo '<tr>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('warning') . '</td>';
    echo '</tr>';

    echo '</table>';
}
// Author's note
if ($versioninfo->getInfo('author_word') != '') {
    echo "<br />\n";
    echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
    echo '<tr>';
    echo "<td class='bg3' align='left'><b>" . _MI_SF_AUTHOR_WORD . '</b></td>';
    echo '</tr>';

    echo '<tr>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('author_word') . '</td>';
    echo '</tr>';

    echo '</table>';
}

// Version History
if ($versioninfo->getInfo('version_history') != '') {
    echo "<br />\n";
    echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
    echo '<tr>';
    echo "<td class='bg3' align='left'><b>" . _MI_SF_VERSION_HISTORY . '</b></td>';
    echo '</tr>';

    echo '<tr>';
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('version_history') . '</td>';
    echo '</tr>';

    echo '</table>';
}

echo '<br />';
//$modfooter = sf_modFooter();

//echo "<div align='center'>" . $modfooter . "</div>";
//xoops_cp_footer();
include_once __DIR__ . '/admin_footer.php';


1		<?php
2
3		/**
4		* Module: SmartFAQ
5		* Author: The SmartFactory <www.smartfactory.ca>
6		* Licence: GNU
7		*/
8
9		include_once __DIR__ . '/admin_header.php';
10		$myts = MyTextSanitizer::getInstance();
11
12		global $xoopsModule;
13
14		xoops_cp_header();
15
16		$moduleHandler = xoops_getHandler('module');
17		$versioninfo =& $moduleHandler->get($xoopsModule->getVar('mid'));
18
19		/* Centered heading
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-30 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `51%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20		echo "<br />";
21		echo "<table width='100%'>";
22		echo "<tr>";
23		echo "<td align = 'center'>";
24		echo "<img src='".XOOPS_URL."/modules/smartfaq/".$versioninfo->getInfo('image')."' alt='' align='center'/></a>";
25		echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . " version " . $versioninfo->getInfo('version') . "</div>";
26		if ( $versioninfo->getInfo('author_realname') != '') {
27		$author_name = $versioninfo->getInfo('author') . " (" . $versioninfo->getInfo('author_realname') . ")";
28		} else {
29		$author_name = $versioninfo->getInfo('author');
30		}
31
32		echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . " " .$author_name;
33		echo "</div>";
34		echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div><br></>\n";
35
36		echo "</td>";
37		echo "</tr>";
38		echo "</table>";
39		*/
40		// Left headings...
41		echo "<img src='" . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/' . $versioninfo->getInfo('image') . "' alt='' hspace='0' vspace='0' align='left' style='margin-right: 10px;'/></a>";
42		echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . ' version ' . $versioninfo->getInfo('version') . ' (' . $versioninfo->getInfo('status_version') . ')</div>';
43		if ($versioninfo->getInfo('author_realname') != '') {
44		$author_name = $versioninfo->getInfo('author') . ' (' . $versioninfo->getInfo('author_realname') . ')';
45		} else {
46		$author_name = $versioninfo->getInfo('author');
47		}
48
49		echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . ' ' . $author_name;
50		echo '</div>';
51		echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div>\n";
52
53		// Developers Information
54		echo "<br /><table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
55		echo '<tr>';
56		echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_AUTHOR_INFO . '</b></td>';
57		echo '</tr>';
58
59		if ($versioninfo->getInfo('developer_lead') != '') {
60		echo '<tr>';
61		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_LEAD . '</td>';
62		echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_lead') . '</td>';
63		echo '</tr>';
64		}
65		if ($versioninfo->getInfo('developer_contributor') != '') {
66		echo '<tr>';
67		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_CONTRIBUTOR . '</td>';
68		echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_contributor') . '</td>';
69		echo '</tr>';
70		}
71	View Code Duplication	if ($versioninfo->getInfo('developer_website_url') != '') {
72		echo '<tr>';
73		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_WEBSITE . '</td>';
74		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('developer_website_url') . "' target='blank'>" . $versioninfo->getInfo('developer_website_name') . '</a></td>';
75		echo '</tr>';
76		}
77	View Code Duplication	if ($versioninfo->getInfo('developer_email') != '') {
78		echo '<tr>';
79		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_EMAIL . '</td>';
80		echo "<td class='even' align='left'><a href='mailto:" . $versioninfo->getInfo('developer_email') . "'>" . $versioninfo->getInfo('developer_email') . '</a></td>';
81		echo '</tr>';
82		}
83
84		echo '</table>';
85		echo "<br />\n";
86		// Module Developpment information
87		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
88		echo '<tr>';
89		echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_MODULE_INFO . '</b></td>';
90		echo '</tr>';
91
92		if ($versioninfo->getInfo('date') != '') {
93		echo '<tr>';
94		echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_RELEASE_DATE . '</td>';
95		echo "<td class='even' align='left'>" . $versioninfo->getInfo('date') . '</td>';
96		echo '</tr>';
97		}
98
99		if ($versioninfo->getInfo('status') != '') {
100		echo '<tr>';
101		echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_STATUS . '</td>';
102		echo "<td class='even' align='left'>" . $versioninfo->getInfo('status') . '</td>';
103		echo '</tr>';
104		}
105
106	View Code Duplication	if ($versioninfo->getInfo('demo_site_url') != '') {
107		echo '<tr>';
108		echo "<td class='head' align='left'>" . _MI_SF_MODULE_DEMO . '</td>';
109		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('demo_site_url') . "' target='blank'>" . $versioninfo->getInfo('demo_site_name') . '</a></td>';
110		echo '</tr>';
111		}
112
113	View Code Duplication	if ($versioninfo->getInfo('support_site_url') != '') {
114		echo '<tr>';
115		echo "<td class='head' align='left'>" . _MI_SF_MODULE_SUPPORT . '</td>';
116		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('support_site_url') . "' target='blank'>" . $versioninfo->getInfo('support_site_name') . '</a></td>';
117		echo '</tr>';
118		}
119
120		if ($versioninfo->getInfo('submit_bug') != '') {
121		echo '<tr>';
122		echo "<td class='head' align='left'>" . _MI_SF_MODULE_BUG . '</td>';
123		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_bug') . "' target='blank'>" . 'Submit a Bug in SmartFAQ Bug Tracker' . '</a></td>';
124		echo '</tr>';
125		}
126		if ($versioninfo->getInfo('submit_feature') != '') {
127		echo '<tr>';
128		echo "<td class='head' align='left'>" . _MI_SF_MODULE_FEATURE . '</td>';
129		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_feature') . "' target='blank'>" . 'Request a feature in the SmartFAQ Feature Tracker' . '</a></td>';
130		echo '</tr>';
131		}
132
133		echo '</table>';
134		// Warning
135	View Code Duplication	if ($versioninfo->getInfo('warning') != '') {
136		echo "<br />\n";
137		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
138		echo '<tr>';
139		echo "<td class='bg3' align='left'><b>" . _MI_SF_MODULE_DISCLAIMER . '</b></td>';
140		echo '</tr>';
141
142		echo '<tr>';
143		echo "<td class='even' align='left'>" . $versioninfo->getInfo('warning') . '</td>';
144		echo '</tr>';
145
146		echo '</table>';
147		}
148		// Author's note
149	View Code Duplication	if ($versioninfo->getInfo('author_word') != '') {
150		echo "<br />\n";
151		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
152		echo '<tr>';
153		echo "<td class='bg3' align='left'><b>" . _MI_SF_AUTHOR_WORD . '</b></td>';
154		echo '</tr>';
155
156		echo '<tr>';
157		echo "<td class='even' align='left'>" . $versioninfo->getInfo('author_word') . '</td>';
158		echo '</tr>';
159
160		echo '</table>';
161		}
162
163		// Version History
164	View Code Duplication	if ($versioninfo->getInfo('version_history') != '') {
165		echo "<br />\n";
166		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
167		echo '<tr>';
168		echo "<td class='bg3' align='left'><b>" . _MI_SF_VERSION_HISTORY . '</b></td>';
169		echo '</tr>';
170
171		echo '<tr>';
172		echo "<td class='even' align='left'>" . $versioninfo->getInfo('version_history') . '</td>';
173		echo '</tr>';
174
175		echo '</table>';
176		}
177
178		echo '<br />';
179		//$modfooter = sf_modFooter();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-30 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `47%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
180		//echo "<div align='center'>" . $modfooter . "</div>";
181		//xoops_cp_footer();
182		include_once __DIR__ . '/admin_footer.php';
183

mambax7 / smartfaq

Branch — master (1b2f30)

admin/about2.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like