Passed
Branch master (4e30dc)
by Michael
02:20
created
answer.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 use XoopsModules\Smartfaq;
11 11
 use XoopsModules\Smartfaq\Constants;
12 12
 
13
-require_once __DIR__ . '/header.php';
13
+require_once __DIR__.'/header.php';
14 14
 
15 15
 global $xoopsUser, $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
16 16
 
@@ -133,12 +133,12 @@  discard block
 block discarded – undo
133 133
 
134 134
         // Storing the FAQ object in the database
135 135
         if (!$faqObj->store()) {
136
-            redirect_header('javascript:history.go(-1)', 3, _MD_SF_SUBMIT_ERROR . Smartfaq\Utility::formatErrors($faqObj->getErrors()));
136
+            redirect_header('javascript:history.go(-1)', 3, _MD_SF_SUBMIT_ERROR.Smartfaq\Utility::formatErrors($faqObj->getErrors()));
137 137
         }
138 138
 
139 139
         // Storing the answer object in the database
140 140
         if (!$newAnswerObj->store()) {
141
-            redirect_header('javascript:history.go(-1)', 3, _MD_SF_SUBMIT_ERROR . Smartfaq\Utility::formatErrors($newAnswerObj->getErrors()));
141
+            redirect_header('javascript:history.go(-1)', 3, _MD_SF_SUBMIT_ERROR.Smartfaq\Utility::formatErrors($newAnswerObj->getErrors()));
142 142
         }
143 143
 
144 144
         /** @var \XoopsNotificationHandler $notificationHandler */
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
             case 2:
156 156
                 // Answer for an open question submitted, auto-approved; became Q&A, need approbation
157 157
                 if (isset($_POST['notifypub']) && 1 == $_POST['notifypub']) {
158
-                    require_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
158
+                    require_once XOOPS_ROOT_PATH.'/include/notification_constants.php';
159 159
                     $notificationHandler->subscribe('faq', $faqObj->faqid(), 'approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
160 160
                 }
161 161
                 // Send notifications
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
             case 3:
166 166
                 // Answer submitted, needs approbation
167 167
                 if (isset($_POST['notifypub']) && 1 == $_POST['notifypub']) {
168
-                    require_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
168
+                    require_once XOOPS_ROOT_PATH.'/include/notification_constants.php';
169 169
                     $notificationHandler->subscribe('question', $newAnswerObj->answerid(), 'approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
170 170
                 }
171 171
                 // Send notifications
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
                 // New answer submitted for a published Q&A, need approbation
181 181
                 // Send notifications
182 182
                 if (isset($_POST['notifypub']) && 1 == $_POST['notifypub']) {
183
-                    require_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
183
+                    require_once XOOPS_ROOT_PATH.'/include/notification_constants.php';
184 184
                     $notificationHandler->subscribe('faq', $newAnswerObj->answerid(), 'answer_approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
185 185
                 }
186 186
 
@@ -216,20 +216,20 @@  discard block
 block discarded – undo
216 216
         }
217 217
 
218 218
         $GLOBALS['xoopsOption']['template_main'] = 'smartfaq_submit.tpl';
219
-        require_once XOOPS_ROOT_PATH . '/header.php';
220
-        require_once __DIR__ . '/footer.php';
219
+        require_once XOOPS_ROOT_PATH.'/header.php';
220
+        require_once __DIR__.'/footer.php';
221 221
 
222 222
         $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
223 223
 
224
-        $moduleName =& $myts->displayTarea($xoopsModule->getVar('name'));
224
+        $moduleName = & $myts->displayTarea($xoopsModule->getVar('name'));
225 225
         $xoopsTpl->assign('whereInSection', $moduleName);
226 226
         $xoopsTpl->assign('lang_submit', _MD_SF_SUBMITANSWER);
227 227
 
228 228
         $xoopsTpl->assign('lang_intro_title', sprintf(_MD_SF_SUBMITANSWERTO, ucwords($xoopsModule->name())));
229
-        $xoopsTpl->assign('lang_intro_text', _MD_SF_GOODDAY . "<b>$name</b>, " . _MD_SF_SUBMITANSWER_INTRO);
229
+        $xoopsTpl->assign('lang_intro_text', _MD_SF_GOODDAY."<b>$name</b>, "._MD_SF_SUBMITANSWER_INTRO);
230 230
 
231
-        require_once __DIR__ . '/include/answer.inc.php';
231
+        require_once __DIR__.'/include/answer.inc.php';
232 232
 
233
-        require_once XOOPS_ROOT_PATH . '/footer.php';
233
+        require_once XOOPS_ROOT_PATH.'/footer.php';
234 234
         break;
235 235
 }
Please login to merge, or discard this patch.
xoops_version.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 // defined('XOOPS_ROOT_PATH') || die('Restricted access');
12 12
 
13
-require_once __DIR__ . '/preloads/autoloader.php';
13
+require_once __DIR__.'/preloads/autoloader.php';
14 14
 
15 15
 $moduleDirName = basename(__DIR__);
16 16
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 //$modversion['icons32']             = '../../Frameworks/moduleclasses/icons/32';
33 33
 $modversion['modicons16']          = 'assets/images/icons/16';
34 34
 $modversion['modicons32']          = 'assets/images/icons/32';
35
-$modversion['release_file']        = XOOPS_URL . '/modules/' . $modversion['dirname'] . '/docs/changelog.txt';
35
+$modversion['release_file']        = XOOPS_URL.'/modules/'.$modversion['dirname'].'/docs/changelog.txt';
36 36
 $modversion['module_website_url']  = 'www.xoops.org';
37 37
 $modversion['module_website_name'] = 'XOOPS';
38 38
 $modversion['min_php']             = '5.5';
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
 
103 103
 // Tables created by sql file (without prefix!)
104 104
 $modversion['tables'] = [
105
-    $moduleDirName . '_' . 'categories',
106
-    $moduleDirName . '_' . 'faq',
107
-    $moduleDirName . '_' . 'answers'
105
+    $moduleDirName.'_'.'categories',
106
+    $moduleDirName.'_'.'faq',
107
+    $moduleDirName.'_'.'answers'
108 108
 ];
109 109
 
110 110
 // Search
Please login to merge, or discard this patch.
include/onupdate.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
     ob_start();
29 29
 
30
-    echo '<code>' . _SDU_UPDATE_UPDATING_DATABASE . '<br>';
30
+    echo '<code>'._SDU_UPDATE_UPDATING_DATABASE.'<br>';
31 31
 
32 32
     // Adding partialview field
33 33
     $table = new Smartfaq\SmartDbTable('smartfaq_faq');
Please login to merge, or discard this patch.
include/oninstall.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -30,16 +30,16 @@  discard block
 block discarded – undo
30 30
  */
31 31
 function xoops_module_pre_install_smartfaq(\XoopsModule $module)
32 32
 {
33
-    include __DIR__ . '/../preloads/autoloader.php';
33
+    include __DIR__.'/../preloads/autoloader.php';
34 34
     /** @var \XoopsModules\Smartfaq\Utility $utility */
35 35
     $utility = new \XoopsModules\Smartfaq\Utility();
36 36
     $xoopsSuccess = $utility::checkVerXoops($module);
37 37
     $phpSuccess   = $utility::checkVerPhp($module);
38 38
 
39
-    if (false !== $xoopsSuccess && false !==  $phpSuccess) {
40
-        $moduleTables =& $module->getInfo('tables');
39
+    if (false !== $xoopsSuccess && false !== $phpSuccess) {
40
+        $moduleTables = & $module->getInfo('tables');
41 41
         foreach ($moduleTables as $table) {
42
-            $GLOBALS['xoopsDB']->queryF('DROP TABLE IF EXISTS ' . $GLOBALS['xoopsDB']->prefix($table) . ';');
42
+            $GLOBALS['xoopsDB']->queryF('DROP TABLE IF EXISTS '.$GLOBALS['xoopsDB']->prefix($table).';');
43 43
         }
44 44
     }
45 45
 
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
  */
56 56
 function xoops_module_install_smartfaq(\XoopsModule $module)
57 57
 {
58
-    require_once  __DIR__ . '/../../../mainfile.php';
59
-    require_once  __DIR__ . '/../include/config.php';
58
+    require_once  __DIR__.'/../../../mainfile.php';
59
+    require_once  __DIR__.'/../include/config.php';
60 60
 
61 61
     $moduleDirName = basename(dirname(__DIR__));
62 62
 
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
     $moduleId2    = $helper->getModule()->mid();
74 74
     $gpermHandler = xoops_getHandler('groupperm');
75 75
     // access rights ------------------------------------------
76
-    $gpermHandler->addRight($moduleDirName . '_approve', 1, XOOPS_GROUP_ADMIN, $moduleId);
77
-    $gpermHandler->addRight($moduleDirName . '_submit', 1, XOOPS_GROUP_ADMIN, $moduleId);
78
-    $gpermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_ADMIN, $moduleId);
79
-    $gpermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_USERS, $moduleId);
80
-    $gpermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_ANONYMOUS, $moduleId);
76
+    $gpermHandler->addRight($moduleDirName.'_approve', 1, XOOPS_GROUP_ADMIN, $moduleId);
77
+    $gpermHandler->addRight($moduleDirName.'_submit', 1, XOOPS_GROUP_ADMIN, $moduleId);
78
+    $gpermHandler->addRight($moduleDirName.'_view', 1, XOOPS_GROUP_ADMIN, $moduleId);
79
+    $gpermHandler->addRight($moduleDirName.'_view', 1, XOOPS_GROUP_USERS, $moduleId);
80
+    $gpermHandler->addRight($moduleDirName.'_view', 1, XOOPS_GROUP_ANONYMOUS, $moduleId);
81 81
 
82 82
     //  ---  CREATE FOLDERS ---------------
83 83
     if (count($configurator->uploadFolders) > 0) {
@@ -89,14 +89,14 @@  discard block
 block discarded – undo
89 89
 
90 90
     //  ---  COPY blank.png FILES ---------------
91 91
     if (count($configurator->copyBlankFiles) > 0) {
92
-        $file = __DIR__ . '/../assets/images/blank.png';
92
+        $file = __DIR__.'/../assets/images/blank.png';
93 93
         foreach (array_keys($configurator->copyBlankFiles) as $i) {
94
-            $dest = $configurator->copyBlankFiles[$i] . '/blank.png';
94
+            $dest = $configurator->copyBlankFiles[$i].'/blank.png';
95 95
             $utilityClass::copyFile($file, $dest);
96 96
         }
97 97
     }
98 98
     //delete .html entries from the tpl table
99
-    $sql = 'DELETE FROM ' . $xoopsDB->prefix('tplfile') . " WHERE `tpl_module` = '" . $xoopsModule->getVar('dirname', 'n') . "' AND `tpl_file` LIKE '%.html%'";
99
+    $sql = 'DELETE FROM '.$xoopsDB->prefix('tplfile')." WHERE `tpl_module` = '".$xoopsModule->getVar('dirname', 'n')."' AND `tpl_file` LIKE '%.html%'";
100 100
     $xoopsDB->queryF($sql);
101 101
 
102 102
     return true;
Please login to merge, or discard this patch.
include/request.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,9 +12,9 @@
 block discarded – undo
12 12
 
13 13
 global $_POST;
14 14
 
15
-require_once XOOPS_ROOT_PATH . '/class/xoopstree.php';
16
-require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
17
-require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
15
+require_once XOOPS_ROOT_PATH.'/class/xoopstree.php';
16
+require_once XOOPS_ROOT_PATH.'/class/xoopslists.php';
17
+require_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
18 18
 
19 19
 $form = new \XoopsThemeForm(_MD_SF_REQUEST, 'form', xoops_getenv('PHP_SELF'), 'post', true);
20 20
 // CATEGORY
Please login to merge, or discard this patch.
include/search.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     for ($i = 0, $iMax = count($faqsObj); $i < $iMax; ++$i) {
28 28
         $ret[$i]['image'] = 'assets/images/smartfaq.gif';
29
-        $ret[$i]['link']  = 'faq.php?faqid=' . $faqsObj[$i]->faqid();
29
+        $ret[$i]['link']  = 'faq.php?faqid='.$faqsObj[$i]->faqid();
30 30
         $ret[$i]['title'] = $faqsObj[$i]->question(50);
31 31
         $ret[$i]['time']  = $faqsObj[$i]->getVar('datesub');
32 32
         $ret[$i]['uid']   = $faqsObj[$i]->uid();
Please login to merge, or discard this patch.
include/answer.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,9 +13,9 @@
 block discarded – undo
13 13
 
14 14
 global $_POST;
15 15
 
16
-require_once XOOPS_ROOT_PATH . '/class/xoopstree.php';
17
-require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
18
-require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
16
+require_once XOOPS_ROOT_PATH.'/class/xoopstree.php';
17
+require_once XOOPS_ROOT_PATH.'/class/xoopslists.php';
18
+require_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
19 19
 //require_once __DIR__ . '/functions.php';
20 20
 
21 21
 $mytree = new Smartfaq\Tree($xoopsDB->prefix('smartfaq_categories'), 'categoryid', 'parentid');
Please login to merge, or discard this patch.
include/submit.inc.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -12,9 +12,9 @@  discard block
 block discarded – undo
12 12
 
13 13
 global $_POST, $xoopsDB;
14 14
 
15
-require_once XOOPS_ROOT_PATH . '/class/xoopstree.php';
16
-require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
17
-require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
15
+require_once XOOPS_ROOT_PATH.'/class/xoopstree.php';
16
+require_once XOOPS_ROOT_PATH.'/class/xoopslists.php';
17
+require_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
18 18
 
19 19
 //require_once __DIR__ . '/functions.php';
20 20
 
@@ -73,18 +73,18 @@  discard block
 block discarded – undo
73 73
 //    $upload_tray->addElement(new \XoopsFormFile('', 'userfile', ($forum_obj->getVar('attach_maxkb') * 1024)));
74 74
 $upload_tray->addElement(new \XoopsFormFile('', 'userfile', $xoopsModuleConfig['max_image_size'] * 1024));
75 75
 $upload_tray->addElement(new \XoopsFormButton('', 'contents_upload', _MD_SF_UPLOAD, 'submit'));
76
-$upload_tray->addElement(new \XoopsFormLabel('<br><br>' . _MD_SF_MAX_FILESIZE . ':', $xoopsModuleConfig['max_image_size'] . 'Kb; '));
76
+$upload_tray->addElement(new \XoopsFormLabel('<br><br>'._MD_SF_MAX_FILESIZE.':', $xoopsModuleConfig['max_image_size'].'Kb; '));
77 77
 $extensions = trim(str_replace('|', ' ', $xoopsModuleConfig['attach_ext']));
78 78
 $extensions = (empty($extensions) || '*' === $extensions) ? _ALL : $extensions;
79
-$upload_tray->addElement(new \XoopsFormLabel(_MD_SF_ALLOWED_EXTENSIONS . ':', $extensions));
80
-$upload_tray->addElement(new \XoopsFormLabel('<br>' . sprintf(_MD_SF_MAXPIC, $xoopsModuleConfig['max_img_height'], $xoopsModuleConfig['max_img_width'])));
79
+$upload_tray->addElement(new \XoopsFormLabel(_MD_SF_ALLOWED_EXTENSIONS.':', $extensions));
80
+$upload_tray->addElement(new \XoopsFormLabel('<br>'.sprintf(_MD_SF_MAXPIC, $xoopsModuleConfig['max_img_height'], $xoopsModuleConfig['max_img_width'])));
81 81
 $form->addElement($upload_tray);
82 82
 //}
83 83
 
84 84
 if (!empty($attachments) && is_array($attachments) && count($attachments)) {
85 85
     $delete_attach_checkbox = new \XoopsFormCheckBox(_MD_SF_ATTACHED_FILES, 'delete_attach[]');
86 86
     foreach ($attachments as $key => $attachment) {
87
-        $attach = ' ' . _DELETE . ' <a href=' . XOOPS_URL . '/' . $xoopsModuleConfig['dir_attachments'] . '/' . $attachment['name_saved'] . ' rel="external">' . $attachment['name_display'] . '</a><br>';
87
+        $attach = ' '._DELETE.' <a href='.XOOPS_URL.'/'.$xoopsModuleConfig['dir_attachments'].'/'.$attachment['name_saved'].' rel="external">'.$attachment['name_display'].'</a><br>';
88 88
         $delete_attach_checkbox->addOption($key, $attach);
89 89
     }
90 90
     $form->addElement($delete_attach_checkbox);
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     $delete_attach_checkbox = new \XoopsFormCheckBox(_MD_REMOVE, 'delete_tmp[]');
96 96
     $url_prefix             = str_replace(XOOPS_ROOT_PATH, XOOPS_URL, XOOPS_CACHE_PATH);
97 97
     foreach ($attachments_tmp as $key => $attachment) {
98
-        $attach = ' <a href="' . $url_prefix . '/' . $attachment[0] . '" rel="external">' . $attachment[1] . '</a><br>';
98
+        $attach = ' <a href="'.$url_prefix.'/'.$attachment[0].'" rel="external">'.$attachment[1].'</a><br>';
99 99
         $delete_attach_checkbox->addOption($key, $attach);
100 100
     }
101 101
     $form->addElement($delete_attach_checkbox);
Please login to merge, or discard this patch.
include/onuninstall.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,10 +34,10 @@  discard block
 block discarded – undo
34 34
 //    return true;
35 35
 
36 36
     $moduleDirName = basename(dirname(__DIR__));
37
-    $xsitemapHelper      = \Xmf\Module\Helper::getHelper($moduleDirName);
37
+    $xsitemapHelper = \Xmf\Module\Helper::getHelper($moduleDirName);
38 38
 
39 39
     /** @var XoopsModules\Smartfaq\Utility $utilityClass */
40
-    $utilityClass     = ucfirst($moduleDirName) . 'Utility';
40
+    $utilityClass = ucfirst($moduleDirName).'Utility';
41 41
     if (!class_exists($utilityClass)) {
42 42
         xoops_load('utility', $moduleDirName);
43 43
     }
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         if ($dirInfo->isDir()) {
57 57
             // The directory exists so delete it
58 58
             if (false === $utilityClass::rrmdir($old_dir)) {
59
-                $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_DEL_PATH'), $old_dir));
59
+                $module->setErrors(sprintf(constant('CO_'.$moduleDirNameUpper.'_ERROR_BAD_DEL_PATH'), $old_dir));
60 60
                 $success = false;
61 61
             }
62 62
         }
Please login to merge, or discard this patch.