blocks/faqs_new.php ➔ b_faqs_new_show()

Complexity

Conditions	7
Paths	4

Size

Total Lines	41
Code Lines	25

Duplication

Lines	41
Ratio	100 %

Importance

Changes

0

<?php
function b_faqs_new_show($options)
{
//    require_once XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php';

    $block = [];

    if (0 == $options[0]) {
        $categoryid = -1;
    } else {
        $categoryid = $options[0];
    }

    $sort              = $options[1];
    $limit             = $options[2];
    $maxQuestionLength = $options[3];

    // Creating the faq handler object
    /** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
    $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
    // creating the FAQ objects that belong to the selected category
    $faqsObj   = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);

    if ($faqsObj) {

The expression $faqsObj of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        foreach ($faqsObj as $iValue) {
            $newfaqs             = [];
            $newfaqs['linktext'] = $iValue->question($maxQuestionLength);
            $newfaqs['id']       = $iValue->faqid();
            if ('datesub' === $sort) {
                $newfaqs['new'] = $iValue->datesub();
            } elseif ('counter' === $sort) {
                $newfaqs['new'] = $iValue->counter();
            } elseif ('weight' === $sort) {
                $newfaqs['new'] = $iValue->weight();
            }
            $newfaqs['show_date'] = $options[4];
            $block['newfaqs'][]   = $newfaqs;
        }
    }

    return $block;
}