mambax7 / smartfaq

admin/mygrouppermform.php

Doc Comments +3 added lines, -3 removed lines

@@ -120,9 +120,9 @@ 
      * Add appendix
      *
      * @access public
-     * @param $permName
+     * @param string $permName
      * @param $itemId
-     * @param $itemName
+     * @param string $itemName
      */
     public function addAppendix($permName, $itemId, $itemName)
     {
@@ -256,7 +256,7 @@ 
     /**
      * Constructor
      * @param      $caption
-     * @param      $name
+     * @param      string $name
      * @param      $groupId
      * @param null $values
      */

admin/question.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 $startfaq = isset($_GET['startfaq']) ? (int)$_GET['startfaq'] : 0;
 
 /**
- * @param bool $showmenu
+ * @param string $showmenu
  * @param int  $faqid
  */
 function editfaq($showmenu = false, $faqid = -1)

class/answer.php

Doc Comments +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
 
     /**
      * constructor
-     * @param null $id
+     * @param integer $id
      */
     public function __construct($id = null)
     {
@@ -368,7 +368,7 @@ 
      * create a new answer
      *
      * @param  bool $isNew flag the new objects as "new"?
-     * @return object sfAnswer
+     * @return sfAnswer sfAnswer
      */
     public function create($isNew = true)
     {
@@ -410,7 +410,7 @@ 
     /**
      * insert a new answer in the database
      *
-     * @param  XoopsObject $answerObj reference to the <a href='psi_element://sfAnswer'>sfAnswer</a> object
+     * @param  sfAnswer $answerObj reference to the <a href='psi_element://sfAnswer'>sfAnswer</a> object
      * @param  bool        $force
      * @return bool        FALSE if failed, TRUE if already present and unchanged or successful
      */

class/category.php

Doc Comments +2 added lines, -2 removed lines

@@ -269,7 +269,7 @@ 
      * create a new category
      *
      * @param  bool $isNew flag the new objects as "new"?
-     * @return object sfCategory
+     * @return sfCategory sfCategory
      */
     public function &create($isNew = true)
     {
@@ -311,7 +311,7 @@ 
     /**
      * insert a new category in the database
      *
-     * @param  XoopsObject $category reference to the {@link sfCategory} object
+     * @param  sfCategory $category reference to the {@link sfCategory} object
      * @param  bool        $force
      * @return bool        FALSE if failed, TRUE if already present and unchanged or successful
      */

class/faq.php

Doc Comments +3 added lines, -3 removed lines

@@ -243,7 +243,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function uid()
     {
@@ -744,7 +744,7 @@ 
     /**
      * insert a new faq in the database
      *
-     * @param  XoopsObject $faq reference to the {@link sfFaq} object
+     * @param  sfFaq $faq reference to the {@link sfFaq} object
      * @param  bool        $force
      * @return bool        FALSE if failed, TRUE if already present and unchanged or successful
      */
@@ -1121,7 +1121,7 @@ 
      * @param  string $order
      * @param  string $notNullFields
      * @param  bool   $asobject
-     * @param  null   $otherCriteria
+     * @param  null|CriteriaCompo   $otherCriteria
      * @return array
      */
     public function getFaqs($limit = 0, $start = 0, $status = '', $categoryid = -1, $sort = 'datesub', $order = 'DESC', $notNullFields = '', $asobject = true, $otherCriteria = null)

class/smartdbupdater.php

Doc Comments +2 added lines, -2 removed lines

@@ -167,7 +167,7 @@ 
     }
 
     /**
-     * @param $field
+     * @param string $field
      * @return bool
      */
     public function fieldExists($field)
@@ -628,7 +628,7 @@ 
     /**
      * Use to update a table
      *
-     * @param object $table {@link SmartDbTable} that will be updated
+     * @param SmartDbTable $table {@link SmartDbTable} that will be updated
      *
      * @see SmartDbTable
      *

class/uploader.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      * Constructor
      *
      * @param string    $uploadDir
-     * @param array|int $allowedMimeTypes
+     * @param integer $allowedMimeTypes
      * @param int       $maxFileSize
      * @param int       $maxWidth
      * @param int       $maxHeight

include/functions.php

Doc Comments +2 added lines, -2 removed lines

@@ -509,7 +509,7 @@ 
 
 /**
  * @param  string $url
- * @return mixed|string
+ * @return string
  */
 function sf_getxoopslink($url = '')
 {
@@ -582,7 +582,7 @@ 
 }
 
 /**
- * @param       $name
+ * @param       string $name
  * @param  bool $optional
  * @return bool
  */

request.php

Switch Indentation +70 added lines, -70 removed lines

@@ -41,94 +41,94 @@
 }
 
 switch ($op) {
-    case 'post':
+        case 'post':
 
-        global $xoopsUser, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsDB;
+            global $xoopsUser, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsDB;
 
-        $newFaqObj = $faqHandler->create();
+            $newFaqObj = $faqHandler->create();
 
-        if (!$xoopsUser) {
-            if ($xoopsModuleConfig['anonpost'] == 1) {
-                $uid = 0;
+            if (!$xoopsUser) {
+                if ($xoopsModuleConfig['anonpost'] == 1) {
+                    $uid = 0;
+                } else {
+                    redirect_header('index.php', 3, _NOPERM);
+                }
             } else {
-                redirect_header('index.php', 3, _NOPERM);
+                $uid = $xoopsUser->uid();
             }
-        } else {
-            $uid = $xoopsUser->uid();
-        }
-
-        // Putting the values about the FAQ in the FAQ object
-        $newFaqObj->setVar('categoryid', $_POST['categoryid']);
-        $newFaqObj->setVar('uid', $uid);
-        $newFaqObj->setVar('question', $_POST['question']);
-        $notifypub = isset($_POST['notifypub']) ? $_POST['notifypub'] : 0;
-        $newFaqObj->setVar('notifypub', $notifypub);
-
-        // Setting the status of the FAQ
-        if ($xoopsModuleConfig['autoapprove_request'] == 1) {
-            $newFaqObj->setVar('status', _SF_STATUS_OPENED);
-        } else {
-            $newFaqObj->setVar('status', _SF_STATUS_ASKED);
-        }
-
-        // Storing the FAQ object in the database
-        if (!$newFaqObj->store()) {
-            redirect_header('javascript:history.go(-1)', 3, _MD_SF_REQUEST_ERROR . sf_formatErrors($newFaqObj->getErrors()));
-        }
-
-        // Get the cateopry object related to that FAQ
-        // If autoapprove_requested
-        if ($xoopsModuleConfig['autoapprove_request'] == 1) {
-            // We do not not subscribe user to notification on publish since we publish it right away
-
-            // Send notifications
-            $newFaqObj->sendNotifications(array(_SF_NOT_QUESTION_PUBLISHED));
-
-            $redirect_msg = _MD_SF_REQUEST_RECEIVED_AND_PUBLISHED;
-        } else {
-            // Subscribe the user to On Published notification, if requested
-            if ($notifypub == 1) {
-                include_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
-                $notificationHandler = xoops_getHandler('notification');
-                $notificationHandler->subscribe('question', $newFaqObj->faqid(), 'approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
+
+            // Putting the values about the FAQ in the FAQ object
+            $newFaqObj->setVar('categoryid', $_POST['categoryid']);
+            $newFaqObj->setVar('uid', $uid);
+            $newFaqObj->setVar('question', $_POST['question']);
+            $notifypub = isset($_POST['notifypub']) ? $_POST['notifypub'] : 0;
+            $newFaqObj->setVar('notifypub', $notifypub);
+
+            // Setting the status of the FAQ
+            if ($xoopsModuleConfig['autoapprove_request'] == 1) {
+                $newFaqObj->setVar('status', _SF_STATUS_OPENED);
+            } else {
+                $newFaqObj->setVar('status', _SF_STATUS_ASKED);
+            }
+
+            // Storing the FAQ object in the database
+            if (!$newFaqObj->store()) {
+                redirect_header('javascript:history.go(-1)', 3, _MD_SF_REQUEST_ERROR . sf_formatErrors($newFaqObj->getErrors()));
             }
-            // Send notifications
-            $newFaqObj->sendNotifications(array(_SF_NOT_QUESTION_SUBMITTED));
 
-            $redirect_msg = _MD_SF_REQUEST_RECEIVED_NEED_APPROVAL;
-        }
+            // Get the cateopry object related to that FAQ
+            // If autoapprove_requested
+            if ($xoopsModuleConfig['autoapprove_request'] == 1) {
+                // We do not not subscribe user to notification on publish since we publish it right away
+
+                // Send notifications
+                $newFaqObj->sendNotifications(array(_SF_NOT_QUESTION_PUBLISHED));
+
+                $redirect_msg = _MD_SF_REQUEST_RECEIVED_AND_PUBLISHED;
+            } else {
+                // Subscribe the user to On Published notification, if requested
+                if ($notifypub == 1) {
+                    include_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
+                    $notificationHandler = xoops_getHandler('notification');
+                    $notificationHandler->subscribe('question', $newFaqObj->faqid(), 'approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
+                }
+                // Send notifications
+                $newFaqObj->sendNotifications(array(_SF_NOT_QUESTION_SUBMITTED));
+
+                $redirect_msg = _MD_SF_REQUEST_RECEIVED_NEED_APPROVAL;
+            }
 
-        //redirect_header("javascript:history.go(-2)", 3, $redirect_msg);
-        redirect_header('index.php', 2, $redirect_msg);
-        break;
+            //redirect_header("javascript:history.go(-2)", 3, $redirect_msg);
+            redirect_header('index.php', 2, $redirect_msg);
+            break;
 
-    case 'form':
-    default:
+        case 'form':
+        default:
 
-        global $xoopsUser, $myts;
+            global $xoopsUser, $myts;
 
-        $xoopsOption['template_main'] = 'smartfaq_submit.tpl';
-        include_once(XOOPS_ROOT_PATH . '/header.php');
-        include_once __DIR__ . '/footer.php';
+            $xoopsOption['template_main'] = 'smartfaq_submit.tpl';
+            include_once(XOOPS_ROOT_PATH . '/header.php');
+            include_once __DIR__ . '/footer.php';
 
-        $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
+            $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
 
-        $moduleName =& $myts->displayTarea($xoopsModule->getVar('name'));
-        $xoopsTpl->assign('whereInSection', $moduleName);
-        $xoopsTpl->assign('lang_submit', _MD_SF_REQUEST);
+            $moduleName =& $myts->displayTarea($xoopsModule->getVar('name'));
+            $xoopsTpl->assign('whereInSection', $moduleName);
+            $xoopsTpl->assign('lang_submit', _MD_SF_REQUEST);
 
-        $xoopsTpl->assign('lang_intro_title', _MD_SF_REQUEST);
-        $xoopsTpl->assign('lang_intro_text', _MD_SF_GOODDAY . "<b>$name</b>, " . $myts->displayTarea($xoopsModuleConfig['requestintromsg']));
+            $xoopsTpl->assign('lang_intro_title', _MD_SF_REQUEST);
+            $xoopsTpl->assign('lang_intro_text', _MD_SF_GOODDAY . "<b>$name</b>, " . $myts->displayTarea($xoopsModuleConfig['requestintromsg']));
 
-        include_once 'include/request.inc.php';
+            include_once 'include/request.inc.php';
 
-        $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
+            $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
 
-        $sectionname = $myts->htmlSpecialChars($xoopsModule->getVar('name'));
+            $sectionname = $myts->htmlSpecialChars($xoopsModule->getVar('name'));
 
-        include_once 'include/request.inc.php';
+            include_once 'include/request.inc.php';
 
-        include_once XOOPS_ROOT_PATH . '/footer.php';
+            include_once XOOPS_ROOT_PATH . '/footer.php';
 
-        break;
+            break;
 }