Issues in about2.php - New Issues - Inspection of "Bring everything back up one level" - mambax7/smartfaq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 65a58d...61df55 )

by Michael

created 2016-01-18 08:37 UTC

admin/about2.php (7 issues)

Labels

Duplication 7

Severity

Informational 7

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
* $Id: about.php,v 1.12 2004/12/14 01:59:42 malanciault Exp $
* Module: SmartFAQ
* Author: The SmartFactory <www.smartfactory.ca>
* Licence: GNU
*/

include_once __DIR__ . '/admin_header.php';
$myts = &MyTextSanitizer::getInstance();

Global $xoopsModule;

xoops_cp_header();

$module_handler = &xoops_gethandler('module');
$versioninfo = &$module_handler->get($xoopsModule->getVar('mid'));

//sf_adminMenu(-1, _AM_SF_ABOUT . " " . $versioninfo->getInfo('name'));

/*  Centered heading
echo "<br />";
echo "<table width='100%'>";
echo "<tr>";
echo "<td align = 'center'>";
echo "<img src='".XOOPS_URL."/modules/smartfaq/".$versioninfo->getInfo('image')."' alt='' align='center'/></a>";
echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . " version " . $versioninfo->getInfo('version') . "</div>";
if ( $versioninfo->getInfo('author_realname') != '') {
$author_name = $versioninfo->getInfo('author') . " (" . $versioninfo->getInfo('author_realname') . ")";
} else {
$author_name = $versioninfo->getInfo('author');
}

echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . " " .$author_name;
echo "</div>";
echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div><br></>\n";

echo "</td>";
echo "</tr>";
echo "</table>";
*/
// Left headings...
echo "<img src='" . XOOPS_URL . "/modules/" . $xoopsModule->getVar('dirname') . "/" . $versioninfo->getInfo('image') . "' alt='' hspace='0' vspace='0' align='left' style='margin-right: 10px;'/></a>";
echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . " version " . $versioninfo->getInfo('version') . " (" . $versioninfo->getInfo('status_version') . ")</div>";
if ($versioninfo->getInfo('author_realname') != '') {
    $author_name = $versioninfo->getInfo('author') . " (" . $versioninfo->getInfo('author_realname') . ")";
} else {
    $author_name = $versioninfo->getInfo('author');
}

echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . " " . $author_name;
echo "</div>";
echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div>\n";

// Developers Information
echo "<br /><table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
echo "<tr>";
echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_AUTHOR_INFO . "</b></td>";
echo "</tr>";

if ($versioninfo->getInfo('developer_lead') != '') {
    echo "<tr>";
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_LEAD . "</td>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_lead') . "</td>";
    echo "</tr>";
}
if ($versioninfo->getInfo('developer_contributor') != '') {
    echo "<tr>";
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_CONTRIBUTOR . "</td>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_contributor') . "</td>";
    echo "</tr>";
}
if ($versioninfo->getInfo('developer_website_url') != '') {

    echo "<tr>";
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_WEBSITE . "</td>";
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('developer_website_url') . "' target='blank'>" . $versioninfo->getInfo('developer_website_name') . "</a></td>";
    echo "</tr>";
}
if ($versioninfo->getInfo('developer_email') != '') {

    echo "<tr>";
    echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_EMAIL . "</td>";
    echo "<td class='even' align='left'><a href='mailto:" . $versioninfo->getInfo('developer_email') . "'>" . $versioninfo->getInfo('developer_email') . "</a></td>";
    echo "</tr>";
}

echo "</table>";
echo "<br />\n";
// Module Developpment information
echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
echo "<tr>";
echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_MODULE_INFO . "</b></td>";
echo "</tr>";

if ($versioninfo->getInfo('date') != '') {
    echo "<tr>";
    echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_RELEASE_DATE . "</td>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('date') . "</td>";
    echo "</tr>";
}

if ($versioninfo->getInfo('status') != '') {
    echo "<tr>";
    echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_STATUS . "</td>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('status') . "</td>";
    echo "</tr>";
}

if ($versioninfo->getInfo('demo_site_url') != '') {

    echo "<tr>";
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_DEMO . "</td>";
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('demo_site_url') . "' target='blank'>" . $versioninfo->getInfo('demo_site_name') . "</a></td>";
    echo "</tr>";
}

if ($versioninfo->getInfo('support_site_url') != '') {

    echo "<tr>";
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_SUPPORT . "</td>";
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('support_site_url') . "' target='blank'>" . $versioninfo->getInfo('support_site_name') . "</a></td>";
    echo "</tr>";
}

if ($versioninfo->getInfo('submit_bug') != '') {
    echo "<tr>";
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_BUG . "</td>";
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_bug') . "' target='blank'>" . "Submit a Bug in SmartFAQ Bug Tracker" . "</a></td>";
    echo "</tr>";
}
if ($versioninfo->getInfo('submit_feature') != '') {
    echo "<tr>";
    echo "<td class='head' align='left'>" . _MI_SF_MODULE_FEATURE . "</td>";
    echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_feature') . "' target='blank'>" . "Request a feature in the SmartFAQ Feature Tracker" . "</a></td>";
    echo "</tr>";
}

echo "</table>";
// Warning
if ($versioninfo->getInfo('warning') != '') {

    echo "<br />\n";
    echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
    echo "<tr>";
    echo "<td class='bg3' align='left'><b>" . _MI_SF_MODULE_DISCLAIMER . "</b></td>";
    echo "</tr>";

    echo "<tr>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('warning') . "</td>";
    echo "</tr>";

    echo "</table>";
}
// Author's note
if ($versioninfo->getInfo('author_word') != '') {

    echo "<br />\n";
    echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
    echo "<tr>";
    echo "<td class='bg3' align='left'><b>" . _MI_SF_AUTHOR_WORD . "</b></td>";
    echo "</tr>";

    echo "<tr>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('author_word') . "</td>";
    echo "</tr>";

    echo "</table>";
}

// Version History
if ($versioninfo->getInfo('version_history') != '') {

    echo "<br />\n";
    echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
    echo "<tr>";
    echo "<td class='bg3' align='left'><b>" . _MI_SF_VERSION_HISTORY . "</b></td>";
    echo "</tr>";

    echo "<tr>";
    echo "<td class='even' align='left'>" . $versioninfo->getInfo('version_history') . "</td>";
    echo "</tr>";

    echo "</table>";
}

echo "<br />";
//$modfooter = sf_modFooter();
//echo "<div align='center'>" . $modfooter . "</div>";
//xoops_cp_footer();
include_once __DIR__ . '/admin_footer.php';


1		<?php
2
3		/**
4		* $Id: about.php,v 1.12 2004/12/14 01:59:42 malanciault Exp $
5		* Module: SmartFAQ
6		* Author: The SmartFactory <www.smartfactory.ca>
7		* Licence: GNU
8		*/
9
10		include_once __DIR__ . '/admin_header.php';
11		$myts = &MyTextSanitizer::getInstance();
12
13		Global $xoopsModule;
14
15		xoops_cp_header();
16
17		$module_handler = &xoops_gethandler('module');
18		$versioninfo = &$module_handler->get($xoopsModule->getVar('mid'));
19
20		//sf_adminMenu(-1, _AM_SF_ABOUT . " " . $versioninfo->getInfo('name'));
21
22		/* Centered heading
23		echo "<br />";
24		echo "<table width='100%'>";
25		echo "<tr>";
26		echo "<td align = 'center'>";
27		echo "<img src='".XOOPS_URL."/modules/smartfaq/".$versioninfo->getInfo('image')."' alt='' align='center'/></a>";
28		echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . " version " . $versioninfo->getInfo('version') . "</div>";
29		if ( $versioninfo->getInfo('author_realname') != '') {
30		$author_name = $versioninfo->getInfo('author') . " (" . $versioninfo->getInfo('author_realname') . ")";
31		} else {
32		$author_name = $versioninfo->getInfo('author');
33		}
34
35		echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . " " .$author_name;
36		echo "</div>";
37		echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div><br></>\n";
38
39		echo "</td>";
40		echo "</tr>";
41		echo "</table>";
42		*/
43		// Left headings...
44		echo "<img src='" . XOOPS_URL . "/modules/" . $xoopsModule->getVar('dirname') . "/" . $versioninfo->getInfo('image') . "' alt='' hspace='0' vspace='0' align='left' style='margin-right: 10px;'/></a>";
45		echo "<div style='margin-top: 10px; color: #33538e; margin-bottom: 4px; font-size: 18px; line-height: 18px; font-weight: bold; display: block;'>" . $versioninfo->getInfo('name') . " version " . $versioninfo->getInfo('version') . " (" . $versioninfo->getInfo('status_version') . ")</div>";
46		if ($versioninfo->getInfo('author_realname') != '') {
47		$author_name = $versioninfo->getInfo('author') . " (" . $versioninfo->getInfo('author_realname') . ")";
48		} else {
49		$author_name = $versioninfo->getInfo('author');
50		}
51
52		echo "<div style = 'line-height: 16px; font-weight: bold; display: block;'>" . _AM_SF_BY . " " . $author_name;
53		echo "</div>";
54		echo "<div style = 'line-height: 16px; display: block;'>" . $versioninfo->getInfo('license') . "</div>\n";
55
56		// Developers Information
57		echo "<br /><table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
58		echo "<tr>";
59		echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_AUTHOR_INFO . "</b></td>";
60		echo "</tr>";
61
62		if ($versioninfo->getInfo('developer_lead') != '') {
63		echo "<tr>";
64		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_LEAD . "</td>";
65		echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_lead') . "</td>";
66		echo "</tr>";
67		}
68		if ($versioninfo->getInfo('developer_contributor') != '') {
69		echo "<tr>";
70		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_CONTRIBUTOR . "</td>";
71		echo "<td class='even' align='left'>" . $versioninfo->getInfo('developer_contributor') . "</td>";
72		echo "</tr>";
73		}
74	View Code Duplication	if ($versioninfo->getInfo('developer_website_url') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		echo "<tr>";
76		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_WEBSITE . "</td>";
77		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('developer_website_url') . "' target='blank'>" . $versioninfo->getInfo('developer_website_name') . "</a></td>";
78		echo "</tr>";
79		}
80	View Code Duplication	if ($versioninfo->getInfo('developer_email') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		echo "<tr>";
82		echo "<td class='head' width = '150px' align='left'>" . _MI_SF_DEVELOPER_EMAIL . "</td>";
83		echo "<td class='even' align='left'><a href='mailto:" . $versioninfo->getInfo('developer_email') . "'>" . $versioninfo->getInfo('developer_email') . "</a></td>";
84		echo "</tr>";
85		}
86
87		echo "</table>";
88		echo "<br />\n";
89		// Module Developpment information
90		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
91		echo "<tr>";
92		echo "<td colspan='2' class='bg3' align='left'><b>" . _MI_SF_MODULE_INFO . "</b></td>";
93		echo "</tr>";
94
95		if ($versioninfo->getInfo('date') != '') {
96		echo "<tr>";
97		echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_RELEASE_DATE . "</td>";
98		echo "<td class='even' align='left'>" . $versioninfo->getInfo('date') . "</td>";
99		echo "</tr>";
100		}
101
102		if ($versioninfo->getInfo('status') != '') {
103		echo "<tr>";
104		echo "<td class='head' width = '200' align='left'>" . _MI_SF_MODULE_STATUS . "</td>";
105		echo "<td class='even' align='left'>" . $versioninfo->getInfo('status') . "</td>";
106		echo "</tr>";
107		}
108
109	View Code Duplication	if ($versioninfo->getInfo('demo_site_url') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		echo "<tr>";
111		echo "<td class='head' align='left'>" . _MI_SF_MODULE_DEMO . "</td>";
112		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('demo_site_url') . "' target='blank'>" . $versioninfo->getInfo('demo_site_name') . "</a></td>";
113		echo "</tr>";
114		}
115
116	View Code Duplication	if ($versioninfo->getInfo('support_site_url') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		echo "<tr>";
118		echo "<td class='head' align='left'>" . _MI_SF_MODULE_SUPPORT . "</td>";
119		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('support_site_url') . "' target='blank'>" . $versioninfo->getInfo('support_site_name') . "</a></td>";
120		echo "</tr>";
121		}
122
123		if ($versioninfo->getInfo('submit_bug') != '') {
124		echo "<tr>";
125		echo "<td class='head' align='left'>" . _MI_SF_MODULE_BUG . "</td>";
126		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_bug') . "' target='blank'>" . "Submit a Bug in SmartFAQ Bug Tracker" . "</a></td>";
127		echo "</tr>";
128		}
129		if ($versioninfo->getInfo('submit_feature') != '') {
130		echo "<tr>";
131		echo "<td class='head' align='left'>" . _MI_SF_MODULE_FEATURE . "</td>";
132		echo "<td class='even' align='left'><a href='" . $versioninfo->getInfo('submit_feature') . "' target='blank'>" . "Request a feature in the SmartFAQ Feature Tracker" . "</a></td>";
133		echo "</tr>";
134		}
135
136		echo "</table>";
137		// Warning
138	View Code Duplication	if ($versioninfo->getInfo('warning') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		echo "<br />\n";
140		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
141		echo "<tr>";
142		echo "<td class='bg3' align='left'><b>" . _MI_SF_MODULE_DISCLAIMER . "</b></td>";
143		echo "</tr>";
144
145		echo "<tr>";
146		echo "<td class='even' align='left'>" . $versioninfo->getInfo('warning') . "</td>";
147		echo "</tr>";
148
149		echo "</table>";
150		}
151		// Author's note
152	View Code Duplication	if ($versioninfo->getInfo('author_word') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
153		echo "<br />\n";
154		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
155		echo "<tr>";
156		echo "<td class='bg3' align='left'><b>" . _MI_SF_AUTHOR_WORD . "</b></td>";
157		echo "</tr>";
158
159		echo "<tr>";
160		echo "<td class='even' align='left'>" . $versioninfo->getInfo('author_word') . "</td>";
161		echo "</tr>";
162
163		echo "</table>";
164		}
165
166		// Version History
167	View Code Duplication	if ($versioninfo->getInfo('version_history') != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		echo "<br />\n";
169		echo "<table width='100%' cellspacing=1 cellpadding=3 border=0 class = outer>";
170		echo "<tr>";
171		echo "<td class='bg3' align='left'><b>" . _MI_SF_VERSION_HISTORY . "</b></td>";
172		echo "</tr>";
173
174		echo "<tr>";
175		echo "<td class='even' align='left'>" . $versioninfo->getInfo('version_history') . "</td>";
176		echo "</tr>";
177
178		echo "</table>";
179		}
180
181		echo "<br />";
182		//$modfooter = sf_modFooter();
183		//echo "<div align='center'>" . $modfooter . "</div>";
184		//xoops_cp_footer();
185		include_once __DIR__ . '/admin_footer.php';
186

mambax7 / smartfaq

Push — master ( 65a58d...61df55 )

admin/about2.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like