Issues in request.php - All Issues - Inspection of "1.20 Beta 1" - mambax7/smartfaq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 454ebd...de22fe )

by Michael

created 2018-03-13 20:39 UTC

request.php (12 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Module: SmartFAQ
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 */

use XoopsModules\Smartfaq;
use XoopsModules\Smartfaq\Constants;

require_once __DIR__ . '/header.php';
require_once XOOPS_ROOT_PATH . '/header.php';

global $xoopsUser, $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}

// Creating the category handler object
/** @var \XoopsModules\Smartfaq\CategoryHandler $categoryHandler */
$categoryHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Category');

// Creating the FAQ handler object
/** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
$faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');

// Get the total number of categories
$totalCategories = count($categoryHandler->getCategories());

if (0 == $totalCategories) {
    redirect_header('index.php', 1, _AM_SF_NOCOLEXISTS);
}

// Find if the user is admin of the module
$isAdmin = Smartfaq\Utility::userIsAdmin();
// If the user is not admin AND we don't allow user submission, exit
if (!($isAdmin

      || (isset($xoopsModuleConfig['allowrequest'])
          && 1 == $xoopsModuleConfig['allowrequest']
          && (is_object($xoopsUser) || (isset($xoopsModuleConfig['anonpost']) && 1 == $xoopsModuleConfig['anonpost']))))) {
    redirect_header('index.php', 1, _NOPERM);
}

$op = '';

if (isset($_GET['op'])) {
    $op = $_GET['op'];
}
if (isset($_POST['op'])) {
    $op = $_POST['op'];
}

switch ($op) {
    case 'post':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

        global $xoopsUser, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        $newFaqObj = $faqHandler->create();

        if (!$xoopsUser) {

            if (1 == $xoopsModuleConfig['anonpost']) {
                $uid = 0;
            } else {
                redirect_header('index.php', 3, _NOPERM);
            }
        } else {
            $uid = $xoopsUser->uid();

        }

        // Putting the values about the FAQ in the FAQ object
        $newFaqObj->setVar('categoryid', $_POST['categoryid']);
        $newFaqObj->setVar('uid', $uid);
        $newFaqObj->setVar('question', $_POST['question']);
        $notifypub = isset($_POST['notifypub']) ? $_POST['notifypub'] : 0;
        $newFaqObj->setVar('notifypub', $notifypub);

        // Setting the status of the FAQ
        if (1 == $xoopsModuleConfig['autoapprove_request']) {
            $newFaqObj->setVar('status', Constants::SF_STATUS_OPENED);
        } else {
            $newFaqObj->setVar('status', Constants::SF_STATUS_ASKED);
        }

        // Storing the FAQ object in the database
        if (!$newFaqObj->store()) {
            redirect_header('javascript:history.go(-1)', 3, _MD_SF_REQUEST_ERROR . Smartfaq\Utility::formatErrors($newFaqObj->getErrors()));
        }

        // Get the cateopry object related to that FAQ
        // If autoapprove_requested
        if (1 == $xoopsModuleConfig['autoapprove_request']) {
            // We do not not subscribe user to notification on publish since we publish it right away

            // Send notifications
            $newFaqObj->sendNotifications([Constants::SF_NOT_QUESTION_PUBLISHED]);

            $redirect_msg = _MD_SF_REQUEST_RECEIVED_AND_PUBLISHED;
        } else {

            // Subscribe the user to On Published notification, if requested
            if (1 == $notifypub) {
                require_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
                $notificationHandler = xoops_getHandler('notification');
                $notificationHandler->subscribe('question', $newFaqObj->faqid(), 'approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
            }
            // Send notifications
            $newFaqObj->sendNotifications([Constants::SF_NOT_QUESTION_SUBMITTED]);

            $redirect_msg = _MD_SF_REQUEST_RECEIVED_NEED_APPROVAL;
        }

        //redirect_header("javascript:history.go(-2)", 3, $redirect_msg);

        redirect_header('index.php', 2, $redirect_msg);
        break;

    case 'form':
    default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

        global $xoopsUser, $myts;
function myFunction($a, $b) {
    // Do something
}

        $GLOBALS['xoopsOption']['template_main'] = 'smartfaq_submit.tpl';
        require_once XOOPS_ROOT_PATH . '/header.php';
        require_once __DIR__ . '/footer.php';

        $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';


        $moduleName =& $myts->displayTarea($xoopsModule->getVar('name'));
        $xoopsTpl->assign('whereInSection', $moduleName);
        $xoopsTpl->assign('lang_submit', _MD_SF_REQUEST);

        $xoopsTpl->assign('lang_intro_title', _MD_SF_REQUEST);
        $xoopsTpl->assign('lang_intro_text', _MD_SF_GOODDAY . "<b>$name</b>, " . $myts->displayTarea($xoopsModuleConfig['requestintromsg']));

        require_once __DIR__ . '/include/request.inc.php';

        $name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';


        $sectionname = $myts->htmlSpecialChars($xoopsModule->getVar('name'));

        require_once __DIR__ . '/include/request.inc.php';

        require_once XOOPS_ROOT_PATH . '/footer.php';

        break;
}


1		<?php
2
3		/**
4		* Module: SmartFAQ
5		* Author: The SmartFactory <www.smartfactory.ca>
6		* Licence: GNU
7		*/
8
9		use XoopsModules\Smartfaq;
10		use XoopsModules\Smartfaq\Constants;
11
12		require_once __DIR__ . '/header.php';
13		require_once XOOPS_ROOT_PATH . '/header.php';
14
15		global $xoopsUser, $xoopsConfig, $xoopsModuleConfig, $xoopsModule;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
16
17		// Creating the category handler object
18		/** @var \XoopsModules\Smartfaq\CategoryHandler $categoryHandler */
19		$categoryHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Category');
20
21		// Creating the FAQ handler object
22		/** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
23		$faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
24
25		// Get the total number of categories
26		$totalCategories = count($categoryHandler->getCategories());
27
28		if (0 == $totalCategories) {
29		redirect_header('index.php', 1, _AM_SF_NOCOLEXISTS);
30		}
31
32		// Find if the user is admin of the module
33		$isAdmin = Smartfaq\Utility::userIsAdmin();
34		// If the user is not admin AND we don't allow user submission, exit
35	View Code Duplication	if (!($isAdmin
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		\|\| (isset($xoopsModuleConfig['allowrequest'])
37		&& 1 == $xoopsModuleConfig['allowrequest']
38		&& (is_object($xoopsUser) \|\| (isset($xoopsModuleConfig['anonpost']) && 1 == $xoopsModuleConfig['anonpost']))))) {
39		redirect_header('index.php', 1, _NOPERM);
40		}
41
42		$op = '';
43
44		if (isset($_GET['op'])) {
45		$op = $_GET['op'];
46		}
47		if (isset($_POST['op'])) {
48		$op = $_POST['op'];
49		}
50
51		switch ($op) {
52		case 'post':
		0 ignored issues – show Coding Style introduced 2016-03-30 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
53
54		global $xoopsUser, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
55
56		$newFaqObj = $faqHandler->create();
57
58	View Code Duplication	if (!$xoopsUser) {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		if (1 == $xoopsModuleConfig['anonpost']) {
60		$uid = 0;
61		} else {
62		redirect_header('index.php', 3, _NOPERM);
63		}
64		} else {
65		$uid = $xoopsUser->uid();
		0 ignored issues – show Bug introduced 2016-01-18 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `uid` cannot be called on `$xoopsUser` (of type `integer\|double\|string\|array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
66		}
67
68		// Putting the values about the FAQ in the FAQ object
69		$newFaqObj->setVar('categoryid', $_POST['categoryid']);
70		$newFaqObj->setVar('uid', $uid);
71		$newFaqObj->setVar('question', $_POST['question']);
72		$notifypub = isset($_POST['notifypub']) ? $_POST['notifypub'] : 0;
73		$newFaqObj->setVar('notifypub', $notifypub);
74
75		// Setting the status of the FAQ
76		if (1 == $xoopsModuleConfig['autoapprove_request']) {
77		$newFaqObj->setVar('status', Constants::SF_STATUS_OPENED);
78		} else {
79		$newFaqObj->setVar('status', Constants::SF_STATUS_ASKED);
80		}
81
82		// Storing the FAQ object in the database
83		if (!$newFaqObj->store()) {
84		redirect_header('javascript:history.go(-1)', 3, _MD_SF_REQUEST_ERROR . Smartfaq\Utility::formatErrors($newFaqObj->getErrors()));
85		}
86
87		// Get the cateopry object related to that FAQ
88		// If autoapprove_requested
89		if (1 == $xoopsModuleConfig['autoapprove_request']) {
90		// We do not not subscribe user to notification on publish since we publish it right away
91
92		// Send notifications
93		$newFaqObj->sendNotifications([Constants::SF_NOT_QUESTION_PUBLISHED]);
94
95		$redirect_msg = _MD_SF_REQUEST_RECEIVED_AND_PUBLISHED;
96	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97		// Subscribe the user to On Published notification, if requested
98		if (1 == $notifypub) {
99		require_once XOOPS_ROOT_PATH . '/include/notification_constants.php';
100		$notificationHandler = xoops_getHandler('notification');
101		$notificationHandler->subscribe('question', $newFaqObj->faqid(), 'approved', XOOPS_NOTIFICATION_MODE_SENDONCETHENDELETE);
102		}
103		// Send notifications
104		$newFaqObj->sendNotifications([Constants::SF_NOT_QUESTION_SUBMITTED]);
105
106		$redirect_msg = _MD_SF_REQUEST_RECEIVED_NEED_APPROVAL;
107		}
108
109		//redirect_header("javascript:history.go(-2)", 3, $redirect_msg);
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-30 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
110		redirect_header('index.php', 2, $redirect_msg);
111		break;
112
113		case 'form':
114		default:
		0 ignored issues – show Coding Style introduced 2016-03-30 08:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
115
116		global $xoopsUser, $myts;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
117
118		$GLOBALS['xoopsOption']['template_main'] = 'smartfaq_submit.tpl';
119		require_once XOOPS_ROOT_PATH . '/header.php';
120		require_once __DIR__ . '/footer.php';
121
122		$name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
		0 ignored issues – show Bug introduced 2017-02-26 23:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getVar` cannot be called on `$xoopsUser` (of type `integer\|double\|string\|array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
123
124		$moduleName =& $myts->displayTarea($xoopsModule->getVar('name'));
125		$xoopsTpl->assign('whereInSection', $moduleName);
126		$xoopsTpl->assign('lang_submit', _MD_SF_REQUEST);
127
128		$xoopsTpl->assign('lang_intro_title', _MD_SF_REQUEST);
129		$xoopsTpl->assign('lang_intro_text', _MD_SF_GOODDAY . "<b>$name</b>, " . $myts->displayTarea($xoopsModuleConfig['requestintromsg']));
130
131		require_once __DIR__ . '/include/request.inc.php';
132
133		$name = $xoopsUser ? ucwords($xoopsUser->getVar('uname')) : 'Anonymous';
		0 ignored issues – show Bug introduced 2017-02-26 23:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getVar` cannot be called on `$xoopsUser` (of type `integer\|double\|string\|array\|boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
134
135		$sectionname = $myts->htmlSpecialChars($xoopsModule->getVar('name'));
136
137		require_once __DIR__ . '/include/request.inc.php';
138
139		require_once XOOPS_ROOT_PATH . '/footer.php';
140
141		break;
142		}
143

mambax7 / smartfaq

Push — master ( 454ebd...de22fe )

request.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like