FilesManagement - Code Metrics - Inspection of "1.20 Beta 1" - mambax7/smartfaq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 454ebd...de22fe )

by Michael

created 2018-03-13 20:39 UTC

FilesManagement C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	228
Duplicated Lines	25.88 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	59
loc	228
rs	6.8539
c	0
b	0
f	0
wmc	54
lcom	0
cbo	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	createFolder()	0	14	6
A	copyFile()	0	4	1
B	recurseCopy()	0	17	7
D	deleteDirectory()	0	37	9
D	rrmdir()	0	31	9
C	rmove()	31	31	11
C	rcopy()	28	28	11

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like FilesManagement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use FilesManagement, and based on these observations, apply Extract Interface, too.

<?php namespace XoopsModules\Smartfaq\Common;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright   XOOPS Project (https://xoops.org)
 * @license     http://www.fsf.org/copyleft/gpl.html GNU public license
 * @author      mamba <[email protected]>
 */
trait FilesManagement
{
    /**
     * Function responsible for checking if a directory exists, we can also write in and create an index.html file
     *
     * @param string $folder The full path of the directory to check
     *
     * @return void
     * @throws \RuntimeException
     */
    public static function createFolder($folder)
    {
        try {
            if (!file_exists($folder)) {
                if (!is_dir($folder) && !mkdir($folder) && !is_dir($folder)) {
                    throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
                }

                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
            }
        } catch (\Exception $e) {
            echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
        }
    }

    /**
     * @param $file
     * @param $folder
     * @return bool
     */
    public static function copyFile($file, $folder)
    {
        return copy($file, $folder);
    }

    /**
     * @param $src
     * @param $dst
     */
    public static function recurseCopy($src, $dst)
    {
        $dir = opendir($src);
        //        @mkdir($dst);
        if (!mkdir($dst) && !is_dir($dst)) {
            while (false !== ($file = readdir($dir))) {
                if (('.' !== $file) && ('..' !== $file)) {
                    if (is_dir($src . '/' . $file)) {
                        self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
                    } else {
                        copy($src . '/' . $file, $dst . '/' . $file);
                    }
                }
            }
        }
        closedir($dir);
    }

    /**
     *
     * Remove files and (sub)directories
     *
     * @param string $src source directory to delete
     *
     * @uses \Xmf\Module\Helper::getHelper()
     * @uses \Xmf\Module\Helper::isUserAdmin()
     *
     * @return bool true on success
     */
    public static function deleteDirectory($src)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Only continue if user is a 'global' Admin
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return false;
        }

        $success = true;
        // remove old files
        $dirInfo = new \SplFileInfo($src);
        // validate is a directory
        if ($dirInfo->isDir()) {
            $fileList = array_diff(scandir($src, SCANDIR_SORT_NONE), ['..', '.']);
            foreach ($fileList as $k => $v) {
                $fileInfo = new \SplFileInfo("{$src}/{$v}");
                if ($fileInfo->isDir()) {
                    // recursively handle subdirectories
                    if (!$success = self::deleteDirectory($fileInfo->getRealPath())) {
                        break;
                    }
                } else {
                    // delete the file
                    if (!($success = unlink($fileInfo->getRealPath()))) {
                        break;
                    }
                }
            }
            // now delete this (sub)directory if all the files are gone
            if ($success) {
                $success = rmdir($dirInfo->getRealPath());
            }
        } else {
            // input is not a valid directory
            $success = false;
        }
        return $success;
    }

    /**
     *
     * Recursively remove directory
     *
     * @todo currently won't remove directories with hidden files, should it?
     *
     * @param string $src directory to remove (delete)
     *
     * @return bool true on success
     */
    public static function rrmdir($src)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Only continue if user is a 'global' Admin
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return false;
        }

        // If source is not a directory stop processing
        if (!is_dir($src)) {
            return false;
        }

        $success = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // Open the source directory to read in files
        $iterator = new \DirectoryIterator($src);
        foreach ($iterator as $fObj) {
            if ($fObj->isFile()) {
                $filename = $fObj->getPathname();
                $fObj     = null; // clear this iterator object to close the file
                if (!unlink($filename)) {
                    return false; // couldn't delete the file
                }
            } elseif (!$fObj->isDot() && $fObj->isDir()) {
                // Try recursively on directory
                self::rrmdir($fObj->getPathname());
            }
        }
        $iterator = null;   // clear iterator Obj to close file/directory
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return rmdir($src); // remove the directory & return results
    }

    /**
     * Recursively move files from one directory to another
     *
     * @param string $src  - Source of files being moved
     * @param string $dest - Destination of files being moved
     *
     * @return bool true on success
     */
    public static function rmove($src, $dest)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Only continue if user is a 'global' Admin
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return false;
        }

        // If source is not a directory stop processing
        if (!is_dir($src)) {
            return false;
        }

        // If the destination directory does not exist and could not be created stop processing
        if (!is_dir($dest) && !mkdir($dest) && !is_dir($dest)) {
            return false;
        }

        // Open the source directory to read in files
        $iterator = new \DirectoryIterator($src);
        foreach ($iterator as $fObj) {
            if ($fObj->isFile()) {
                rename($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
            } elseif (!$fObj->isDot() && $fObj->isDir()) {
                // Try recursively on directory
                self::rmove($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
                //                rmdir($fObj->getPath()); // now delete the directory

            }
        }
        $iterator = null;   // clear iterator Obj to close file/directory
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return rmdir($src); // remove the directory & return results
    }

    /**
     * Recursively copy directories and files from one directory to another
     *
     * @param string $src  - Source of files being moved
     * @param string $dest - Destination of files being moved
     *
     * @uses \Xmf\Module\Helper::getHelper()
     * @uses \Xmf\Module\Helper::isUserAdmin()
     *
     * @return bool true on success
     */
    public static function rcopy($src, $dest)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // Only continue if user is a 'global' Admin
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return false;
        }

        // If source is not a directory stop processing
        if (!is_dir($src)) {
            return false;
        }

        // If the destination directory does not exist and could not be created stop processing
        if (!is_dir($dest) && !mkdir($dest) && !is_dir($dest)) {
            return false;
        }

        // Open the source directory to read in files
        $iterator = new \DirectoryIterator($src);
        foreach ($iterator as $fObj) {
            if ($fObj->isFile()) {
                copy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
            } elseif (!$fObj->isDot() && $fObj->isDir()) {
                self::rcopy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
            }
        }
        return true;
    }
}


Push — master ( 454ebd...de22fe )

FilesManagement C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1		<?php namespace XoopsModules\Smartfaq\Common;
2
3		/*
4		You may not change or alter any portion of this comment or credits
5		of supporting developers from this source code or any supporting source code
6		which is considered copyrighted (c) material of the original comment or credit authors.
7
8		This program is distributed in the hope that it will be useful,
9		but WITHOUT ANY WARRANTY; without even the implied warranty of
10		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11		*/
12
13		/**
14		* @copyright XOOPS Project (https://xoops.org)
15		* @license http://www.fsf.org/copyleft/gpl.html GNU public license
16		* @author mamba <[email protected]>
17		*/
18		trait FilesManagement
19		{
20		/**
21		* Function responsible for checking if a directory exists, we can also write in and create an index.html file
22		*
23		* @param string $folder The full path of the directory to check
24		*
25		* @return void
26		* @throws \RuntimeException
27		*/
28		public static function createFolder($folder)
29		{
30		try {
31		if (!file_exists($folder)) {
32		if (!is_dir($folder) && !mkdir($folder) && !is_dir($folder)) {
33		throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
34		}
35
36		file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
37		}
38		} catch (\Exception $e) {
39		echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
40		}
41		}
42
43		/**
44		* @param $file
45		* @param $folder
46		* @return bool
47		*/
48		public static function copyFile($file, $folder)
49		{
50		return copy($file, $folder);
51		}
52
53		/**
54		* @param $src
55		* @param $dst
56		*/
57		public static function recurseCopy($src, $dst)
58		{
59		$dir = opendir($src);
60		// @mkdir($dst);
61		if (!mkdir($dst) && !is_dir($dst)) {
62		while (false !== ($file = readdir($dir))) {
63		if (('.' !== $file) && ('..' !== $file)) {
64		if (is_dir($src . '/' . $file)) {
65		self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
66		} else {
67		copy($src . '/' . $file, $dst . '/' . $file);
68		}
69		}
70		}
71		}
72		closedir($dir);
73		}
74
75		/**
76		*
77		* Remove files and (sub)directories
78		*
79		* @param string $src source directory to delete
80		*
81		* @uses \Xmf\Module\Helper::getHelper()
82		* @uses \Xmf\Module\Helper::isUserAdmin()
83		*
84		* @return bool true on success
85		*/
86		public static function deleteDirectory($src)
		0 ignored issues – show Coding Style introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `deleteDirectory` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
87		{
88		// Only continue if user is a 'global' Admin
89		if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) \|\| !$GLOBALS['xoopsUser']->isAdmin()) {
		0 ignored issues – show Bug introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
90		return false;
91		}
92
93		$success = true;
94		// remove old files
95		$dirInfo = new \SplFileInfo($src);
96		// validate is a directory
97		if ($dirInfo->isDir()) {
98		$fileList = array_diff(scandir($src, SCANDIR_SORT_NONE), ['..', '.']);
99		foreach ($fileList as $k => $v) {
100		$fileInfo = new \SplFileInfo("{$src}/{$v}");
101		if ($fileInfo->isDir()) {
102		// recursively handle subdirectories
103		if (!$success = self::deleteDirectory($fileInfo->getRealPath())) {
104		break;
105		}
106		} else {
107		// delete the file
108		if (!($success = unlink($fileInfo->getRealPath()))) {
109		break;
110		}
111		}
112		}
113		// now delete this (sub)directory if all the files are gone
114		if ($success) {
115		$success = rmdir($dirInfo->getRealPath());
116		}
117		} else {
118		// input is not a valid directory
119		$success = false;
120		}
121		return $success;
122		}
123
124		/**
125		*
126		* Recursively remove directory
127		*
128		* @todo currently won't remove directories with hidden files, should it?
129		*
130		* @param string $src directory to remove (delete)
131		*
132		* @return bool true on success
133		*/
134		public static function rrmdir($src)
		0 ignored issues – show Coding Style introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `rrmdir` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
135		{
136		// Only continue if user is a 'global' Admin
137		if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) \|\| !$GLOBALS['xoopsUser']->isAdmin()) {
		0 ignored issues – show Bug introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
138		return false;
139		}
140
141		// If source is not a directory stop processing
142		if (!is_dir($src)) {
143		return false;
144		}
145
146		$success = true;
		0 ignored issues – show Unused Code introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `$success` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
147
148		// Open the source directory to read in files
149		$iterator = new \DirectoryIterator($src);
150		foreach ($iterator as $fObj) {
151		if ($fObj->isFile()) {
152		$filename = $fObj->getPathname();
153		$fObj = null; // clear this iterator object to close the file
154		if (!unlink($filename)) {
155		return false; // couldn't delete the file
156		}
157		} elseif (!$fObj->isDot() && $fObj->isDir()) {
158		// Try recursively on directory
159		self::rrmdir($fObj->getPathname());
160		}
161		}
162		$iterator = null; // clear iterator Obj to close file/directory
		0 ignored issues – show Unused Code introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `$iterator` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
163		return rmdir($src); // remove the directory & return results
164		}
165
166		/**
167		* Recursively move files from one directory to another
168		*
169		* @param string $src - Source of files being moved
170		* @param string $dest - Destination of files being moved
171		*
172		* @return bool true on success
173		*/
174	View Code Duplication	public static function rmove($src, $dest)
		0 ignored issues – show Duplication introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `rmove` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
175		{
176		// Only continue if user is a 'global' Admin
177		if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) \|\| !$GLOBALS['xoopsUser']->isAdmin()) {
		0 ignored issues – show Bug introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
178		return false;
179		}
180
181		// If source is not a directory stop processing
182		if (!is_dir($src)) {
183		return false;
184		}
185
186		// If the destination directory does not exist and could not be created stop processing
187		if (!is_dir($dest) && !mkdir($dest) && !is_dir($dest)) {
188		return false;
189		}
190
191		// Open the source directory to read in files
192		$iterator = new \DirectoryIterator($src);
193		foreach ($iterator as $fObj) {
194		if ($fObj->isFile()) {
195		rename($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
196		} elseif (!$fObj->isDot() && $fObj->isDir()) {
197		// Try recursively on directory
198		self::rmove($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
199		// rmdir($fObj->getPath()); // now delete the directory
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
200		}
201		}
202		$iterator = null; // clear iterator Obj to close file/directory
		0 ignored issues – show Unused Code introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `$iterator` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
203		return rmdir($src); // remove the directory & return results
204		}
205
206		/**
207		* Recursively copy directories and files from one directory to another
208		*
209		* @param string $src - Source of files being moved
210		* @param string $dest - Destination of files being moved
211		*
212		* @uses \Xmf\Module\Helper::getHelper()
213		* @uses \Xmf\Module\Helper::isUserAdmin()
214		*
215		* @return bool true on success
216		*/
217	View Code Duplication	public static function rcopy($src, $dest)
		0 ignored issues – show Duplication introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report `rcopy` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
218		{
219		// Only continue if user is a 'global' Admin
220		if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) \|\| !$GLOBALS['xoopsUser']->isAdmin()) {
		0 ignored issues – show Bug introduced 2018-03-13 20:42 UTC by Report Bug Copy Issue Report The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
221		return false;
222		}
223
224		// If source is not a directory stop processing
225		if (!is_dir($src)) {
226		return false;
227		}
228
229		// If the destination directory does not exist and could not be created stop processing
230		if (!is_dir($dest) && !mkdir($dest) && !is_dir($dest)) {
231		return false;
232		}
233
234		// Open the source directory to read in files
235		$iterator = new \DirectoryIterator($src);
236		foreach ($iterator as $fObj) {
237		if ($fObj->isFile()) {
238		copy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
239		} elseif (!$fObj->isDot() && $fObj->isDir()) {
240		self::rcopy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
241		}
242		}
243		return true;
244		}
245		}
246

mambax7 / smartfaq

Push — master ( 454ebd...de22fe )

FilesManagement C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like