mambax7 / smartfaq

include/comment_functions.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 function smartfaq_com_update($faq_id, $total_num)
 {
     $db  = \XoopsDatabaseFactory::getDatabaseConnection();
-    $sql = 'UPDATE ' . $db->prefix('smartfaq_faq') . ' SET comments = ' . $total_num . ' WHERE faqid = ' . $faq_id;
+    $sql = 'UPDATE '.$db->prefix('smartfaq_faq').' SET comments = '.$total_num.' WHERE faqid = '.$faq_id;
     $db->query($sql);
 }
 

include/common.php

Spacing +27 added lines, -27 removed lines

@@ -20,10 +20,10 @@ 
 
 use XoopsModules\Smartfaq;
 
-include __DIR__ . '/../preloads/autoloader.php';
+include __DIR__.'/../preloads/autoloader.php';
 
 $moduleDirName = basename(dirname(__DIR__));
-$moduleDirNameUpper   = strtoupper($moduleDirName); //$capsDirName
+$moduleDirNameUpper = strtoupper($moduleDirName); //$capsDirName
 
 
 /** @var \XoopsDatabase $db */
@@ -40,20 +40,20 @@ 
 //$categoryHandler     = new Smartfaq\CategoryHandler($db);
 //$downloadHandler     = new Smartfaq\DownloadHandler($db);
 
-if (!defined($moduleDirNameUpper . '_CONSTANTS_DEFINED')) {
-    define($moduleDirNameUpper . '_DIRNAME', basename(dirname(__DIR__)));
-    define($moduleDirNameUpper . '_ROOT_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
-    define($moduleDirNameUpper . '_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
-    define($moduleDirNameUpper . '_URL', XOOPS_URL . '/modules/' . $moduleDirName . '/');
-    define($moduleDirNameUpper . '_IMAGE_URL', constant($moduleDirNameUpper . '_URL') . '/assets/images/');
-    define($moduleDirNameUpper . '_IMAGE_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/assets/images');
-    define($moduleDirNameUpper . '_ADMIN_URL', constant($moduleDirNameUpper . '_URL') . '/admin/');
-    define($moduleDirNameUpper . '_ADMIN_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/admin/');
-    define($moduleDirNameUpper . '_ADMIN', constant($moduleDirNameUpper . '_URL') . '/admin/index.php');
-    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', constant($moduleDirNameUpper . '_URL') . '/assets/images/logoModule.png');
-    define($moduleDirNameUpper . '_UPLOAD_URL', XOOPS_UPLOAD_URL . '/' . $moduleDirName); // WITHOUT Trailing slash
-    define($moduleDirNameUpper . '_UPLOAD_PATH', XOOPS_UPLOAD_PATH . '/' . $moduleDirName); // WITHOUT Trailing slash
-    define($moduleDirNameUpper . '_CONSTANTS_DEFINED', 1);
+if (!defined($moduleDirNameUpper.'_CONSTANTS_DEFINED')) {
+    define($moduleDirNameUpper.'_DIRNAME', basename(dirname(__DIR__)));
+    define($moduleDirNameUpper.'_ROOT_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
+    define($moduleDirNameUpper.'_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
+    define($moduleDirNameUpper.'_URL', XOOPS_URL.'/modules/'.$moduleDirName.'/');
+    define($moduleDirNameUpper.'_IMAGE_URL', constant($moduleDirNameUpper.'_URL').'/assets/images/');
+    define($moduleDirNameUpper.'_IMAGE_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/assets/images');
+    define($moduleDirNameUpper.'_ADMIN_URL', constant($moduleDirNameUpper.'_URL').'/admin/');
+    define($moduleDirNameUpper.'_ADMIN_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/admin/');
+    define($moduleDirNameUpper.'_ADMIN', constant($moduleDirNameUpper.'_URL').'/admin/index.php');
+    define($moduleDirNameUpper.'_AUTHOR_LOGOIMG', constant($moduleDirNameUpper.'_URL').'/assets/images/logoModule.png');
+    define($moduleDirNameUpper.'_UPLOAD_URL', XOOPS_UPLOAD_URL.'/'.$moduleDirName); // WITHOUT Trailing slash
+    define($moduleDirNameUpper.'_UPLOAD_PATH', XOOPS_UPLOAD_PATH.'/'.$moduleDirName); // WITHOUT Trailing slash
+    define($moduleDirNameUpper.'_CONSTANTS_DEFINED', 1);
 }
 
 
@@ -63,15 +63,15 @@ 
 //$pathModIcon32 = $helper->getModule()->getInfo('modicons32');
 
 $icons = [
-    'edit'    => "<img src='" . $pathIcon16 . "/edit.png'  alt=" . _EDIT . "' align='middle'>",
-    'delete'  => "<img src='" . $pathIcon16 . "/delete.png' alt='" . _DELETE . "' align='middle'>",
-    'clone'   => "<img src='" . $pathIcon16 . "/editcopy.png' alt='" . _CLONE . "' align='middle'>",
-    'preview' => "<img src='" . $pathIcon16 . "/view.png' alt='" . _PREVIEW . "' align='middle'>",
-    'print'   => "<img src='" . $pathIcon16 . "/printer.png' alt='" . _CLONE . "' align='middle'>",
-    'pdf'     => "<img src='" . $pathIcon16 . "/pdf.png' alt='" . _CLONE . "' align='middle'>",
-    'add'     => "<img src='" . $pathIcon16 . "/add.png' alt='" . _ADD . "' align='middle'>",
-    '0'       => "<img src='" . $pathIcon16 . "/0.png' alt='" . 0 . "' align='middle'>",
-    '1'       => "<img src='" . $pathIcon16 . "/1.png' alt='" . 1 . "' align='middle'>",
+    'edit'    => "<img src='".$pathIcon16."/edit.png'  alt="._EDIT."' align='middle'>",
+    'delete'  => "<img src='".$pathIcon16."/delete.png' alt='"._DELETE."' align='middle'>",
+    'clone'   => "<img src='".$pathIcon16."/editcopy.png' alt='"._CLONE."' align='middle'>",
+    'preview' => "<img src='".$pathIcon16."/view.png' alt='"._PREVIEW."' align='middle'>",
+    'print'   => "<img src='".$pathIcon16."/printer.png' alt='"._CLONE."' align='middle'>",
+    'pdf'     => "<img src='".$pathIcon16."/pdf.png' alt='"._CLONE."' align='middle'>",
+    'add'     => "<img src='".$pathIcon16."/add.png' alt='"._ADD."' align='middle'>",
+    '0'       => "<img src='".$pathIcon16."/0.png' alt='".0."' align='middle'>",
+    '1'       => "<img src='".$pathIcon16."/1.png' alt='".1."' align='middle'>",
 ];
 
 $debug = false;
@@ -84,12 +84,12 @@ 
     $GLOBALS['xoopsTpl'] = new \XoopsTpl();
 }
 
-$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL . '/modules/' . $moduleDirName);
+$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL.'/modules/'.$moduleDirName);
 // Local icons path
 if (is_object($helper->getModule())) {
     $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
     $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
 
-    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
+    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL.'/modules/'.$moduleDirName.'/'.$pathModIcon16);
     $GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
 }

header.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
  * Licence: GNU
  */
 
-include __DIR__ . '/../../mainfile.php';
+include __DIR__.'/../../mainfile.php';
 
 //require_once XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php';
 //require_once XOOPS_ROOT_PATH . '/modules/smartfaq/class/category.php';

blocks/faqs_recent_questions.php

Spacing +10 added lines, -10 removed lines

@@ -38,7 +38,7 @@ 
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
 
     // creating the FAQ objects that belong to the selected category
-    $faqsObj   = $faqHandler->getFaqs($limit, 0, Constants::SF_STATUS_OPENED, $categoryid, $sort);
+    $faqsObj = $faqHandler->getFaqs($limit, 0, Constants::SF_STATUS_OPENED, $categoryid, $sort);
 
     if ($faqsObj) {
         foreach ($faqsObj as $iValue) {
@@ -72,40 +72,40 @@ 
 
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
 
-    $form .= '&nbsp;<br>' . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
+    $form .= '&nbsp;<br>'._MB_SF_ORDER."&nbsp;<select name='options[]'>";
 
     $form .= "<option value='datesub'";
     if ('datesub' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_DATE . "</option>\n";
+    $form .= '>'._MB_SF_DATE."</option>\n";
 
     $form .= "<option value='counter'";
     if ('counter' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_HITS . "</option>\n";
+    $form .= '>'._MB_SF_HITS."</option>\n";
 
     $form .= "<option value='weight'";
     if ('weight' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_WEIGHT . "</option>\n";
+    $form .= '>'._MB_SF_WEIGHT."</option>\n";
 
     $form .= "</select>\n";
 
-    $form .= '&nbsp;' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_QUESTIONS . '';
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "'>&nbsp;" . _MB_SF_LENGTH . '';
+    $form .= '&nbsp;'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_QUESTIONS.'';
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."'>&nbsp;"._MB_SF_LENGTH.'';
 
-    $form .= '<br>' . _MB_SF_SHOW_DATE . "&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
+    $form .= '<br>'._MB_SF_SHOW_DATE."&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
     if (1 == $options[4]) {
         $form .= ' checked';
     }
-    $form .= '>&nbsp;' . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
+    $form .= '>&nbsp;'._YES."<input type='radio' id='options[]' name='options[]' value='0'";
     if (0 == $options[4]) {
         $form .= ' checked';
     }
-    $form .= '>&nbsp;' . _NO . '';
+    $form .= '>&nbsp;'._NO.'';
 
     return $form;
 }

blocks/faqs_new.php

Spacing +10 added lines, -10 removed lines

@@ -36,7 +36,7 @@ 
     /** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
     // creating the FAQ objects that belong to the selected category
-    $faqsObj   = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
+    $faqsObj = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
 
     if ($faqsObj) {
         foreach ($faqsObj as $iValue) {
@@ -69,40 +69,40 @@ 
 
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
 
-    $form .= '&nbsp;<br>' . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
+    $form .= '&nbsp;<br>'._MB_SF_ORDER."&nbsp;<select name='options[]'>";
 
     $form .= "<option value='datesub'";
     if ('datesub' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_DATE . "</option>\n";
+    $form .= '>'._MB_SF_DATE."</option>\n";
 
     $form .= "<option value='counter'";
     if ('counter' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_HITS . "</option>\n";
+    $form .= '>'._MB_SF_HITS."</option>\n";
 
     $form .= "<option value='weight'";
     if ('weight' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_WEIGHT . "</option>\n";
+    $form .= '>'._MB_SF_WEIGHT."</option>\n";
 
     $form .= "</select>\n";
 
-    $form .= '&nbsp;' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_FAQS . '';
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "'>&nbsp;" . _MB_SF_LENGTH . '';
+    $form .= '&nbsp;'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_FAQS.'';
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."'>&nbsp;"._MB_SF_LENGTH.'';
 
-    $form .= '<br>' . _MB_SF_SHOW_DATE . "&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
+    $form .= '<br>'._MB_SF_SHOW_DATE."&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
     if (1 == $options[4]) {
         $form .= ' checked';
     }
-    $form .= '>&nbsp;' . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
+    $form .= '>&nbsp;'._YES."<input type='radio' id='options[]' name='options[]' value='0'";
     if (0 == $options[4]) {
         $form .= ' checked';
     }
-    $form .= '>&nbsp;' . _NO . '';
+    $form .= '>&nbsp;'._NO.'';
 
     return $form;
 }

blocks/faqs_most_viewed.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
     /** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
     // creating the FAQ objects that belong to the selected category
-    $faqsObj   = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
+    $faqsObj = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
 
     if ($faqsObj) {
         foreach ($faqsObj as $iValue) {
@@ -60,8 +60,8 @@ 
 
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
 
-    $form .= '&nbsp;<br>' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[1] . "'>&nbsp;" . _MB_SF_FAQS . '';
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_LENGTH . '';
+    $form .= '&nbsp;<br>'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[1]."'>&nbsp;"._MB_SF_FAQS.'';
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_LENGTH.'';
 
     return $form;
 }

blocks/faqs_recent.php

Spacing +8 added lines, -8 removed lines

@@ -62,7 +62,7 @@ 
         }
 
         $memberHandler = xoops_getHandler('member');
-        $users         = $memberHandler->getUsers(new \Criteria('uid', '(' . implode(',', array_keys($userids)) . ')', 'IN'), true);
+        $users         = $memberHandler->getUsers(new \Criteria('uid', '('.implode(',', array_keys($userids)).')', 'IN'), true);
         foreach ($faqsObj as $iValue) {
             $faqs['categoryid']   = $iValue->categoryid();
             $faqs['question']     = $iValue->question($maxQuestionLength);
@@ -84,7 +84,7 @@ 
         $block['lang_poster']   = _MB_SF_ANSWEREDBY;
         $block['lang_date']     = _MB_SF_DATE;
         $modulename             = $myts->htmlSpecialChars($smartModule->getVar('name'));
-        $block['lang_visitfaq'] = _MB_SF_VISITFAQ . ' ' . $modulename;
+        $block['lang_visitfaq'] = _MB_SF_VISITFAQ.' '.$modulename;
     }
 
     return $block;
@@ -100,30 +100,30 @@ 
 
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
 
-    $form .= '&nbsp;<br>' . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
+    $form .= '&nbsp;<br>'._MB_SF_ORDER."&nbsp;<select name='options[]'>";
 
     $form .= "<option value='datesub'";
     if ('datesub' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_DATE . "</option>\n";
+    $form .= '>'._MB_SF_DATE."</option>\n";
 
     $form .= "<option value='counter'";
     if ('counter' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_HITS . "</option>\n";
+    $form .= '>'._MB_SF_HITS."</option>\n";
 
     $form .= "<option value='weight'";
     if ('weight' === $options[1]) {
         $form .= ' selected';
     }
-    $form .= '>' . _MB_SF_WEIGHT . "</option>\n";
+    $form .= '>'._MB_SF_WEIGHT."</option>\n";
 
     $form .= "</select>\n";
 
-    $form .= '&nbsp;' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_FAQS . '';
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "'>&nbsp;" . _MB_SF_LENGTH . '';
+    $form .= '&nbsp;'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_FAQS.'';
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."'>&nbsp;"._MB_SF_LENGTH.'';
 
     return $form;
 }

blocks/faqs_context.php

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
 
     // creating the FAQ objects that belong to the selected category
-    $faqsObj   = $faqHandler->getContextualFaqs($limit);
+    $faqsObj = $faqHandler->getContextualFaqs($limit);
 
     if ($faqsObj) {
         foreach ($faqsObj as $iValue) {
@@ -48,8 +48,8 @@ 
  */
 function b_faqs_context_edit($options)
 {
-    $form = '' . _MB_SF_DISP . ' ';
-    $form .= "<input type='text' name='options[]' value='" . $options[0] . "'>&nbsp;" . _MB_SF_FAQS . '';
+    $form = ''._MB_SF_DISP.'&nbsp;';
+    $form .= "<input type='text' name='options[]' value='".$options[0]."'>&nbsp;"._MB_SF_FAQS.'';
 
     return $form;
 }

class/Category.php

Spacing +5 added lines, -5 removed lines

@@ -166,7 +166,7 @@ 
             $filename = 'open_category.php';
         }
         if ($withAllLink) {
-            $ret = "<a href='" . XOOPS_URL . '/modules/smartfaq/' . $filename . '?categoryid=' . $this->categoryid() . "'>" . $this->name() . '</a>';
+            $ret = "<a href='".XOOPS_URL.'/modules/smartfaq/'.$filename.'?categoryid='.$this->categoryid()."'>".$this->name().'</a>';
         } else {
             $ret = $this->name();
         }
@@ -179,7 +179,7 @@ 
                 exit;
             }
             $parentid = $parentObj->parentid();
-            $ret      = $parentObj->getCategoryPath(true, $open) . ' > ' . $ret;
+            $ret      = $parentObj->getCategoryPath(true, $open).' > '.$ret;
         }
 
         return $ret;
@@ -236,7 +236,7 @@ 
         $tags                  = [];
         $tags['MODULE_NAME']   = $myts->htmlSpecialChars($smartModule->getVar('name'));
         $tags['CATEGORY_NAME'] = $this->name();
-        $tags['CATEGORY_URL']  = XOOPS_URL . '/modules/' . $smartModule->getVar('dirname') . '/category.php?categoryid=' . $this->categoryid();
+        $tags['CATEGORY_URL']  = XOOPS_URL.'/modules/'.$smartModule->getVar('dirname').'/category.php?categoryid='.$this->categoryid();
 
         $notificationHandler = xoops_getHandler('notification');
         $notificationHandler->triggerEvent('global_faq', 0, 'category_created', $tags);
@@ -252,9 +252,9 @@ 
         $category['categoryid'] = $this->categoryid();
         $category['name']       = $this->name();
         if (false !== $open) {
-            $category['categorylink'] = "<a href='" . XOOPS_URL . '/modules/smartfaq/open_category.php?categoryid=' . $this->categoryid() . "'>" . $this->name() . '</a>';
+            $category['categorylink'] = "<a href='".XOOPS_URL.'/modules/smartfaq/open_category.php?categoryid='.$this->categoryid()."'>".$this->name().'</a>';
         } else {
-            $category['categorylink'] = "<a href='" . XOOPS_URL . '/modules/smartfaq/category.php?categoryid=' . $this->categoryid() . "'>" . $this->name() . '</a>';
+            $category['categorylink'] = "<a href='".XOOPS_URL.'/modules/smartfaq/category.php?categoryid='.$this->categoryid()."'>".$this->name().'</a>';
         }
         $category['total']       = $this->getVar('faqcount');
         $category['description'] = $this->description();