Passed
Push — master ( 2744eb...81ba93 )
by Michael
02:46
created
include/search.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
     for ($i = 0, $iMax = count($faqsObj); $i < $iMax; ++$i) {
28 28
         $ret[$i]['image'] = 'assets/images/smartfaq.gif';
29
-        $ret[$i]['link']  = 'faq.php?faqid=' . $faqsObj[$i]->faqid();
29
+        $ret[$i]['link']  = 'faq.php?faqid='.$faqsObj[$i]->faqid();
30 30
         $ret[$i]['title'] = $faqsObj[$i]->question(50);
31 31
         $ret[$i]['time']  = $faqsObj[$i]->getVar('datesub');
32 32
         $ret[$i]['uid']   = $faqsObj[$i]->uid();
Please login to merge, or discard this patch.
include/answer.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,9 +13,9 @@
 block discarded – undo
13 13
 
14 14
 global $_POST;
15 15
 
16
-require_once XOOPS_ROOT_PATH . '/class/xoopstree.php';
17
-require_once XOOPS_ROOT_PATH . '/class/xoopslists.php';
18
-require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
16
+require_once XOOPS_ROOT_PATH.'/class/xoopstree.php';
17
+require_once XOOPS_ROOT_PATH.'/class/xoopslists.php';
18
+require_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
19 19
 //require_once __DIR__ . '/functions.php';
20 20
 
21 21
 $mytree = new Smartfaq\Tree($xoopsDB->prefix('smartfaq_categories'), 'categoryid', 'parentid');
Please login to merge, or discard this patch.
include/onuninstall.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,10 +34,10 @@  discard block
 block discarded – undo
34 34
 //    return true;
35 35
 
36 36
     $moduleDirName = basename(dirname(__DIR__));
37
-    $xsitemapHelper      = \Xmf\Module\Helper::getHelper($moduleDirName);
37
+    $xsitemapHelper = \Xmf\Module\Helper::getHelper($moduleDirName);
38 38
 
39 39
     /** @var XoopsModules\Smartfaq\Utility $utilityClass */
40
-    $utilityClass     = ucfirst($moduleDirName) . 'Utility';
40
+    $utilityClass = ucfirst($moduleDirName).'Utility';
41 41
     if (!class_exists($utilityClass)) {
42 42
         xoops_load('utility', $moduleDirName);
43 43
     }
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         if ($dirInfo->isDir()) {
57 57
             // The directory exists so delete it
58 58
             if (false === $utilityClass::rrmdir($old_dir)) {
59
-                $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_DEL_PATH'), $old_dir));
59
+                $module->setErrors(sprintf(constant('CO_'.$moduleDirNameUpper.'_ERROR_BAD_DEL_PATH'), $old_dir));
60 60
                 $success = false;
61 61
             }
62 62
         }
Please login to merge, or discard this patch.
include/comment_functions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 function smartfaq_com_update($faq_id, $total_num)
12 12
 {
13 13
     $db  = \XoopsDatabaseFactory::getDatabaseConnection();
14
-    $sql = 'UPDATE ' . $db->prefix('smartfaq_faq') . ' SET comments = ' . $total_num . ' WHERE faqid = ' . $faq_id;
14
+    $sql = 'UPDATE '.$db->prefix('smartfaq_faq').' SET comments = '.$total_num.' WHERE faqid = '.$faq_id;
15 15
     $db->query($sql);
16 16
 }
17 17
 
Please login to merge, or discard this patch.
include/common.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -20,10 +20,10 @@  discard block
 block discarded – undo
20 20
 
21 21
 use XoopsModules\Smartfaq;
22 22
 
23
-include __DIR__ . '/../preloads/autoloader.php';
23
+include __DIR__.'/../preloads/autoloader.php';
24 24
 
25 25
 $moduleDirName = basename(dirname(__DIR__));
26
-$moduleDirNameUpper   = strtoupper($moduleDirName); //$capsDirName
26
+$moduleDirNameUpper = strtoupper($moduleDirName); //$capsDirName
27 27
 
28 28
 
29 29
 /** @var \XoopsDatabase $db */
@@ -40,20 +40,20 @@  discard block
 block discarded – undo
40 40
 //$categoryHandler     = new Smartfaq\CategoryHandler($db);
41 41
 //$downloadHandler     = new Smartfaq\DownloadHandler($db);
42 42
 
43
-if (!defined($moduleDirNameUpper . '_CONSTANTS_DEFINED')) {
44
-    define($moduleDirNameUpper . '_DIRNAME', basename(dirname(__DIR__)));
45
-    define($moduleDirNameUpper . '_ROOT_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
46
-    define($moduleDirNameUpper . '_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
47
-    define($moduleDirNameUpper . '_URL', XOOPS_URL . '/modules/' . $moduleDirName . '/');
48
-    define($moduleDirNameUpper . '_IMAGE_URL', constant($moduleDirNameUpper . '_URL') . '/assets/images/');
49
-    define($moduleDirNameUpper . '_IMAGE_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/assets/images');
50
-    define($moduleDirNameUpper . '_ADMIN_URL', constant($moduleDirNameUpper . '_URL') . '/admin/');
51
-    define($moduleDirNameUpper . '_ADMIN_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/admin/');
52
-    define($moduleDirNameUpper . '_ADMIN', constant($moduleDirNameUpper . '_URL') . '/admin/index.php');
53
-    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', constant($moduleDirNameUpper . '_URL') . '/assets/images/logoModule.png');
54
-    define($moduleDirNameUpper . '_UPLOAD_URL', XOOPS_UPLOAD_URL . '/' . $moduleDirName); // WITHOUT Trailing slash
55
-    define($moduleDirNameUpper . '_UPLOAD_PATH', XOOPS_UPLOAD_PATH . '/' . $moduleDirName); // WITHOUT Trailing slash
56
-    define($moduleDirNameUpper . '_CONSTANTS_DEFINED', 1);
43
+if (!defined($moduleDirNameUpper.'_CONSTANTS_DEFINED')) {
44
+    define($moduleDirNameUpper.'_DIRNAME', basename(dirname(__DIR__)));
45
+    define($moduleDirNameUpper.'_ROOT_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
46
+    define($moduleDirNameUpper.'_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
47
+    define($moduleDirNameUpper.'_URL', XOOPS_URL.'/modules/'.$moduleDirName.'/');
48
+    define($moduleDirNameUpper.'_IMAGE_URL', constant($moduleDirNameUpper.'_URL').'/assets/images/');
49
+    define($moduleDirNameUpper.'_IMAGE_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/assets/images');
50
+    define($moduleDirNameUpper.'_ADMIN_URL', constant($moduleDirNameUpper.'_URL').'/admin/');
51
+    define($moduleDirNameUpper.'_ADMIN_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/admin/');
52
+    define($moduleDirNameUpper.'_ADMIN', constant($moduleDirNameUpper.'_URL').'/admin/index.php');
53
+    define($moduleDirNameUpper.'_AUTHOR_LOGOIMG', constant($moduleDirNameUpper.'_URL').'/assets/images/logoModule.png');
54
+    define($moduleDirNameUpper.'_UPLOAD_URL', XOOPS_UPLOAD_URL.'/'.$moduleDirName); // WITHOUT Trailing slash
55
+    define($moduleDirNameUpper.'_UPLOAD_PATH', XOOPS_UPLOAD_PATH.'/'.$moduleDirName); // WITHOUT Trailing slash
56
+    define($moduleDirNameUpper.'_CONSTANTS_DEFINED', 1);
57 57
 }
58 58
 
59 59
 
@@ -63,15 +63,15 @@  discard block
 block discarded – undo
63 63
 //$pathModIcon32 = $helper->getModule()->getInfo('modicons32');
64 64
 
65 65
 $icons = [
66
-    'edit'    => "<img src='" . $pathIcon16 . "/edit.png'  alt=" . _EDIT . "' align='middle'>",
67
-    'delete'  => "<img src='" . $pathIcon16 . "/delete.png' alt='" . _DELETE . "' align='middle'>",
68
-    'clone'   => "<img src='" . $pathIcon16 . "/editcopy.png' alt='" . _CLONE . "' align='middle'>",
69
-    'preview' => "<img src='" . $pathIcon16 . "/view.png' alt='" . _PREVIEW . "' align='middle'>",
70
-    'print'   => "<img src='" . $pathIcon16 . "/printer.png' alt='" . _CLONE . "' align='middle'>",
71
-    'pdf'     => "<img src='" . $pathIcon16 . "/pdf.png' alt='" . _CLONE . "' align='middle'>",
72
-    'add'     => "<img src='" . $pathIcon16 . "/add.png' alt='" . _ADD . "' align='middle'>",
73
-    '0'       => "<img src='" . $pathIcon16 . "/0.png' alt='" . 0 . "' align='middle'>",
74
-    '1'       => "<img src='" . $pathIcon16 . "/1.png' alt='" . 1 . "' align='middle'>",
66
+    'edit'    => "<img src='".$pathIcon16."/edit.png'  alt="._EDIT."' align='middle'>",
67
+    'delete'  => "<img src='".$pathIcon16."/delete.png' alt='"._DELETE."' align='middle'>",
68
+    'clone'   => "<img src='".$pathIcon16."/editcopy.png' alt='"._CLONE."' align='middle'>",
69
+    'preview' => "<img src='".$pathIcon16."/view.png' alt='"._PREVIEW."' align='middle'>",
70
+    'print'   => "<img src='".$pathIcon16."/printer.png' alt='"._CLONE."' align='middle'>",
71
+    'pdf'     => "<img src='".$pathIcon16."/pdf.png' alt='"._CLONE."' align='middle'>",
72
+    'add'     => "<img src='".$pathIcon16."/add.png' alt='"._ADD."' align='middle'>",
73
+    '0'       => "<img src='".$pathIcon16."/0.png' alt='".0."' align='middle'>",
74
+    '1'       => "<img src='".$pathIcon16."/1.png' alt='".1."' align='middle'>",
75 75
 ];
76 76
 
77 77
 $debug = false;
@@ -84,12 +84,12 @@  discard block
 block discarded – undo
84 84
     $GLOBALS['xoopsTpl'] = new \XoopsTpl();
85 85
 }
86 86
 
87
-$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL . '/modules/' . $moduleDirName);
87
+$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL.'/modules/'.$moduleDirName);
88 88
 // Local icons path
89 89
 if (is_object($helper->getModule())) {
90 90
     $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
91 91
     $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
92 92
 
93
-    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
93
+    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL.'/modules/'.$moduleDirName.'/'.$pathModIcon16);
94 94
     $GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
95 95
 }
Please login to merge, or discard this patch.
header.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
  * Licence: GNU
7 7
  */
8 8
 
9
-include __DIR__ . '/../../mainfile.php';
9
+include __DIR__.'/../../mainfile.php';
10 10
 
11 11
 //require_once XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php';
12 12
 //require_once XOOPS_ROOT_PATH . '/modules/smartfaq/class/category.php';
Please login to merge, or discard this patch.
blocks/faqs_recent_questions.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
39 39
 
40 40
     // creating the FAQ objects that belong to the selected category
41
-    $faqsObj   = $faqHandler->getFaqs($limit, 0, Constants::SF_STATUS_OPENED, $categoryid, $sort);
41
+    $faqsObj = $faqHandler->getFaqs($limit, 0, Constants::SF_STATUS_OPENED, $categoryid, $sort);
42 42
 
43 43
     if ($faqsObj) {
44 44
         foreach ($faqsObj as $iValue) {
@@ -72,40 +72,40 @@  discard block
 block discarded – undo
72 72
 
73 73
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
74 74
 
75
-    $form .= '&nbsp;<br>' . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
75
+    $form .= '&nbsp;<br>'._MB_SF_ORDER."&nbsp;<select name='options[]'>";
76 76
 
77 77
     $form .= "<option value='datesub'";
78 78
     if ('datesub' === $options[1]) {
79 79
         $form .= ' selected';
80 80
     }
81
-    $form .= '>' . _MB_SF_DATE . "</option>\n";
81
+    $form .= '>'._MB_SF_DATE."</option>\n";
82 82
 
83 83
     $form .= "<option value='counter'";
84 84
     if ('counter' === $options[1]) {
85 85
         $form .= ' selected';
86 86
     }
87
-    $form .= '>' . _MB_SF_HITS . "</option>\n";
87
+    $form .= '>'._MB_SF_HITS."</option>\n";
88 88
 
89 89
     $form .= "<option value='weight'";
90 90
     if ('weight' === $options[1]) {
91 91
         $form .= ' selected';
92 92
     }
93
-    $form .= '>' . _MB_SF_WEIGHT . "</option>\n";
93
+    $form .= '>'._MB_SF_WEIGHT."</option>\n";
94 94
 
95 95
     $form .= "</select>\n";
96 96
 
97
-    $form .= '&nbsp;' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_QUESTIONS . '';
98
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "'>&nbsp;" . _MB_SF_LENGTH . '';
97
+    $form .= '&nbsp;'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_QUESTIONS.'';
98
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."'>&nbsp;"._MB_SF_LENGTH.'';
99 99
 
100
-    $form .= '<br>' . _MB_SF_SHOW_DATE . "&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
100
+    $form .= '<br>'._MB_SF_SHOW_DATE."&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
101 101
     if (1 == $options[4]) {
102 102
         $form .= ' checked';
103 103
     }
104
-    $form .= '>&nbsp;' . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
104
+    $form .= '>&nbsp;'._YES."<input type='radio' id='options[]' name='options[]' value='0'";
105 105
     if (0 == $options[4]) {
106 106
         $form .= ' checked';
107 107
     }
108
-    $form .= '>&nbsp;' . _NO . '';
108
+    $form .= '>&nbsp;'._NO.'';
109 109
 
110 110
     return $form;
111 111
 }
Please login to merge, or discard this patch.
blocks/faqs_new.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     /** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
37 37
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
38 38
     // creating the FAQ objects that belong to the selected category
39
-    $faqsObj   = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
39
+    $faqsObj = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
40 40
 
41 41
     if ($faqsObj) {
42 42
         foreach ($faqsObj as $iValue) {
@@ -69,40 +69,40 @@  discard block
 block discarded – undo
69 69
 
70 70
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
71 71
 
72
-    $form .= '&nbsp;<br>' . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";
72
+    $form .= '&nbsp;<br>'._MB_SF_ORDER."&nbsp;<select name='options[]'>";
73 73
 
74 74
     $form .= "<option value='datesub'";
75 75
     if ('datesub' === $options[1]) {
76 76
         $form .= ' selected';
77 77
     }
78
-    $form .= '>' . _MB_SF_DATE . "</option>\n";
78
+    $form .= '>'._MB_SF_DATE."</option>\n";
79 79
 
80 80
     $form .= "<option value='counter'";
81 81
     if ('counter' === $options[1]) {
82 82
         $form .= ' selected';
83 83
     }
84
-    $form .= '>' . _MB_SF_HITS . "</option>\n";
84
+    $form .= '>'._MB_SF_HITS."</option>\n";
85 85
 
86 86
     $form .= "<option value='weight'";
87 87
     if ('weight' === $options[1]) {
88 88
         $form .= ' selected';
89 89
     }
90
-    $form .= '>' . _MB_SF_WEIGHT . "</option>\n";
90
+    $form .= '>'._MB_SF_WEIGHT."</option>\n";
91 91
 
92 92
     $form .= "</select>\n";
93 93
 
94
-    $form .= '&nbsp;' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_FAQS . '';
95
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "'>&nbsp;" . _MB_SF_LENGTH . '';
94
+    $form .= '&nbsp;'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_FAQS.'';
95
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[3]."'>&nbsp;"._MB_SF_LENGTH.'';
96 96
 
97
-    $form .= '<br>' . _MB_SF_SHOW_DATE . "&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
97
+    $form .= '<br>'._MB_SF_SHOW_DATE."&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
98 98
     if (1 == $options[4]) {
99 99
         $form .= ' checked';
100 100
     }
101
-    $form .= '>&nbsp;' . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
101
+    $form .= '>&nbsp;'._YES."<input type='radio' id='options[]' name='options[]' value='0'";
102 102
     if (0 == $options[4]) {
103 103
         $form .= ' checked';
104 104
     }
105
-    $form .= '>&nbsp;' . _NO . '';
105
+    $form .= '>&nbsp;'._NO.'';
106 106
 
107 107
     return $form;
108 108
 }
Please login to merge, or discard this patch.
blocks/faqs_most_viewed.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     /** @var \XoopsModules\Smartfaq\FaqHandler $faqHandler */
35 35
     $faqHandler = \XoopsModules\Smartfaq\Helper::getInstance()->getHandler('Faq');
36 36
     // creating the FAQ objects that belong to the selected category
37
-    $faqsObj   = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
37
+    $faqsObj = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
38 38
 
39 39
     if ($faqsObj) {
40 40
         foreach ($faqsObj as $iValue) {
@@ -60,8 +60,8 @@  discard block
 block discarded – undo
60 60
 
61 61
     $form = Smartfaq\Utility::createCategorySelect($options[0]);
62 62
 
63
-    $form .= '&nbsp;<br>' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[1] . "'>&nbsp;" . _MB_SF_FAQS . '';
64
-    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_SF_LENGTH . '';
63
+    $form .= '&nbsp;<br>'._MB_SF_DISP."&nbsp;<input type='text' name='options[]' value='".$options[1]."'>&nbsp;"._MB_SF_FAQS.'';
64
+    $form .= '&nbsp;<br>'._MB_SF_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."'>&nbsp;"._MB_SF_LENGTH.'';
65 65
 
66 66
     return $form;
67 67
 }
Please login to merge, or discard this patch.