faqs_new.php ➔ b_faqs_new_show() - Code Metrics - Inspection of "fix by trabis" - mambax7/smartfaq - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c5294...348995 )

by Michael

created 2017-02-26 20:43 UTC

faqs_new.php ➔ b_faqs_new_show() C

↳ Parent: Project

Complexity

Conditions	7
Paths	4

Size

Total Lines	40
Code Lines	27

Duplication

Lines	21
Ratio	52.5 %

Importance

Changes

Metric	Value
cc	7
eloc	27
nc	4
nop	1
dl	21
loc	40
rs	6.7272
c	0
b	0
f	0

<?php

/**
 * Module: SmartFAQ
 * Author: The SmartFactory <www.smartfactory.ca>
 * Licence: GNU
 * @param $options
 * @return array
 */
// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');


function b_faqs_new_show($options)
{
    include_once(XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php');

    $block = array();

    if ($options[0] == 0) {

        $categoryid = -1;
    } else {
        $categoryid = $options[0];
    }

    $sort              = $options[1];
    $limit             = $options[2];
    $maxQuestionLength = $options[3];

    // Creating the faq handler object
    $faqHandler = sf_gethandler('faq');
    // creating the FAQ objects that belong to the selected category
    $faqsObj   = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
    $totalfaqs = count($faqsObj);
    if ($faqsObj) {

        for ($i = 0; $i < $totalfaqs; ++$i) {
            $newfaqs             = array();
            $newfaqs['linktext'] = $faqsObj[$i]->question($maxQuestionLength);
            $newfaqs['id']       = $faqsObj[$i]->faqid();
            if ($sort === 'datesub') {
                $newfaqs['new'] = $faqsObj[$i]->datesub();
            } elseif ($sort === 'counter') {
                $newfaqs['new'] = $faqsObj[$i]->counter();
            } elseif ($sort === 'weight') {
                $newfaqs['new'] = $faqsObj[$i]->weight();
            }
            $newfaqs['show_date'] = $options[4];
            $block['newfaqs'][]   = $newfaqs;
        }
    }

    return $block;
}

/**
 * @param $options
 * @return string
 */
function b_faqs_new_edit($options)
{
    global $xoopsDB, $xoopsModule, $xoopsUser;
function myFunction($a, $b) {
    // Do something
}
    include_once(XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php');

    $form = sf_createCategorySelect($options[0]);

    $form .= '&nbsp;<br>' . _MB_SF_ORDER . "&nbsp;<select name='options[]'>";

    $form .= "<option value='datesub'";
    if ($options[1] === 'datesub') {
        $form .= " selected='selected'";
    }
    $form .= '>' . _MB_SF_DATE . "</option>\n";

    $form .= "<option value='counter'";
    if ($options[1] === 'counter') {
        $form .= " selected='selected'";
    }
    $form .= '>' . _MB_SF_HITS . "</option>\n";

    $form .= "<option value='weight'";
    if ($options[1] === 'weight') {
        $form .= " selected='selected'";
    }
    $form .= '>' . _MB_SF_WEIGHT . "</option>\n";

    $form .= "</select>\n";

    $form .= '&nbsp;' . _MB_SF_DISP . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "' />&nbsp;" . _MB_SF_FAQS . '';
    $form .= '&nbsp;<br>' . _MB_SF_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "' />&nbsp;" . _MB_SF_LENGTH . '';

    $form .= '<br />' . _MB_SF_SHOW_DATE . "&nbsp;<input type='radio' id='options[]' name='options[]' value='1'";
    if ($options[4] == 1) {
        $form .= " checked='checked'";
    }
    $form .= ' />&nbsp;' . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
    if ($options[4] == 0) {
        $form .= " checked='checked'";
    }
    $form .= ' />&nbsp;' . _NO . '';

    return $form;
}


1		<?php
2
3		/**
4		* Module: SmartFAQ
5		* Author: The SmartFactory <www.smartfactory.ca>
6		* Licence: GNU
7		* @param $options
8		* @return array
9		*/
10		// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-30 08:40 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
11
12		function b_faqs_new_show($options)
13		{
14		include_once(XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php');
15
16		$block = array();
17
18	View Code Duplication	if ($options[0] == 0) {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		$categoryid = -1;
20		} else {
21		$categoryid = $options[0];
22		}
23
24		$sort = $options[1];
25		$limit = $options[2];
26		$maxQuestionLength = $options[3];
27
28		// Creating the faq handler object
29		$faqHandler = sf_gethandler('faq');
30		// creating the FAQ objects that belong to the selected category
31		$faqsObj = $faqHandler->getAllPublished($limit, 0, $categoryid, $sort);
32		$totalfaqs = count($faqsObj);
33	View Code Duplication	if ($faqsObj) {
		0 ignored issues – show Duplication introduced 2016-01-18 08:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		for ($i = 0; $i < $totalfaqs; ++$i) {
35		$newfaqs = array();
36		$newfaqs['linktext'] = $faqsObj[$i]->question($maxQuestionLength);
37		$newfaqs['id'] = $faqsObj[$i]->faqid();
38		if ($sort === 'datesub') {
39		$newfaqs['new'] = $faqsObj[$i]->datesub();
40		} elseif ($sort === 'counter') {
41		$newfaqs['new'] = $faqsObj[$i]->counter();
42		} elseif ($sort === 'weight') {
43		$newfaqs['new'] = $faqsObj[$i]->weight();
44		}
45		$newfaqs['show_date'] = $options[4];
46		$block['newfaqs'][] = $newfaqs;
47		}
48		}
49
50		return $block;
51		}
52
53		/**
54		* @param $options
55		* @return string
56		*/
57		function b_faqs_new_edit($options)
58		{
59		global $xoopsDB, $xoopsModule, $xoopsUser;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 08:41 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
60		include_once(XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php');
61
62		$form = sf_createCategorySelect($options[0]);
63
64		$form .= ' <br>' . _MB_SF_ORDER . " <select name='options[]'>";
65
66		$form .= "<option value='datesub'";
67		if ($options[1] === 'datesub') {
68		$form .= " selected='selected'";
69		}
70		$form .= '>' . _MB_SF_DATE . "</option>\n";
71
72		$form .= "<option value='counter'";
73		if ($options[1] === 'counter') {
74		$form .= " selected='selected'";
75		}
76		$form .= '>' . _MB_SF_HITS . "</option>\n";
77
78		$form .= "<option value='weight'";
79		if ($options[1] === 'weight') {
80		$form .= " selected='selected'";
81		}
82		$form .= '>' . _MB_SF_WEIGHT . "</option>\n";
83
84		$form .= "</select>\n";
85
86		$form .= ' ' . _MB_SF_DISP . " <input type='text' name='options[]' value='" . $options[2] . "' /> " . _MB_SF_FAQS . '';
87		$form .= ' <br>' . _MB_SF_CHARS . " <input type='text' name='options[]' value='" . $options[3] . "' /> " . _MB_SF_LENGTH . '';
88
89		$form .= '<br />' . _MB_SF_SHOW_DATE . " <input type='radio' id='options[]' name='options[]' value='1'";
90		if ($options[4] == 1) {
91		$form .= " checked='checked'";
92		}
93		$form .= ' /> ' . _YES . "<input type='radio' id='options[]' name='options[]' value='0'";
94		if ($options[4] == 0) {
95		$form .= " checked='checked'";
96		}
97		$form .= ' /> ' . _NO . '';
98
99		return $form;
100		}
101

mambax7 / smartfaq

Push — master ( 6c5294...348995 )

faqs_new.php ➔ b_faqs_new_show() C

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like