Conditions | 8 |
Paths | 30 |
Total Lines | 60 |
Code Lines | 42 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types=1); |
||
146 | public function render() |
||
147 | { |
||
148 | // load all child ids for javascript codes |
||
149 | foreach (\array_keys($this->_itemTree) as $item_id) { |
||
150 | $this->_itemTree[$item_id]['allchild'] = []; |
||
151 | $this->_loadAllChildItemIds($item_id, $this->_itemTree[$item_id]['allchild']); |
||
152 | } |
||
153 | /** @var \XoopsGroupPermHandler $grouppermHandler */ |
||
154 | $grouppermHandler = \xoops_getHandler('groupperm'); |
||
155 | $memberHandler = \xoops_getHandler('member'); |
||
156 | $glist = $memberHandler->getGroupList(); |
||
|
|||
157 | foreach (\array_keys($glist) as $i) { |
||
158 | // get selected item id(s) for each group |
||
159 | $selected = $grouppermHandler->getItemIds($this->_permName, $i, $this->_modid); |
||
160 | $ele = new GroupFormCheckBox($glist[$i], 'perms[' . $this->_permName . ']', $i, $selected); |
||
161 | $ele->setOptionTree($this->_itemTree); |
||
162 | |||
163 | foreach ($this->_appendix as $key => $append) { |
||
164 | $this->_appendix[$key]['selected'] = $grouppermHandler->checkRight($append['permname'], $append['itemid'], $i, $this->_modid); |
||
165 | } |
||
166 | $ele->setAppendix($this->_appendix); |
||
167 | $this->addElement($ele); |
||
168 | unset($ele); |
||
169 | } |
||
170 | |||
171 | // GIJ start |
||
172 | $jstray = new \XoopsFormElementTray(' '); |
||
173 | $jsuncheckbutton = new \XoopsFormButton('', 'none', \_NONE, 'button'); |
||
174 | $jsuncheckbutton->setExtra("onclick=\"with(document.groupperm_form){for (i=0;i<length;i++) {if (elements[i].type=='checkbox') {elements[i].checked=false;}}}\""); |
||
175 | $jscheckbutton = new \XoopsFormButton('', 'all', \_ALL, 'button'); |
||
176 | $jscheckbutton->setExtra("onclick=\"with(document.groupperm_form){for (i=0;i<length;i++) {if (elements[i].type=='checkbox' && (elements[i].name.indexOf('module_admin')<0 || elements[i].name.indexOf('[groups][1]')>=0)) {elements[i].checked=true;}}}\""); |
||
177 | $jstray->addElement($jsuncheckbutton); |
||
178 | $jstray->addElement($jscheckbutton); |
||
179 | $this->addElement($jstray); |
||
180 | // GIJ end |
||
181 | |||
182 | $tray = new \XoopsFormElementTray(''); |
||
183 | $tray->addElement(new \XoopsFormButton('', 'reset', \_CANCEL, 'reset')); |
||
184 | $tray->addElement(new \XoopsFormButton('', 'submit', \_SUBMIT, 'submit')); |
||
185 | $this->addElement($tray); |
||
186 | |||
187 | $ret = '<h4>' . $this->getTitle() . '</h4>' . $this->_permDesc . '<br>'; |
||
188 | $ret .= "<form name='" . $this->getName() . "' id='" . $this->getName() . "' action='" . $this->getAction() . "' method='" . $this->getMethod() . "'" . $this->getExtra() . ">\n<table width='100%' class='outer' cellspacing='1'>\n"; |
||
189 | $elements = &$this->getElements(); |
||
190 | foreach (\array_keys($elements) as $i) { |
||
191 | if (!\is_object($elements[$i])) { |
||
192 | $ret .= $elements[$i]; |
||
193 | } elseif ($elements[$i]->isHidden()) { |
||
194 | $ret .= $elements[$i]->render(); |
||
195 | } else { |
||
196 | $ret .= "<tr valign='top' align='left'><td class='head'>" . $elements[$i]->getCaption(); |
||
197 | if ('' != $elements[$i]->getDescription()) { |
||
198 | $ret .= '<br><br><span style="font-weight: normal;">' . $elements[$i]->getDescription() . '</span>'; |
||
199 | } |
||
200 | $ret .= "</td>\n<td class='even'>\n" . $elements[$i]->render() . "\n</td></tr>\n"; |
||
201 | } |
||
202 | } |
||
203 | $ret .= '</table></form>'; |
||
204 | |||
205 | return $ret; |
||
206 | } |
||
208 |