XoopsModules\Smartfaq\FaqHandler::getFaqs()

Complexity

Conditions	17
Paths	864

Size

Total Lines	85
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types=1);
    public function getFaqs(
        $limit = 0,
        $start = 0,
        $status = '',
        $categoryid = -1,
        $sort = 'datesub',
        $order = 'DESC',
        $notNullFields = '',
        $asobject = true,

The parameter $asobject is not used and could be removed.

        $otherCriteria = null
    ) {
        global $xoopsUser;
        //        require_once XOOPS_ROOT_PATH . '/modules/smartfaq/include/functions.php';

        //if ( ($categoryid == -1) && (empty($status) || ($status == -1)) && ($limit == 0) && ($start ==0) ) {
        //  return $this->getObjects();
        //}
        $ret              = [];

The assignment to $ret is dead and can be removed.

        $userIsAdmin      = Smartfaq\Utility::userIsAdmin();
        $criteriaCategory = null;
        // Categories for which user has access
        if (!$userIsAdmin) {
            /** @var Smartfaq\PermissionHandler $smartPermHandler */
            $smartPermHandler = Smartfaq\Helper::getInstance()->getHandler('Permission');

            $categoriesGranted = $smartPermHandler->getPermissions('category');
            $grantedCategories = new \Criteria('categoryid', '(' . \implode(',', $categoriesGranted) . ')', 'IN');

            $faqsGranted = $smartPermHandler->getPermissions('item');
            $grantedFaq  = new \CriteriaCompo();
            $grantedFaq->add(new \Criteria('faqid', '(' . \implode(',', $faqsGranted) . ')', 'IN'), 'OR');
            // If user is anonymous, check if the FAQ allow partialview
            if (!\is_object($xoopsUser)) {
                $grantedFaq->add(new \Criteria('partialview', '1'), 'OR');
            }
        }

        if (isset($categoryid) && (-1 != $categoryid)) {
            if (\is_array($categoryid)) {
                $criteriaCategory = new \Criteria('categoryid', '(' . \implode(',', $categoryid) . ')', 'IN');
            } else {
                $criteriaCategory = new \Criteria('categoryid', (int)$categoryid);
            }
        }

        if (!empty($status) && \is_array($status)) {
            $criteriaStatus = new \CriteriaCompo();
            foreach ($status as $v) {
                $criteriaStatus->add(new \Criteria('status', $v), 'OR');
            }
        } elseif (!empty($status) && (-1 != $status)) {
            $criteriaStatus = new \CriteriaCompo();
            $criteriaStatus->add(new \Criteria('status', $status), 'OR');
        }

        $criteriaPermissions = new \CriteriaCompo();
        if (!$userIsAdmin) {
            $criteriaPermissions->add($grantedCategories, 'AND');

The variable $grantedCategories does not seem to be defined for all execution paths leading up to this point.

            $criteriaPermissions->add($grantedFaq, 'AND');

The variable $grantedFaq does not seem to be defined for all execution paths leading up to this point.

        }

        $criteria = new \CriteriaCompo();
        if (null !== $criteriaCategory) {
            $criteria->add($criteriaCategory);
        }

        if (null !== $criteriaPermissions && (!$userIsAdmin)) {
            $criteria->add($criteriaPermissions);
        }

        if (null !== $criteriaStatus) {

The variable $criteriaStatus does not seem to be defined for all execution paths leading up to this point.

            $criteria->add($criteriaStatus);
        }

        if (!empty($otherCriteria)) {
            $criteria->add($otherCriteria);
        }

        $criteria->setLimit($limit);
        $criteria->setStart($start);
        $criteria->setSort($sort);
        $criteria->setOrder($order);
        $ret = $this->getObjects($criteria, false, $notNullFields);

        return $ret;

The expression return $ret could also return false which is incompatible with the documented return type array. Did you maybe forget to handle an error condition?

    }