XoopsModules\Smartfaq\PermissionHandler

Complexity

Total Complexity

9

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getPermissions()	0	32	9

<?php declare(strict_types=1);

namespace XoopsModules\Smartfaq;

/**
 * Module: SmartFAQ
 * Author: The SmartFactory <www.smartfactory.ca>
 * Credits: Mithrandir
 * Licence: GNU
 */

use XoopsModules\Smartfaq;

/**
 * Class PermissionHandler
 */
class PermissionHandler extends \XoopsObjectHandler
{
    /*
    * Returns permissions for a certain type
    *
    * @param string $type "global", "forum" or "topic" (should perhaps have "post" as well - but I don't know)
    * @param int $id id of the item (forum, topic or possibly post) to get permissions for
    *
    * @return array
    */

    /**
     * @param string $type
     * @param null   $id

Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?

     * @return array
     */
    public function getPermissions($type = 'category', $id = null)
    {
        global $xoopsUser;
        static $permissions;

        if (!isset($permissions[$type]) || (null !== $id && !isset($permissions[$type][$id]))) {
            $smartModule = Smartfaq\Utility::getModuleInfo();
            //Get group permissions handler
            /** @var \XoopsGroupPermHandler $grouppermHandler */
            $grouppermHandler = \xoops_getHandler('groupperm');
            //Get user's groups
            $groups = \is_object($xoopsUser) ? $xoopsUser->getGroups() : [XOOPS_GROUP_ANONYMOUS];

            switch ($type) {
                case 'category':
                    $gperm_name = 'category_read';
                    break;
                case 'item':
                    $gperm_name = 'item_read';
                    break;
                case 'moderation':
                    $gperm_name = 'category_moderation';
                    $groups     = \is_object($xoopsUser) ? $xoopsUser->getVar('uid') : 0;
            }

            //Get all allowed item ids in this module and for this user's groups
            $userpermissions    = $grouppermHandler->getItemIds($gperm_name, $groups, $smartModule->getVar('mid'));

The variable $gperm_name does not seem to be defined for all execution paths leading up to this point.

            $permissions[$type] = $userpermissions;
        }

        //Return the permission array
        return $permissions[$type] ?? [];
    }
}