notification.inc.php ➔ references_notify_iteminfo() - Code Metrics - mambax7/references - Measure and Improve Code Quality continuously with Scrutinizer

notification.inc.php ➔ references_notify_iteminfo() B
last analyzed 2019-01-19 04:12 UTC

↳ Parent: Project

Complexity

Conditions	6
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
nc	8
nop	2
dl	0
loc	34
rs	8.7537
c	0
b	0
f	0

<?php
/**
 * ****************************************************************************
 * references - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package         references
 * @author          Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 *
 * ****************************************************************************
 */

/**
 * Gestion des notifications
 * @param $category
 * @param $item_id
 * @return mixed
 */
function references_notify_iteminfo($category, $item_id)
{
    global $xoopsModule, $xoopsModuleConfig, $xoopsConfig;
    $item_id = (int)$item_id;

    if (empty($xoopsModule) || $xoopsModule->getVar('dirname') !== 'references') {
        $module_handler = xoops_getHandler('module');
        $module         = $module_handler->getByDirname('references');
        $config_handler = xoops_getHandler('config');
        $config         = $config_handler->getConfigsByCat(0, $module->getVar('mid'));
    } else {
        $module =& $xoopsModule;
        $config =& $xoopsModuleConfig;
    }

    if ($category === 'global') {
        $item['name'] = '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['url']  = '';

        return $item;
    }

    if ($category === 'new_article') {
        include REFERENCES_PATH . ' include/common.php';
        $article = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $article = $h_references_articles->get($item_id);

        if (is_object($article)) {
            $item['name'] = $article->getVar('article_title');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $item['url']  = REFERENCES_URL;
        }

        return $item;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2			/**
3			* ****************************************************************************
4			* references - MODULE FOR XOOPS
5			* Copyright (c) Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
6			*
7			* You may not change or alter any portion of this comment or credits
8			* of supporting developers from this source code or any supporting source code
9			* which is considered copyrighted (c) material of the original comment or credit authors.
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13			*
14			* @copyright Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
15			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
16			* @package references
17			* @author Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
18			*
19			* ****************************************************************************
20			*/
21
22			/**
23			* Gestion des notifications
24			* @param $category
25			* @param $item_id
26			* @return mixed
27			*/
28			function references_notify_iteminfo($category, $item_id)
29			{
30			global $xoopsModule, $xoopsModuleConfig, $xoopsConfig;
31			$item_id = (int)$item_id;
32
33			if (empty($xoopsModule) \|\| $xoopsModule->getVar('dirname') !== 'references') {
34			$module_handler = xoops_getHandler('module');
35			$module = $module_handler->getByDirname('references');
36			$config_handler = xoops_getHandler('config');
37			$config = $config_handler->getConfigsByCat(0, $module->getVar('mid'));
38			} else {
39			$module =& $xoopsModule;
40			$config =& $xoopsModuleConfig;
41			}
42
43			if ($category === 'global') {
44			$item['name'] = '';
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-05 02:02 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
45			$item['url'] = '';
46
47			return $item;
48			}
49
50			if ($category === 'new_article') {
51			include REFERENCES_PATH . ' include/common.php';
52			$article = null;
			0 ignored issues – show Unused Code introduced 2016-07-05 02:02 UTC by Report Bug Copy Issue Report `$article` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
53			$article = $h_references_articles->get($item_id);
			0 ignored issues – show Bug introduced 2016-07-05 02:02 UTC by Report Bug Copy Issue Report The variable `$h_references_articles` does not exist. Did you mean `$article`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
54			if (is_object($article)) {
55			$item['name'] = $article->getVar('article_title');
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-05 02:02 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
56			$item['url'] = REFERENCES_URL;
57			}
58
59			return $item;
			0 ignored issues – show Bug introduced 2016-07-05 02:02 UTC by Report Bug Copy Issue Report The variable `$item` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
60			}
61			}
62

mambax7 / references

notification.inc.php ➔ references_notify_iteminfo() B last analyzed 2019-01-19 04:12 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

notification.inc.php ➔ references_notify_iteminfo() B
last analyzed 2019-01-19 04:12 UTC