references_parameters

Complexity

Total Complexity

6

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__set()	0	6	1
A	__call()	0	11	2
A	extend()	0	12	3

<?php
/**
 * ****************************************************************************
 * references - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package         references
 * @author          Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 *
 * ****************************************************************************
 */

/**
 * Class used for parameters passing to classes methods
 *
 * @copyright       Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package         references
 * @author          Hervé Thouzard of Instant Zero (http://www.instant-zero.com)
 *
 */
class references_parameters extends ArrayObject
{
    /**
     * Permet de valoriser un indice de la classe comme si c'était une propriété de la classe
     *
     * @example $enregistrement->nom_du_champ = 'ma chaine'
     *
     * @param string $key   Le nom du champ à traiter
     * @param mixed  $value La valeur à lui attribuer
     * @return object
     */
    public function __set($key, $value)
    {
        parent::offsetSet($key, $value);

It seems like you call parent on a different method (offsetSet() instead of __set()). Are you sure this is correct? If so, you might want to change this to $this->offsetSet().

        return $this;
    }

    /**
     * Valorisation d'un indice de la classe en utilisant un appel de fonction basé sur le principe suivant :
     *      $maClasse->setLimit(10);
     * Il est possible de chainer comme ceci : $maClasse->setStart(0)->setLimit(10);
     *
     * @param  string $method
     * @param  mixed  $args
     * @return object
     */
    public function __call($method, $args)
    {
        if (substr($method, 0, 3) === 'set') {
            parent::offsetSet(strtolower(substr($method, 3, 1)) . substr($method, 4), $args[0]);

It seems like you call parent on a different method (offsetSet() instead of __call()). Are you sure this is correct? If so, you might want to change this to $this->offsetSet().

            return $this;
        } else {    // Affichage de la valeur

            return parent::offsetGet($method);

It seems like you call parent on a different method (offsetGet() instead of __call()). Are you sure this is correct? If so, you might want to change this to $this->offsetGet().

        }
    }

    /**
     * Méthode qui essaye de faire la même chose que la méthode extend() de jQuery
     *
     * On lui passe les valeurs par défaut que l'on attend et la méthode les compare avec les valeurs actuelles
     * Si des valeurs manquent, elles sont ajoutées
     *
     * @param  references_parameters $defaultValues

Should the type for parameter $defaultValues not be self?

     * @return references_parameters
     */
    public function extend(self $defaultValues)
    {
        $result = new self;

$result is not used, you could remove the assignment.

        $result = $this;
        foreach ($defaultValues as $key => $value) {
            if (!isset($result[$key])) {
                $result[$key] = $value;
            }
        }

        return $result;
    }
}