Twitter

Complexity

Total Complexity

371

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	update()	0	48	11

<?php

/*
 * Twitter.class.php - update the status of a twitter user
 * Author: Felix Oghina
 */

if (class_exists('Twitter')) {
    return true;
}

class Twitter
{

    private $auth  = false;
    private $debug = false;
    public  $error = false;

    function __construct($user, $pass, $debug = false)

It is generally recommended to explicitly declare the visibility for methods.

    {
        // Store an auth key for the HTTP Authorization: header
        $this->auth  = base64_encode($user . ':' . $pass);

The property $auth was declared of type boolean, but base64_encode($user . ':' . $pass) is of type string. Maybe add a type cast?

        $this->debug = $debug;
    }

    function update($new_status)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if (strlen($new_status) > 140) {
            $this->error = "Status too long: {$new_status}.";
            return false;
        }
        $fp = @fsockopen('twitter.com', 80, $errno, $errstr);
        if (!$fp) {
            $this->error = "Socket error #{$errno}: {$errstr}";
            return false;
        }
        $post_data = 'status=' . urlencode($new_status);
        $to_send   = "POST /statuses/update.xml HTTP/1.1\r\n";
        $to_send .= "Host: twitter.com\r\n";
        $to_send .= 'Content-Length: ' . strlen($post_data) . "\r\n";
        $to_send .= "Authorization: Basic {$this->auth}\r\n\r\n";
        $to_send .= $post_data . "\r\n\r\n";
        $bytes = fwrite($fp, $to_send);
        if ($bytes === false) {
            $this->error = 'Socket error: Error sending data.';

The property $error was declared of type boolean, but 'Socket error: Error sending data.' is of type string. Maybe add a type cast?

            return false;
        } elseif ($bytes < strlen($to_send)) {
            $this->error = 'Socket error: Could not send all data.';

The property $error was declared of type boolean, but 'Socket error: Could not send all data.' is of type string. Maybe add a type cast?

            return false;
        }
        if ($this->debug) echo "Sent:\n{$to_send}\n\n";
        $response = '';
        while (!feof($fp)) {
            $buf = fread($fp, 1024);
            if ($buf === false) {
                $this->error = 'Socket error: Error reading data.';

The property $error was declared of type boolean, but 'Socket error: Error reading data.' is of type string. Maybe add a type cast?

                return false;
            }
            $response .= $buf;
        }
        if ($this->debug) echo "Received:\n{$response}";
        $was_error = preg_match('#' . preg_quote('<error>') . '(.+)' . preg_quote('</error>') . '#i', $response, $matches);
        if ($was_error) {
            $this->error = "Twitter error: {$matches[1]}";
            return false;
        }
        list($first_line) = explode("\r\n", $response);
        if ($first_line !== 'HTTP/1.1 200 OK') {
            $this->error = "Request error: {$first_line}";
            return false;
        }
        return true;
    }

}