category.php ➔ setPermissions() - Code Metrics - Inspection of "namespaces, category" - mambax7/randomquote - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 171474...8d265e )

by Michael

created 2018-01-01 13:50 UTC

category.php ➔ setPermissions() B

↳ Parent: Project

Complexity

Conditions	6
Paths	10

Size

Total Lines	38
Code Lines	30

Duplication

Lines	18
Ratio	47.37 %

Importance

Changes

Metric	Value
cc	6
eloc	30
nc	10
nop	6
dl	18
loc	38
rs	8.439
c	0
b	0
f	0

<?php


/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Module: randomquote
 *
 * @category        Module
 * @package         randomquote
 * @author          XOOPS Development Team <[email protected]> - <https://xoops.org>
 * @copyright       {@link https://xoops.org/ XOOPS Project}
 * @license         GPL 2.0 or later
 * @link            https://xoops.org/
 * @since           1.0.0
 */

use Xmf\Module\Helper\Permission;
use Xmf\Request;
use Xoopsmodules\randomquote;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Xoopsmodules\randomquote\common;

require_once __DIR__ . '/admin_header.php';
xoops_cp_header();
//It recovered the value of argument op in URL$
$op    = Request::getString('op', 'list');
$order = Request::getString('order', 'desc');
$sort  = Request::getString('sort', '');

$adminObject->displayNavigation(basename(__FILE__));
/** @var Permission $permHelper */
$permHelper = new \Xmf\Module\Helper\Permission();
$uploadDir  = XOOPS_UPLOAD_PATH . '/randomquote/images/';
$uploadUrl  = XOOPS_UPLOAD_URL . '/randomquote/images/';

switch ($op) {
    case 'list':
    default:
        $adminObject->addItemButton(AM_RANDOMQUOTE_ADD_CATEGORY, 'category.php?op=new', 'add');
        echo $adminObject->displayButton('left');
        $start                   = Request::getInt('start', 0);
        $categoryPaginationLimit = $GLOBALS['xoopsModuleConfig']['userpager'];

        $criteria = new CriteriaCompo();
        $criteria->setSort('id ASC, title');
        $criteria->setOrder('ASC');
        $criteria->setLimit($categoryPaginationLimit);
        $criteria->setStart($start);
        $categoryTempRows  = $categoryHandler->getCount();
        $categoryTempArray = $categoryHandler->getAll($criteria);

        // Display Page Navigation
        if ($categoryTempRows > $categoryPaginationLimit) {

            require_once XOOPS_ROOT_PATH . '/class/pagenav.php';

            $pagenav = new \XoopsPageNav($categoryTempRows, $categoryPaginationLimit, $start, 'start', 'op=list' . '&sort=' . $sort . '&order=' . $order . '');
            $GLOBALS['xoopsTpl']->assign('pagenav', null === $pagenav ? $pagenav->renderNav() : '');
        }

        $GLOBALS['xoopsTpl']->assign('categoryRows', $categoryTempRows);
        $categoryArray = [];

        $criteria = new CriteriaCompo();

        //$criteria->setOrder('DESC');

        $criteria->setSort($sort);
        $criteria->setOrder($order);
        $criteria->setLimit($categoryPaginationLimit);
        $criteria->setStart($start);

        $categoryCount     = $categoryHandler->getCount($criteria);
        $categoryTempArray = $categoryHandler->getAll($criteria);

        //    for ($i = 0; $i < $fieldsCount; ++$i) {

        if ($categoryCount > 0) {
            foreach (array_keys($categoryTempArray) as $i) {


                //        $field = explode(':', $fields[$i]);


                $selectorid = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_ID, 'id');
                $GLOBALS['xoopsTpl']->assign('selectorid', $selectorid);
                $categoryArray['id'] = $categoryTempArray[$i]->getVar('id');

                $selectorpid = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_PID, 'pid');
                $GLOBALS['xoopsTpl']->assign('selectorpid', $selectorpid);
                $categoryArray['pid'] = $categoryTempArray[$i]->getVar('pid');

                $selectortitle = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_TITLE, 'title');
                $GLOBALS['xoopsTpl']->assign('selectortitle', $selectortitle);
                $categoryArray['title'] = $categoryTempArray[$i]->getVar('title');

                $selectordescription = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_DESCRIPTION, 'description');
                $GLOBALS['xoopsTpl']->assign('selectordescription', $selectordescription);
                $categoryArray['description'] = $categoryTempArray[$i]->getVar('description');

                $selectorimage = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_IMAGE, 'image');
                $GLOBALS['xoopsTpl']->assign('selectorimage', $selectorimage);
                $categoryArray['image'] = "<img src='" . $uploadUrl . $categoryTempArray[$i]->getVar('image') . "' name='" . 'name' . "' id=" . 'id' . " alt='' style='max-width:100px'>";

                $selectorweight = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_WEIGHT, 'weight');
                $GLOBALS['xoopsTpl']->assign('selectorweight', $selectorweight);
                $categoryArray['weight'] = $categoryTempArray[$i]->getVar('weight');

                $selectorcolor = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_COLOR, 'color');
                $GLOBALS['xoopsTpl']->assign('selectorcolor', $selectorcolor);
                $categoryArray['color'] = $categoryTempArray[$i]->getVar('color');

                $selectoronline = $utility::selectSorting(AM_RANDOMQUOTE_CATEGORY_ONLINE, 'online');
                $GLOBALS['xoopsTpl']->assign('selectoronline', $selectoronline);
                $categoryArray['online']      = $categoryTempArray[$i]->getVar('online');
                $categoryArray['edit_delete'] = "<a href='category.php?op=edit&id=" . $i . "'><img src=" . $pathIcon16 . "/edit.png alt='" . _EDIT . "' title='" . _EDIT . "'></a>
               <a href='category.php?op=delete&id=" . $i . "'><img src=" . $pathIcon16 . "/delete.png alt='" . _DELETE . "' title='" . _DELETE . "'></a>
               <a href='category.php?op=clone&id=" . $i . "'><img src=" . $pathIcon16 . "/editcopy.png alt='" . _CLONE . "' title='" . _CLONE . "'></a>";

                $GLOBALS['xoopsTpl']->append_by_ref('categoryArrays', $categoryArray);
                unset($categoryArray);
            }
            unset($categoryTempArray);
            // Display Navigation
            if ($categoryCount > $categoryPaginationLimit) {

                require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
                $pagenav = new \XoopsPageNav($categoryCount, $categoryPaginationLimit, $start, 'start', 'op=list' . '&sort=' . $sort . '&order=' . $order . '');
                $GLOBALS['xoopsTpl']->assign('pagenav', $pagenav->renderNav(4));
            }

            echo $GLOBALS['xoopsTpl']->fetch(XOOPS_ROOT_PATH . '/modules/' . $GLOBALS['xoopsModule']->getVar('dirname') . '/templates/admin/randomquote_admin_category.tpl');
        }

        break;

    case 'new':

        $adminObject->addItemButton(AM_RANDOMQUOTE_CATEGORY_LIST, 'category.php', 'list');
        echo $adminObject->displayButton('left');

        $categoryObject = $categoryHandler->create();
        $form           = $categoryObject->getForm();
        $form->display();
        break;

    case 'save':
        if (!$GLOBALS['xoopsSecurity']->check()) {
            redirect_header('category.php', 3, implode(',', $GLOBALS['xoopsSecurity']->getErrors()));
        }
        if (0 != Request::getInt('id', 0)) {
            $categoryObject = $categoryHandler->get(Request::getInt('id', 0));
        } else {
            $categoryObject = $categoryHandler->create();
        }
        // Form save fields
        $categoryObject->setVar('pid', Request::getVar('pid', ''));
        $categoryObject->setVar('title', Request::getVar('title', ''));
        $categoryObject->setVar('description', Request::getText('description', ''));

        require_once XOOPS_ROOT_PATH . '/class/uploader.php';
        $uploadDir = XOOPS_UPLOAD_PATH . '/randomquote/images/';
        $uploader  = new \XoopsMediaUploader($uploadDir, xoops_getModuleOption('mimetypes', 'randomquote'), xoops_getModuleOption('maxsize', 'randomquote'), null, null);
        if ($uploader->fetchMedia(Request::getArray('xoops_upload_file', '', 'POST')[0])) {
            $uploader->setPrefix('image_');
            $uploader->fetchMedia(Request::getArray('xoops_upload_file', '', 'POST')[0]);
            if (!$uploader->upload()) {
                $errors = $uploader->getErrors();
                redirect_header('javascript:history.go(-1)', 3, $errors);
            } else {
                $categoryObject->setVar('image', $uploader->getSavedFileName());
            }
        } else {
            $categoryObject->setVar('image', Request::getVar('image', ''));
        }

        $categoryObject->setVar('weight', Request::getVar('weight', ''));
        $categoryObject->setVar('color', Request::getVar('color', ''));
        $categoryObject->setVar('online', ((1 == Request::getInt('online', 0)) ? '1' : '0'));
        //Permissions
        //===============================================================

        $mid = $GLOBALS['xoopsModule']->mid();
        /** @var XoopsGroupPermHandler $gpermHandler */
        $gpermHandler = xoops_getHandler('groupperm');
        $id           = Request::getInt('id', 0);

        /**
         * @param $myArray
         * @param $permissionGroup
         * @param $id
         * @param $gpermHandler
         * @param $permissionName
         * @param $mid
         */
        function setPermissions($myArray, $permissionGroup, $id, $gpermHandler, $permissionName, $mid)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
        {
            $permissionArray = $myArray;
            if ($id > 0) {
                $sql = 'DELETE FROM `' . $GLOBALS['xoopsDB']->prefix('group_permission') . "` WHERE `gperm_name` = '" . $permissionName . "' AND `gperm_itemid`= $id;";
                $GLOBALS['xoopsDB']->query($sql);
            }
            //admin
            $gperm = $gpermHandler->create();
            $gperm->setVar('gperm_groupid', XOOPS_GROUP_ADMIN);
            $gperm->setVar('gperm_name', $permissionName);
            $gperm->setVar('gperm_modid', $mid);
            $gperm->setVar('gperm_itemid', $id);
            $gpermHandler->insert($gperm);
            unset($gperm);
            //non-Admin groups
            if (is_array($permissionArray)) {
                foreach ($permissionArray as $key => $cat_groupperm) {
                    if ($cat_groupperm > 0) {

                        $gperm = $gpermHandler->create();
                        $gperm->setVar('gperm_groupid', $cat_groupperm);
                        $gperm->setVar('gperm_name', $permissionName);
                        $gperm->setVar('gperm_modid', $mid);
                        $gperm->setVar('gperm_itemid', $id);
                        $gpermHandler->insert($gperm);
                        unset($gperm);
                    }
                }
            } elseif ($permissionArray > 0) {

                $gperm = $gpermHandler->create();
                $gperm->setVar('gperm_groupid', $permissionArray);
                $gperm->setVar('gperm_name', $permissionName);
                $gperm->setVar('gperm_modid', $mid);
                $gperm->setVar('gperm_itemid', $id);
                $gpermHandler->insert($gperm);
                unset($gperm);
            }
        }

        //setPermissions for View items
        $permissionGroup   = 'groupsRead';
        $permissionName    = 'randomquote_view';
        $permissionArray   = Request::getArray($permissionGroup, '');
        $permissionArray[] = XOOPS_GROUP_ADMIN;
        //setPermissions($permissionArray, $permissionGroup, $id, $gpermHandler, $permissionName, $mid);

        $permHelper->savePermissionForItem($permissionName, $id, $permissionArray);

        //setPermissions for Submit items
        $permissionGroup   = 'groupsSubmit';
        $permissionName    = 'randomquote_submit';
        $permissionArray   = Request::getArray($permissionGroup, '');
        $permissionArray[] = XOOPS_GROUP_ADMIN;
        //setPermissions($permissionArray, $permissionGroup, $id, $gpermHandler, $permissionName, $mid);

        $permHelper->savePermissionForItem($permissionName, $id, $permissionArray);

        //setPermissions for Approve items
        $permissionGroup   = 'groupsModeration';
        $permissionName    = 'randomquote_approve';
        $permissionArray   = Request::getArray($permissionGroup, '');
        $permissionArray[] = XOOPS_GROUP_ADMIN;
        //setPermissions($permissionArray, $permissionGroup, $id, $gpermHandler, $permissionName, $mid);

        $permHelper->savePermissionForItem($permissionName, $id, $permissionArray);

        if ($categoryHandler->insert($categoryObject)) {
            redirect_header('category.php?op=list', 2, AM_RANDOMQUOTE_FORMOK);
        }

        echo $categoryObject->getHtmlErrors();
        $form = $categoryObject->getForm();
        $form->display();
        break;

    case 'edit':

        $adminObject->addItemButton(AM_RANDOMQUOTE_ADD_CATEGORY, 'category.php?op=new', 'add');
        $adminObject->addItemButton(AM_RANDOMQUOTE_CATEGORY_LIST, 'category.php', 'list');
        echo $adminObject->displayButton('left');
        $categoryObject = $categoryHandler->get(Request::getString('id', ''));
        $form           = $categoryObject->getForm();
        $form->display();
        break;

    case 'delete':

        $categoryObject = $categoryHandler->get(Request::getString('id', ''));
        if (1 == Request::getInt('ok', 0)) {
            if (!$GLOBALS['xoopsSecurity']->check()) {
                redirect_header('category.php', 3, implode(', ', $GLOBALS['xoopsSecurity']->getErrors()));
            }
            if ($categoryHandler->delete($categoryObject)) {
                redirect_header('category.php', 3, AM_RANDOMQUOTE_FORMDELOK);
            } else {
                echo $categoryObject->getHtmlErrors();
            }
        } else {
            xoops_confirm(['ok' => 1, 'id' => Request::getString('id', ''), 'op' => 'delete'], Request::getCmd('REQUEST_URI', '', 'SERVER'), sprintf(AM_RANDOMQUOTE_FORMSUREDEL, $categoryObject->getVar('title')));
        }
        break;

    case 'clone':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

        $id_field = Request::getString('id', '');

        if ($utility::cloneRecord('randomquote_category', 'id', $id_field)) {
            redirect_header('category.php', 3, AM_RANDOMQUOTE_CLONED_OK);
        } else {
            redirect_header('category.php', 3, AM_RANDOMQUOTE_CLONED_FAILED);
        }

        break;
}
require_once __DIR__ . '/admin_footer.php';


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-24 22:31 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 197 and the first side effect is on line 30. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/*
4			You may not change or alter any portion of this comment or credits
5			of supporting developers from this source code or any supporting source code
6			which is considered copyrighted (c) material of the original comment or credit authors.
7
8			This program is distributed in the hope that it will be useful,
9			but WITHOUT ANY WARRANTY; without even the implied warranty of
10			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*/
12
13			/**
14			* Module: randomquote
15			*
16			* @category Module
17			* @package randomquote
18			* @author XOOPS Development Team <[email protected]> - <https://xoops.org>
19			* @copyright {@link https://xoops.org/ XOOPS Project}
20			* @license GPL 2.0 or later
21			* @link https://xoops.org/
22			* @since 1.0.0
23			*/
24
25			use Xmf\Module\Helper\Permission;
26			use Xmf\Request;
27			use Xoopsmodules\randomquote;
			0 ignored issues – show Bug introduced 2018-01-01 13:52 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `randomquote`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
28			use Xoopsmodules\randomquote\common;
29
30			require_once __DIR__ . '/admin_header.php';
31			xoops_cp_header();
32			//It recovered the value of argument op in URL$
33			$op = Request::getString('op', 'list');
34			$order = Request::getString('order', 'desc');
35			$sort = Request::getString('sort', '');
36
37			$adminObject->displayNavigation(basename(__FILE__));
38			/** @var Permission $permHelper */

mambax7 / randomquote

Push — master ( 171474...8d265e )

category.php ➔ setPermissions() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like