mambax7 /
randomquote
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 52 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 46 | function xoops_module_uninstall_randomquote(\XoopsModule $module) |
||
| 47 | { |
||
| 48 | include __DIR__ . '/../preloads/autoloader.php'; |
||
| 49 | $moduleDirName = basename(dirname(__DIR__)); |
||
| 50 | $moduleDirNameUpper = strtoupper($moduleDirName); //$capsDirName |
||
| 51 | |||
| 52 | /** @var randomquote\Helper $helper */ |
||
| 53 | /** @var randomquote\Utility $utility */ |
||
| 54 | $helper = randomquote\Helper::getInstance(); |
||
| 55 | $utility = new randomquote\Utility(); |
||
| 56 | // $configurator = new randomquote\common\Configurator(); |
||
| 57 | |||
| 58 | // Load language files |
||
| 59 | $helper->loadLanguage('admin'); |
||
| 60 | $helper->loadLanguage('common'); |
||
| 61 | $success = true; |
||
| 62 | |||
| 63 | //------------------------------------------------------------------ |
||
| 64 | // Remove uploads folder (and all subfolders) if they exist |
||
| 65 | //------------------------------------------------------------------ |
||
| 66 | /* |
||
| 67 | $old_directories = [$GLOBALS['xoops']->path("uploads/{$moduleDirName}")]; |
||
| 68 | foreach ($old_directories as $old_dir) { |
||
| 69 | $dirInfo = new SplFileInfo($old_dir); |
||
| 70 | if ($dirInfo->isDir()) { |
||
| 71 | // The directory exists so delete it |
||
| 72 | if (false === $utility::rrmdir($old_dir)) { |
||
| 73 | $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_DEL_PATH'), $old_dir)); |
||
| 74 | $success = false; |
||
| 75 | } |
||
| 76 | } |
||
| 77 | unset($dirInfo); |
||
| 78 | } |
||
| 79 | */ |
||
| 80 | |||
| 81 | /* |
||
| 82 | //------------ START ---------------- |
||
| 83 | //------------------------------------------------------------------ |
||
| 84 | // Remove xsitemap.xml from XOOPS root folder if it exists |
||
| 85 | //------------------------------------------------------------------ |
||
| 86 | $xmlfile = $GLOBALS['xoops']->path('xsitemap.xml'); |
||
| 87 | if (is_file($xmlfile)) { |
||
| 88 | if (false === ($delOk = unlink($xmlfile))) { |
||
| 89 | $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_REMOVE'), $xmlfile)); |
||
| 90 | } |
||
| 91 | } |
||
| 92 | // return $success && $delOk; // use this if you're using this routine |
||
| 93 | */ |
||
| 94 | |||
| 95 | return $success; |
||
| 96 | //------------ END ---------------- |
||
| 97 | } |
||
| 98 |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: