mambax7 /
randomquote
| Conditions | 7 |
| Paths | 8 |
| Total Lines | 61 |
| Lines | 21 |
| Ratio | 34.43 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | function xoops_module_install_randomquote(\XoopsModule $module) |
||
| 63 | { |
||
| 64 | include __DIR__ . '/../preloads/autoloader.php'; |
||
| 65 | |||
| 66 | $moduleDirName = basename(dirname(__DIR__)); |
||
| 67 | |||
| 68 | /** @var randomquote\Helper $helper */ |
||
| 69 | /** @var randomquote\Utility $utility */ |
||
| 70 | /** @var common\Configurator $configurator */ |
||
| 71 | $helper = randomquote\Helper::getInstance(); |
||
| 72 | $utility = new randomquote\Utility(); |
||
| 73 | $configurator = new common\Configurator(); |
||
| 74 | |||
| 75 | // Load language files |
||
| 76 | $helper->loadLanguage('admin'); |
||
| 77 | $helper->loadLanguage('modinfo'); |
||
| 78 | |||
| 79 | // default Permission Settings ---------------------- |
||
| 80 | $moduleId = $module->getVar('mid'); |
||
| 81 | $moduleId2 = $helper->getModule()->mid(); |
||
| 82 | //$moduleName = $module->getVar('name'); |
||
| 83 | $gpermHandler = xoops_getHandler('groupperm'); |
||
| 84 | // access rights ------------------------------------------ |
||
| 85 | $gpermHandler->addRight($moduleDirName . '_approve', 1, XOOPS_GROUP_ADMIN, $moduleId); |
||
| 86 | $gpermHandler->addRight($moduleDirName . '_submit', 1, XOOPS_GROUP_ADMIN, $moduleId); |
||
| 87 | $gpermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_ADMIN, $moduleId); |
||
| 88 | $gpermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_USERS, $moduleId); |
||
| 89 | $gpermHandler->addRight($moduleDirName . '_view', 1, XOOPS_GROUP_ANONYMOUS, $moduleId); |
||
| 90 | |||
| 91 | // --- CREATE FOLDERS --------------- |
||
| 92 | View Code Duplication | if (count($configurator->uploadFolders) > 0) { |
|
| 93 | // foreach (array_keys($GLOBALS['uploadFolders']) as $i) { |
||
| 94 | foreach (array_keys($configurator->uploadFolders) as $i) { |
||
| 95 | $utility::createFolder($configurator->uploadFolders[$i]); |
||
| 96 | } |
||
| 97 | } |
||
| 98 | // --- COPY blank.png FILES --------------- |
||
| 99 | View Code Duplication | if (count($configurator->copyBlankFiles) > 0) { |
|
| 100 | $file = __DIR__ . '/../assets/images/blank.png'; |
||
| 101 | foreach (array_keys($configurator->copyBlankFiles) as $i) { |
||
| 102 | $dest = $configurator->copyBlankFiles[$i] . '/blank.png'; |
||
| 103 | $utility::copyFile($file, $dest); |
||
| 104 | } |
||
| 105 | } |
||
| 106 | |||
| 107 | // --- COPY test folder files --------------- |
||
| 108 | View Code Duplication | if (count($configurator->copyTestFolders) > 0) { |
|
| 109 | // $file = __DIR__ . '/../testdata/images/'; |
||
| 110 | foreach (array_keys($configurator->copyTestFolders) as $i) { |
||
| 111 | $src = $configurator->copyTestFolders[$i][0]; |
||
| 112 | $dest = $configurator->copyTestFolders[$i][1]; |
||
| 113 | $utility::xcopy($src, $dest); |
||
| 114 | } |
||
| 115 | } |
||
| 116 | |||
| 117 | //delete .html entries from the tpl table |
||
| 118 | $sql = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('tplfile') . " WHERE `tpl_module` = '" . $module->getVar('dirname', 'n') . "' AND `tpl_file` LIKE '%.html%'"; |
||
| 119 | $GLOBALS['xoopsDB']->queryF($sql); |
||
| 120 | |||
| 121 | return true; |
||
| 122 | } |
||
| 123 |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: