admin/item.php ➔ publisher_editItem()

Complexity

Conditions	15
Paths	342

Size

Total Lines	160
Code Lines	112

Duplication

Lines	24
Ratio	15 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function publisher_editItem($showmenu = false, $itemid = 0, $clone = false)

The parameter $showmenu is not used and could be removed.

{
    $publisher = PublisherPublisher::getInstance();
    global $publisherCurrentPage;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    xoops_load('XoopsFormLoader');

    $formTpl = new XoopsTpl();
    //publisher_submit.html

    // if there is a parameter, and the id exists, retrieve data: we're editing a item

    if ($itemid != 0) {
        // Creating the ITEM object
        $itemObj = $publisher->getHandler('item')->get($itemid);

        if (!$itemObj) {
            redirect_header('item.php', 1, _AM_PUBLISHER_NOITEMSELECTED);
            //            exit();
        }

        if ($clone) {
            $itemObj->setNew();
            $itemObj->setVar('itemid', 0);
            $itemObj->setVar('status', PublisherConstants::PUBLISHER_STATUS_NOTSET);
            $itemObj->setVar('datesub', time());
        }

        switch ($itemObj->status()) {
            case PublisherConstants::PUBLISHER_STATUS_SUBMITTED:
                $breadcrumbAction1 = _CO_PUBLISHER_SUBMITTED;

$breadcrumbAction1 is not used, you could remove the assignment.

                $breadcrumbAction2 = _AM_PUBLISHER_APPROVING;

$breadcrumbAction2 is not used, you could remove the assignment.

                $pageTitle         = _AM_PUBLISHER_SUBMITTED_TITLE;
                $pageInfo          = _AM_PUBLISHER_SUBMITTED_INFO;
                $buttonCaption     = _AM_PUBLISHER_APPROVE;

$buttonCaption is not used, you could remove the assignment.

                $newStatus         = PublisherConstants::PUBLISHER_STATUS_PUBLISHED;

$newStatus is not used, you could remove the assignment.

                break;

            case PublisherConstants::PUBLISHER_STATUS_PUBLISHED:

This code seems to be duplicated across your project.

                $breadcrumbAction1 = _CO_PUBLISHER_PUBLISHED;

$breadcrumbAction1 is not used, you could remove the assignment.

                $breadcrumbAction2 = _AM_PUBLISHER_EDITING;

$breadcrumbAction2 is not used, you could remove the assignment.

                $pageTitle         = _AM_PUBLISHER_PUBLISHEDEDITING;
                $pageInfo          = _AM_PUBLISHER_PUBLISHEDEDITING_INFO;
                $buttonCaption     = _AM_PUBLISHER_MODIFY;

$buttonCaption is not used, you could remove the assignment.

                $newStatus         = PublisherConstants::PUBLISHER_STATUS_PUBLISHED;

$newStatus is not used, you could remove the assignment.

                break;

            case PublisherConstants::PUBLISHER_STATUS_OFFLINE:
                $breadcrumbAction1 = _CO_PUBLISHER_OFFLINE;

$breadcrumbAction1 is not used, you could remove the assignment.

                $breadcrumbAction2 = _AM_PUBLISHER_EDITING;

$breadcrumbAction2 is not used, you could remove the assignment.

                $pageTitle         = _AM_PUBLISHER_OFFLINEEDITING;
                $pageInfo          = _AM_PUBLISHER_OFFLINEEDITING_INFO;
                $buttonCaption     = _AM_PUBLISHER_MODIFY;

$buttonCaption is not used, you could remove the assignment.

                $newStatus         = PublisherConstants::PUBLISHER_STATUS_OFFLINE;

$newStatus is not used, you could remove the assignment.

                break;

            case PublisherConstants::PUBLISHER_STATUS_REJECTED:
                $breadcrumbAction1 = _CO_PUBLISHER_REJECTED;

$breadcrumbAction1 is not used, you could remove the assignment.

                $breadcrumbAction2 = _AM_PUBLISHER_REJECTED;

$breadcrumbAction2 is not used, you could remove the assignment.

                $pageTitle         = _AM_PUBLISHER_REJECTED_EDIT;
                $pageInfo          = _AM_PUBLISHER_REJECTED_EDIT_INFO;
                $buttonCaption     = _AM_PUBLISHER_MODIFY;

$buttonCaption is not used, you could remove the assignment.

                $newStatus         = PublisherConstants::PUBLISHER_STATUS_REJECTED;

$newStatus is not used, you could remove the assignment.

                break;

            case PublisherConstants::PUBLISHER_STATUS_NOTSET: // Then it's a clone...
                $breadcrumbAction1 = _AM_PUBLISHER_ITEMS;

$breadcrumbAction1 is not used, you could remove the assignment.

                $breadcrumbAction2 = _AM_PUBLISHER_CLONE_NEW;

$breadcrumbAction2 is not used, you could remove the assignment.

                $buttonCaption     = _AM_PUBLISHER_CREATE;

$buttonCaption is not used, you could remove the assignment.

                $newStatus         = PublisherConstants::PUBLISHER_STATUS_PUBLISHED;

$newStatus is not used, you could remove the assignment.

                $pageTitle         = _AM_PUBLISHER_ITEM_DUPLICATING;
                $pageInfo          = _AM_PUBLISHER_ITEM_DUPLICATING_DSC;
                break;

            case 'default':
            default:

This code seems to be duplicated across your project.

                $breadcrumbAction1 = _AM_PUBLISHER_ITEMS;

$breadcrumbAction1 is not used, you could remove the assignment.

                $breadcrumbAction2 = _AM_PUBLISHER_EDITING;

$breadcrumbAction2 is not used, you could remove the assignment.

                $pageTitle         = _AM_PUBLISHER_PUBLISHEDEDITING;
                $pageInfo          = _AM_PUBLISHER_PUBLISHEDEDITING_INFO;
                $buttonCaption     = _AM_PUBLISHER_MODIFY;

$buttonCaption is not used, you could remove the assignment.

                $newStatus         = PublisherConstants::PUBLISHER_STATUS_PUBLISHED;

$newStatus is not used, you could remove the assignment.

                break;
        }

        $categoryObj = $itemObj->getCategory();

$categoryObj is not used, you could remove the assignment.

        echo "<br>\n";
        publisherOpenCollapsableBar('edititemtable', 'edititemicon', $pageTitle, $pageInfo);

        if ($clone) {
            echo "<form><div style=\"margin-bottom: 10px;\">";
            echo "<input type='button' name='button' onclick=\"location='item.php?op=clone&itemid=" . $itemObj->itemid() . "'\" value='" . _AM_PUBLISHER_CLONE_ITEM . "'>&nbsp;&nbsp;";
            echo '</div></form>';
        }
    } else {
        // there's no parameter, so we're adding an item

        $itemObj = $publisher->getHandler('item')->create();
        $itemObj->setVarsFromRequest();

        $categoryObj       = $publisher->getHandler('category')->create();
        $breadcrumbAction1 = _AM_PUBLISHER_ITEMS;

$breadcrumbAction1 is not used, you could remove the assignment.

        $breadcrumbAction2 = _AM_PUBLISHER_CREATINGNEW;

$breadcrumbAction2 is not used, you could remove the assignment.

        $buttonCaption     = _AM_PUBLISHER_CREATE;

$buttonCaption is not used, you could remove the assignment.

        $newStatus         = PublisherConstants::PUBLISHER_STATUS_PUBLISHED;

$newStatus is not used, you could remove the assignment.

        $categoryObj->setVar('categoryid', XoopsRequest::getInt('categoryid', 0, 'GET'));

        publisherOpenCollapsableBar('createitemtable', 'createitemicon', _AM_PUBLISHER_ITEM_CREATING, _AM_PUBLISHER_ITEM_CREATING_DSC);
    }

    $sform = $itemObj->getForm(_AM_PUBLISHER_ITEMS);

    $sform->assign($formTpl);
    $formTpl->display('db:publisher_submit.tpl');

    publisherCloseCollapsableBar('edititemtable', 'edititemicon');

    publisherOpenCollapsableBar('pagewraptable', 'pagewrapicon', _AM_PUBLISHER_PAGEWRAP, _AM_PUBLISHER_PAGEWRAPDSC);

    $dir = publisherGetUploadDir(true, 'content');

'content' is of type string, but the function expects a boolean.

    if (false !== strpos(decoct(fileperms($dir)), '755')) {

This code seems to be duplicated across your project.

        echo "<span style='color:#ff0000;'><h4>" . _AM_PUBLISHER_PERMERROR . '</h4></span>';
    }

    // Upload File
    echo "<form name='form_name2' id='form_name2' action='pw_upload_file.php' method='post' enctype='multipart/form-data'>";
    echo "<table cellspacing='1' width='100%' class='outer'>";
    echo "<tr><th colspan='2'>" . _AM_PUBLISHER_UPLOAD_FILE . '</th></tr>';
    echo "<tr valign='top' align='left'><td class='head'>" . _AM_PUBLISHER_SEARCH_PW . "</td><td class='even'><input type='file' name='fileupload' id='fileupload' size='30' /></td></tr>";
    echo "<tr valign='top' align='left'><td class='head'><input type='hidden' name='MAX_FILE_SIZE' id='op' value='500000' /></td><td class='even'><input type='submit' name='submit' value='" . _AM_PUBLISHER_UPLOAD . "' /></td></tr>";
    echo "<input type='hidden' name='backto' value='$publisherCurrentPage'/>";
    echo '</table>';
    echo '</form>';

    // Delete File
    $form = new XoopsThemeForm(_CO_PUBLISHER_DELETEFILE, 'form_name', 'pw_delete_file.php');

    $pWrapSelect = new XoopsFormSelect(publisherGetUploadDir(true, 'content'), 'address');

'content' is of type string, but the function expects a boolean.

    $folder      = dir($dir);
    while (($file = $folder->read()) !== false) {

This code seems to be duplicated across your project.

        if ($file !== '.' && $file !== '..') {
            $pWrapSelect->addOption($file, $file);
        }
    }
    $folder->close();
    $form->addElement($pWrapSelect);

    $delfile = 'delfile';
    $form->addElement(new XoopsFormHidden('op', $delfile));
    $submit = new XoopsFormButton('', 'submit', _AM_PUBLISHER_BUTTON_DELETE, 'submit');
    $form->addElement($submit);

    $form->addElement(new XoopsFormHidden('backto', $publisherCurrentPage));
    $form->display();

    publisherCloseCollapsableBar('pagewraptable', 'pagewrapicon');
}