TrelloManagement - Code Metrics - Inspection of "Merge pull request #15 from mambax7/imgbot" - mambax7/publisher - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (1b1cd9)

by Michael

created 2020-12-21 12:14 UTC

TrelloManagement A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	18
c	2
b	0
f	0
dl	0
loc	53
rs	10
wmc	4

4 Methods

Rating	Name	Size	Complexity
A	getProjectTaskByStatus()	8	1
A	getAllStatus()	8	1
A	__construct()	3	1
A	editTaskStatus()	8	1

<?php declare(strict_types=1);

namespace XoopsModules\Publisher;

use XoopsModules\Publisher\Helper;

/**
 * Class TrelloManagement
 */
class TrelloManagement
{
    private $xoopsDb;

    /**
     * TrelloManagement constructor.
     * @param $xoopsDb
     */
    public function __construct($xoopsDb)
    {
        $this->xoopsDb = $xoopsDb;
    }

    /**
     * @param $statusId
     * @param $itemId
     * @return mixed
     */
    public function getProjectTaskByStatus($statusId, $itemId)
    {
        $helper   = Helper::getInstance();
        $dbHandle = new TrelloDBController($this->xoopsDb);
        $query    = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix($helper->getDirname() . '_items') . 'WHERE status= ? AND itemid = ?';
        $result   = $dbHandle->runQuery($query, 'ii', [$statusId, $itemId]);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        return $result;
    }

    /**
     * @return mixed
     */
    public function getAllStatus()
    {
        $helper   = Helper::getInstance();
        $dbHandle = new TrelloDBController($this->xoopsDb);
        $query    = 'SELECT itemid, title, status FROM ' . $GLOBALS['xoopsDB']->prefix($helper->getDirname() . '_items');
        $result   = $dbHandle->runBaseQuery($query);

        return $result;
    }

    /**
     * @param $statusId
     * @param $itemId
     */
    public function editTaskStatus($statusId, $itemId)
    {
        $helper   = Helper::getInstance();
        $dbHandle = new TrelloDBController($this->xoopsDb);
        $query    = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix($helper->getDirname() . '_items') . ' SET status = ? WHERE itemid = ?';
        $result   = $dbHandle->update($query, 'ii', [$statusId, $itemId]);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        return $result;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace XoopsModules\Publisher;
4
5			use XoopsModules\Publisher\Helper;
6
7			/**
8			* Class TrelloManagement
9			*/
10			class TrelloManagement
11			{
12			private $xoopsDb;
13
14			/**
15			* TrelloManagement constructor.
16			* @param $xoopsDb
17			*/
18			public function __construct($xoopsDb)
19			{
20			$this->xoopsDb = $xoopsDb;
21			}
22
23			/**
24			* @param $statusId
25			* @param $itemId
26			* @return mixed
27			*/
28			public function getProjectTaskByStatus($statusId, $itemId)
29			{
30			$helper = Helper::getInstance();
31			$dbHandle = new TrelloDBController($this->xoopsDb);
32			$query = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix($helper->getDirname() . '_items') . 'WHERE status= ? AND itemid = ?';
33			$result = $dbHandle->runQuery($query, 'ii', [$statusId, $itemId]);
			0 ignored issues – show Bug introduced 2020-07-13 01:16 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$dbHandle->runQuery($que...ay($statusId, $itemId))` targeting `XoopsModules\Publisher\T...BController::runQuery()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
34
35			return $result;
36			}
37
38			/**
39			* @return mixed
40			*/
41			public function getAllStatus()
42			{
43			$helper = Helper::getInstance();
44			$dbHandle = new TrelloDBController($this->xoopsDb);
45			$query = 'SELECT itemid, title, status FROM ' . $GLOBALS['xoopsDB']->prefix($helper->getDirname() . '_items');
46			$result = $dbHandle->runBaseQuery($query);
47
48			return $result;
49			}
50
51			/**
52			* @param $statusId
53			* @param $itemId
54			*/
55			public function editTaskStatus($statusId, $itemId)
56			{
57			$helper = Helper::getInstance();
58			$dbHandle = new TrelloDBController($this->xoopsDb);
59			$query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix($helper->getDirname() . '_items') . ' SET status = ? WHERE itemid = ?';
60			$result = $dbHandle->update($query, 'ii', [$statusId, $itemId]);
			0 ignored issues – show Bug introduced 2020-07-13 01:16 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$dbHandle->update($query...ay($statusId, $itemId))` targeting `XoopsModules\Publisher\T...oDBController::update()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
61
62			return $result;
63			}
64			}
65

mambax7 / publisher

Branch — master (1b1cd9)

TrelloManagement A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like