PublisherMetagen::generateSeoTitle() - Code Metrics - Inspection of "cleanup" - mambax7/publisher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 16270d...f28230 )

by Michael

created 2016-05-29 17:21 UTC

PublisherMetagen::generateSeoTitle() A

↳ Parent: PublisherMetagen

Complexity

Conditions	3
Paths	3

Size

Total Lines	57
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	8
Bugs	0	Features	0

Metric	Value
cc	3
eloc	44
c	8
b	0
f	0
nc	3
nop	2
dl	0
loc	57
rs	9.6818

How to fix Long Method

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */
/**
 * @copyright       The XUUPS Project http://sourceforge.net/projects/xuups/
 * @license         http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package         Publisher
 * @since           1.0
 * @author          trabis <[email protected]>
 * @author          The SmartFactory <www.smartfactory.ca>
 */
// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');


include_once dirname(__DIR__) . '/include/common.php';

/**
 * Class PublisherMetagen
 */
class PublisherMetagen
namespace YourVendor;

class YourClass { }
{
    /**
     * @var PublisherPublisher
     * @access public
     */
    public $publisher;

    /**
     * @var MyTextSanitizer
     */
    public $myts;

    /**
     * @var string
     */
    public $title;

    /**
     * @var string
     */
    public $originalTitle;

    /**
     * @var string
     */
    public $keywords;

    /**
     * @var string
     */
    public $categoryPath;

    /**
     * @var string
     */
    public $description;

    /**
     * @var int
     *
     */
    public $minChar = 4;

    /**
     * @param string $title
     * @param string $keywords
     * @param string $description
     * @param string $categoryPath
     */
    public function __construct($title, $keywords = '', $description = '', $categoryPath = '')
    {
        $this->publisher = PublisherPublisher::getInstance();
        $this->myts      = MyTextSanitizer::getInstance();
        $this->setCategoryPath($categoryPath);
        $this->setTitle($title);
        $this->setDescription($description);
        if ($keywords == '') {
            $keywords = $this->createMetaKeywords();
        }
        $this->setKeywords($keywords);
    }

    /**
     * @param string $title
     */
    public function setTitle($title)
    {
        $this->title         = $this->html2text($title);
        $this->originalTitle = $this->title;
        $titleTag            = array();
        $titleTag['module']  = $this->publisher->getModule()->getVar('name');

        if (isset($this->title) && ($this->title != '') && (strtoupper($this->title) != strtoupper($titleTag['module']))) {
            $titleTag['title'] = $this->title;
        }
        if (isset($this->categoryPath) && ($this->categoryPath != '')) {
            $titleTag['category'] = $this->categoryPath;
        }
        $ret = isset($titleTag['title']) ? $titleTag['title'] : '';
        if (isset($titleTag['category']) && $titleTag['category'] != '') {

            if ($ret != '') {
                $ret .= ' - ';
            }
            $ret .= $titleTag['category'];
        }
        if (isset($titleTag['module']) && $titleTag['module'] != '') {

            if ($ret != '') {
                $ret .= ' - ';
            }
            $ret .= $titleTag['module'];
        }
        $this->title = $ret;
    }

    /**
     * @param string $keywords
     */
    public function setKeywords($keywords)
    {
        $this->keywords = $keywords;
    }

    /**
     * @param string $categoryPath
     */
    public function setCategoryPath($categoryPath)
    {
        $categoryPath       = $this->html2text($categoryPath);
        $this->categoryPath = $categoryPath;
    }

    /**
     * @param string $description
     */
    public function setDescription($description)
    {
        $description       = $this->html2text($description);
        $description       = $this->purifyText($description);
        $this->description = $description;
    }

    /**
     * Does nothing
     */
    public function createTitleTag()
    {
    }

    /**
     * @param int $maxWords
     *
     * @return string
     */
    public function createMetaDescription($maxWords = 30)

    {
        $description = $this->purifyText($this->description);
        $description = $this->html2text($description);
        $words       = explode(' ', $description);
        $ret         = '';
        $i           = 1;
        $wordCount   = count($words);
        foreach ($words as $word) {
            $ret .= $word;
            if ($i < $wordCount) {
                $ret .= ' ';
            }
            ++$i;
        }

        return $ret;
    }

    /**
     * @param string $text
     * @param int    $minChar
     *
     * @return array
     */
    public function findMetaKeywords($text, $minChar)
    {
        $keywords         = array();
        $text             = $this->purifyText($text);
        $text             = $this->html2text($text);
        $originalKeywords = explode(' ', $text);
        foreach ($originalKeywords as $originalKeyword) {
            $secondRoundKeywords = explode("'", $originalKeyword);
            foreach ($secondRoundKeywords as $secondRoundKeyword) {
                if (strlen($secondRoundKeyword) >= $minChar) {
                    if (!in_array($secondRoundKeyword, $keywords)) {
                        $keywords[] = trim($secondRoundKeyword);
                    }
                }
            }
        }

        return $keywords;
    }

    /**
     * @return string
     */
    public function createMetaKeywords()
    {
        $keywords       = $this->findMetaKeywords($this->originalTitle . ' ' . $this->description, $this->minChar);
        $moduleKeywords = $this->publisher->getConfig('seo_meta_keywords');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if ($moduleKeywords != '') {
            $moduleKeywords = explode(',', $moduleKeywords);
            $keywords       = array_merge($keywords, array_map('trim', $moduleKeywords));
        }
        $ret = implode(',', $keywords);

        return $ret;
    }

    /**
     * Does nothing
     */
    public function autoBuildMetaKeywords()
    {
    }

    /**
     * Build Metatags
     */
    public function buildAutoMetaTags()
    {
        $this->keywords    = $this->createMetaKeywords();
        $this->description = $this->createMetaDescription();
        //$this->title = $this->createTitleTag();

    }

    /**
     * Creates meta tags
     */
    public function createMetaTags()
    {
        global $xoopsTpl, $xoTheme;
function myFunction($a, $b) {
    // Do something
}
        if ($this->keywords != '') {
            $xoTheme->addMeta('meta', 'keywords', $this->keywords);
        }
        if ($this->description != '') {
            $xoTheme->addMeta('meta', 'description', $this->description);
        }
        if ($this->title != '') {
            $xoopsTpl->assign('xoops_pagetitle', $this->title);
        }
    }

    /**
     * Return true if the string is length > 0
     *
     * @credit psylove
     * @var    string $string Chaine de caractère
     * @return boolean
     */
    public function emptyString($var)
    {
        return (strlen($var) > 0);
    }

    /**
     * Create a title for the short_url field of an article
     *
     * @credit psylove
     *
     * @param string $title   title of the article
     * @param bool   $withExt do we add an html extension or not
     *
     * @return string short url for article
     */
    public static function generateSeoTitle($title = '', $withExt = true)
    {
        // Transformation de la chaine en minuscule
        // Codage de la chaine afin d'éviter les erreurs 500 en cas de caractères imprévus
        $title = rawurlencode(strtolower($title));
        // Transformation des ponctuations
                                                 
        $pattern = array(
            '/%09/', // Tab
            '/%20/', // Space
            '/%21/', // !
            '/%22/', // "
            '/%23/', // #
            '/%25/', // %
            '/%26/', // &
            '/%27/', // '
            '/%28/', // (
            '/%29/', // )
            '/%2C/', // ,
            '/%2F/', // /
            '/%3A/', // :
            '/%3B/', // ;
            '/%3C/', // <
            '/%3D/', // =
            '/%3E/', // >
            '/%3F/', // ?
            '/%40/', // @
            '/%5B/', // [
            '/%5C/', // \
            '/%5D/', // ]
            '/%5E/', // ^
            '/%7B/', // {
            '/%7C/', // |
            '/%7D/', // }
            '/%7E/', // ~
            "/\./" // .
        );
        $repPat  = array('-', '-', '-', '-', '-', '-100', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-at-', '-', '-', '-', '-', '-', '-', '-', '-', '-');
        $title   = preg_replace($pattern, $repPat, $title);
        // Transformation des caractères accentués
        //                  °        è        é        ê        ë        ç        à        â        ä        î        ï        ù        ü        û        ô        ö
        $pattern = array('/%B0/', '/%E8/', '/%E9/', '/%EA/', '/%EB/', '/%E7/', '/%E0/', '/%E2/', '/%E4/', '/%EE/', '/%EF/', '/%F9/', '/%FC/', '/%FB/', '/%F4/', '/%F6/');
        $repPat  = array('-', 'e', 'e', 'e', 'e', 'c', 'a', 'a', 'a', 'i', 'i', 'u', 'u', 'u', 'o', 'o');
        $title   = preg_replace($pattern, $repPat, $title);
        $tableau = explode('-', $title); // Transforme la chaine de caractères en tableau
        $tableau = array_filter($tableau, array('PublisherMetagen', 'emptyString')); // Supprime les chaines vides du tableau
        $title   = implode('-', $tableau); // Transforme un tableau en chaine de caractères séparé par un tiret
        if (count($title) > 0) {
            if ($withExt) {
                $title .= '.html';
            }

            return $title;
        }

        return '';
    }

    /**
     * @param      $text
     * @param bool $keyword
     *
     * @return mixed
     */
    public function purifyText($text, $keyword = false)
    {
        //        $text = str_replace(['&nbsp;', ' '], ['<br>', ' '], $text); //for php 5.4

        $text = str_replace('&nbsp;', ' ', $text);
        $text = str_replace('<br>', ' ', $text);
        $text = strip_tags($text);
        $text = html_entity_decode($text);
        $text = $this->myts->undoHtmlSpecialChars($text);

        $text = str_replace(')', ' ', $text);
        $text = str_replace('(', ' ', $text);
        $text = str_replace(':', ' ', $text);
        $text = str_replace('&euro', ' euro ', $text);
        $text = str_replace('&hellip', '...', $text);
        $text = str_replace('&rsquo', ' ', $text);
        $text = str_replace('!', ' ', $text);
        $text = str_replace('?', ' ', $text);
        $text = str_replace('"', ' ', $text);
        $text = str_replace('-', ' ', $text);
        $text = str_replace('\n', ' ', $text);

        //        $text = str_replace([')','(',':','&euro','&hellip','&rsquo','!','?','"','-','\n'], [' ' , ' ',  ' ',  ' euro ',  '...',  ' ', ' ', ' ',  ' ', ' ',  ' '], $text); //for PHP 5.4


        if ($keyword) {
            $text = str_replace('.', ' ', $text);
            $text = str_replace(',', ' ', $text);
            $text = str_replace('\'', ' ', $text);
            //            $text = str_replace(['.', ' '], [',', ' '], ['\'', ' '], $text); //for PHP 5.4
        }
        $text = str_replace(';', ' ', $text);

        return $text;
    }

    /**
     * @param string $document
     *
     * @return mixed

     */
    public function html2text($document)

    {
        // PHP Manual:: function preg_replace
        // $document should contain an HTML document.
        // This will remove HTML tags, javascript sections
        // and white space. It will also convert some
        // common HTML entities to their text equivalent.
        // Credits : newbb2
        $search = array(
            "'<script[^>]*?>.*?</script>'si", // Strip out javascript<?php
            "'<img.*?/>'si", // Strip out img tags
            "'<[\/\!]*?[^<>]*?>'si", // Strip out HTML tags<?php
            "'([\r\n])[\s]+'", // Strip out white space
            "'&(quot|#34);'i", // Replace HTML entities
            "'&(amp|#38);'i",
            "'&(lt|#60);'i",
            "'&(gt|#62);'i",
            "'&(nbsp|#160);'i",
            "'&(iexcl|#161);'i",
            "'&(cent|#162);'i",
            "'&(pound|#163);'i",
            "'&(copy|#169);'i",//"'&#(\d+);'e"
        );
        // evaluate as php
        $replace = array(
            '',
            '',
            '',
            "\\1",
            "\"",
            '&',
            '<',
            '>',
            ' ',
            chr(161),
            chr(162),
            chr(163),
            chr(169),//"chr(\\1)"
        );
        $text    = preg_replace($search, $replace, $document);

        return $text;
    }
}


Push — master ( 16270d...f28230 )

PublisherMetagen::generateSeoTitle() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-19 04:57 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 26 and the first side effect is on line 21. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11		/**
12		* @copyright The XUUPS Project http://sourceforge.net/projects/xuups/
13		* @license http://www.fsf.org/copyleft/gpl.html GNU public license
14		* @package Publisher
15		* @since 1.0
16		* @author trabis <[email protected]>
17		* @author The SmartFactory <www.smartfactory.ca>
18		*/
19		// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-19 04:57 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20
21		include_once dirname(__DIR__) . '/include/common.php';
22
23		/**
24		* Class PublisherMetagen
25		*/
26		class PublisherMetagen
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 06:40 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
27		{
28		/**
29		* @var PublisherPublisher
30		* @access public
31		*/
32		public $publisher;
33
34		/**
35		* @var MyTextSanitizer
36		*/
37		public $myts;
38
39		/**
40		* @var string
41		*/
42		public $title;
43
44		/**
45		* @var string
46		*/
47		public $originalTitle;
48
49		/**
50		* @var string
51		*/
52		public $keywords;
53
54		/**
55		* @var string
56		*/
57		public $categoryPath;
58
59		/**
60		* @var string
61		*/
62		public $description;
63
64		/**
65		* @var int
66		*
67		*/
68		public $minChar = 4;
69
70		/**
71		* @param string $title
72		* @param string $keywords
73		* @param string $description
74		* @param string $categoryPath
75		*/
76		public function __construct($title, $keywords = '', $description = '', $categoryPath = '')
77		{
78		$this->publisher = PublisherPublisher::getInstance();
79		$this->myts = MyTextSanitizer::getInstance();
80		$this->setCategoryPath($categoryPath);
81		$this->setTitle($title);
82		$this->setDescription($description);
83		if ($keywords == '') {
84		$keywords = $this->createMetaKeywords();
85		}
86		$this->setKeywords($keywords);
87		}
88
89		/**
90		* @param string $title
91		*/
92		public function setTitle($title)
93		{
94		$this->title = $this->html2text($title);
95		$this->originalTitle = $this->title;
96		$titleTag = array();
97		$titleTag['module'] = $this->publisher->getModule()->getVar('name');
		0 ignored issues – show Bug introduced 2015-12-25 06:35 UTC by Report Bug Copy Issue Report The method `getVar` cannot be called on `$this->publisher->getModule()` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
98		if (isset($this->title) && ($this->title != '') && (strtoupper($this->title) != strtoupper($titleTag['module']))) {
99		$titleTag['title'] = $this->title;
100		}
101		if (isset($this->categoryPath) && ($this->categoryPath != '')) {
102		$titleTag['category'] = $this->categoryPath;
103		}
104		$ret = isset($titleTag['title']) ? $titleTag['title'] : '';
105	View Code Duplication	if (isset($titleTag['category']) && $titleTag['category'] != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 06:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		if ($ret != '') {
107		$ret .= ' - ';
108		}
109		$ret .= $titleTag['category'];
110		}
111	View Code Duplication	if (isset($titleTag['module']) && $titleTag['module'] != '') {
		0 ignored issues – show Duplication introduced 2016-01-18 06:40 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		if ($ret != '') {
113		$ret .= ' - ';
114		}
115		$ret .= $titleTag['module'];
116		}
117		$this->title = $ret;
118		}
119
120		/**
121		* @param string $keywords
122		*/
123		public function setKeywords($keywords)
124		{
125		$this->keywords = $keywords;
126		}
127
128		/**
129		* @param string $categoryPath
130		*/
131		public function setCategoryPath($categoryPath)
132		{
133		$categoryPath = $this->html2text($categoryPath);
134		$this->categoryPath = $categoryPath;
135		}
136
137		/**
138		* @param string $description
139		*/
140		public function setDescription($description)
141		{
142		$description = $this->html2text($description);
143		$description = $this->purifyText($description);
144		$this->description = $description;
145		}
146
147		/**
148		* Does nothing
149		*/
150		public function createTitleTag()
151		{
152		}
153
154		/**
155		* @param int $maxWords
156		*
157		* @return string
158		*/
159		public function createMetaDescription($maxWords = 30)
		0 ignored issues – show Unused Code introduced 2015-12-25 06:35 UTC by Report Bug Copy Issue Report The parameter `$maxWords` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
160		{
161		$description = $this->purifyText($this->description);
162		$description = $this->html2text($description);
163		$words = explode(' ', $description);
164		$ret = '';
165		$i = 1;
166		$wordCount = count($words);
167		foreach ($words as $word) {
168		$ret .= $word;
169		if ($i < $wordCount) {
170		$ret .= ' ';
171		}
172		++$i;
173		}
174
175		return $ret;
176		}
177
178		/**
179		* @param string $text
180		* @param int $minChar
181		*
182		* @return array
183		*/
184		public function findMetaKeywords($text, $minChar)
185		{
186		$keywords = array();
187		$text = $this->purifyText($text);
188		$text = $this->html2text($text);
189		$originalKeywords = explode(' ', $text);
190		foreach ($originalKeywords as $originalKeyword) {
191		$secondRoundKeywords = explode("'", $originalKeyword);
192		foreach ($secondRoundKeywords as $secondRoundKeyword) {
193		if (strlen($secondRoundKeyword) >= $minChar) {
194		if (!in_array($secondRoundKeyword, $keywords)) {
195		$keywords[] = trim($secondRoundKeyword);
196		}
197		}
198		}
199		}
200
201		return $keywords;
202		}
203
204		/**
205		* @return string
206		*/
207		public function createMetaKeywords()
208		{
209		$keywords = $this->findMetaKeywords($this->originalTitle . ' ' . $this->description, $this->minChar);
210		$moduleKeywords = $this->publisher->getConfig('seo_meta_keywords');
		0 ignored issues – show Bug introduced 2015-12-25 06:35 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$moduleKeywords` is correct as `$this->publisher->getConfig('seo_meta_keywords')` (which targets `PublisherPublisher::getConfig()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
211		if ($moduleKeywords != '') {
212		$moduleKeywords = explode(',', $moduleKeywords);
213		$keywords = array_merge($keywords, array_map('trim', $moduleKeywords));
214		}
215		$ret = implode(',', $keywords);
216
217		return $ret;
218		}
219
220		/**
221		* Does nothing
222		*/
223		public function autoBuildMetaKeywords()
224		{
225		}
226
227		/**
228		* Build Metatags
229		*/
230		public function buildAutoMetaTags()
231		{
232		$this->keywords = $this->createMetaKeywords();
233		$this->description = $this->createMetaDescription();
234		//$this->title = $this->createTitleTag();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-19 04:57 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
235		}
236
237		/**
238		* Creates meta tags
239		*/
240		public function createMetaTags()
241		{
242		global $xoopsTpl, $xoTheme;
		0 ignored issues – show Compatibility Best Practice introduced 2015-12-25 06:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
243		if ($this->keywords != '') {
244		$xoTheme->addMeta('meta', 'keywords', $this->keywords);
245		}
246		if ($this->description != '') {
247		$xoTheme->addMeta('meta', 'description', $this->description);
248		}
249		if ($this->title != '') {
250		$xoopsTpl->assign('xoops_pagetitle', $this->title);
251		}
252		}
253
254		/**
255		* Return true if the string is length > 0
256		*
257		* @credit psylove
258		* @var string $string Chaine de caractère
259		* @return boolean
260		*/
261		public function emptyString($var)
262		{
263		return (strlen($var) > 0);
264		}
265
266		/**
267		* Create a title for the short_url field of an article
268		*
269		* @credit psylove
270		*
271		* @param string $title title of the article
272		* @param bool $withExt do we add an html extension or not
273		*
274		* @return string short url for article
275		*/
276		public static function generateSeoTitle($title = '', $withExt = true)
277		{
278		// Transformation de la chaine en minuscule
279		// Codage de la chaine afin d'éviter les erreurs 500 en cas de caractères imprévus
280		$title = rawurlencode(strtolower($title));
281		// Transformation des ponctuations
282
283		$pattern = array(
284		'/%09/', // Tab
285		'/%20/', // Space
286		'/%21/', // !
287		'/%22/', // "
288		'/%23/', // #
289		'/%25/', // %
290		'/%26/', // &
291		'/%27/', // '
292		'/%28/', // (
293		'/%29/', // )
294		'/%2C/', // ,
295		'/%2F/', // /
296		'/%3A/', // :
297		'/%3B/', // ;
298		'/%3C/', // <
299		'/%3D/', // =
300		'/%3E/', // >
301		'/%3F/', // ?
302		'/%40/', // @
303		'/%5B/', // [
304		'/%5C/', // \
305		'/%5D/', // ]
306		'/%5E/', // ^
307		'/%7B/', // {
308		'/%7C/', // \|
309		'/%7D/', // }
310		'/%7E/', // ~
311		"/\./" // .
312		);
313		$repPat = array('-', '-', '-', '-', '-', '-100', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-', '-at-', '-', '-', '-', '-', '-', '-', '-', '-', '-');
314		$title = preg_replace($pattern, $repPat, $title);
315		// Transformation des caractères accentués
316		// ° è é ê ë ç à â ä î ï ù ü û ô ö
317		$pattern = array('/%B0/', '/%E8/', '/%E9/', '/%EA/', '/%EB/', '/%E7/', '/%E0/', '/%E2/', '/%E4/', '/%EE/', '/%EF/', '/%F9/', '/%FC/', '/%FB/', '/%F4/', '/%F6/');
318		$repPat = array('-', 'e', 'e', 'e', 'e', 'c', 'a', 'a', 'a', 'i', 'i', 'u', 'u', 'u', 'o', 'o');
319		$title = preg_replace($pattern, $repPat, $title);
320		$tableau = explode('-', $title); // Transforme la chaine de caractères en tableau
321		$tableau = array_filter($tableau, array('PublisherMetagen', 'emptyString')); // Supprime les chaines vides du tableau
322		$title = implode('-', $tableau); // Transforme un tableau en chaine de caractères séparé par un tiret
323		if (count($title) > 0) {
324		if ($withExt) {
325		$title .= '.html';
326		}
327
328		return $title;
329		}
330
331		return '';
332		}
333
334		/**
335		* @param $text
336		* @param bool $keyword
337		*
338		* @return mixed
339		*/
340		public function purifyText($text, $keyword = false)
341		{
342		// $text = str_replace([' ', ' '], ['<br>', ' '], $text); //for php 5.4
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-19 04:57 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
343		$text = str_replace(' ', ' ', $text);
344		$text = str_replace('<br>', ' ', $text);
345		$text = strip_tags($text);
346		$text = html_entity_decode($text);
347		$text = $this->myts->undoHtmlSpecialChars($text);
348
349		$text = str_replace(')', ' ', $text);
350		$text = str_replace('(', ' ', $text);
351		$text = str_replace(':', ' ', $text);
352		$text = str_replace('&euro', ' euro ', $text);
353		$text = str_replace('&hellip', '...', $text);
354		$text = str_replace('&rsquo', ' ', $text);
355		$text = str_replace('!', ' ', $text);
356		$text = str_replace('?', ' ', $text);
357		$text = str_replace('"', ' ', $text);
358		$text = str_replace('-', ' ', $text);
359		$text = str_replace('\n', ' ', $text);
360
361		// $text = str_replace([')','(',':','&euro','&hellip','&rsquo','!','?','"','-','\n'], [' ' , ' ', ' ', ' euro ', '...', ' ', ' ', ' ', ' ', ' ', ' '], $text); //for PHP 5.4
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-19 04:57 UTC by Report Bug Copy Issue Report `74%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
362
363		if ($keyword) {
364		$text = str_replace('.', ' ', $text);
365		$text = str_replace(',', ' ', $text);
366		$text = str_replace('\'', ' ', $text);
367		// $text = str_replace(['.', ' '], [',', ' '], ['\'', ' '], $text); //for PHP 5.4
368		}
369		$text = str_replace(';', ' ', $text);
370
371		return $text;
372		}
373
374		/**
375		* @param string $document
376		*
377		* @return mixed
		0 ignored issues – show Documentation introduced 2015-12-25 06:52 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
378		*/
379	View Code Duplication	public function html2text($document)
		0 ignored issues – show Duplication introduced 2016-01-18 06:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
380		{
381		// PHP Manual:: function preg_replace
382		// $document should contain an HTML document.
383		// This will remove HTML tags, javascript sections
384		// and white space. It will also convert some
385		// common HTML entities to their text equivalent.
386		// Credits : newbb2
387		$search = array(
388		"'<script[^>]?>.?</script>'si", // Strip out javascript<?php
389		"'<img.*?/>'si", // Strip out img tags
390		"'<[\/\!]?[^<>]?>'si", // Strip out HTML tags<?php
391		"'([\r\n])[\s]+'", // Strip out white space
392		"'&(quot\|#34);'i", // Replace HTML entities
393		"'&(amp\|#38);'i",
394		"'&(lt\|#60);'i",
395		"'&(gt\|#62);'i",
396		"'&(nbsp\|#160);'i",
397		"'&(iexcl\|#161);'i",
398		"'&(cent\|#162);'i",
399		"'&(pound\|#163);'i",
400		"'&(copy\|#169);'i",//"'&#(\d+);'e"
401		);
402		// evaluate as php
403		$replace = array(
404		'',
405		'',
406		'',
407		"\\1",
408		"\"",
409		'&',
410		'<',
411		'>',
412		' ',
413		chr(161),
414		chr(162),
415		chr(163),
416		chr(169),//"chr(\\1)"
417		);
418		$text = preg_replace($search, $replace, $document);
419
420		return $text;
421		}
422		}
423

mambax7 / publisher

Push — master ( 16270d...f28230 )

PublisherMetagen::generateSeoTitle() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like