publisher_items_spot_show()

Complexity

Conditions	26
Paths	360

Size

Total Lines	150
Code Lines	121

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

<?php declare(strict_types=1);
function publisher_items_spot_show($options)
{
    //    global $xoTheme;
    $helper = Helper::getInstance();
    /** @var CategoryHandler $categoryHandler */
    $categoryHandler = $helper->getHandler('Category');
    /** @var ItemHandler $itemHandler */
    $itemHandler = $helper->getHandler('Item');
    xoops_loadLanguage('main', 'publisher');

    $optDisplayLast         = $options[0];
    $optItemsCount          = $options[1];
    $optCategoryId          = $options[2];
    $selItems               = isset($options[3]) ? explode(',', $options[3]) : '';
    $optDisplayPoster       = $options[4];
    $optDisplayComment      = $options[5];
    $optDisplayType         = $options[6];
    $optTruncate            = (int)$options[7];
    $optCatImage            = $options[8];
    $optSortOrder           = $options[9] ?? '';
    $optBtnDisplayMore      = $options[10] ?? '';
    $optDisplayReads        = $options[11] ?? '';
    $optdisplayitemimage    = $options[12] ?? '';
    $optdisplaywhenlink     = $options[13] ?? '';
    $optdisplaycategorylink = $options[14] ?? '';
    $optdisplayadminlink    = $options[15] ?? '';
    $optdisplayreadmore     = $options[16] ?? '';

    if (0 == $optCategoryId) {
        $optCategoryId = -1;
    }
    $block = [];
    if (1 == $optDisplayLast) {
        switch ($optSortOrder) {
            case 'title':
                $sort  = 'title';
                $order = 'ASC';
                break;
            case 'date':
                $sort  = 'datesub';
                $order = 'DESC';
                break;
            case 'counter':
                $sort  = 'counter';
                $order = 'DESC';
                break;
            case 'rating':
                $sort  = 'rating';
                $order = 'DESC';
                break;
            case 'votes':
                $sort  = 'votes';
                $order = 'DESC';
                break;
            case 'comments':
                $sort  = 'comments';
                $order = 'DESC';
                break;
            default:
                $sort  = 'weight';
                $order = 'ASC';
                break;
        }
        $itemsObj   = $itemHandler->getAllPublished($optItemsCount, 0, $optCategoryId, $sort, $order, 'summary');
        $i          = 1;
        $itemsCount = count($itemsObj);
        if ($itemsObj) {
            if (-1 != $optCategoryId) {
                /** @var Category $cat */
                $cat                     = $categoryHandler->get($optCategoryId);
                $category['name']        = $cat->name;

$category was never initialized. Although not strictly required by PHP, it is generally a good practice to add $category = array(); before regardless.

                $category['categoryurl'] = $cat->getCategoryUrl();
                if ('blank.png' !== $cat->getImage()) {
                    $category['image_path'] = Utility::getImageDir('category', false) . $cat->getImage();
                } else {
                    $category['image_path'] = '';
                }
                $block['category'] = $category;
            } else {
                $block['category']['categoryurl'] = XOOPS_URL . '/modules/' . PUBLISHER_DIRNAME;
            }
            foreach ($itemsObj as $key => $thisItem) {
                $item = $thisItem->toArraySimple('default', 0, $optTruncate);
                if ($i < $itemsCount) {
                    $item['showline'] = true;
                } else {
                    $item['showline'] = false;
                }
                if ($optTruncate > 0) {
                    $block['truncate'] = true;
                }
                $block['items'][] = $item;
                ++$i;
            }
        }
    } else {
        $i = 1;
        if ($selItems && \is_array($selItems)) {
            $itemsCount = count($selItems);
            foreach ($selItems as $itemId) {
                /** @var Item $itemObj */
                $itemObj = $itemHandler->get($itemId);

$itemId of type string is incompatible with the type integer|null expected by parameter $id of XoopsModules\Publisher\ItemHandler::get().

                if (null !== $itemObj && !$itemObj->notLoaded()) {
                    $item             = $itemObj->toArraySimple();
                    $item['who_when'] = sprintf(_MB_PUBLISHER_WHO_WHEN, $item['who'], $item['when']);
                    if ($i < $itemsCount) {
                        $item['showline'] = true;
                    } else {
                        $item['showline'] = false;
                    }
                    if ($optTruncate > 0) {
                        $block['truncate'] = true;
                        $item['summary']   = Utility::truncateHtml($item['summary'], $optTruncate);
                    }
                    $block['items'][] = $item;
                    ++$i;
                }
            }
        }
    }
    if (!isset($block['items']) || 0 == count($block['items'])) {
        return false;
    }
    $block['lang_reads']    = _MB_PUBLISHER_READS;
    $block['lang_comments'] = _MB_PUBLISHER_COMMENTS;
    $block['lang_readmore'] = _MB_PUBLISHER_READMORE;
    $block['lang_poster']   = _MB_PUBLISHER_POSTEDBY;
    $block['lang_date']     = _MB_PUBLISHER_ON;
    $block['lang_category'] = _MB_PUBLISHER_CATEGORY;

    $block['display_whowhen_link'] = $optDisplayPoster;
    $block['display_who_link']     = $optDisplayPoster;
    $block['display_comment_link'] = $optDisplayComment;
    $block['display_type']         = $optDisplayType;
    $block['display_reads']        = $optDisplayReads;
    $block['display_cat_image']    = $optCatImage;
    $block['display_item_image']   = $optdisplayitemimage;
    $block['display_when_link']    = $optdisplaywhenlink;
    $block['display_categorylink'] = $optdisplaycategorylink;
    $block['display_adminlink']    = $optdisplayadminlink;
    $block['display_readmore']     = $optdisplayreadmore;

    if ($optBtnDisplayMore) {
        $block['lang_displaymore'] = _MB_PUBLISHER_MORE_ITEMS;
    }

    $block['publisher_url'] = PUBLISHER_URL;
    $GLOBALS['xoTheme']->addStylesheet(XOOPS_URL . '/modules/' . PUBLISHER_DIRNAME . '/assets/css/' . PUBLISHER_DIRNAME . '.css');

    return $block;
}