Issues in slides.php - Fixed Issues - Inspection of "cosmetics" - mambax7/presenter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 56603d...bee6fb )

by Michael

created 2017-08-04 04:58 UTC

slides.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * presenter module for xoops
 *
 * @copyright       XOOPS Project (http://xoops.org)
 * @license         GPL 2.0 or later
 * @package         presenter
 * @since           2.5.5
 * @author          XOOPS Development Team <[email protected]> - <http://xoops.org>
 * @version         $Id: 1.0 slides.php 11532 Wed 2013/08/28 4:00:27Z XOOPS Development Team $
 */
include_once __DIR__ . '/header.php';
$xoopsOption['template_main'] = 'presenter_slides.tpl';
//$xoopsOption['template_main'] = 'presenter_iframe.tpl';

include_once XOOPS_ROOT_PATH . '/header.php';
$start = presenter_CleanVars($_REQUEST, 'start', 0);
// Define Stylesheet
$xoTheme->addStylesheet($style);
// Get Handler
$slidesHandler =& xoops_getModuleHandler('slides', 'presenter');
$nb_slides     = $GLOBALS['xoopsModuleConfig']['userpager'];

$criteria     = new CriteriaCompo();
$slides_count = $slidesHandler->getCount($criteria);
$slides_arr   = $slidesHandler->getAll($criteria);
foreach (array_keys($slides_arr) as $i) {
    $slides['slides_id']      = $slides_arr[$i]->getVar('slides_id');
    $slides['slides_cid']     = $slides_arr[$i]->getVar('slides_cid');
    $slides['slides_uid']     = $slides_arr[$i]->getVar('slides_uid');
    $slides['slides_title']   = $slides_arr[$i]->getVar('slides_title');
    $slides['slides_content'] = $slides_arr[$i]->getVar('slides_content');

    $slides['css_id']    = $slides_arr[$i]->getVar('css_id');
    $slides['css_class'] = $slides_arr[$i]->getVar('css_class');

    $slides['slides_transition_x'] = $slides_arr[$i]->getVar('slides_transition_x');
    $slides['slides_transition_y'] = $slides_arr[$i]->getVar('slides_transition_y');
    $slides['slides_transition_z'] = $slides_arr[$i]->getVar('slides_transition_z');
    $slides['slides_rotation_x']   = $slides_arr[$i]->getVar('slides_rotation_x');
    $slides['slides_rotation_y']   = $slides_arr[$i]->getVar('slides_rotation_y');
    $slides['slides_rotation_z']   = $slides_arr[$i]->getVar('slides_rotation_z');
    $slides['slides_scale_x']      = $slides_arr[$i]->getVar('slides_scale_x');
    $slides['slides_scale_y']      = $slides_arr[$i]->getVar('slides_scale_y');
    $slides['slides_scale_z']      = $slides_arr[$i]->getVar('slides_scale_z');
    $slides['slides_created']      = $slides_arr[$i]->getVar('slides_created');
    $slides['slides_published']    = $slides_arr[$i]->getVar('slides_published');
    $slides['slides_position']     = $slides_arr[$i]->getVar('slides_position');
    $slides['slides_online']       = $slides_arr[$i]->getVar('slides_online');
    $slides['slides_type']         = $slides_arr[$i]->getVar('slides_type');
    $slides['slides_notes']        = strip_tags($slides_arr[$i]->getVar('slides_notes'));
    $slides['slides_mp3']          = $slides_arr[$i]->getVar('slides_mp3');
    $slides['slides_time']         = $slides_arr[$i]->getVar('slides_time');
    $slides['slides_status']       = $slides_arr[$i]->getVar('slides_status');
    $slides['slides_waiting']      = $slides_arr[$i]->getVar('slides_waiting');
    $slides['slides_online']       = $slides_arr[$i]->getVar('slides_online');
    $GLOBALS['xoopsTpl']->append('slides', $slides);
    $keywords[] = $slides_arr[$i]->getVar('slides_name');

    //    $GLOBALS['xoopsTpl']->assign('slides_title', $slides_arr[$i]->getVar('slides_title'));
    //    $GLOBALS['xoopsTpl']->assign('slides_content', $slides_arr[$i]->getVar('slides_content'));
    //    $GLOBALS['xoopsTpl']->assign('slides_transition_x', $slides_arr[$i]->getVar('slides_transition_x'));
    //    $GLOBALS['xoopsTpl']->assign('slides_transition_y', $slides_arr[$i]->getVar('slides_transition_y'));
    //    $GLOBALS['xoopsTpl']->assign('slides_transition_z', $slides_arr[$i]->getVar('slides_transition_z'));
    //    $GLOBALS['xoopsTpl']->assign('slides_rotation_x', $slides_arr[$i]->getVar('slides_rotation_x'));
    //    $GLOBALS['xoopsTpl']->assign('slides_rotation_y', $slides_arr[$i]->getVar('slides_rotation_y'));
    //    $GLOBALS['xoopsTpl']->assign('slides_rotation_z', $slides_arr[$i]->getVar('slides_rotation_z'));
    //    $GLOBALS['xoopsTpl']->assign('slides_scale_x', $slides_arr[$i]->getVar('slides_scale_x'));
    //    $GLOBALS['xoopsTpl']->assign('slides_scale_y', $slides_arr[$i]->getVar('slides_scale_y'));
    //    $GLOBALS['xoopsTpl']->assign('slides_scale_z', $slides_arr[$i]->getVar('slides_scale_z'));

    unset($slides);
}

// Display Navigation
if ($slides_count > $nb_slides) {
    include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
    $nav = new XoopsPageNav($slides_count, $nb_slides, $start, 'start');
    $GLOBALS['xoopsTpl']->assign('pagenav', $nav->renderNav(4));
}
//keywords
presenter_meta_keywords($GLOBALS['xoopsModuleConfig']['keywords'] . ', ' . implode(', ', $keywords));
//description
presenter_meta_description(_MA_PRESENTER_SLIDES_DESC);
//
$GLOBALS['xoopsTpl']->assign('xoops_mpageurl', PRESENTER_URL . '/slides.php');
$GLOBALS['xoopsTpl']->assign('presenter_url', PRESENTER_URL);
$GLOBALS['xoopsTpl']->assign('adv', $GLOBALS['xoopsModuleConfig']['advertise']);
//
$GLOBALS['xoopsTpl']->assign('social_bookmarks', $GLOBALS['xoopsModuleConfig']['social_bookmarks']);
$GLOBALS['xoopsTpl']->assign('fbcomments', $GLOBALS['xoopsModuleConfig']['fbcomments']);
//
$GLOBALS['xoopsTpl']->assign('admin', PRESENTER_ADMIN);
$GLOBALS['xoopsTpl']->assign('copyright', $copyright);
//
include_once XOOPS_ROOT_PATH . '/footer.php';


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11		/**
12		* presenter module for xoops
13		*
14		* @copyright XOOPS Project (http://xoops.org)
15		* @license GPL 2.0 or later
16		* @package presenter
17		* @since 2.5.5
18		* @author XOOPS Development Team <[email protected]> - <http://xoops.org>
19		* @version $Id: 1.0 slides.php 11532 Wed 2013/08/28 4:00:27Z XOOPS Development Team $
20		*/
21		include_once __DIR__ . '/header.php';
22		$xoopsOption['template_main'] = 'presenter_slides.tpl';
23		//$xoopsOption['template_main'] = 'presenter_iframe.tpl';
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-29 08:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
24		include_once XOOPS_ROOT_PATH . '/header.php';
25		$start = presenter_CleanVars($_REQUEST, 'start', 0);
26		// Define Stylesheet
27		$xoTheme->addStylesheet($style);
28		// Get Handler
29		$slidesHandler =& xoops_getModuleHandler('slides', 'presenter');
30		$nb_slides = $GLOBALS['xoopsModuleConfig']['userpager'];
31
32		$criteria = new CriteriaCompo();
33		$slides_count = $slidesHandler->getCount($criteria);
34		$slides_arr = $slidesHandler->getAll($criteria);
35		foreach (array_keys($slides_arr) as $i) {
36		$slides['slides_id'] = $slides_arr[$i]->getVar('slides_id');
37		$slides['slides_cid'] = $slides_arr[$i]->getVar('slides_cid');
38		$slides['slides_uid'] = $slides_arr[$i]->getVar('slides_uid');
39		$slides['slides_title'] = $slides_arr[$i]->getVar('slides_title');
40		$slides['slides_content'] = $slides_arr[$i]->getVar('slides_content');
41
42		$slides['css_id'] = $slides_arr[$i]->getVar('css_id');
43		$slides['css_class'] = $slides_arr[$i]->getVar('css_class');
44
45		$slides['slides_transition_x'] = $slides_arr[$i]->getVar('slides_transition_x');
46		$slides['slides_transition_y'] = $slides_arr[$i]->getVar('slides_transition_y');
47		$slides['slides_transition_z'] = $slides_arr[$i]->getVar('slides_transition_z');
48		$slides['slides_rotation_x'] = $slides_arr[$i]->getVar('slides_rotation_x');
49		$slides['slides_rotation_y'] = $slides_arr[$i]->getVar('slides_rotation_y');
50		$slides['slides_rotation_z'] = $slides_arr[$i]->getVar('slides_rotation_z');
51		$slides['slides_scale_x'] = $slides_arr[$i]->getVar('slides_scale_x');
52		$slides['slides_scale_y'] = $slides_arr[$i]->getVar('slides_scale_y');
53		$slides['slides_scale_z'] = $slides_arr[$i]->getVar('slides_scale_z');
54		$slides['slides_created'] = $slides_arr[$i]->getVar('slides_created');
55		$slides['slides_published'] = $slides_arr[$i]->getVar('slides_published');
56		$slides['slides_position'] = $slides_arr[$i]->getVar('slides_position');
57		$slides['slides_online'] = $slides_arr[$i]->getVar('slides_online');
58		$slides['slides_type'] = $slides_arr[$i]->getVar('slides_type');
59		$slides['slides_notes'] = strip_tags($slides_arr[$i]->getVar('slides_notes'));
60		$slides['slides_mp3'] = $slides_arr[$i]->getVar('slides_mp3');
61		$slides['slides_time'] = $slides_arr[$i]->getVar('slides_time');
62		$slides['slides_status'] = $slides_arr[$i]->getVar('slides_status');
63		$slides['slides_waiting'] = $slides_arr[$i]->getVar('slides_waiting');
64		$slides['slides_online'] = $slides_arr[$i]->getVar('slides_online');
65		$GLOBALS['xoopsTpl']->append('slides', $slides);
66		$keywords[] = $slides_arr[$i]->getVar('slides_name');
67
68		// $GLOBALS['xoopsTpl']->assign('slides_title', $slides_arr[$i]->getVar('slides_title'));
69		// $GLOBALS['xoopsTpl']->assign('slides_content', $slides_arr[$i]->getVar('slides_content'));
70		// $GLOBALS['xoopsTpl']->assign('slides_transition_x', $slides_arr[$i]->getVar('slides_transition_x'));
71		// $GLOBALS['xoopsTpl']->assign('slides_transition_y', $slides_arr[$i]->getVar('slides_transition_y'));
72		// $GLOBALS['xoopsTpl']->assign('slides_transition_z', $slides_arr[$i]->getVar('slides_transition_z'));
73		// $GLOBALS['xoopsTpl']->assign('slides_rotation_x', $slides_arr[$i]->getVar('slides_rotation_x'));
74		// $GLOBALS['xoopsTpl']->assign('slides_rotation_y', $slides_arr[$i]->getVar('slides_rotation_y'));
75		// $GLOBALS['xoopsTpl']->assign('slides_rotation_z', $slides_arr[$i]->getVar('slides_rotation_z'));
76		// $GLOBALS['xoopsTpl']->assign('slides_scale_x', $slides_arr[$i]->getVar('slides_scale_x'));
77		// $GLOBALS['xoopsTpl']->assign('slides_scale_y', $slides_arr[$i]->getVar('slides_scale_y'));
78		// $GLOBALS['xoopsTpl']->assign('slides_scale_z', $slides_arr[$i]->getVar('slides_scale_z'));
79
80		unset($slides);
81		}
82
83		// Display Navigation
84	View Code Duplication	if ($slides_count > $nb_slides) {
85		include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
86		$nav = new XoopsPageNav($slides_count, $nb_slides, $start, 'start');
87		$GLOBALS['xoopsTpl']->assign('pagenav', $nav->renderNav(4));
88		}
89		//keywords
90		presenter_meta_keywords($GLOBALS['xoopsModuleConfig']['keywords'] . ', ' . implode(', ', $keywords));
91		//description
92		presenter_meta_description(_MA_PRESENTER_SLIDES_DESC);
93		//
94		$GLOBALS['xoopsTpl']->assign('xoops_mpageurl', PRESENTER_URL . '/slides.php');
95		$GLOBALS['xoopsTpl']->assign('presenter_url', PRESENTER_URL);
96		$GLOBALS['xoopsTpl']->assign('adv', $GLOBALS['xoopsModuleConfig']['advertise']);
97		//
98		$GLOBALS['xoopsTpl']->assign('social_bookmarks', $GLOBALS['xoopsModuleConfig']['social_bookmarks']);
99		$GLOBALS['xoopsTpl']->assign('fbcomments', $GLOBALS['xoopsModuleConfig']['fbcomments']);
100		//
101		$GLOBALS['xoopsTpl']->assign('admin', PRESENTER_ADMIN);
102		$GLOBALS['xoopsTpl']->assign('copyright', $copyright);
103		//
104		include_once XOOPS_ROOT_PATH . '/footer.php';
105

mambax7 / presenter

Push — master ( 56603d...bee6fb )

slides.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like