functions.php ➔ presenter_meta_description() - Code Metrics - Inspection of "update for PayPal" - mambax7/presenter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 583920...a73650 )

by Michael

created 2017-03-29 08:45 UTC

functions.php ➔ presenter_meta_description() A

↳ Parent: Project

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
eloc	8
nc	2
nop	1
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * presenter module for xoops
 *
 * @copyright       XOOPS Project (http://xoops.org)
 * @license         GPL 2.0 or later
 * @package         presenter
 * @since           2.5.5
 * @author          XOOPS Development Team <[email protected]> - <http://xoops.org>
 * @version         $Id: 1.0 functions.php 11532 Wed 2013/08/28 4:00:28Z XOOPS Development Team $
 */
/***************Blocks**************
 * @param $cats
 * @return string
 */
function presenter_block_addCatSelect($cats)
{
    if (is_array($cats)) {
        $cat_sql = '(' . current($cats);
        array_shift($cats);
        foreach ($cats as $cat) {
            $cat_sql .= ',' . $cat;
        }
        $cat_sql .= ')';
    }

    return $cat_sql;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

/**
 * @param        $global
 * @param        $key
 * @param string $default
 * @param string $type
 * @return mixed|string
 */
function presenter_CleanVars(&$global, $key, $default = '', $type = 'int')
{
    switch ($type) {
        case 'string':
            $ret = (isset($global[$key])) ? filter_var($global[$key], FILTER_SANITIZE_MAGIC_QUOTES) : $default;
            break;
        case 'int':
        default:
            $ret = (isset($global[$key])) ? filter_var($global[$key], FILTER_SANITIZE_NUMBER_INT) : $default;
            break;
    }
    if ($ret === false) {
        return $default;
    }

    return $ret;
}

/**
 * @param $content
 */
function presenter_meta_keywords($content)

{
    global $xoopsTpl, $xoTheme;
function myFunction($a, $b) {
    // Do something
}
    $myts    =& MyTextSanitizer::getInstance();
    $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
    if (isset($xoTheme) && is_object($xoTheme)) {
        $xoTheme->addMeta('meta', 'keywords', strip_tags($content));
    } else {    // Compatibility for old Xoops versions
        $xoopsTpl->assign('xoops_meta_keywords', strip_tags($content));
    }
}

/**
 * @param $content
 */
function presenter_meta_description($content)

{
    global $xoopsTpl, $xoTheme;
function myFunction($a, $b) {
    // Do something
}
    $myts    =& MyTextSanitizer::getInstance();
    $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
    if (isset($xoTheme) && is_object($xoTheme)) {
        $xoTheme->addMeta('meta', 'description', strip_tags($content));
    } else {    // Compatibility for old Xoops versions
        $xoopsTpl->assign('xoops_meta_description', strip_tags($content));
    }
}


Push — master ( 583920...a73650 )

functions.php ➔ presenter_meta_description() A

Complexity

Size

Duplication

Importance

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11		/**
12		* presenter module for xoops
13		*
14		* @copyright XOOPS Project (http://xoops.org)
15		* @license GPL 2.0 or later
16		* @package presenter
17		* @since 2.5.5
18		* @author XOOPS Development Team <[email protected]> - <http://xoops.org>
19		* @version $Id: 1.0 functions.php 11532 Wed 2013/08/28 4:00:28Z XOOPS Development Team $
20		*/
21		/*************Blocks************
22		* @param $cats
23		* @return string
24		*/
25		function presenter_block_addCatSelect($cats)
26		{
27		if (is_array($cats)) {
28		$cat_sql = '(' . current($cats);
29		array_shift($cats);
30		foreach ($cats as $cat) {
31		$cat_sql .= ',' . $cat;
32		}
33		$cat_sql .= ')';
34		}
35
36		return $cat_sql;
		0 ignored issues – show Bug introduced 2016-01-11 19:09 UTC by Report Bug Copy Issue Report The variable `$cat_sql` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
37		}
38
39		/**
40		* @param $global
41		* @param $key
42		* @param string $default
43		* @param string $type
44		* @return mixed\|string
45		*/
46		function presenter_CleanVars(&$global, $key, $default = '', $type = 'int')
47		{
48		switch ($type) {
49		case 'string':
50		$ret = (isset($global[$key])) ? filter_var($global[$key], FILTER_SANITIZE_MAGIC_QUOTES) : $default;
51		break;
52		case 'int':
53		default:
54		$ret = (isset($global[$key])) ? filter_var($global[$key], FILTER_SANITIZE_NUMBER_INT) : $default;
55		break;
56		}
57		if ($ret === false) {
58		return $default;
59		}
60
61		return $ret;
62		}
63
64		/**
65		* @param $content
66		*/
67	View Code Duplication	function presenter_meta_keywords($content)
		0 ignored issues – show Duplication introduced 2016-01-18 07:54 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		global $xoopsTpl, $xoTheme;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-11 19:09 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
70		$myts =& MyTextSanitizer::getInstance();
71		$content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
72		if (isset($xoTheme) && is_object($xoTheme)) {
73		$xoTheme->addMeta('meta', 'keywords', strip_tags($content));
74		} else { // Compatibility for old Xoops versions
75		$xoopsTpl->assign('xoops_meta_keywords', strip_tags($content));
76		}
77		}
78
79		/**
80		* @param $content
81		*/
82	View Code Duplication	function presenter_meta_description($content)
		0 ignored issues – show Duplication introduced 2016-01-18 07:54 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		{
84		global $xoopsTpl, $xoTheme;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-11 19:09 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
85		$myts =& MyTextSanitizer::getInstance();
86		$content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
87		if (isset($xoTheme) && is_object($xoTheme)) {
88		$xoTheme->addMeta('meta', 'description', strip_tags($content));
89		} else { // Compatibility for old Xoops versions
90		$xoopsTpl->assign('xoops_meta_description', strip_tags($content));
91		}
92		}
93

mambax7 / presenter

Push — master ( 583920...a73650 )

functions.php ➔ presenter_meta_description() A

Complexity

Size

Duplication

Importance

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like