| Conditions | 3 |
| Paths | 4 |
| Total Lines | 58 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | function b_presenter_slides_show($options) |
||
| 26 | { |
||
| 27 | require_once XOOPS_ROOT_PATH . '/modules/presenter/class/slides.php'; |
||
| 28 | $myts = MyTextSanitizer::getInstance(); |
||
|
|
|||
| 29 | |||
| 30 | $slides = []; |
||
| 31 | $type_block = $options[0]; |
||
| 32 | $nb_slides = $options[1]; |
||
| 33 | $lenght_title = $options[2]; |
||
| 34 | |||
| 35 | $slidesHandler = xoops_getModuleHandler('slides', 'presenter'); |
||
| 36 | $criteria = new CriteriaCompo(); |
||
| 37 | array_shift($options); |
||
| 38 | array_shift($options); |
||
| 39 | array_shift($options); |
||
| 40 | |||
| 41 | if ($type_block) { |
||
| 42 | $criteria->add(new Criteria('slides_id', 0, '!=')); |
||
| 43 | $criteria->setSort('slides_id'); |
||
| 44 | $criteria->setOrder('ASC'); |
||
| 45 | } |
||
| 46 | |||
| 47 | $criteria->setLimit($nb_slides); |
||
| 48 | $slides_arr = $slidesHandler->getAll($criteria); |
||
| 49 | foreach (array_keys($slides_arr) as $i) { |
||
| 50 | $slides[$i]['slides_id'] = $slides_arr[$i]->getVar('slides_id'); |
||
| 51 | $slides[$i]['slides_cid'] = $slides_arr[$i]->getVar('slides_cid'); |
||
| 52 | $slides[$i]['slides_uid'] = $slides_arr[$i]->getVar('slides_uid'); |
||
| 53 | $slides[$i]['slides_title'] = $slides_arr[$i]->getVar('slides_title'); |
||
| 54 | $slides[$i]['slides_content'] = $slides_arr[$i]->getVar('slides_content'); |
||
| 55 | |||
| 56 | $slides[$i]['css_id'] = $slides_arr[$i]->getVar('css_id'); |
||
| 57 | $slides[$i]['css_class'] = $slides_arr[$i]->getVar('css_class'); |
||
| 58 | |||
| 59 | $slides[$i]['slides_transition_x'] = $slides_arr[$i]->getVar('slides_transition_x'); |
||
| 60 | $slides[$i]['slides_transition_y'] = $slides_arr[$i]->getVar('slides_transition_y'); |
||
| 61 | $slides[$i]['slides_transition_z'] = $slides_arr[$i]->getVar('slides_transition_z'); |
||
| 62 | $slides[$i]['slides_rotation_x'] = $slides_arr[$i]->getVar('slides_rotation_x'); |
||
| 63 | $slides[$i]['slides_rotation_y'] = $slides_arr[$i]->getVar('slides_rotation_y'); |
||
| 64 | $slides[$i]['slides_rotation_z'] = $slides_arr[$i]->getVar('slides_rotation_z'); |
||
| 65 | $slides[$i]['slides_scale_x'] = $slides_arr[$i]->getVar('slides_scale_x'); |
||
| 66 | $slides[$i]['slides_scale_y'] = $slides_arr[$i]->getVar('slides_scale_y'); |
||
| 67 | $slides[$i]['slides_scale_z'] = $slides_arr[$i]->getVar('slides_scale_z'); |
||
| 68 | $slides[$i]['slides_created'] = $slides_arr[$i]->getVar('slides_created'); |
||
| 69 | $slides[$i]['slides_published'] = $slides_arr[$i]->getVar('slides_published'); |
||
| 70 | $slides[$i]['slides_position'] = $slides_arr[$i]->getVar('slides_position'); |
||
| 71 | $slides[$i]['slides_online'] = $slides_arr[$i]->getVar('slides_online'); |
||
| 72 | $slides[$i]['slides_type'] = $slides_arr[$i]->getVar('slides_type'); |
||
| 73 | $slides[$i]['slides_notes'] = $slides_arr[$i]->getVar('slides_notes'); |
||
| 74 | $slides[$i]['slides_mp3'] = $slides_arr[$i]->getVar('slides_mp3'); |
||
| 75 | $slides[$i]['slides_time'] = $slides_arr[$i]->getVar('slides_time'); |
||
| 76 | $slides[$i]['slides_status'] = $slides_arr[$i]->getVar('slides_status'); |
||
| 77 | $slides[$i]['slides_waiting'] = $slides_arr[$i]->getVar('slides_waiting'); |
||
| 78 | $slides[$i]['slides_online'] = $slides_arr[$i]->getVar('slides_online'); |
||
| 79 | } |
||
| 80 | |||
| 81 | return $slides; |
||
| 82 | } |
||
| 83 | |||
| 115 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.