Issues in action.blog.php - All Issues - Inspection of "Merge pull request #1 from mambax7/imgbot" - mambax7/planet - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a0a78b...8db6f6 )

by Michael

created 2019-01-19 11:42 UTC

action.blog.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
//
// ------------------------------------------------------------------------ //
// This program is free software; you can redistribute it and/or modify     //
// it under the terms of the GNU General Public License as published by     //
// the Free Software Foundation; either version 2 of the License, or        //
// (at your option) any later version.                                      //
//                                                                          //
// You may not change or alter any portion of this comment or credits       //
// of supporting developers from this source code or any supporting         //
// source code which is considered copyrighted (c) material of the          //
// original comment or credit authors.                                      //
//                                                                          //
// This program is distributed in the hope that it will be useful,          //
// but WITHOUT ANY WARRANTY; without even the implied warranty of           //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
// GNU General Public License for more details.                             //
//                                                                          //
// You should have received a copy of the GNU General Public License        //
// along with this program; if not, write to the Free Software              //
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
// ------------------------------------------------------------------------ //
// Author: phppp (D.J., [email protected])                                  //
// URL: https://xoops.org                         //
// Project: Article Project                                                 //
// ------------------------------------------------------------------------ //
use Xmf\Request;
use XoopsModules\Planet;

include __DIR__ . '/header.php';

/** @var Planet\Helper $helper */
$helper = Planet\Helper::getInstance();

$op      = Request::getString('op', Request::getString('op', '', 'POST'), 'GET');//!empty($_POST['op']) ? $_POST['op'] : (!empty($_GET['op']) ? $_GET['op'] : '');
$blog_id = Request::getArray('blog', Request::getArray('blog', [], 'POST'), 'GET');//!empty($_POST['blog']) ? $_POST['blog'] : (!empty($_GET['blog']) ? $_GET['blog'] : 0);
$blog_id = is_array($blog_id) ? array_map('intval', $blog_id) : (int)$blog_id;

if (empty($helper->getConfig('newblog_submit')) && (!is_object($xoopsUser) || !$xoopsUser->isAdmin())) {
    redirect_header('index.php', 2, _NOPERM);
}

if ('save' === $op && !empty(Request::getString('fetch', '', 'POST'))) {//!empty($_POST['fetch'])) {
    $op = 'edit';
}

if ('save' === $op && !$GLOBALS['xoopsSecurity']->check()) {
    redirect_header('javascript:history.go(-1);', 1, planet_constant('MD_INVALID') . ': security check failed');
}
include XOOPS_ROOT_PATH . '/header.php';
include XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/include/vars.php';

$blogHandler     = xoops_getModuleHandler('blog', $GLOBALS['moddirname']);
$categoryHandler = xoops_getModuleHandler('category', $GLOBALS['moddirname']);

switch ($op) {
    /* save a single blog */
    case 'save':

        if ($blog_id) {
            $blog_obj = $blogHandler->get($blog_id);
            if ($xoopsUser->isAdmin()) {
                $blog_obj->setVar('blog_status', Request::getInt('blog_status', 0, 'POST'));// @$_POST['blog_status']);
            }
        } else {
            if ($blog_exists = $blogHandler->getCount(new \Criteria('blog_feed', $myts->addSlashes(trim(Request::getText('blog_feed', '', 'POST')))))  //$_POST['blog_feed']))))
            ) {
                redirect_header('index.php', 2, planet_constant('MD_BLOGEXISTS'));
            }

            $blog_obj = $blogHandler->create();
            $blog_obj->setVar('blog_submitter', is_object($xoopsUser) ? $xoopsUser->getVar('uid') : PlanetUtility::planetGetIP(true));

            switch ($helper->getConfig('newblog_submit')) {
                case 2:
                    if (!is_object($xoopsUser)) {
                        $status = 0;
                    } else {
                        $status = 1;
                    }
                    break;
                case 0:
                case 3:
                    $status = 1;
                    break;
                case 1:
                default:
                    if (!is_object($xoopsUser) || !$xoopsUser->isAdmin()) {
                        $status = 0;
                    } else {
                        $status = 1;
                    }
                    break;
            }

            $blog_obj->setVar('blog_status', $status);
        }

        $blog_obj->setVar('blog_title', Request::getString('blog_title', '', 'POST'));//$_POST['blog_title']);
        $blog_obj->setVar('blog_desc', Request::getString('blog_desc', '', 'POST'));//$_POST['blog_desc']);
        $blog_obj->setVar('blog_image', Request::getString('blog_image', '', 'POST'));//$_POST['blog_image']);
        $blog_obj->setVar('blog_feed', Request::getText('blog_feed', '', 'POST'));//$_POST['blog_feed']);
        $blog_obj->setVar('blog_link', Request::getString('blog_link', '', 'POST'));//$_POST['blog_link']);
        $blog_obj->setVar('blog_language', Request::getString('blog_language', '', 'POST'));//$_POST['blog_language']);
        $blog_obj->setVar('blog_charset', Request::getString('blog_charset', '', 'POST'));//$_POST['blog_charset']);
        $blog_obj->setVar('blog_trackback', Request::getString('blog_trackback', '', 'POST'));//$_POST['blog_trackback']);
        if ($blog_obj->isNew()) {
            $blog_obj->setVar('blog_submitter', is_object($xoopsUser) ? $xoopsUser->getVar('uid') : PlanetUtility::planetGetIP(true));
        }

        if (!$blogHandler->insert($blog_obj)) {
        } elseif (0 !== count(Request::getArray('categories', [], 'POST'))) {
            $blog_id = $blog_obj->getVar('blog_id');
            if (in_array(0, $_POST['categories'])) {
                $_POST['categories'] = [];
            }
            $blogHandler->setCategories($blog_id, Request::getString('andor', '', 'POST'));//$_POST['categories']);
        }
        $message = planet_constant('MD_DBUPDATED');
        redirect_header('index.php' . URL_DELIMITER . 'b' . $blog_id, 2, $message);

    /* edit a single blog */
    // no break
    case 'edit':
    default:

        if (!empty(Request::getString('fetch', '', 'POST'))) {
            $blog_obj = $blogHandler->fetch(Request::getText('blog_feed', '', 'POST'));
            $blog_obj->setVar('blog_id', $blog_id);
        } else {
            $blog_obj = $blogHandler->get($blog_id);
        }
        $categories = Request::getArray('categories', [], 'POST');//isset($_POST['categories']) ? $_POST['categories'] : array();
        if (in_array('-1', $categories)) {
            $categories = [];
        }
        if (empty($categories) && $blog_id > 0) {
            $crit       = new \Criteria('bc.blog_id', $blog_id);
            $categories = array_keys($categoryHandler->getByBlog($crit));
        }
        if (empty($categories)) {
            $categories = [0 => _NONE];
        }

        echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _EDIT . '</legend>';
        echo '<br>';
        if (empty($blog_id) && $blog_obj->getVar('blog_feed')) {
            $criteria  = new \Criteria('blog_feed', $blog_obj->getVar('blog_feed'));
            $blogs_obj = $blogHandler->getList($criteria);
            if (count($blogs_obj) > 0) {
                echo '<div class="errorMsg">' . planet_constant('MD_BLOGEXISTS');
                foreach (array_keys($blogs_obj) as $bid) {
                    echo '<br><a href="' . XOOPS_URL . '/modules/' . $GLOBALS['moddirname'] . '/index.php' . URL_DELIMITER . 'b' . $bid . '" target="_blank">' . $blogs_obj[$bid] . '</a>';
                }
                echo '</div>';
                unset($blogs_obj, $criteria);
            }
        }
        include XOOPS_ROOT_PATH . '/modules/' . $GLOBALS['moddirname'] . '/include/form.blog.php';
        echo '</fieldset>';
        break;
}

include XOOPS_ROOT_PATH . '/footer.php';


1		<?php
2		//
3		// ------------------------------------------------------------------------ //
4		// This program is free software; you can redistribute it and/or modify //
5		// it under the terms of the GNU General Public License as published by //
6		// the Free Software Foundation; either version 2 of the License, or //
7		// (at your option) any later version. //
8		// //
9		// You may not change or alter any portion of this comment or credits //
10		// of supporting developers from this source code or any supporting //
11		// source code which is considered copyrighted (c) material of the //
12		// original comment or credit authors. //
13		// //
14		// This program is distributed in the hope that it will be useful, //
15		// but WITHOUT ANY WARRANTY; without even the implied warranty of //
16		// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
17		// GNU General Public License for more details. //
18		// //
19		// You should have received a copy of the GNU General Public License //
20		// along with this program; if not, write to the Free Software //
21		// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
22		// ------------------------------------------------------------------------ //
23		// Author: phppp (D.J., [email protected]) //
24		// URL: https://xoops.org //
25		// Project: Article Project //
26		// ------------------------------------------------------------------------ //
27		use Xmf\Request;
28		use XoopsModules\Planet;
29
30		include __DIR__ . '/header.php';
31
32		/** @var Planet\Helper $helper */
33		$helper = Planet\Helper::getInstance();
34
35		$op = Request::getString('op', Request::getString('op', '', 'POST'), 'GET');//!empty($_POST['op']) ? $_POST['op'] : (!empty($_GET['op']) ? $_GET['op'] : '');
36		$blog_id = Request::getArray('blog', Request::getArray('blog', [], 'POST'), 'GET');//!empty($_POST['blog']) ? $_POST['blog'] : (!empty($_GET['blog']) ? $_GET['blog'] : 0);
37		$blog_id = is_array($blog_id) ? array_map('intval', $blog_id) : (int)$blog_id;
38
39		if (empty($helper->getConfig('newblog_submit')) && (!is_object($xoopsUser) \|\| !$xoopsUser->isAdmin())) {
40		redirect_header('index.php', 2, _NOPERM);
41		}
42
43		if ('save' === $op && !empty(Request::getString('fetch', '', 'POST'))) {//!empty($_POST['fetch'])) {
44		$op = 'edit';
45		}
46
47		if ('save' === $op && !$GLOBALS['xoopsSecurity']->check()) {
48		redirect_header('javascript:history.go(-1);', 1, planet_constant('MD_INVALID') . ': security check failed');
49		}
50		include XOOPS_ROOT_PATH . '/header.php';
51		include XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/include/vars.php';
52
53		$blogHandler = xoops_getModuleHandler('blog', $GLOBALS['moddirname']);
54		$categoryHandler = xoops_getModuleHandler('category', $GLOBALS['moddirname']);
55
56		switch ($op) {
57		/* save a single blog */
58		case 'save':
59
60		if ($blog_id) {
61		$blog_obj = $blogHandler->get($blog_id);
62		if ($xoopsUser->isAdmin()) {
63		$blog_obj->setVar('blog_status', Request::getInt('blog_status', 0, 'POST'));// @$_POST['blog_status']);
64		}
65		} else {
66		if ($blog_exists = $blogHandler->getCount(new \Criteria('blog_feed', $myts->addSlashes(trim(Request::getText('blog_feed', '', 'POST'))))) //$_POST['blog_feed']))))
67		) {
68		redirect_header('index.php', 2, planet_constant('MD_BLOGEXISTS'));
69		}
70
71		$blog_obj = $blogHandler->create();
72		$blog_obj->setVar('blog_submitter', is_object($xoopsUser) ? $xoopsUser->getVar('uid') : PlanetUtility::planetGetIP(true));
73
74		switch ($helper->getConfig('newblog_submit')) {
75		case 2:
76		if (!is_object($xoopsUser)) {
77		$status = 0;
78		} else {
79		$status = 1;
80		}
81		break;
82		case 0:
83		case 3:
84		$status = 1;
85		break;
86		case 1:
87		default:
88		if (!is_object($xoopsUser) \|\| !$xoopsUser->isAdmin()) {
89		$status = 0;
90		} else {
91		$status = 1;
92		}
93		break;
94		}
95
96		$blog_obj->setVar('blog_status', $status);
97		}
98
99		$blog_obj->setVar('blog_title', Request::getString('blog_title', '', 'POST'));//$_POST['blog_title']);
100		$blog_obj->setVar('blog_desc', Request::getString('blog_desc', '', 'POST'));//$_POST['blog_desc']);
101		$blog_obj->setVar('blog_image', Request::getString('blog_image', '', 'POST'));//$_POST['blog_image']);
102		$blog_obj->setVar('blog_feed', Request::getText('blog_feed', '', 'POST'));//$_POST['blog_feed']);
103		$blog_obj->setVar('blog_link', Request::getString('blog_link', '', 'POST'));//$_POST['blog_link']);
104		$blog_obj->setVar('blog_language', Request::getString('blog_language', '', 'POST'));//$_POST['blog_language']);
105		$blog_obj->setVar('blog_charset', Request::getString('blog_charset', '', 'POST'));//$_POST['blog_charset']);
106		$blog_obj->setVar('blog_trackback', Request::getString('blog_trackback', '', 'POST'));//$_POST['blog_trackback']);
107		if ($blog_obj->isNew()) {
108		$blog_obj->setVar('blog_submitter', is_object($xoopsUser) ? $xoopsUser->getVar('uid') : PlanetUtility::planetGetIP(true));
109		}
110
111		if (!$blogHandler->insert($blog_obj)) {
112		} elseif (0 !== count(Request::getArray('categories', [], 'POST'))) {
113		$blog_id = $blog_obj->getVar('blog_id');
114		if (in_array(0, $_POST['categories'])) {
115		$_POST['categories'] = [];
116		}
117		$blogHandler->setCategories($blog_id, Request::getString('andor', '', 'POST'));//$_POST['categories']);
118		}
119		$message = planet_constant('MD_DBUPDATED');
120		redirect_header('index.php' . URL_DELIMITER . 'b' . $blog_id, 2, $message);
121
122		/* edit a single blog */
123		// no break
124		case 'edit':
125	View Code Duplication	default:
		0 ignored issues – show Duplication introduced 2017-08-04 05:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		if (!empty(Request::getString('fetch', '', 'POST'))) {
127		$blog_obj = $blogHandler->fetch(Request::getText('blog_feed', '', 'POST'));
128		$blog_obj->setVar('blog_id', $blog_id);
129		} else {
130		$blog_obj = $blogHandler->get($blog_id);
131		}
132		$categories = Request::getArray('categories', [], 'POST');//isset($_POST['categories']) ? $_POST['categories'] : array();
133		if (in_array('-1', $categories)) {
134		$categories = [];
135		}
136		if (empty($categories) && $blog_id > 0) {
137		$crit = new \Criteria('bc.blog_id', $blog_id);
138		$categories = array_keys($categoryHandler->getByBlog($crit));
139		}
140		if (empty($categories)) {
141		$categories = [0 => _NONE];
142		}
143
144		echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _EDIT . '</legend>';
145		echo '<br>';
146		if (empty($blog_id) && $blog_obj->getVar('blog_feed')) {
147		$criteria = new \Criteria('blog_feed', $blog_obj->getVar('blog_feed'));
148		$blogs_obj = $blogHandler->getList($criteria);
149		if (count($blogs_obj) > 0) {
150		echo '<div class="errorMsg">' . planet_constant('MD_BLOGEXISTS');
151		foreach (array_keys($blogs_obj) as $bid) {
152		echo '<br><a href="' . XOOPS_URL . '/modules/' . $GLOBALS['moddirname'] . '/index.php' . URL_DELIMITER . 'b' . $bid . '" target="_blank">' . $blogs_obj[$bid] . '</a>';
153		}
154		echo '</div>';
155		unset($blogs_obj, $criteria);
156		}
157		}
158		include XOOPS_ROOT_PATH . '/modules/' . $GLOBALS['moddirname'] . '/include/form.blog.php';
159		echo '</fieldset>';
160		break;
161		}
162
163		include XOOPS_ROOT_PATH . '/footer.php';
164

mambax7 / planet

Push — master ( a0a78b...8db6f6 )

action.blog.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like