mambax7 / pedigree

delete.php

<?php
/*
 You may not change or alter any portion of this comment or credits of
 supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit
 authors.

 This program is distributed in the hope that it will be useful, but
 WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * Module: Pedigree
 *
 * @package   XoopsModules\Pedigree
 * @copyright Copyright (c) 2001-2019 {@link https://xoops.org XOOPS Project}
 * @license   https://www.gnu.org/licenses/gpl-2.0.html GNU Public License
 * @author    XOOPS Module Development Team
 */

use Xmf\Request;

This use statement conflicts with another class in this namespace, Request. Consider defining an alias.

use XoopsModules\Pedigree;
use XoopsModules\Pedigree\Constants;

require_once __DIR__ . '/header.php';

/** @var XoopsModules\Pedigree\Helper $helper */
$helper->loadLanguage('main');

//check for access - only allow registered users
if (empty($GLOBALS['xoopsUser']) || !($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
    redirect_header('javascript:history.go(-1)', 3, _NOPERM . '<br>' . _MA_PEDIGREE_REGIST);
}

$GLOBALS['xoopsOption']['template_main'] = 'pedigree_delete.tpl';
require XOOPS_ROOT_PATH . '/header.php';

$id = Request::getInt('id', 0, 'GET');
if (empty($id)) {
    //re-route user if we didn't get a valid id
    $helper->redirect('', Constants::REDIRECT_DELAY_MEDIUM, _MA_PEDIGREE_INVALID_ID);

The constant _MA_PEDIGREE_INVALID_ID was not found. Maybe you did not declare it correctly or list all dependencies?

}
//query - find values for this animal
$treeHandler = $helper->getHandler('Tree');
$treeObj     = $treeHandler->get($id);

if ($treeObj instanceof Pedigree\Tree && !$treeObj->isNew()) {
    $pname = $treeObj->getVar('pname', 's');
    //$namelink = "<a href=\"" . $helper->url("dog.php?id={$id}") . "\">{$pname}</a>";

    //Create form
    require XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
    $form = new \XoopsThemeForm($pname, 'deletedata', 'deletepage.php', 'post');

It seems like $pname can also be of type array and array; however, parameter $title of XoopsThemeForm::__construct() does only seem to accept string, maybe add an additional type check?

    //hidden value current record owner
    $form->addElement(new \XoopsFormHidden('dbuser', $treeObj->getVar('user')));

It seems like $treeObj->getVar('user') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

    //hidden value dog ID
    $form->addElement(new \XoopsFormHidden('dogid', $id));
    $form->addElement(new \XoopsFormHidden('curname', $pname));
    $form->addElement(new \XoopsFormHiddenToken('XOOPS_TOKEN_REQUEST', Constants::TOKEN_TIMEOUT));
    $form->addElement(new \XoopsFormLabel(_MA_PEDIGREE_DELE_SURE, _MA_PEDIGREE_DEL_MSG . $helper->getConfig('animalType') . " : <span style=\"font-weight: bold;\">{$pname}</span>?"));
    //@todo move pups() function to Tree class method
    $pups = pups($id, (int)$treeObj->getVar('roft'));

Are you sure the assignment to $pups is correct as pups($id, (int)$treeObj->getVar('roft')) seems to always return null.

    $form->addElement(new \XoopsFormLabel(_MA_PEDIGREE_DELE_WARN, _MA_PEDIGREE_ALL . $helper->getConfig('children') . _MA_PEDIGREE_ALL_ORPH . $pups));
    $form->addElement(new \XoopsFormButton('', 'button_id', _DELETE, 'submit'));
    //add data (form) to smarty template
    $GLOBALS['xoopsTpl']->assign('form', $form->render());
} else {
    //redirect because this animal wasn't found
    $helper->redirect('', Constants::REDIRECT_DELAY_MEDIUM, _MA_PEDIGREE_INVALID_ID);
}

//footer
require XOOPS_ROOT_PATH . '/footer.php';