Issues in Trash.php - New Issues - Inspection of "Merge pull request #3 from zyspec/master" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b847d6...d6d54c )

by Michael

created 2019-10-21 01:45 UTC

class/Trash.php (2 issues)

Labels

Severity

<?php namespace XoopsModules\Pedigree;
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Pedigree module for XOOPS
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GPL 2.0 or later
 * @package         pedigree
 * @since           2.5.x
 * @author          XOOPS Module Dev Team (https://xoops.org)
 */

use XoopsModules\Pedigree;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Class Pedigree\Trash
 */
class Trash extends \XoopsObject
{
    //Constructor
    /**
     *
     */
    public function __construct()
    {
        parent::__construct();
        $this->initVar('id', XOBJ_DTYPE_INT, null, false, 11);
        $this->initVar('naam', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('id_owner', XOBJ_DTYPE_INT, null, false, 11);
        $this->initVar('id_breeder', XOBJ_DTYPE_INT, null, false, 11);
        $this->initVar('user', XOBJ_DTYPE_TXTBOX, null, false, 25);
        $this->initVar('roft', XOBJ_DTYPE_TXTBOX, null, false, 1);
        $this->initVar('mother', XOBJ_DTYPE_INT, null, false, 5);
        $this->initVar('father', XOBJ_DTYPE_INT, null, false, 5);
        $this->initVar('foto', XOBJ_DTYPE_TXTBOX, null, false, 255);
        $this->initVar('coi', XOBJ_DTYPE_TXTBOX, null, false, 10);
    }

    /**
     * @param bool $action
     *
     * @return \XoopsThemeForm
     */
    public function getForm($action = false)
    {
        //global $xoopsModuleConfig;



        if (false === $action) {
            $action = $_SERVER['REQUEST_URI'];
        }

        $title = $this->isNew() ? sprintf(_AM_PEDIGREE_PEDIGREE_TRASH_ADD) : sprintf(_AM_PEDIGREE_PEDIGREE_TRASH_EDIT);

        require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

        $form = new \XoopsThemeForm($title, 'form', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');

        $form->addElement(new \XoopsFormTextArea(_AM_PEDIGREE_PEDIGREE_TRASH_NAAM, 'naam', $this->getVar('naam'), 4, 47), true);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_ID_OWNER, 'id_owner', 50, 255, $this->getVar('id_owner')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_ID_BREEDER, 'id_breeder', 50, 255, $this->getVar('id_breeder')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_USER, 'user', 50, 255, $this->getVar('user')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_ROFT, 'roft', 50, 255, $this->getVar('roft')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_MOTHER, 'mother', 50, 255, $this->getVar('mother')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_FATHER, 'father', 50, 255, $this->getVar('father')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_FOTO, 'foto', 50, 255, $this->getVar('foto')), false);
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_COI, 'coi', 50, 255, $this->getVar('coi')), false);

        $form->addElement(new \XoopsFormHidden('op', 'save_pedigree_trash'));

        //Submit buttons
        $button_tray   = new \XoopsFormElementTray('', '');
        $submit_button = new \XoopsFormButton('', 'submit', _SUBMIT, 'submit');
        $button_tray->addElement($submit_button);

        $cancel_button = new \XoopsFormButton('', '', _CANCEL, 'cancel');
        $cancel_button->setExtra('onclick="history.go(-1)"');
        $button_tray->addElement($cancel_button);

        $form->addElement($button_tray);

        return $form;
    }
}


1			<?php namespace XoopsModules\Pedigree;
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11			/**
12			* Pedigree module for XOOPS
13			*
14			* @copyright XOOPS Project (https://xoops.org)
15			* @license GPL 2.0 or later
16			* @package pedigree
17			* @since 2.5.x
18			* @author XOOPS Module Dev Team (https://xoops.org)
19			*/
20
21			use XoopsModules\Pedigree;
			0 ignored issues – show Bug introduced 2019-10-21 01:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `XoopsModules\Pedigree\Pedigree`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
22
23			defined('XOOPS_ROOT_PATH') \|\| die('Restricted access');
24
25			/**
26			* Class Pedigree\Trash
27			*/
28			class Trash extends \XoopsObject
29			{
30			//Constructor
31			/**
32			*
33			*/
34			public function __construct()
35			{
36			parent::__construct();
37			$this->initVar('id', XOBJ_DTYPE_INT, null, false, 11);
38			$this->initVar('naam', XOBJ_DTYPE_TXTAREA, null, false);
39			$this->initVar('id_owner', XOBJ_DTYPE_INT, null, false, 11);
40			$this->initVar('id_breeder', XOBJ_DTYPE_INT, null, false, 11);
41			$this->initVar('user', XOBJ_DTYPE_TXTBOX, null, false, 25);
42			$this->initVar('roft', XOBJ_DTYPE_TXTBOX, null, false, 1);
43			$this->initVar('mother', XOBJ_DTYPE_INT, null, false, 5);
44			$this->initVar('father', XOBJ_DTYPE_INT, null, false, 5);
45			$this->initVar('foto', XOBJ_DTYPE_TXTBOX, null, false, 255);
46			$this->initVar('coi', XOBJ_DTYPE_TXTBOX, null, false, 10);
47			}
48
49			/**
50			* @param bool $action
51			*
52			* @return \XoopsThemeForm
53			*/
54			public function getForm($action = false)
55			{
56			//global $xoopsModuleConfig;
			0 ignored issues – show Unused Code Comprehensibility introduced 2019-10-21 01:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
57
58
59			if (false === $action) {
60			$action = $_SERVER['REQUEST_URI'];
61			}
62
63			$title = $this->isNew() ? sprintf(_AM_PEDIGREE_PEDIGREE_TRASH_ADD) : sprintf(_AM_PEDIGREE_PEDIGREE_TRASH_EDIT);
64
65			require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
66
67			$form = new \XoopsThemeForm($title, 'form', $action, 'post', true);
68			$form->setExtra('enctype="multipart/form-data"');
69
70			$form->addElement(new \XoopsFormTextArea(_AM_PEDIGREE_PEDIGREE_TRASH_NAAM, 'naam', $this->getVar('naam'), 4, 47), true);
71			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_ID_OWNER, 'id_owner', 50, 255, $this->getVar('id_owner')), false);
72			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_ID_BREEDER, 'id_breeder', 50, 255, $this->getVar('id_breeder')), false);
73			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_USER, 'user', 50, 255, $this->getVar('user')), false);
74			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_ROFT, 'roft', 50, 255, $this->getVar('roft')), false);
75			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_MOTHER, 'mother', 50, 255, $this->getVar('mother')), false);
76			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_FATHER, 'father', 50, 255, $this->getVar('father')), false);
77			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_FOTO, 'foto', 50, 255, $this->getVar('foto')), false);
78			$form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TRASH_COI, 'coi', 50, 255, $this->getVar('coi')), false);
79
80			$form->addElement(new \XoopsFormHidden('op', 'save_pedigree_trash'));
81
82			//Submit buttons
83			$button_tray = new \XoopsFormElementTray('', '');
84			$submit_button = new \XoopsFormButton('', 'submit', _SUBMIT, 'submit');
85			$button_tray->addElement($submit_button);
86
87			$cancel_button = new \XoopsFormButton('', '', _CANCEL, 'cancel');
88			$cancel_button->setExtra('onclick="history.go(-1)"');
89			$button_tray->addElement($cancel_button);
90
91			$form->addElement($button_tray);
92
93			return $form;
94			}
95			}
96

mambax7 / pedigree

Push — master ( b847d6...d6d54c )

class/Trash.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like