pedigree_config_post() - Code Metrics - Inspection of "Merge pull request #3 from zyspec/master" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b847d6...d6d54c )

by Michael

created 2019-10-21 01:45 UTC

pedigree_config_post() A

↳ Parent: Project

Complexity

Conditions	5
Paths	12

Size

Total Lines	31
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	23
c	0
b	0
f	0
nc	12
nop	0
dl	0
loc	31
rs	9.2408

<?php

// -------------------------------------------------------------------------
//    pedigree
//        Copyright 2004, James Cotton
//         http://www.dobermannvereniging.nl
//    Template
//        Copyright 2004 Thomas Hill
//        <a href="http://www.worldware.com">worldware.com</a>
// -------------------------------------------------------------------------
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
// ------------------------------------------------------------------------- //

use Xmf\Request;
use XoopsModules\Pedigree;

//To be deleted?

require_once  dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';
//require_once(XOOPS_ROOT_PATH . "/modules/" . $xoopsModule->dirname() . "/include/pedigree_includes.php");

//require_once dirname(__DIR__) . "/include/pedigree_includes.php";

xoops_loadLanguage('modinfo', basename(dirname(dirname(__DIR__))));
require_once $GLOBALS['xoops']->path('modules/pedigree/admin/menu.php');

// Get HTTP post/get parameters.
//import_request_variables("gp", "param_");
extract($_GET, EXTR_PREFIX_ALL, 'param');
extract($_POST, EXTR_PREFIX_ALL, 'param');

$op = Request::getCmd('op', 'main');
//
// Writes out the form to get all config parameters.
//
function pedigree_config_form()
{
    $config_fields = pedigree_get_config_fields();
    $config_fields = /** @scrutinizer ignore-call */ pedigree_get_config_fields();
    $values        = pedigree_get_config();
    $values        = /** @scrutinizer ignore-call */ pedigree_get_config();
    print "
    <form action='config.php' method='POST' enctype='application/x-www-form-urlencoded'>\n
    <table border='1' cellpadding='0' cellspacing='0' width='100%'>\n
        <tr><th>" . _AM_PEDIGREE_CTITLE . "</th></tr>\n
        <tr>\n
        <td class='bg2'>\n
            <table width='100%' border='0' cellpadding='4' cellspacing='1'>\n";

    foreach ($config_fields as $field => $prompt) {
        if ('config_id' === $field) {
            continue;
        }
        $pname = 'param_' . $field;

        print "
                <tr nowrap='nowrap'>\n
                <td class ='head'>{$prompt}</td>\n
                <td class='even aligntop'>\n
                    <input type='text' name='{$field}' size='32' maxlength='32' value ='{$values[$field]}'>\n
                </td></tr>\n
                </tr>\n";
    }
    print "
                <td class='head'>&nbsp;</td>\n
                <td class='even'>\n
                    <input type='hidden' name='op' value='config'>\n
                    <input type='hidden' name='window' value='config'>\n
                    <input type='submit' value='" . _AM_PEDIGREE_BUT_GO . "'>\n
                </td></tr>\n
            </table>\n
        </td></tr>\n
    </table>\n
    </form>\n";
}

/**
 *
 * @todo: create pedigree_admin_hmenu - it doesn't exist
 *
 * Displays the main admin interface
 *
 */
function pedigree_config_main()
{
    //xoops_cp_header();

    $p_title = _AM_PEDIGREE_CONFIGURE;
    print "<h4 style='text-align:left;'>$p_title</h4>";
    pedigree_admin_hmenu();
    pedigree_admin_hmenu();
    pedigree_config_form();
    xoops_cp_footer();
    exit();

}

/**
 *
 * @todo: create pedigree_get_config_fields() method, it doesn't exist anywhere
 *
 * Processes the configuration update request, by
 * getting the HTTP parameters, and putting them into the database.
 */
function pedigree_config_post()
{
    $config_fields = pedigree_get_config_fields();
    $config_fields = /** @scrutinizer ignore-call */ pedigree_get_config_fields();
    foreach ($config_fields as $field => $prompt) {
        $param = 'param_' . $field;

        global $$param;
function myFunction($a, $b) {
    // Do something
}
    }
    $param_config_id = 1;
    $sql             = 'REPLACE INTO ' . $GLOBALS['xoopsDB']->prefix('pedigree_fields') . ' (' . pedigree_to_string($config_fields) . ') VALUES (';
    $sql             = 'REPLACE INTO ' . $GLOBALS['xoopsDB']->prefix('pedigree_fields') . ' (' . /** @scrutinizer ignore-call */ pedigree_to_string($config_fields) . ') VALUES (';

    $first = true;
    foreach ($config_fields as $field => $prompt) {
        $param = 'param_' . $field;
        if (!$first) {
            $sql .= ', ';
        }
        // Handle a 'feature' of PHP that adds backslashes to HTTP parameters.
        $param_value = $$param;
        $sql         .= "'" . $GLOBALS['xoopsDB']->escape($param_value) . "'";
        $first       = false;
    }
    $sql .= ' )';
    if (!$GLOBALS['xoopsDB']->query($sql)) {
        $error = $GLOBALS['xoopsDB']->error();
        xoops_cp_header();
        pedigree_show_sql_error(_AM_PEDIGREE_ERR_ADD_FAILED, $error, $sql);
        pedigree_show_sql_error(_AM_PEDIGREE_ERR_ADD_FAILED, $error, $sql);
        xoops_cp_footer();
    } else {
        redirect_header('config.php', 1, _AM_PEDIGREE_OK_DB);
    }
    exit();

}

switch ($op) {
    case 'main':
        pedigree_config_main();
        break;
    case 'config':
        pedigree_config_post();
        break;
    default:
        //xoops_cp_header();

        /* @todo: move hard coded language string to language file */
        print "<h1>Unknown method requested ('{$op}')</h1>";
        xoops_cp_footer();
}


Push — master ( b847d6...d6d54c )

pedigree_config_post() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

mambax7 / pedigree

Push — master ( b847d6...d6d54c )

pedigree_config_post() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like