Passed
Push — master ( b847d6...d6d54c )
by Michael
09:34 queued 05:00
created

Temp::getForm()   A

Complexity

Conditions 3
Paths 4

Size

Total Lines 49
Code Lines 31

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 3
eloc 31
nc 4
nop 1
dl 0
loc 49
rs 9.424
c 0
b 0
f 0
1
<?php namespace XoopsModules\Pedigree;
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 29 and the first side effect is on line 24.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
3
/*
4
 You may not change or alter any portion of this comment or credits
5
 of supporting developers from this source code or any supporting source code
6
 which is considered copyrighted (c) material of the original comment or credit authors.
7
8
 This program is distributed in the hope that it will be useful,
9
 but WITHOUT ANY WARRANTY; without even the implied warranty of
10
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11
*/
12
/**
13
 * Pedigree module for XOOPS
14
 *
15
 * @copyright       XOOPS Project (https://xoops.org)
16
 * @license         GPL 2.0 or later
17
 * @package         pedigree
18
 * @since           2.5.x
19
 * @author          XOOPS Module Dev Team (https://xoops.org)
20
 */
21
22
use XoopsModules\Pedigree;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, XoopsModules\Pedigree\Pedigree. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
23
24
defined('XOOPS_ROOT_PATH') || die('Restricted access');
25
26
/**
27
 * Class Pedigree\Temp
28
 */
29
class Temp extends \XoopsObject
30
{
31
    //Constructor
32
    /**
33
     *
34
     */
35
    public function __construct()
36
    {
37
        parent::__construct();
38
        $this->initVar('id', XOBJ_DTYPE_INT, null, false, 11);
39
        $this->initVar('naam', XOBJ_DTYPE_TXTAREA, null, false);
40
        $this->initVar('id_owner', XOBJ_DTYPE_INT, null, false, 11);
41
        $this->initVar('id_breeder', XOBJ_DTYPE_INT, null, false, 11);
42
        $this->initVar('user', XOBJ_DTYPE_TXTBOX, null, false, 25);
43
        $this->initVar('roft', XOBJ_DTYPE_TXTAREA, null, false);
44
        $this->initVar('mother', XOBJ_DTYPE_INT, null, false, 5);
45
        $this->initVar('father', XOBJ_DTYPE_INT, null, false, 5);
46
        $this->initVar('foto', XOBJ_DTYPE_TXTBOX, null, false, 255);
47
        $this->initVar('coi', XOBJ_DTYPE_TXTBOX, null, false, 10);
48
    }
49
50
    /**
51
     * @param bool $action
52
     *
53
     * @return \XoopsThemeForm
54
     */
55
    public function getForm($action = false)
56
    {
57
        global $xoopsDB, $xoopsModuleConfig;
0 ignored issues
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
58
59
        if (false === $action) {
60
            $action = $_SERVER['REQUEST_URI'];
61
        }
62
63
        $title = $this->isNew() ? sprintf(_AM_PEDIGREE_PEDIGREE_TEMP_ADD) : sprintf(_AM_PEDIGREE_PEDIGREE_TEMP_EDIT);
64
65
        require_once $GLOBALS['xoops']->path('class/xoopsformloader.php');
66
67
        $form = new \XoopsThemeForm($title, 'form', $action, 'post', true);
68
        $form->setExtra('enctype="multipart/form-data"');
69
70
        $form->addElement(new \XoopsFormTextArea(_AM_PEDIGREE_PEDIGREE_TEMP_NAAM, 'naam', $this->getVar('naam'), 4, 47), true);
0 ignored issues
show
Bug introduced by
It seems like $this->getVar('naam') can also be of type array and array; however, parameter $value of XoopsFormTextArea::__construct() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

70
        $form->addElement(new \XoopsFormTextArea(_AM_PEDIGREE_PEDIGREE_TEMP_NAAM, 'naam', /** @scrutinizer ignore-type */ $this->getVar('naam'), 4, 47), true);
Loading history...
71
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_ID_OWNER, 'id_owner', 50, 255, $this->getVar('id_owner')), false);
0 ignored issues
show
Bug introduced by
It seems like $this->getVar('id_owner') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

71
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_ID_OWNER, 'id_owner', 50, 255, /** @scrutinizer ignore-type */ $this->getVar('id_owner')), false);
Loading history...
72
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_ID_BREEDER, 'id_breeder', 50, 255, $this->getVar('id_breeder')), false);
73
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_USER, 'user', 50, 255, $this->getVar('user')), false);
74
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_ROFT, 'roft', 50, 255, $this->getVar('roft')), false);
75
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_MOTHER, 'mother', 50, 255, $this->getVar('mother')), false);
76
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_FATHER, 'father', 50, 255, $this->getVar('father')), false);
77
        $form->addElement(new \XoopsFormText(_AM_PEDIGREE_PEDIGREE_TEMP_FOTO, 'foto', 50, 255, $this->getVar('foto')), false);
78
79
        //            $Handler = xoops_getModuleHandler("animal_", $xoopsModule->getVar("dirname"));
0 ignored issues
show
Unused Code Comprehensibility introduced by
62% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
80
        $tempHandler = Pedigree\Helper::getInstance()->getHandler('Temp');
81
        $criteria    = new \CriteriaCompo();
82
        $criteria->setSort('id');
83
        $criteria->setOrder('ASC');
84
        $_arr   = $tempHandler->getAll();
85
        //@todo - the keys below aren't right for XoopsObjectTree. _id should be id, then need to determine which lineage (father/mother)
86
        //        and then use the appropriate key ('father', 'mother'). Can't really do a "combined" tree using XoopsObjectTree only.
87
        $mytree = new \XoopsObjectTree($_arr, '_id', '_pid');
88
        $form->addElement(new \XoopsFormLabel(_AM_PEDIGREE_PEDIGREE_TEMP_COI, $mytree->makeSelBox('_pid', '_title', '--', $this->getVar('_pid'), false)));
0 ignored issues
show
Deprecated Code introduced by
The function XoopsObjectTree::makeSelBox() has been deprecated: since 2.5.9, please use makeSelectElement() ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-deprecated  annotation

88
        $form->addElement(new \XoopsFormLabel(_AM_PEDIGREE_PEDIGREE_TEMP_COI, /** @scrutinizer ignore-deprecated */ $mytree->makeSelBox('_pid', '_title', '--', $this->getVar('_pid'), false)));

This function has been deprecated. The supplier of the function has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the function will be removed and what other function to use instead.

Loading history...
Bug introduced by
It seems like $this->getVar('_pid') can also be of type array and array; however, parameter $selected of XoopsObjectTree::makeSelBox() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

88
        $form->addElement(new \XoopsFormLabel(_AM_PEDIGREE_PEDIGREE_TEMP_COI, $mytree->makeSelBox('_pid', '_title', '--', /** @scrutinizer ignore-type */ $this->getVar('_pid'), false)));
Loading history...
89
90
        $form->addElement(new \XoopsFormHidden('op', 'save_pedigree_temp'));
91
92
        //Submit buttons
93
        $button_tray   = new \XoopsFormElementTray('', '');
94
        $submit_button = new \XoopsFormButton('', 'submit', _SUBMIT, 'submit');
95
        $button_tray->addElement($submit_button);
96
97
        $cancel_button = new \XoopsFormButton('', '', _CANCEL, 'cancel');
98
        $cancel_button->setExtra('onclick="history.go(-1)"');
99
        $button_tray->addElement($cancel_button);
100
101
        $form->addElement($button_tray);
102
103
        return $form;
104
    }
105
}
106