SISContext::myGoto() - Code Metrics - Inspection of "Merge pull request #3 from zyspec/master" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b847d6...d6d54c )

by Michael

created 2019-10-21 01:45 UTC

SISContext::myGoto() A

↳ Parent: SISContext

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	10
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	18
rs	9.9332

<?php namespace XoopsModules\Pedigree;

use XoopsModules\Pedigree;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * Class Pedigree\SISContext
 */
class SISContext
{
    private $contexts;
    private $depth;

    /**
     * SISContext constructor.
     */
    public function __construct()
    {
        $this->contexts = [];
        $this->depth    = 0;
    }

    /**
     * @param $url
     * @param $name
     */
    public function myGoto($url, $name)
    {
        $keys = array_keys($this->contexts);
        for ($i = 0; $i < $this->depth; ++$i) {
            if ($keys[$i] == $name) {
                $this->contexts[$name] = $url; // the url might be slightly different
                $this->depth           = $i + 1;

                for ($x = count($this->contexts); $x > $i + 1; $x--) {
                    array_pop($this->contexts);
                }

                return;
            }
        }

        $this->contexts[$name] = $url;
        $this->depth++;
    }

    /**
     * @return array
     */
    public function getAllContexts()
    {
        return $this->contexts;
    }

    /**
     * @return array
     */
    public function getAllContextNames()
    {
        return array_keys($this->contexts);
    }
}


1			<?php namespace XoopsModules\Pedigree;
2
3			use XoopsModules\Pedigree;
			0 ignored issues – show Bug introduced 2019-10-21 01:50 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `XoopsModules\Pedigree\Pedigree`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
4
5			/**
6			* Class Pedigree\SISContext
7			*/
8			class SISContext
9			{
10			private $contexts;
11			private $depth;
12
13			/**
14			* SISContext constructor.
15			*/
16			public function __construct()
17			{
18			$this->contexts = [];
19			$this->depth = 0;
20			}
21
22			/**
23			* @param $url
24			* @param $name
25			*/
26			public function myGoto($url, $name)
27			{
28			$keys = array_keys($this->contexts);
29			for ($i = 0; $i < $this->depth; ++$i) {
30			if ($keys[$i] == $name) {
31			$this->contexts[$name] = $url; // the url might be slightly different
32			$this->depth = $i + 1;
33
34			for ($x = count($this->contexts); $x > $i + 1; $x--) {
35			array_pop($this->contexts);
36			}
37
38			return;
39			}
40			}
41
42			$this->contexts[$name] = $url;
43			$this->depth++;
44			}
45
46			/**
47			* @return array
48			*/
49			public function getAllContexts()
50			{
51			return $this->contexts;
52			}
53
54			/**
55			* @return array
56			*/
57			public function getAllContextNames()
58			{
59			return array_keys($this->contexts);
60			}
61			}
62

mambax7 / pedigree

Push — master ( b847d6...d6d54c )

SISContext::myGoto() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like