OwnerHandler - Code Metrics - Inspection of "Merge pull request #3 from zyspec/master" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b847d6...d6d54c )

by Michael

created 2019-10-21 01:45 UTC

OwnerHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	6
c	2
b	0
f	0
dl	0
loc	36
rs	10
wmc	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getActiveCriteria()	0	21	1
A	__construct()	0	3	1

<?php namespace XoopsModules\Pedigree;


/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Pedigree module for XOOPS
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GPL 2.0 or later
 * @package         \XoopsModules\Pedigree\Class
 * @since
 * @author          XOOPS Module Dev Team (https://xoops.org)
 */

use XoopsModules\Pedigree;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Class Pedigree\OwnerHandler
 */
class OwnerHandler extends \XoopsPersistableObjectHandler
{
    /**
     * @param null|object|\XoopsDatabase $db
     */
    public function __construct(\XoopsDatabase $db)
    {
        parent::__construct($db, 'pedigree_owner', Owner::class, 'id', 'firstname');
    }

    /**
     * Get criteria for active animals
     *
     * @return \CriteriaCompo
     */
    public function getActiveCriteria()
    {
        /** @todo this currently returns all animals, not just active ones - should it? */
        //$grouppermHandler = xoops_getHandler('groupperm');


        //        $criteria = new \CriteriaCompo(new \Criteria('offline', false));

        //        $criteria->add(new \Criteria('published', 0, '>'));

        //        $criteria->add(new \Criteria('published', time(), '<='));

        //        $expiredCriteria = new \CriteriaCompo(new \Criteria('expired', 0));

        //        $expiredCriteria->add(new \Criteria('expired', time(), '>='), 'OR');

        //        $criteria->add($expiredCriteria);

        // add criteria for categories that the user has permissions for
        //        $groups                   = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : array(0 => XOOPS_GROUP_ANONYMOUS);

        //mb        $allowedDownCategoriesIds = $grouppermHandler->getItemIds('WFDownCatPerm', $groups, $this->wfdownloads->getModule()->mid());

        //mb        $criteria->add(new \Criteria('cid', '(' . implode(',', $allowedDownCategoriesIds) . ')', 'IN'));


        $criteria = new \CriteriaCompo();
        $criteria->setSort('lastname');
        $criteria->setOrder('ASC');

        return $criteria;
    }
}


1			<?php namespace XoopsModules\Pedigree;
			0 ignored issues – show Coding Style Compatibility introduced 2019-01-19 04:01 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 29 and the first side effect is on line 24. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/*
4			You may not change or alter any portion of this comment or credits
5			of supporting developers from this source code or any supporting source code
6			which is considered copyrighted (c) material of the original comment or credit authors.
7
8			This program is distributed in the hope that it will be useful,
9			but WITHOUT ANY WARRANTY; without even the implied warranty of
10			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*/
12			/**
13			* Pedigree module for XOOPS
14			*
15			* @copyright XOOPS Project (https://xoops.org)
16			* @license GPL 2.0 or later
17			* @package \XoopsModules\Pedigree\Class
18			* @since
19			* @author XOOPS Module Dev Team (https://xoops.org)
20			*/
21
22			use XoopsModules\Pedigree;
			0 ignored issues – show Bug introduced 2019-10-21 01:50 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `XoopsModules\Pedigree\Pedigree`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
23
24			defined('XOOPS_ROOT_PATH') \|\| die('Restricted access');
25
26			/**
27			* Class Pedigree\OwnerHandler
28			*/
29			class OwnerHandler extends \XoopsPersistableObjectHandler
30			{
31			/**
32			* @param null\|object\|\XoopsDatabase $db
33			*/
34			public function __construct(\XoopsDatabase $db)
35			{
36			parent::__construct($db, 'pedigree_owner', Owner::class, 'id', 'firstname');
37			}
38
39			/**
40			* Get criteria for active animals
41			*
42			* @return \CriteriaCompo
43			*/
44			public function getActiveCriteria()
45			{
46			/** @todo this currently returns all animals, not just active ones - should it? */
47			//$grouppermHandler = xoops_getHandler('groupperm');
			0 ignored issues – show Unused Code Comprehensibility introduced 2019-10-21 01:50 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48
49			// $criteria = new \CriteriaCompo(new \Criteria('offline', false));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			// $criteria->add(new \Criteria('published', 0, '>'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51			// $criteria->add(new \Criteria('published', time(), '<='));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			// $expiredCriteria = new \CriteriaCompo(new \Criteria('expired', 0));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53			// $expiredCriteria->add(new \Criteria('expired', time(), '>='), 'OR');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `68%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
54			// $criteria->add($expiredCriteria);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
55			// add criteria for categories that the user has permissions for
56			// $groups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : array(0 => XOOPS_GROUP_ANONYMOUS);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
57			//mb $allowedDownCategoriesIds = $grouppermHandler->getItemIds('WFDownCatPerm', $groups, $this->wfdownloads->getModule()->mid());
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			//mb $criteria->add(new \Criteria('cid', '(' . implode(',', $allowedDownCategoriesIds) . ')', 'IN'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
59
60			$criteria = new \CriteriaCompo();
61			$criteria->setSort('lastname');
62			$criteria->setOrder('ASC');
63
64			return $criteria;
65			}
66			}
67

mambax7 / pedigree

Push — master ( b847d6...d6d54c )

OwnerHandler A

Complexity

Size/Duplication

Importance

2 Methods

Duplication Side-by-Side

Filter issues like