Issues in breeder.php - Fixed Issues - Inspection of "code cleanup" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6e3dd5...871d94 )

by Michael

created 2016-04-24 22:59 UTC

breeder.php (1 issue)

Labels

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
// -------------------------------------------------------------------------

require_once dirname(dirname(__DIR__)) . '/mainfile.php';
$moduleDirName = basename(__DIR__);
xoops_loadLanguage('main', $moduleDirName);
// Include any common code for this module.

// Get all HTTP post or get parameters into global variables that are prefixed with "param_"
//import_request_variables("gp", "param_");
extract($_GET, EXTR_PREFIX_ALL, 'param');
extract($_POST, EXTR_PREFIX_ALL, 'param');

$xoopsOption['template_main'] = 'pedigree_breeder.tpl';

include XOOPS_ROOT_PATH . '/header.php';
// Include any common code for this module.
require_once(XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/include/common.php');
$xoopsTpl->assign('page_title', 'Pedigree database - View owner/breeder');

//get module configuration
$moduleHandler = xoops_getHandler('module');
$module        = $moduleHandler->getByDirname('pedigree');
$configHandler = xoops_getHandler('config');
$moduleConfig  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));

if (!isset($f)) {
    $f = 'lastname';
}
//find letter on which to start else set to 'a'
if (isset($_GET['l'])) {
    $l = $_GET['l'];
} else {
    $l = 'a';
}
$w = $l . '%';
if ($l == 1) {
    $l = 'LIKE';
}
if (!isset($o)) {
    $o = 'lastname';
}
if (!isset($d)) {
    $d = 'ASC';
}
if (!isset($st)) {
    $st = 0;
}

$perp = $moduleConfig['perpage'];

global $xoopsTpl;
global $xoopsDB;
global $xoopsModuleConfig;

//iscurrent user a module admin ?
$modadmin    = false;
$xoopsModule = XoopsModule::getByDirname('pedigree');
if (!empty($xoopsUser)) {
    if ($xoopsUser->isAdmin($xoopsModule->mid())) {
        $modadmin = true;
    }
}

//count total number of owners
$numowner = 'SELECT count(ID) from ' . $GLOBALS['xoopsDB']->prefix('pedigree_owner') . ' WHERE ' . $f . " LIKE '" . $w . "'";
$numres   = $GLOBALS['xoopsDB']->query($numowner);
//total number of owners the query will find
list($numresults) = $GLOBALS['xoopsDB']->fetchRow($numres);
//total number of pages
$numpages = floor($numresults / $perp) + 1;
if (($numpages * $perp) == ($numresults + $perp)) {
    ++$numpages;
}
//find current page
$cpage = floor($st / $perp) + 1;
//create alphabet
$pages = '';
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=a\">A</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=b\">B</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=c\">C</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=d\">D</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=e\">E</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=f\">F</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=g\">G</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=h\">H</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=i\">I</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=j\">J</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=k\">K</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=l\">L</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=m\">M</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=n\">N</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=o\">O</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=p\">P</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=q\">Q</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=r\">R</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=s\">S</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=t\">T</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=u\">U</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=v\">V</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=w\">W</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=x\">X</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=y\">Y</a>&nbsp;";
$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=z\">Z</a>&nbsp;";
//create linebreak
$pages .= '<br />';
//create previous button
if ($numpages > 1) {
    if ($cpage > 1) {
        $pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . '&l=' . $l . '&st=' . ($st - $perp) . "\">" . _MA_PEDIGREE_PREVIOUS . '</a>&nbsp;&nbsp;';
    }
}
//create numbers
for ($x = 1; $x < ($numpages + 1); ++$x) {
    //create line break after 20 number
    if (($x % 20) == 0) {
        $pages .= '<br />';
    }
    if ($x != $cpage) {
        $pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . '&l=' . $l . '&st=' . ($perp * ($x - 1)) . "\">" . $x . '</a>&nbsp;&nbsp;';
    } else {
        $pages .= $x . '&nbsp;&nbsp';
    }
}
//create next button
if ($numpages > 1) {
    if ($cpage < $numpages) {
        $pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . '&l=' . $l . '&st=' . ($st + $perp) . "\">" . _MA_PEDIGREE_NEXT . '</a>&nbsp;&nbsp;';
    }
}

//query
$queryString = 'SELECT * from ' . $GLOBALS['xoopsDB']->prefix('pedigree_owner') . ' WHERE ' . $f . " LIKE '" . $w . "' ORDER BY " . $o . ' ' . $d . ' LIMIT ' . $st . ', ' . $perp;
$result      = $GLOBALS['xoopsDB']->query($queryString);

while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
    print_r();
    //check for access
    $access = '';
    if (!empty($xoopsUser)) {
        if ($row['user'] == $xoopsUser->getVar('uid') || $modadmin == true) {

            //$access = "<a href=\"dog.php?id=".$row['Id']."\"><img src=\"assets/images/edit.gif\" alt="._MA_PEDIGREE_BTN_EDIT."></a>";
            $access .= "<a href=\"deletebreeder.php?id=" . $row['Id'] . "\"><img src=\"assets/images/delete.gif\" alt=" . _MA_PEDIGREE_BTN_DELE . '></a>';
        } else {
            $access = '';
        }
    }
    //make names
    $name = $access . "<a href=\"owner.php?ownid=" . $row['Id'] . "\">" . stripslashes($row['lastname']) . ', ' . stripslashes($row['firstname']) . '</a>';
    //create array for owners
    $dogs[] = array(
        'id'   => $row['Id'],
        'name' => $name,
        'city' => $row['city']
    );
}

//add data to smarty template
//assign dog
if (isset($dogs)) {
    $xoopsTpl->assign('dogs', $dogs);
}
//assign links
if ($d === 'ASC') {
    $nl = "<a href=\"breeder.php?f=" . $f . "&o=lastname&d=DESC\">" . _MA_PEDIGREE_OWN_NAME . '</a>';
    $cl = "<a href=\"breeder.php?f=" . $f . "&o=city&d=DESC\">" . _MA_PEDIGREE_OWN_CITY . '</a>';
} else {
    $nl = "<a href=\"breeder.php?f=" . $f . "&o=lastname&d=ASC\">" . _MA_PEDIGREE_OWN_NAME . '</a>';
    $cl = "<a href=\"breeder.php?f=" . $f . "&o=city&d=ASC\">" . _MA_PEDIGREE_OWN_CITY . '</a>';
}
$xoopsTpl->assign('namelink', $nl);
$xoopsTpl->assign('colourlink', $cl);

//find last shown number
if (($st + $perp) > $numresults) {
    $lastshown = $numresults;
} else {
    $lastshown = $st + $perp;
}
//create string
$matches     = _MA_PEDIGREE_MATCHESB;
$nummatchstr = $numresults . $matches . ($st + 1) . '-' . $lastshown . ' (' . $numpages . ' pages)';
$xoopsTpl->assign('nummatch', $nummatchstr);
$xoopsTpl->assign('pages', $pages);

//$breederArray['letters']          = PedigreeUtilities::lettersChoice();

$myObject     = PedigreePedigree::getInstance();
$criteria     = $myObject->getHandler('tree')->getActiveCriteria();
$activeObject = 'owner';
$name         = 'lastname';
$file         = 'breeder.php';
$file2        = "breeder.php?f={$name}&amp;o={$name}&amp;d=ASC&amp;st=0&amp;l={$letter}";

$breederArray['letters'] = PedigreeUtilities::lettersChoice($myObject, $activeObject, $criteria, $name, $file, $file2);
//$catarray['toolbar']          = pedigree_toolbar();
$xoopsTpl->assign('breederArray', $breederArray);

//comments and footer
include XOOPS_ROOT_PATH . '/footer.php';


1		<?php
2		// -------------------------------------------------------------------------
3
4		require_once dirname(dirname(__DIR__)) . '/mainfile.php';
5		$moduleDirName = basename(__DIR__);
6		xoops_loadLanguage('main', $moduleDirName);
7		// Include any common code for this module.
8
9		// Get all HTTP post or get parameters into global variables that are prefixed with "param_"
10		//import_request_variables("gp", "param_");
11		extract($_GET, EXTR_PREFIX_ALL, 'param');
12		extract($_POST, EXTR_PREFIX_ALL, 'param');
13
14		$xoopsOption['template_main'] = 'pedigree_breeder.tpl';
15
16		include XOOPS_ROOT_PATH . '/header.php';
17		// Include any common code for this module.
18		require_once(XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/include/common.php');
19		$xoopsTpl->assign('page_title', 'Pedigree database - View owner/breeder');
20
21		//get module configuration
22		$moduleHandler = xoops_getHandler('module');
23		$module = $moduleHandler->getByDirname('pedigree');
24		$configHandler = xoops_getHandler('config');
25		$moduleConfig = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
26
27		if (!isset($f)) {
28		$f = 'lastname';
29		}
30		//find letter on which to start else set to 'a'
31		if (isset($_GET['l'])) {
32		$l = $_GET['l'];
33		} else {
34		$l = 'a';
35		}
36		$w = $l . '%';
37		if ($l == 1) {
38		$l = 'LIKE';
39		}
40		if (!isset($o)) {
41		$o = 'lastname';
42		}
43		if (!isset($d)) {
44		$d = 'ASC';
45		}
46		if (!isset($st)) {
47		$st = 0;
48		}
49
50		$perp = $moduleConfig['perpage'];
51
52		global $xoopsTpl;
53		global $xoopsDB;
54		global $xoopsModuleConfig;
55
56		//iscurrent user a module admin ?
57		$modadmin = false;
58		$xoopsModule = XoopsModule::getByDirname('pedigree');
59		if (!empty($xoopsUser)) {
60		if ($xoopsUser->isAdmin($xoopsModule->mid())) {
61		$modadmin = true;
62		}
63		}
64
65		//count total number of owners
66		$numowner = 'SELECT count(ID) from ' . $GLOBALS['xoopsDB']->prefix('pedigree_owner') . ' WHERE ' . $f . " LIKE '" . $w . "'";
67		$numres = $GLOBALS['xoopsDB']->query($numowner);
68		//total number of owners the query will find
69		list($numresults) = $GLOBALS['xoopsDB']->fetchRow($numres);
70		//total number of pages
71		$numpages = floor($numresults / $perp) + 1;
72		if (($numpages * $perp) == ($numresults + $perp)) {
73		++$numpages;
74		}
75		//find current page
76		$cpage = floor($st / $perp) + 1;
77		//create alphabet
78		$pages = '';
79		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=a\">A</a> ";
80		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=b\">B</a> ";
81		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=c\">C</a> ";
82		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=d\">D</a> ";
83		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=e\">E</a> ";
84		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=f\">F</a> ";
85		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=g\">G</a> ";
86		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=h\">H</a> ";
87		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=i\">I</a> ";
88		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=j\">J</a> ";
89		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=k\">K</a> ";
90		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=l\">L</a> ";
91		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=m\">M</a> ";
92		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=n\">N</a> ";
93		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=o\">O</a> ";
94		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=p\">P</a> ";
95		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=q\">Q</a> ";
96		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=r\">R</a> ";
97		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=s\">S</a> ";
98		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=t\">T</a> ";
99		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=u\">U</a> ";
100		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=v\">V</a> ";
101		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=w\">W</a> ";
102		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=x\">X</a> ";
103		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=y\">Y</a> ";
104		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . "&st=0&l=z\">Z</a> ";
105		//create linebreak
106		$pages .= '<br />';
107		//create previous button
108	View Code Duplication	if ($numpages > 1) {
109		if ($cpage > 1) {
110		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . '&l=' . $l . '&st=' . ($st - $perp) . "\">" . _MA_PEDIGREE_PREVIOUS . '</a>  ';
111		}
112		}
113		//create numbers
114		for ($x = 1; $x < ($numpages + 1); ++$x) {
115		//create line break after 20 number
116		if (($x % 20) == 0) {
117		$pages .= '<br />';
118		}
119		if ($x != $cpage) {
120		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . '&l=' . $l . '&st=' . ($perp * ($x - 1)) . "\">" . $x . '</a>  ';
121		} else {
122		$pages .= $x . ' &nbsp';
123		}
124		}
125		//create next button
126	View Code Duplication	if ($numpages > 1) {
127		if ($cpage < $numpages) {
128		$pages .= "<a href=\"breeder.php?f=" . $f . '&o=' . $o . '&d=' . $d . '&l=' . $l . '&st=' . ($st + $perp) . "\">" . _MA_PEDIGREE_NEXT . '</a>  ';
129		}
130		}
131
132		//query
133		$queryString = 'SELECT * from ' . $GLOBALS['xoopsDB']->prefix('pedigree_owner') . ' WHERE ' . $f . " LIKE '" . $w . "' ORDER BY " . $o . ' ' . $d . ' LIMIT ' . $st . ', ' . $perp;
134		$result = $GLOBALS['xoopsDB']->query($queryString);
135
136		while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
137		print_r();
138		//check for access
139		$access = '';
140		if (!empty($xoopsUser)) {
141		if ($row['user'] == $xoopsUser->getVar('uid') \|\| $modadmin == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
142		//$access = "<a href=\"dog.php?id=".$row['Id']."\"><img src=\"assets/images/edit.gif\" alt="._MA_PEDIGREE_BTN_EDIT."></a>";
143		$access .= "<a href=\"deletebreeder.php?id=" . $row['Id'] . "\"><img src=\"assets/images/delete.gif\" alt=" . _MA_PEDIGREE_BTN_DELE . '></a>';
144		} else {
145		$access = '';
146		}
147		}
148		//make names
149		$name = $access . "<a href=\"owner.php?ownid=" . $row['Id'] . "\">" . stripslashes($row['lastname']) . ', ' . stripslashes($row['firstname']) . '</a>';
150		//create array for owners
151		$dogs[] = array(
152		'id' => $row['Id'],
153		'name' => $name,
154		'city' => $row['city']
155		);
156		}
157
158		//add data to smarty template
159		//assign dog
160		if (isset($dogs)) {
161		$xoopsTpl->assign('dogs', $dogs);
162		}
163		//assign links
164		if ($d === 'ASC') {
165		$nl = "<a href=\"breeder.php?f=" . $f . "&o=lastname&d=DESC\">" . _MA_PEDIGREE_OWN_NAME . '</a>';
166		$cl = "<a href=\"breeder.php?f=" . $f . "&o=city&d=DESC\">" . _MA_PEDIGREE_OWN_CITY . '</a>';
167		} else {
168		$nl = "<a href=\"breeder.php?f=" . $f . "&o=lastname&d=ASC\">" . _MA_PEDIGREE_OWN_NAME . '</a>';
169		$cl = "<a href=\"breeder.php?f=" . $f . "&o=city&d=ASC\">" . _MA_PEDIGREE_OWN_CITY . '</a>';
170		}
171		$xoopsTpl->assign('namelink', $nl);
172		$xoopsTpl->assign('colourlink', $cl);
173
174		//find last shown number
175		if (($st + $perp) > $numresults) {
176		$lastshown = $numresults;
177		} else {
178		$lastshown = $st + $perp;
179		}
180		//create string
181		$matches = _MA_PEDIGREE_MATCHESB;
182		$nummatchstr = $numresults . $matches . ($st + 1) . '-' . $lastshown . ' (' . $numpages . ' pages)';
183		$xoopsTpl->assign('nummatch', $nummatchstr);
184		$xoopsTpl->assign('pages', $pages);
185
186		//$breederArray['letters'] = PedigreeUtilities::lettersChoice();
187
188		$myObject = PedigreePedigree::getInstance();
189		$criteria = $myObject->getHandler('tree')->getActiveCriteria();
190		$activeObject = 'owner';
191		$name = 'lastname';
192		$file = 'breeder.php';
193		$file2 = "breeder.php?f={$name}&o={$name}&d=ASC&st=0&l={$letter}";
194
195		$breederArray['letters'] = PedigreeUtilities::lettersChoice($myObject, $activeObject, $criteria, $name, $file, $file2);
196		//$catarray['toolbar'] = pedigree_toolbar();
197		$xoopsTpl->assign('breederArray', $breederArray);
198
199		//comments and footer
200		include XOOPS_ROOT_PATH . '/footer.php';
201

mambax7 / pedigree

Push — master ( 6e3dd5...871d94 )

breeder.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like