add_dog.php ➔ sire()

Complexity

Conditions	38
Paths	> 20000

Size

Total Lines	236
Code Lines	155

Duplication

Lines	66
Ratio	27.97 %

Importance

Changes

0

<?php
        $animal = new Pedigree\Animal();
        //test to find out how many user fields there are..
        $fields = $animal->getNumOfFields();

        for ($i = 0, $iMax = count($fields); $i < $iMax; ++$i) {
            $userField   = new Pedigree\Field($fields[$i], $animal->getConfig());
            $fieldType   = $userField->getSetting('FieldType');
            $fieldObject = new $fieldType($userField, $animal);
            if ($userField->isActive() && !$userField->isLocked()) {
                $newEntry = $fieldObject->newField();
                $form->addElement($newEntry);
            }
            unset($newEntry);
        }

        //submit button
        $form->addElement(new \XoopsFormButton('', 'button_id', strtr(_MA_PEDIGREE_ADD_SIRE, ['[father]' => $moduleConfig['father']]), 'submit'));

        //add data (form) to smarty template
        $xoopsTpl->assign('form', $form->render());
    }
}

function sire()
{
    global $xoopsTpl, $xoopsUser, $xoopsDB;
    $moduleDirName = basename(__DIR__);
    //get module configuration
    /** @var XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');

The function xoops_getHandler was not found. Maybe you did not declare it correctly or list all dependencies?

    $module        = $moduleHandler->getByDirname($moduleDirName);
    $configHandler = xoops_getHandler('config');
    $moduleConfig  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
    $empty         = []; // an empty array

    //check for access
    if (empty($GLOBALS['xoopsUser']) || !($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
        redirect_header('javascript:history.go(-1)', 3, _NOPERM . '<br>' . _MA_PEDIGREE_REGIST);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

The constant _NOPERM was not found. Maybe you did not declare it correctly or list all dependencies?

    }
    $user = isset($_POST['user']) ? $_POST['user'] : null;
    if (empty($random)) {

The variable $random seems to never exist and therefore empty should always be true.

        //        $random = isset($_POST['random']) ? $_POST['random'] : null;
        $random = Request::getString('random', null, 'POST');
    }
    //    if (isset($_GET['random'])) {
    //        $random = $_GET['random'];
    //    }

    $random = Request::getString('random', $random, 'GET');

    if (empty($st)) {

The variable $st seems to never exist and therefore empty should always be true.

        $st = 0;
    }
    if (isset($_GET['st'])) {
        $st = $_GET['st'];
    }
    $name = isset($_POST['naam']) ? $_POST['naam'] : null;
    $roft = isset($_POST['roft']) ? $_POST['roft'] : null;

    $id_owner   = isset($_POST['id_owner']) ? $_POST['id_owner'] : null;
    $id_breeder = isset($_POST['id_breeder']) ? $_POST['id_breeder'] : null;

    $pictureField = isset($_FILES['photo']) ? $_FILES['photo']['name'] : null; // $_FILES['photo']['name'];
    if (empty($pictureField) || '' == $pictureField) {
        $foto = '';
    } else {
        $foto = Pedigree\Utility::uploadPicture(0);
    }
    $numPictureField = 1;

    //make the redirect
    if (!isset($_GET['r'])) {
        if ('' == $_POST['naam']) {
            redirect_header('add_dog.php', 1, _MA_PEDIGREE_ADD_NAMEPLZ);
        }
        //create animal object
        $animal = new Pedigree\Animal();
        //test to find out how many user fields there are..
        $fields = $animal->getNumOfFields();
        sort($fields); //sort by ID not by order
        $usersql = '';
        for ($i = 0, $iMax = count($fields); $i < $iMax; ++$i) {
            $userField   = new Pedigree\Field($fields[$i], $animal->getConfig());
            $fieldType   = $userField->getSetting('FieldType');
            $fieldObject = new $fieldType($userField, $animal);

The assignment to $fieldObject is dead and can be removed.

            if ($userField->isActive()) {
                //check if _FILES variable exists for user picturefield
                $currentfield = 'user' . $fields[$i];
                $pictureField = $_FILES[$currentfield]['name'];
                if ('Picture' === $fieldType && (!empty($pictureField) || '' != $pictureField)) {
                    $userpicture = Pedigree\Utility::uploadPicture($numPictureField);
                    $usersql .= ",'" . $userpicture . "'";
                    ++$numPictureField;
                } elseif ($userField->isLocked()) {
                    //userfield is locked, substitute default value
                    $usersql .= ",'" . $userField->defaultvalue . "'";
                } else {
                    //echo $fieldType.":".$i.":".$fields[$i]."<br>";
                    $usersql .= ",'" . Pedigree\Utility::unHtmlEntities($_POST['user' . $fields[$i]]) . "'";
                }
            } else {
                $usersql .= ",''";
            }
            //echo $fields[$i]."<br>";
        }

        //insert into pedigree_temp
        //        $query = 'INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . " VALUES ('" . $random . "','" . Pedigree\Utility::unHtmlEntities($name) . "','" . $id_owner . "','" . $id_breeder . "','" . $user . "','" . $roft . "','','','" . $foto . "', ''" . $usersql . ')';
        $query = 'INSERT INTO '
                 . $GLOBALS['xoopsDB']->prefix('pedigree_temp')
                 . " VALUES ('"
                 . $GLOBALS['xoopsDB']->escape($random)
                 . "','"
                 . $GLOBALS['xoopsDB']->escape(Pedigree\Utility::unHtmlEntities($name))
                 . "','"
                 . $GLOBALS['xoopsDB']->escape($id_owner)
                 . "','"
                 . $GLOBALS['xoopsDB']->escape($id_breeder)
                 . "','"
                 . $GLOBALS['xoopsDB']->escape($user)
                 . "','"
                 . $GLOBALS['xoopsDB']->escape($roft)
                 . "','0','0','"
                 . $GLOBALS['xoopsDB']->escape($foto)
                 . "', ''"
                 . $usersql
                 . ')';
        //echo $query; die();
        $GLOBALS['xoopsDB']->queryF($query);
        redirect_header('add_dog.php?f=sire&random=' . $random . '&st=' . $st . '&r=1&l=a', 1, strtr(_MA_PEDIGREE_ADD_SIREPLZ, ['[father]' => $moduleConfig['father']]));
    }
    //find letter on which to start else set to 'a'
    $l = Request::getString('l', 'A', 'GET');
    //    if (isset($_GET['l'])) {
    //        $l = $_GET['l'];
    //    } else {
    //        $l = 'a';
    //    }
    //assign sire to template
    $xoopsTpl->assign('sire', '1');
    //create list of males dog to select from
    $perPage = $moduleConfig['perpage'];
    //count total number of dogs
    $numDog = 'SELECT count(id) FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE roft='0' AND naam LIKE '" . $l . "%'";
    $numRes = $GLOBALS['xoopsDB']->query($numDog);
    //total number of dogs the query will find
    list($numResults) = $GLOBALS['xoopsDB']->fetchRow($numRes);
    //total number of pages
    $numPages = floor($numResults / $perPage) + 1;
    if (($numPages * $perPage) == ($numResults + $perPage)) {
        --$numPages;
    }
    //find current page
    $currentPage = floor($st / $perPage) + 1;
    //create alphabet
    $pages = '';
    for ($i = 65; $i <= 90; ++$i) {
        if ($l == chr($i)) {
            $pages .= '<b><a href="add_dog.php?f=sire&r=1&random=' . $random . '&l=' . chr($i) . '">' . chr($i) . '</a></b>&nbsp;';
        } else {
            $pages .= '<a href="add_dog.php?f=sire&r=1&random=' . $random . '&l=' . chr($i) . '">' . chr($i) . '</a>&nbsp;';
        }
    }
    $pages .= '-&nbsp;';
    $pages .= '<a href="add_dog.php?f=sire&r=1&random=' . $random . '&l=Ã…">Ã…</a>&nbsp;';
    $pages .= '<a href="add_dog.php?f=sire&r=1&random=' . $random . '&l=Ö">Ö</a>&nbsp;';
    //create linebreak
    $pages .= '<br>';
    //create previous button
    if ($numPages > 1) {
        if ($currentPage > 1) {
            $pages .= '<a href="add_dog.php?f=sire&r=1&l=' . $l . '&random=' . $random . '&st=' . ($st - $perPage) . '">' . _MA_PEDIGREE_PREVIOUS . '</a>&nbsp;&nbsp';
        }
    }
    //create numbers
    for ($x = 1; $x < ($numPages + 1); ++$x) {
        //create line break after 20 numbers
        if (0 == ($x % 20)) {
            $pages .= '<br>';
        }
        if ($x != $currentPage) {
            $pages .= '<a href="add_dog.php?f=sire&r=1&l=' . $l . '&random=' . $random . '&st=' . ($perPage * ($x - 1)) . '">' . $x . '</a>&nbsp;&nbsp;';
        } else {
            $pages .= $x . '&nbsp;&nbsp';
        }
    }
    //create next button
    if ($numPages > 1) {
        if ($currentPage < $numPages) {
            $pages .= '<a href="add_dog.php?f=sire&r=1&l=' . $l . '&random=' . $random . '&st=' . ($st + $perPage) . '">' . _MA_PEDIGREE_NEXT . '</a>&nbsp;&nbsp';
        }
    }

    //query
    $queryString = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE roft = '0' AND naam LIKE '" . $l . "%'ORDER BY naam LIMIT " . $st . ', ' . $perPage;
    $result      = $GLOBALS['xoopsDB']->query($queryString);

    $animal = new Pedigree\Animal();
    //test to find out how many user fields there are...
    $fields       = $animal->getNumOfFields();
    $numofcolumns = 1;
    $columns[]    = ['columnname' => 'Name'];

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

    for ($i = 0, $iMax = count($fields); $i < $iMax; ++$i) {
        $userField   = new Pedigree\Field($fields[$i], $animal->getConfig());
        $fieldType   = $userField->getSetting('FieldType');
        $fieldObject = new $fieldType($userField, $animal);
        //create empty string
        $lookupValues = '';
        if ($userField->isActive() && $userField->inList()) {
            if ($userField->hasLookup()) {
                $lookupValues = $userField->lookupField($fields[$i]);
                //debug information
                //print_r($lookupValues);
            }
            $columns[] = [
                'columnname'   => $fieldObject->fieldname,
                'columnnumber' => $userField->getId(),
                'lookupval'    => $lookupValues
            ];
            ++$numofcolumns;
            unset($lookupValues);
        }
    }

    for ($i = 1; $i < $numofcolumns; ++$i) {
        $empty[] = ['value' => ''];
    }
    $dogs [] = [

$dogs was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dogs = array(); before regardless.

        'id'          => '0',
        'name'        => '',
        'gender'      => '',
        'link'        => '<a href="add_dog.php?f=dam&random=' . $random . '&selsire=0">' . strtr(_MA_PEDIGREE_ADD_SIREUNKNOWN, ['[father]' => $moduleConfig['father']]) . '</a>',
        'colour'      => '',
        'number'      => '',
        'usercolumns' => $empty
    ];