add_dog.php ➔ dam()

Complexity

Conditions	24
Paths	> 20000

Size

Total Lines	186
Code Lines	128

Duplication

Lines	74
Ratio	39.78 %

Importance

Changes

0

<?php
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        //create picture information
        if ('' != $row['foto']) {
            $camera = ' <img src="assets/images/camera.png">';
        } else {
            $camera = '';
        }
        $name = stripslashes($row['naam']) . $camera;
        //empty array
        unset($columnvalue);
        //fill array
        for ($i = 1; $i < $numofcolumns; ++$i) {
            $x = $columns[$i]['columnnumber'];
            if (is_array($columns[$i]['lookupval'])) {
                foreach ($columns[$i]['lookupval'] as $key => $keyValue) {
                    if ($key == $row['user' . $x]) {
                        $value = $keyValue['value'];
                    }
                }
                //debug information
                ///echo $columns[$i]['columnname']."is an array !";
            } //format value - cant use object because of query count
            elseif (0 === strncmp($row['user' . $x], 'http://', 7)) {
                $value = '<a href="' . $row['user' . $x] . '">' . $row['user' . $x] . '</a>';
            } else {
                $value = $row['user' . $x];
            }
            $columnvalue[] = ['value' => $value];

The variable $value does not seem to be defined for all execution paths leading up to this point.

        }
        $dogs[] = [
            'id'          => $row['id'],
            'name'        => $name,
            'gender'      => '<img src="assets/images/male.gif">',
            'link'        => '<a href="add_dog.php?f=dam&random=' . $random . '&selsire=' . $row['id'] . '">' . $name . '</a>',
            'colour'      => '',
            'number'      => '',
            'usercolumns' => $columnvalue

The variable $columnvalue does not seem to be defined for all execution paths leading up to this point.

        ];
    }

    //add data to smarty template
    //assign dog
    $xoopsTpl->assign('dogs', $dogs);
    $xoopsTpl->assign('columns', $columns);
    $xoopsTpl->assign('numofcolumns', $numofcolumns);
    $xoopsTpl->assign('tsarray', Pedigree\Utility::sortTable($numofcolumns));
    //assign links
    $xoopsTpl->assign('nummatch', strtr(_MA_PEDIGREE_ADD_SELSIRE, ['[father]' => $moduleConfig['father']]));
    $xoopsTpl->assign('pages', $pages);

    //mb =========== FATHER LETTERS =============================
    $myObject = Pedigree\Helper::getInstance();
    $roft     = 0;
    //    $criteria     = $myObject->getHandler('Tree')->getActiveCriteria($roft);
    $activeObject = 'Tree';
    $name         = 'naam';
    $number1      = '1';

The assignment to $number1 is dead and can be removed.

    $number2      = '0';

The assignment to $number2 is dead and can be removed.

    //    $link         = "virtual.php?r={$number1}&st={$number2}&l=";
    $link = "add_dog.php?f=sire&r=1&random={$random}&l=";

    //    http://localhost/257belgi/modules/pedigree/virtual.php?f=dam&selsire=35277

    $link2 = '';

    $criteria = $myObject->getHandler('Tree')->getActiveCriteria($roft);
    //    $criteria->setGroupby('UPPER(LEFT(' . $name . ',1))');

    $fatherArray['letters'] = Pedigree\Utility::lettersChoice($myObject, $activeObject, $criteria, $name, $link, $link2);

$fatherArray was never initialized. Although not strictly required by PHP, it is generally a good practice to add $fatherArray = array(); before regardless.

    //$catarray['toolbar']          = pedigree_toolbar();
    $xoopsTpl->assign('fatherArray', $fatherArray);

    //mb ========================================
}

function dam()
{
    global $xoopsTpl, $xoopsUser, $xoopsDB;
    $moduleDirName = basename(__DIR__);
    //get module configuration
    /** @var XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');

The function xoops_getHandler was not found. Maybe you did not declare it correctly or list all dependencies?

    $module        = $moduleHandler->getByDirname($moduleDirName);
    $configHandler = xoops_getHandler('config');
    $moduleConfig  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
    $empty         = []; // an empty array

    //check for access
    $xoopsModule = XoopsModule::getByDirname($moduleDirName);

The assignment to $xoopsModule is dead and can be removed.

    if (empty($GLOBALS['xoopsUser']) || !($GLOBALS['xoopsUser'] instanceof \XoopsUser)) {
        redirect_header('javascript:history.go(-1)', 3, _NOPERM . '<br>' . _MA_PEDIGREE_REGIST);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

The constant _NOPERM was not found. Maybe you did not declare it correctly or list all dependencies?

    }
    //    if (empty($random)) {
    //$random = isset($_POST['random']) ? $_POST['random'] : null;
    //}
    //if (isset($_GET['random'])) {
    //$random = $_GET['random'];
    //}
    //if (empty($st)) {
    //$st = 0;
    //}
    //if (isset($_GET['st'])) {
    //$st = $_GET['st'];
    //}
    $random = Request::getInt('random', 0);
    $st     = Request::getInt('st', 0, 'GET');
    //find letter on which to start else set to 'a'
    //    if (isset($_GET['l'])) {
    //        $l = $_GET['l'];
    //    } else {
    //        $l = 'a';
    //    }
    $l = Request::getString('l', 'a', 'GET');
    //make the redirect
    if (!isset($_GET['r'])) {
        //insert into pedigree_temp
        //        $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . ' SET father =' . $_GET['selsire'] . ' WHERE id=' . $random;
        //        $GLOBALS['xoopsDB']->queryF($query);
        $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . ' SET father =' . Request::getInt('selsire', 0, 'GET') . ' WHERE id=' . $random;
        $GLOBALS['xoopsDB']->queryF($query);
        redirect_header('add_dog.php?f=dam&random=' . $random . '&st=' . $st . '&r=1&l=a', 1, strtr(_MA_PEDIGREE_ADD_SIREOK, ['[mother]' => $moduleConfig['mother']]));
    }

    $xoopsTpl->assign('sire', '1');
    //create list of males dog to select from
    $perPage = $moduleConfig['perpage'];
    //count total number of dogs
    $numDog = 'SELECT count(id) FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE roft='1' AND naam LIKE '" . $l . "%'";
    $numRes = $GLOBALS['xoopsDB']->query($numDog);
    list($numResults) = $GLOBALS['xoopsDB']->fetchRow($numRes);
    $numPages = floor($numResults / $perPage) + 1;
    if (($numPages * $perPage) == ($numResults + $perPage)) {
        --$numPages;
    }
    $currentPage = floor($st / $perPage) + 1;
    //create alphabet
    $pages = '';
    for ($i = 65; $i <= 90; ++$i) {
        if ($l == chr($i)) {
            $pages .= '<b><a href="add_dog.php?f=dam&r=1&random=' . $random . '&l=' . chr($i) . '">' . chr($i) . '</a></b>&nbsp;';
        } else {
            $pages .= '<a href="add_dog.php?f=dam&r=1&random=' . $random . '&l=' . chr($i) . '">' . chr($i) . '</a>&nbsp;';
        }
    }
    $pages .= '-&nbsp;';
    $pages .= '<a href="add_dog.php?f=dam&r=1&random=' . $random . '&l=Ã…">Ã…</a>&nbsp;';
    $pages .= '<a href="add_dog.php?f=dam&r=1&random=' . $random . '&l=Ö">Ö</a>&nbsp;';
    $pages .= '<br>';
    //create previous button
    if ($numPages > 1) {
        if ($currentPage > 1) {
            $pages .= '<a href="add_dog.php?f=dam&r=1&l=' . $l . '&random=' . $random . '&st=' . ($st - $perPage) . '">' . _MA_PEDIGREE_PREVIOUS . '</a>&nbsp;&nbsp';
        }
    }
    //create numbers
    for ($x = 1; $x < ($numPages + 1); ++$x) {
        //create line break after 20 number
        if (0 == ($x % 20)) {
            $pages .= '<br>';
        }
        if ($x != $currentPage) {
            $pages .= '<a href="add_dog.php?f=dam&r=1&l=' . $l . '&random=' . $random . '&st=' . ($perPage * ($x - 1)) . '">' . $x . '</a>&nbsp;&nbsp;';
        } else {
            $pages .= $x . '&nbsp;&nbsp';
        }
    }
    //create next button
    if ($numPages > 1) {
        if ($currentPage < $numPages) {
            $pages .= '<a href="add_dog.php?f=dam&l=' . $l . '&r=1&random=' . $random . '&st=' . ($st + $perPage) . '">' . _MA_PEDIGREE_NEXT . '</a>&nbsp;&nbsp;';
        }
    }

    //query
    $queryString = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE roft = '1' AND naam LIKE '" . $l . "%' ORDER BY naam LIMIT " . $st . ', ' . $perPage;
    $result      = $GLOBALS['xoopsDB']->query($queryString);

    $animal = new Pedigree\Animal();
    //test to find out how many user fields there are...
    $fields       = $animal->getNumOfFields();
    $numofcolumns = 1;
    $columns[]    = ['columnname' => 'Name'];

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

    for ($i = 0, $iMax = count($fields); $i < $iMax; ++$i) {
        $userField   = new Pedigree\Field($fields[$i], $animal->getConfig());
        $fieldType   = $userField->getSetting('FieldType');
        $fieldObject = new $fieldType($userField, $animal);
        //create empty string