CheckoutWizard - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/XoopsM..." - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c8eead...62889a )

by Michael

created 2016-04-13 09:52 UTC

CheckoutWizard C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	434
Duplicated Lines	0.92 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	61
c	1
b	0
f	0
lcom	1
cbo	1
dl	4
loc	434
rs	6.018

15 Methods

Rating	Name	Duplication	Size	Complexity
C	CheckoutWizard()	0	26	7
A	prepare_Fieldname()	0	20	3
A	process_Fieldname()	0	18	3
A	prepare_Fieldtype()	0	9	1
A	process_Fieldtype()	0	8	1
B	process_lookup()	0	25	4
D	prepare_Settings()	0	41	10
B	process_Settings()	0	24	3
A	prepare_search()	0	17	4
A	process_search()	0	18	3
B	prepare_defaultvalue()	4	25	5
A	process_defaultvalue()	0	11	2
A	process_confirm()	0	4	1
A	isValidEmail()	0	4	1
F	completeCallback()	0	124	13

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like CheckoutWizard often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use CheckoutWizard, and based on these observations, apply Extract Interface, too.

<?php

require_once 'wizard.php';

/**
 * Class CheckoutWizard
 */
class CheckoutWizard extends ZervWizard
namespace YourVendor;

class YourClass { }
{
    function CheckoutWizard()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $field;
function myFunction($a, $b) {
    // Do something
}
        // start the session and initialize the wizard
        if (!isset($_SESSION)) {
            session_start();
        }
        parent::ZervWizard($_SESSION, __CLASS__);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

        $this->addStep('Fieldname', _MA_PEDIGREE_ENTER_FIELD);
        if ($this->getValue('field') == 0) { //only for a new field
            $this->addStep('Fieldtype', _MA_PEDIGREE_FIELD_TYP_SEL);
            if ($this->getValue('fieldtype') == 'selectbox' || $this->getValue('fieldtype') == 'radiobutton') {
                $this->addStep('lookup', _MA_PEDIGREE_FIELD_ADD_VALUE);
            }
        }

        $this->addStep('Settings', _MA_PEDIGREE_FIELD_PARAM);
        if ($this->getValue('hassearch') == 'hassearch') {
            $this->addStep('search', _MA_PEDIGREE_SEARCH_PARAMFIELD);
        }
        if ($this->getValue('fieldtype') != 'picture') {
            $this->addStep('defaultvalue', _MA_PEDIGREE_FIELD_DEFAUT);
        }
        $this->addStep('confirm', _MA_PEDIGREE_FIELDCONFIRM);
    }

    function prepare_Fieldname()

    {
        global $xoopsDB, $field;
function myFunction($a, $b) {
    // Do something
}
        if (!$field == 0) // field allready exists (editing mode)
        {
            $sql    = "SELECT * from " . $xoopsDB->prefix("pedigree_fields") . " WHERE ID=" . $field;
            $result = $xoopsDB->query($sql);
            while ($row = $xoopsDB->fetchArray($result)) {
                $name             = $row['FieldName'];
                $fieldexplenation = $row['FieldExplenation'];
                $fieldtype        = $row['FieldType'];
            }
            $this->setValue('name', $name);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $this->setValue('explain', $fieldexplenation);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            //set the fieldtype because we wont allow it to be edited
            $this->setValue('fieldtype', $fieldtype);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        }
        $this->setValue('field', $field); //is it a new field or are we editing a field
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_Fieldname(&$form)

    {
        $name = $this->coalesce($form['name']);
        if (strlen($name) > 0) {
            $this->setValue('name', $name);
        } else {
            $this->addError('name', _MA_PEDIGREE_FIELD_NAM);
        }

        $fieldexplenation = $this->coalesce($form['explain']);
        if (strlen($fieldexplenation) > 0) {
            $this->setValue('explain', $fieldexplenation);
        } else {
            $this->addError('explain', _MA_PEDIGREE_FIELD_EXPLAN1);
        }

        return !$this->isError();
    }

    function prepare_Fieldtype()

    {
        $this->fieldtype[] = array('value' => "radiobutton", 'description' => "Radiobutton");
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->fieldtype[] = array('value' => "selectbox", 'description' => _MA_PEDIGREE_DROPDOWNFIELD);
        $this->fieldtype[] = array('value' => "textbox", 'description' => _MA_PEDIGREE_TEXTBOXFIELD);
        $this->fieldtype[] = array('value' => "textarea", 'description' => _MA_PEDIGREE_TEXTAREAFIELD);
        $this->fieldtype[] = array('value' => "dateselect", 'description' => _MA_PEDIGREE_DATEFIELD);
        $this->fieldtype[] = array('value' => "urlfield", 'description' => _MA_PEDIGREE_URLFIELD);
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_Fieldtype(&$form)

    {
        $this->prepare_Fieldtype();
        $fieldtype = $this->coalesce($form['fieldtype']);
        $this->setValue('fieldtype', $fieldtype);

        return !$this->isError();
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_lookup(&$form)

    {

        $fc = $this->coalesce($form['fc']);
        $this->setValue('fc', $fc);
        $lookup   = $this->coalesce($form['lookup' . $fc]);
        $lookupid = $this->coalesce($form['id' . $fc]);
        if (strlen($lookup) > 0) {
            $this->setValue('lookup' . $fc, $lookup);
            $this->setValue('id' . $fc, $lookupid);
        }
        $lastlookup = $this->getValue('lookup' . $fc);
        if ($lastlookup == "") {
            $this->setValue('fc', $fc - 1);
        }

        for ($i = 0; $i < $fc; ++$i) {
            $radioarray[] = array('id' => $this->getValue('id' . ($i+1)), 'value' => $this->getValue('lookup' . ($i+1)));
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        //print_r($radioarray); die();

        $this->setValue('radioarray', $radioarray);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return !$this->isError();
        //
    }

    function prepare_Settings()

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        if (!$this->getValue('field') == 0) // field allready exists (editing mode)
        {
            {
                $sql = "SELECT * from " . $xoopsDB->prefix("pedigree_fields") . " WHERE ID='" . $this->getValue('field') . "'";
            }
            $result = $xoopsDB->query($sql);
            while ($row = $xoopsDB->fetchArray($result)) {
                $hs = $row['HasSearch'];
                if ($hs == "1") {
                    $this->setValue('hassearch', "hassearch");
                }
                $vip = $row['ViewInPedigree'];
                if ($vip == "1") {
                    $this->setValue('viewinpedigree', "viewinpedigree");
                }
                $via = $row['ViewInAdvanced'];
                if ($via == "1") {
                    $this->setValue('viewinadvanced', "viewinadvanced");
                }
                $vipie = $row['ViewInPie'];
                if ($vipie == "1") {
                    $this->setValue('viewinpie', "viewinpie");
                }
                $vil = $row['ViewInList'];
                if ($vil == "1") {
                    $this->setValue('viewinlist', "viewinlist");
                }
                $lit = $row['Litter'];
                if ($lit == "1") {
                    $this->setValue('Litter', "Litter");
                }
                $Glit = $row['Generallitter'];
                if ($Glit == "1") {
                    $this->setValue('Generallitter', "Generallitter");
                }
            }
        }
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_Settings(&$form)

    {
        $hassearch = $this->coalesce($form['hassearch']);
        $this->setValue('hassearch', $hassearch);
        $viewinpedigree = $this->coalesce($form['viewinpedigree']);
        $this->setValue('viewinpedigree', $viewinpedigree);
        $viewinadvanced = $this->coalesce($form['viewinadvanced']);
        $this->setValue('viewinadvanced', $viewinadvanced);
        $viewinpie = $this->coalesce($form['viewinpie']);
        $this->setValue('viewinpie', $viewinpie);
        $viewinlist = $this->coalesce($form['viewinlist']);
        $this->setValue('viewinlist', $viewinlist);
        $Litter = $this->coalesce($form['Litter']);
        $this->setValue('Litter', $Litter);
        $Generallitter = $this->coalesce($form['Generallitter']);
        $this->setValue('Generallitter', $Generallitter);

        //if both litter and general litter are set; unset one of them
        if ($this->getValue('Litter') == "Litter" && $this->getValue('Generallitter') == "Generallitter") {
            $this->setValue('Generallitter', 0);
        }

        return !$this->isError();
    }

    function prepare_search()

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        if (!$this->getValue('field') == 0) // field allready exists (editing mode)
        {
            $sql    = "SELECT * from " . $xoopsDB->prefix("pedigree_fields") . " WHERE ID=" . $this->getValue('field');
            $result = $xoopsDB->query($sql);
            while ($row = $xoopsDB->fetchArray($result)) {
                if ($this->getValue('hassearch') == "hassearch") {
                    $searchname = $row['SearchName'];
                    $this->setValue('searchname', $searchname);
                    $searchexplain = $row['SearchExplenation'];
                    $this->setValue('searchexplain', $searchexplain);
                }
            }
        }
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_search(&$form)

    {
        $searchname = $this->coalesce($form['searchname']);
        if (strlen($searchname) > 0) {
            $this->setValue('searchname', $searchname);
        } else {
            $this->addError('searchname', 'Please enter the searchname');
        }

        $fieldexplenation = $this->coalesce($form['searchexplain']);
        if (strlen($fieldexplenation) > 0) {
            $this->setValue('searchexplain', $fieldexplenation);
        } else {
            $this->addError('searchexplain', 'Please enter the search explanation for this field');
        }

        return !$this->isError();
    }

    function prepare_defaultvalue()

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        if (!$this->getValue('field') == 0) // field allready exists (editing mode)
        {
            $sql    = "SELECT * from " . $xoopsDB->prefix("pedigree_fields") . " WHERE ID=" . $this->getValue('field');
            $result = $xoopsDB->query($sql);
            while ($row = $xoopsDB->fetchArray($result)) {
                $def = $row['DefaultValue'];
                $this->setValue('defaultvalue', $def);
                if ($row['LookupTable'] == "1") { //we have a lookup table; load values
                    $sql    = "SELECT * from " . $xoopsDB->prefix("pedigree_lookup" . $this->getValue('field')) . " order by 'order'";
                    $fc     = 0;
                    $result = $xoopsDB->query($sql);
                    while ($row = $xoopsDB->fetchArray($result)) {

                        $radioarray[] = array('id' => $row['ID'], 'value' => $row['value']);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                        ++$fc;
                    }
                    $this->setValue('radioarray', $radioarray);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    $this->setValue('fc', $fc);
                }
            }

        }
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_defaultvalue(&$form)

    {
        $defaultvalue = $this->coalesce($form['defaultvalue']);
        if (strlen($defaultvalue) >= 0) {
            $this->setValue('defaultvalue', $defaultvalue);
        } else {
            $this->addError('defaultvalue', 'Please enter a defaultvalue');
        }

        return !$this->isError();
    }

    /**
     * @param $form
     *
     * @return bool
     */
    function process_confirm(&$form)

    {
        return !$this->isError();
    }

    function completeCallback()

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        //can this field be searched
        $search = $this->getValue('hassearch');
        if ($search == "hassearch") {
            $search        = "1";
            $searchname    = $this->getValue('searchname');
            $searchexplain = $this->getValue('searchexplain');
        } else {
            $search        = "0";
            $searchname    = "";
            $searchexplain = "";
        }
        //show in pedigree
        $viewinpedigree = $this->getValue('viewinpedigree');
        if ($viewinpedigree == "viewinpedigree") {
            $viewinpedigree = "1";
        } else {
            $viewinpedigree = "0";
        }
        //show in advanced
        $viewinadvanced = $this->getValue('viewinadvanced');
        if ($viewinadvanced == "viewinadvanced") {
            $viewinadvanced = "1";
        } else {
            $viewinadvanced = "0";
        }
        //show in pie
        $viewinpie = $this->getValue('viewinpie');
        if ($viewinpie == "viewinpie") {
            $viewinpie = "1";
        } else {
            $viewinpie = "0";
        }
        //view in list
        $viewinlist = $this->getValue('viewinlist');
        if ($viewinlist == "viewinlist") {
            $viewinlist = "1";
        } else {
            $viewinlist = "0";
        }
        //add a litter
        $Litter = $this->getValue('Litter');
        if ($Litter == "Litter") {
            $Litter = "1";
        } else {
            $Litter = "0";
        }
        //general litter
        $Generallitter = $this->getValue('Generallitter');
        if ($Generallitter == "Generallitter") {
            $Generallitter = "1";
        } else {
            $Generallitter = "0";
        }

        if (!$this->getValue('field') == 0) // field allready exists (editing mode)
        {
            $sql = "UPDATE " . $xoopsDB->prefix("pedigree_fields") . " SET FieldName = '" . htmlSpecialChars($this->getValue('name')) . "', FieldType = '" . $this->getValue('fieldtype')
                . "', DefaultValue = '" . $this->getValue('defaultvalue') . "', FieldExplenation = '" . $this->getValue('explain') . "', HasSearch = '" . $search . "', Litter = '" . $Litter
                . "', Generallitter = '" . $Generallitter . "', SearchName = '" . $searchname . "', SearchExplenation = '" . $searchexplain . "', ViewInPedigree = '" . $viewinpedigree
                . "', ViewInAdvanced = '" . $viewinadvanced . "', ViewInPie = '" . $viewinpie . "', ViewInList = '" . $viewinlist . "' WHERE ID ='" . $this->getValue('field') . "'";
            $xoopsDB->queryF($sql);
            //possible change defaultvalue for userfield
            $sql
                = "ALTER TABLE " . $xoopsDB->prefix("pedigree_tree") . " CHANGE `user" . $this->getValue('field') . "` `user" . $this->getValue(
                    'field'
                ) . "` VARCHAR( 255 ) NOT NULL DEFAULT '" . $this->getValue('defaultvalue') . "'";
            $xoopsDB->queryF($sql);
            $sql
                = "ALTER TABLE " . $xoopsDB->prefix("pedigree_temp") . " CHANGE `user" . $this->getValue('field') . "` `user" . $this->getValue(
                    'field'
                ) . "` VARCHAR( 1024 ) NOT NULL DEFAULT '" . $this->getValue('defaultvalue') . "'";
            $xoopsDB->queryF($sql);
            $sql = "ALTER TABLE " . $xoopsDB->prefix("pedigree_trash") . " CHANGE `user" . $this->getValue('field') . "` `user" . $this->getValue(
                    'field'
                ) . "` VARCHAR( 255 ) NOT NULL DEFAULT '" . $this->getValue('defaultvalue') . "'";
            $xoopsDB->queryF($sql);
        } else { //this is a new field
            $sql    = "SELECT MAX(ID) AS lid from " . $xoopsDB->prefix("pedigree_fields") . " LIMIT 1";
            $result = $xoopsDB->query($sql);
            while ($row = $xoopsDB->fetchArray($result)) {
                $nextfieldnum = $row['lid'] + 1;
            }
            //add userfield to various tables as a new field.
            //allways add at the end of the table
            $tables = array('pedigree_tree', 'pedigree_temp', 'pedigree_trash');
            foreach ($tables as $table) {
                $SQL = "ALTER TABLE " . $xoopsDB->prefix($table) . " ADD `user" . $nextfieldnum . "` VARCHAR( 255 ) NOT NULL DEFAULT '" . $this->getValue(
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                        'defaultvalue'
                    ) . "'";
                $xoopsDB->queryF($SQL);
            }
            //is a lookup table present
            $lookup = $this->getValue('lookup1');
            if ($lookup == "") {
                $lookup = "0";
            } else {
                $lookup = "1";
                //create table for lookupfield
                $createtable = "CREATE TABLE " . $xoopsDB->prefix("pedigree_lookup" . $nextfieldnum) . " (`ID` INT( 10 ) NOT NULL ,`value` VARCHAR( 255 ) NOT NULL, `order` INT( 10 )) ENGINE = MyISAM";
                $xoopsDB->queryF($createtable);
                //fill table
                $count = $this->getValue('fc');
                for ($x = 1; $x < $count + 1; ++$x) {
                    $y = $x - 1;
                    $sql = "INSERT INTO " . $xoopsDB->prefix("pedigree_lookup" . $nextfieldnum) . " ( `ID` , `value`, `order`) VALUES ('" . $y . "', '" . $this->getValue('lookup' . $x) . "','" . $y
                        . "')";
                    $xoopsDB->queryF($sql);
                }

            }

            //Insert new record into pedigree_config
            $sql = "INSERT INTO " . $xoopsDB->prefix("pedigree_fields") . " VALUES ('" . $nextfieldnum . "', '1', '" . htmlSpecialChars(
                    $this->getValue('name')
                ) . "', '" . $this->getValue('fieldtype') . "', '" . $lookup . "', '" . $this->getValue('defaultvalue') . "', '" . $this->getValue(
                    'explain'
                ) . "', '" . $search . "', '" . $Litter . "', '" . $Generallitter . "', '" . $searchname . "', '" . $searchexplain . "', '" . $viewinpedigree . "', '" . $viewinadvanced . "', '"
                . $viewinpie . "', '" . $viewinlist . "','','" . $nextfieldnum . "')";
            $xoopsDB->queryF($sql);
        }
    }

    /**
     * Miscellaneous utility functions
     *
     * @param $email
     *
     * @return int
     */

    function isValidEmail($email)

    {
        return preg_match('/^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*$/i', $email);
    }
}


Push — master ( c8eead...62889a )

CheckoutWizard C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-13 09:56 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 7 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			require_once 'wizard.php';
3
4			/**
5			* Class CheckoutWizard
6			*/
7			class CheckoutWizard extends ZervWizard
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9			function CheckoutWizard()
			0 ignored issues – show Best Practice introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report `CheckoutWizard` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style Best Practice introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
10			{
11			global $field;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
12			// start the session and initialize the wizard
13			if (!isset($_SESSION)) {
14			session_start();
15			}
16			parent::ZervWizard($_SESSION, __CLASS__);
			0 ignored issues – show Comprehensibility Bug introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`ZervWizard()` instead of `CheckoutWizard()`). Are you sure this is correct? If so, you might want to change this to `$this->ZervWizard()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Coding Style introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report PHP4 style calls to parent constructors are not allowed; use "parent::__construct()" instead Loading history...
17
18			$this->addStep('Fieldname', _MA_PEDIGREE_ENTER_FIELD);
19			if ($this->getValue('field') == 0) { //only for a new field
20			$this->addStep('Fieldtype', _MA_PEDIGREE_FIELD_TYP_SEL);
21			if ($this->getValue('fieldtype') == 'selectbox' \|\| $this->getValue('fieldtype') == 'radiobutton') {
22			$this->addStep('lookup', _MA_PEDIGREE_FIELD_ADD_VALUE);
23			}
24			}
25
26			$this->addStep('Settings', _MA_PEDIGREE_FIELD_PARAM);
27			if ($this->getValue('hassearch') == 'hassearch') {
28			$this->addStep('search', _MA_PEDIGREE_SEARCH_PARAMFIELD);
29			}
30			if ($this->getValue('fieldtype') != 'picture') {
31			$this->addStep('defaultvalue', _MA_PEDIGREE_FIELD_DEFAUT);
32			}
33			$this->addStep('confirm', _MA_PEDIGREE_FIELDCONFIRM);
34			}
35

mambax7 / pedigree

Push — master ( c8eead...62889a )

CheckoutWizard C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like