update_function.php ➔ xoops_module_update_animal() - Code Metrics - Inspection of "update for PayPal" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 871d94...af939e )

by Michael

created 2017-03-29 08:45 UTC

update_function.php ➔ xoops_module_update_animal() D

↳ Parent: Project

Complexity

Conditions	11
Paths	243

Size

Total Lines	51
Code Lines	33

Duplication

Lines	40
Ratio	78.43 %

Importance

Changes

Metric	Value
cc	11
eloc	33
nc	243
nop	0
dl	40
loc	51
rs	4.34
c	0
b	0
f	0

How to fix Long Method Complexity

<?php


/**
 * Verify that a mysql table exists
 *
 * @package       News
 * @author        Hervé Thouzard (http://www.herve-thouzard.com)
 * @copyright (c) Hervé Thouzard
 *
 * @param $tablename
 *
 * @return bool
 */
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $result = $GLOBALS['xoopsDB']->queryF("SHOW TABLES LIKE '$tablename'");

    return ($GLOBALS['xoopsDB']->getRowsNum($result) > 0);
}

/**
 * @return bool
 */
function xoops_module_update_animal()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    if (tableExists($GLOBALS['xoopsDB']->prefix('owner'))) {

        $sql    = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('owner') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_owner'));
        $result = $GLOBALS['xoopsDB']->queryF($sql);
        if (!$result) {
            echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
            ++$errors;
        }
    }

    if (tableExists($GLOBALS['xoopsDB']->prefix('stamboom'))) {

        $sql    = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('stamboom') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree'));
        $result = $GLOBALS['xoopsDB']->queryF($sql);
        if (!$result) {
            echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
            ++$errors;
        }
    }

    if (tableExists($GLOBALS['xoopsDB']->prefix('pedigree_config'))) {

        $sql    = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('pedigree_config') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_fields'));
        $result = $GLOBALS['xoopsDB']->queryF($sql);
        if (!$result) {
            echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
            ++$errors;
        }
    }

    if (tableExists($GLOBALS['xoopsDB']->prefix('pedigree_temp'))) {

        $sql    = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp'));
        $result = $GLOBALS['xoopsDB']->queryF($sql);
        if (!$result) {
            echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
            ++$errors;
        }
    }

    if (tableExists($GLOBALS['xoopsDB']->prefix('pedigree_trash'))) {

        $sql    = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash'));
        $result = $GLOBALS['xoopsDB']->queryF($sql);
        if (!$result) {
            echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
            ++$errors;
        }
    }

    return true;
}


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 24 and the first side effect is on line 14. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		/**
4		* Verify that a mysql table exists
5		*
6		* @package News
7		* @author Hervé Thouzard (http://www.herve-thouzard.com)
8		* @copyright (c) Hervé Thouzard
9		*
10		* @param $tablename
11		*
12		* @return bool
13		*/
14		{
15		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
16		$result = $GLOBALS['xoopsDB']->queryF("SHOW TABLES LIKE '$tablename'");
17
18		return ($GLOBALS['xoopsDB']->getRowsNum($result) > 0);
19		}
20
21		/**
22		* @return bool
23		*/
24		function xoops_module_update_animal()
		0 ignored issues – show Coding Style introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `xoops_module_update_animal` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25		{
26		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
27
28	View Code Duplication	if (tableExists($GLOBALS['xoopsDB']->prefix('owner'))) {
		0 ignored issues – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$sql = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('owner') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_owner'));
30		$result = $GLOBALS['xoopsDB']->queryF($sql);
31		if (!$result) {
32		echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
33		++$errors;
34		}
35		}
36
37	View Code Duplication	if (tableExists($GLOBALS['xoopsDB']->prefix('stamboom'))) {
		0 ignored issues – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		$sql = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('stamboom') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree'));
39		$result = $GLOBALS['xoopsDB']->queryF($sql);
40		if (!$result) {
41		echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
42		++$errors;
43		}
44		}
45
46	View Code Duplication	if (tableExists($GLOBALS['xoopsDB']->prefix('pedigree_config'))) {
		0 ignored issues – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		$sql = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('pedigree_config') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_fields'));
48		$result = $GLOBALS['xoopsDB']->queryF($sql);
49		if (!$result) {
50		echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
51		++$errors;
52		}
53		}
54
55	View Code Duplication	if (tableExists($GLOBALS['xoopsDB']->prefix('pedigree_temp'))) {
		0 ignored issues – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		$sql = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp'));
57		$result = $GLOBALS['xoopsDB']->queryF($sql);
58		if (!$result) {
59		echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
60		++$errors;
61		}
62		}
63
64	View Code Duplication	if (tableExists($GLOBALS['xoopsDB']->prefix('pedigree_trash'))) {
		0 ignored issues – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		$sql = sprintf('ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash') . ' RENAME ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash'));
66		$result = $GLOBALS['xoopsDB']->queryF($sql);
67		if (!$result) {
68		echo '<br />' . _AM_PEDIGREE_UPGRADEFAILED . ' ' . _AM_PEDIGREE_UPGRADEFAILED2;
69		++$errors;
70		}
71		}
72
73		return true;
74		}
75

mambax7 / pedigree

Push — master ( 871d94...af939e )

update_function.php ➔ xoops_module_update_animal() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like