menu_block.php ➔ menu_block() - Code Metrics - Inspection of "update for PayPal" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 871d94...af939e )

by Michael

created 2017-03-29 08:45 UTC

menu_block.php ➔ menu_block() F

↳ Parent: Project

Complexity

Conditions	39
Paths	> 20000

Size

Total Lines	192
Code Lines	137

Duplication

Lines	24
Ratio	12.5 %

Importance

Changes

Metric	Value
cc	39
eloc	137
nc	13056000
nop	0
dl	24
loc	192
rs	2
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

// -------------------------------------------------------------------------
//    pedigree
//        Copyright 2004, James Cotton
//         http://www.dobermannvereniging.nl

// Include any constants used for internationalizing templates.
$moduleDirName = basename(dirname(__DIR__));
xoops_loadLanguage('main', $moduleDirName);
//xoops_loadLanguage('main', 'pedigree');

// Include any common code for this module.
//require_once(XOOPS_ROOT_PATH . "/modules/" . $xoopsModule->dirname() . "/include/class_field.php");
//require_once(XOOPS_ROOT_PATH . "/modules/" . $xoopsModule->dirname() . "/include/functions.php");
require_once $GLOBALS['xoops']->path('modules/' . $moduleDirName . '/include/class_field.php');
require_once(XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/include/common.php');

/**
 * @todo: move hard coded language strings to language file
 *
 * @return XoopsTpl
 */
function menu_block()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl, $xoopsUser;
function myFunction($a, $b) {
    // Do something
}
    $moduleDirName = basename(dirname(__DIR__));
    //get module configuration
    $moduleHandler = xoops_getHandler('module');
    $module        = $moduleHandler->getByDirname($moduleDirName);
    $configHandler = xoops_getHandler('config');
    $moduleConfig  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));

    //colour variables
    $colors  = explode(',', $moduleConfig['colourscheme']);
    $actlink = $colors[0];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $even    = $colors[1];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $odd     = $colors[2];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $text    = $colors[3];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $hovlink = $colors[4];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $head    = $colors[5];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $body    = $colors[6];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $title   = $colors[7];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    /*
        //inline-css
        echo '<style>';
        //text-colour
        echo 'body {margin: 0;padding: 0;background: ' . $body . ';color: ' . $text . ";font-size: 62.5%; font-family: 'Lucida Grande', Verdana, Arial, Sans-Serif; text-align: left;}";
        //link-colour
        echo 'a, h2 a:hover, h3 a:hover { color: ' . $actlink . '; text-decoration: none; }';
        //link hover colour
        echo 'a:hover { color: ' . $hovlink . '; text-decoration: underline; }';
        //th
        echo 'th {padding: 2px;color: #ffffff;background: ' . $title . ';font-family: Verdana, Arial, Helvetica, sans-serif;vertical-align: middle;}';
        echo 'td#centercolumn th { color: #fff; background: ' . $title . '; vertical-align: middle; }';
        //head
        echo '.head {background-color: ' . $head . '; padding: 3px; font-weight: normal;}';
        //even
        echo '.even {background-color: ' . $even . '; padding: 3px;}';
        echo 'tr.even td {background-color: ' . $even . '; padding: 3px;}';
        //odd
        echo '.odd {background-color: ' . $odd . '; padding: 3px;}';
        echo 'tr.odd td {background-color: ' . $odd . '; padding: 3px;}';
        echo '</style>';
    */

    //iscurrent user a module admin ?
    $xoopsModule = XoopsModule::getByDirname('pedigree');
    if ((!empty($xoopsUser)) && ($GLOBALS['xoopsUser'] instanceof XoopsUser) && $xoopsUser->isAdmin($xoopsModule->mid())) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
        $modadmin = true;
    } else {
        $modadmin = false;
    }
    $counter   = 1;
    $menuwidth = 4;

    $x       = $_SERVER['PHP_SELF'];
    $lastpos = my_strrpos($x, '/');
    $len     = strlen($x);
    $curpage = substr($x, $lastpos, $len);
    if (1 == $moduleConfig['showwelcome']) {
        if ('/welcome.php' === $curpage) {
            $title = '<b>Welcome</b>';
        } else {
            $title = 'Welcome';
        }
        $menuarray[] = array('title' => $title, 'link' => 'welcome.php', 'counter' => $counter);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
        }
    }
    if ($curpage === '/index.php' || $curpage === '/result.php') {
        $title = '<b>View/Search ' . $moduleConfig['animalTypes'] . '</b>';
    } else {
        $title = 'View/Search ' . $moduleConfig['animalTypes'];
    }
    $menuarray[] = array('title' => $title, 'link' => 'index.php', 'counter' => $counter);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    ++$counter;
    if ($counter == $menuwidth) {
        $counter = 1;
    }
    if ($curpage === '/add_dog.php') {
        $title = '<b>Add a ' . $moduleConfig['animalType'] . '</b>';
    } else {
        $title = 'Add a ' . $moduleConfig['animalType'];
    }
    $menuarray[] = array('title' => $title, 'link' => 'add_dog.php', 'counter' => $counter);
    ++$counter;
    if ($counter == $menuwidth) {
        $counter = 1;
    }
    if ($moduleConfig['uselitter'] == '1') {

        if ($curpage === '/add_litter.php') {
            $title = '<b>Add a ' . $moduleConfig['litter'] . '</b>';
        } else {
            $title = 'Add a ' . $moduleConfig['litter'];
        }
        $menuarray[] = array('title' => $title, 'link' => 'add_litter.php', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
        }
    }
    if ($moduleConfig['ownerbreeder'] == '1') {
        if ($curpage === '/breeder.php' || $curpage === '/owner.php') {
            $title = '<b>View owners/breeders</b>';
        } else {
            $title = 'View owners/breeders';
        }
        $menuarray[] = array('title' => $title, 'link' => 'breeder.php', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
        }
        if ($curpage === '/add_breeder.php') {
            $title = '<b>Add an owner/breeder</b>';
        } else {
            $title = 'Add an owner/breeder';
        }
        $menuarray[] = array('title' => $title, 'link' => 'add_breeder.php', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
        }
    }
    if ($curpage === '/advanced.php') {
        $title = '<b>Advanced info</b>';
    } else {
        $title = 'Advanced info';
    }
    $menuarray[] = array('title' => $title, 'link' => 'advanced.php', 'counter' => $counter);
    ++$counter;
    if ($counter == $menuwidth) {
        $counter = 1;
    }
    if ($moduleConfig['proversion'] == '1') {
        if ($curpage === '/virtual.php') {
            $title = '<b>Virtual mating</b>';
        } else {
            $title = 'Virtual Mating';
        }
        $menuarray[] = array('title' => $title, 'link' => 'virtual.php', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
        }
    }
    if ($curpage === '/latest.php') {
        $title = '<b>latest additions</b>';
    } else {
        $title = 'latest additions';
    }
    $menuarray[] = array('title' => $title, 'link' => 'latest.php', 'counter' => $counter);
    ++$counter;
    if ($counter == $menuwidth) {
        $counter = 1;
    }
    if ($modadmin === true) {
        if ($curpage === '/tools.php') {
            $title = '<b>Webmaster tools</b>';
        } else {
            $title = 'Webmaster tools';
        }
        $menuarray[] = array('title' => $title, 'link' => 'tools.php?op=index', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
        }
        $title       = 'Logout';
        $menuarray[] = array('title' => $title, 'link' => '../../user.php?op=logout', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    } else {

        if ($curpage === '/user.php') {
            $title = '<b>User login</b>';
        } else {
            $title = 'User login';
        }
        $menuarray[] = array('title' => $title, 'link' => '../../user.php', 'counter' => $counter);
        ++$counter;
        if ($counter == $menuwidth) {
            $counter = 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
    }

    //create path taken
    //showpath();
    $xoopsTpl->assign('menuarray', $menuarray);
    //return the template contents
    return $xoopsTpl;
}

/**
 * @param     $haystack
 * @param     $needle
 * @param int $offset
 *
 * @return bool|int

 */
function my_strrpos($haystack, $needle, $offset = 0)

{
    // same as strrpos, except $needle can be a string
    $strrpos = false;
    if (is_string($haystack) && is_string($needle) && is_numeric($offset)) {
        $strlen = strlen($haystack);
        $strpos = strpos(strrev(substr($haystack, $offset)), strrev($needle));
        if (is_numeric($strpos)) {
            $strrpos = $strlen - $strpos - strlen($needle);
        }
    }

    return $strrpos;
}


Push — master ( 871d94...af939e )

menu_block.php ➔ menu_block() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Missing dependencies

2. Missing use statement

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-13 09:56 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 22 and the first side effect is on line 8. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			// -------------------------------------------------------------------------
3			// pedigree
4			// Copyright 2004, James Cotton
5			// http://www.dobermannvereniging.nl
6
7			// Include any constants used for internationalizing templates.
8			$moduleDirName = basename(dirname(__DIR__));
9			xoops_loadLanguage('main', $moduleDirName);
10			//xoops_loadLanguage('main', 'pedigree');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `42%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
11			// Include any common code for this module.
12			//require_once(XOOPS_ROOT_PATH . "/modules/" . $xoopsModule->dirname() . "/include/class_field.php");
13			//require_once(XOOPS_ROOT_PATH . "/modules/" . $xoopsModule->dirname() . "/include/functions.php");
14			require_once $GLOBALS['xoops']->path('modules/' . $moduleDirName . '/include/class_field.php');
15			require_once(XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/include/common.php');
16
17			/**
18			* @todo: move hard coded language strings to language file
19			*
20			* @return XoopsTpl
21			*/
22			function menu_block()
			0 ignored issues – show Coding Style introduced 2016-04-17 06:28 UTC by Report Bug Copy Issue Report `menu_block` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report `menu_block` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
23			{
24			global $xoopsTpl, $xoopsUser;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:34 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
25			$moduleDirName = basename(dirname(__DIR__));
26			//get module configuration
27			$moduleHandler = xoops_getHandler('module');
28			$module = $moduleHandler->getByDirname($moduleDirName);
29			$configHandler = xoops_getHandler('config');
30			$moduleConfig = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
31
32			//colour variables
33			$colors = explode(',', $moduleConfig['colourscheme']);
34			$actlink = $colors[0];
			0 ignored issues – show Unused Code introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report `$actlink` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			$even = $colors[1];

mambax7 / pedigree

Push — master ( 871d94...af939e )

menu_block.php ➔ menu_block() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Missing dependencies

2. Missing use statement

Available Fixes

Duplication Side-by-Side

Filter issues like