tools.php ➔ userfields() - Code Metrics - Inspection of "update for PayPal" - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 871d94...af939e )

by Michael

created 2017-03-29 08:45 UTC

tools.php ➔ userfields() D

↳ Parent: Project

Complexity

Conditions	55
Paths	> 20000

Size

Total Lines	6
Code Lines	183

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	55
eloc	183
nc	76744
nop	0
dl	0
loc	6
rs	4.923
c	0
b	0
f	0

How to fix Complexity

<?php

// -------------------------------------------------------------------------

require_once dirname(dirname(dirname(__DIR__))) . '/mainfile.php';
xoops_loadLanguage('main', basename(dirname(dirname(__DIR__))));

// Include any common code for this module.
require_once dirname(__DIR__) . '/include/common.php';

$xoopsOption['template_main'] = 'pedigree_tools.tpl';

include XOOPS_ROOT_PATH . '/header.php';
$xoopsTpl->assign('page_title', 'Pedigree database - Add owner/breeder');

//check for access
$xoopsModule = XoopsModule::getByDirname('pedigree');
if (empty($GLOBALS['xoopsUser'])) {

    redirect_header('index.php', 3, _NOPERM . '<br />' . _MA_PEDIGREE_REGIST);
}

//add JS routines
echo '<script language="JavaScript" src="picker.js"></script>';

//set form to be empty
$form = '';

//get module configuration
$moduleHandler = xoops_getHandler('module');
$module        = $moduleHandler->getByDirname('pedigree');
$configHandler = xoops_getHandler('config');
$moduleConfig  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));

switch ($_GET['op']) {
    case 'lang':
        lang();
        break;
    case 'langsave':
        langsave();
        break;
    case 'colours':
        colours();
        break;
    case 'settings':
        settings();
        break;
    case 'settingssave':
        settingssave();
        break;
    case 'pro':
        pro();
        break;
    case 'userfields':
        userfields();
        break;
    case 'deleted':
        deleted();
        break;
    case 'delperm':
        delperm($_GET['id']);
        break;
    case 'delall':
        delall();
        break;
    case 'restore':
        restore($_GET['id']);
        break;
    case 'database':
        database();
        $db = true;
        break;
    case 'dbanc':
        database_oa();
        $db = true;
        break;
    case 'fltypar':
        database_fp();
        $db = true;
        break;
    case 'credits':
        credits();
        break;
    default :
switch ($expr) {
    default : //wrong
        doSomething();
        break;
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
        index();

        break;
}

//create tools array
$tools[] = array('title' => 'General settings', 'link' => 'tools.php?op=settings', 'main' => '1');
if ($moduleConfig['proversion'] == '1') {
    $tools[] = array('title' => 'Pro-version settings', 'link' => 'tools.php?op=pro', 'main' => '1');
}
$tools[] = array('title' => 'Language options', 'link' => 'tools.php?op=lang', 'main' => '1');
$tools[] = array('title' => 'Create user fields', 'link' => 'tools.php?op=userfields', 'main' => '1');
$tools[] = array('title' => 'Create colours', 'link' => 'tools.php?op=colours', 'main' => '1');
$tools[] = array('title' => "Deleted pedigree's", 'link' => 'tools.php?op=deleted', 'main' => '1');
$tools[] = array('title' => 'Database tools', 'link' => 'tools.php?op=database', 'main' => '1');
if (isset($db)) {
    //create database submenu
    $tools[] = array('title' => 'Own ancestors', 'link' => 'tools.php?op=dbanc', 'main' => '0');
    $tools[] = array('title' => 'Incorrect gender', 'link' => 'tools.php?op=fltypar', 'main' => '0');
    $tools[] = array('title' => 'User Queries', 'link' => 'tools.php?op=userq', 'main' => '0');
}
$tools[] = array('title' => 'Credits', 'link' => 'tools.php?op=credits', 'main' => '1');
$tools[] = array('title' => 'Logout', 'link' => '../../user.php?op=logout', 'main' => '1');
//add data (form) to smarty template

$xoopsTpl->assign('tools', $tools);

//footer
include XOOPS_ROOT_PATH . '/footer.php';

function index()
{
    $form = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
}

function colours()
{
    global $xoopsTpl, $femaleTextColour;
function myFunction($a, $b) {
    // Do something
}
    $form = 'This will be the wizard to create and modify the website colourscheme.<hr>';
    $form .= '<FORM NAME="myForm" action=\'savecolors.php\' method=\'POST\'>';
    $form .= '<INPUT TYPE="text" id="ftxtcolor" name="ftxtcolor" value="#' . $femaleTextColour . '" size="11" maxlength="7">';
    $form .= '<a href="javascript:TCP.popup(document.forms[\'myForm\'].elements[\'ftxtcolor\'])">';
    $form .= '<img width="15" height="13" border="0" alt="Click Here to Pick up the color" src="img/sel.gif"></a>';
    $form .= '</form>';
    $xoopsTpl->assign('form', $form);
}

function userfields()
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form = 'This will be the wizard to create and modify the custom userfields.<hr>';
    $xoopsTpl->assign('form', $form);
}

function credits()
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form = "Pedigree database module<br /><br /><li>Programming : James Cotton<br/><li>Design & Layout : Ton van der Hagen<br /><br />Technical support :<br /><li><a href=\"mailto:[email protected]\">[email protected]<br /><li><a href=\"http://www.animalpedigree.com\">www.animalpedigree.com</a><hr>";
    $xoopsTpl->assign('form', $form);
}

function database()
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form = _MA_PEDIGREE_QUERY_EXPLAN;
    $xoopsTpl->assign('form', $form);
}

function database_oa()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form   = _AM_PEDIGREE_DATABASE_CHECK_ANCESTORS;
    $sql    = 'SELECT d.id AS d_id, d.naam AS d_naam
            FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' d
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' m ON m.id = d.mother
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' f ON f.id = d.father
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' mm ON mm.id = m.mother
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' mf ON mf.id = m.father
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' fm ON fm.id = f.mother
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' ff ON ff.id = f.father
            WHERE
            d.mother = d.id
            OR d.father = d.id
            OR m.mother = d.id
            OR m.father = d.id
            OR f.mother = d.id
            OR f.father = d.id
            OR mm.mother = d.id
            OR mm.father = d.id
            OR mf.mother = d.id
            OR mf.father = d.id
            OR fm.mother = d.id
            OR fm.father = d.id
            OR ff.mother = d.id
            OR ff.father = d.id
            ';
    $result = $GLOBALS['xoopsDB']->query($sql);
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {

        $form .= "<li><a href=\"pedigree.php?pedid=" . $row['d_id'] . "\">" . $row['d_naam'] . '</a> [own parent or grandparent]<br />';
    }
    $xoopsTpl->assign('form', $form);
}

function database_fp()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form   = _AM_PEDIGREE_DATABASE_CHECK_GENDER;
    $sql    = 'SELECT d.id AS d_id, d.naam AS d_naam, m.roft as m_roft
            FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' d
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " m ON m.id = d.mother
            WHERE
            d.mother = m.id
            AND m.roft = '0' ";
    $result = $GLOBALS['xoopsDB']->query($sql);
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {

        $form .= "<li><a href=\"dog.php?id=" . $row['d_id'] . "\">" . $row['d_naam'] . '</a> [mother seems to be male]<br />';
    }
    $sql    = 'SELECT d.id AS d_id, d.naam AS d_naam, f.roft as f_roft
            FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' d
            LEFT JOIN ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " f ON f.id = d.father
            WHERE
            d.father = f.id
            AND f.roft = '1' ";
    $result = $GLOBALS['xoopsDB']->query($sql);
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {

        $form .= "<li><a href=\"dog.php?id=" . $row['d_id'] . "\">" . $row['d_naam'] . '</a> [father seems to be female]<br />';
    }
    $xoopsTpl->assign('form', $form);
}

function pro()
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form = 'Pro version settings go here.<hr>';
    $xoopsTpl->assign('form', $form);
}

function deleted()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl, $moduleConfig;
function myFunction($a, $b) {
    // Do something
}
    $form   = "Below the line are the animals which have been deleted from your database.<br /><br />By clicking on the name you can reinsert them into the database.<br />By clicking on the 'X' in front of the name you can permanently delete the animal.<hr>";
    $sql    = 'SELECT ID, NAAM  FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash');
    $result = $GLOBALS['xoopsDB']->query($sql);
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $form .= "<a href=\"tools.php?op=delperm&id=" . $row['Id'] . "\"><img src=\"assets/images/delete.gif\" /></a>&nbsp;<a href=\"tools.php?op=restore&id=" . $row['Id'] . "\">" . $row['NAAM'] . '</a><br />';
    }
    if ($GLOBALS['xoopsDB']->getRowsNum($result) > 0) {

        $form .= "<hr><a href=\"tools.php?op=delall\">Click here</a> to remove all these " . $moduleConfig['animalTypes'] . ' permenantly ';
    }
    $xoopsTpl->assign('form', $form);
}

/**
 * @param $id
 */
function delperm($id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $sql = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash') . ' WHERE ID = ' . $id;
    $GLOBALS['xoopsDB']->queryF($sql);
    deleted();
}

function delall()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $sql = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash');
    $GLOBALS['xoopsDB']->queryF($sql);
    deleted();
}

/**
 * @param $id
 */
function restore($id)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $sql    = 'SELECT * from ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash') . ' WHERE ID = ' . $id;
    $result = $GLOBALS['xoopsDB']->query($sql);
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {

        foreach ($row as $key => $values) {
            //          $queryvalues .= "'" . $values . "',";
            $queryvalues .= "'" . $GLOBALS['xoopsDB']->escape($values) . "',";
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
        $outgoing = substr_replace($queryvalues, '', -1);
        $query    = 'INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' VALUES (' . $outgoing . ')';
        $GLOBALS['xoopsDB']->queryF($query);
        $delquery = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_trash') . ' WHERE ID = ' . $id;
        $GLOBALS['xoopsDB']->queryF($delquery);
        $form .= "<li><a href=\"pedigree.php?pedid=" . $row['Id'] . "\">" . $row['NAAM'] . '</a> has been restored into the database.<hr>';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
    $xoopsTpl->assign('form', $form);
}

function settings()
{
    global $xoopsTpl, $moduleConfig;
function myFunction($a, $b) {
    // Do something
}
    include XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
    $form = new XoopsThemeForm('General settings', 'settings', 'tools.php?op=settingssave', 'POST', 1);
    $form->addElement(new XoopsFormHiddenToken($name = 'XOOPS_TOKEN_REQUEST', $timeout = 360));
    $select  = new XoopsFormSelect('<b>Number of results per page</b>', 'perpage', $value = $moduleConfig['perpage'], $size = 1, $multiple = false);
    $options = array('50' => 50, '100' => 100, '250' => 250, '500' => 500, '1000' => 1000, '2000' => 2000, '5000' => 5000, '10000' => 10000);
    foreach ($options as $key => $values) {
        $select->addOption($key, $name = $values);
    }
    unset($options);
    $form->addElement($select);
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'This field is used to set the number of results a page will return from a search. If more results are returned extra pages will be created for easy browsing.<br />Set this number higher as your database grows and the number of pages increase.'));
    $radio = new XoopsFormRadio('<b>Use owner/breeder fields</b>', 'ownerbreeder', $value = $moduleConfig['ownerbreeder']);
    $radio->addOption(1, $name = 'yes');
    $radio->addOption(0, $name = 'no');
    $form->addElement($radio);
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set if you would like to use the owner/breeder fields of the database.<br />As the name suggests the owner/breeder fields let you record and display information about the owner and or breeder.<br />The owner/breeder menu items will also be affected by this setting.'));
    $radiobr = new XoopsFormRadio('<b>Show brother & sister field</b>', 'brothers', $value = $moduleConfig['brothers']);
    $radiobr->addOption(1, $name = 'yes');
    $radiobr->addOption(0, $name = 'no');
    $form->addElement($radiobr);
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set if you would like to use the add a ' . $moduleConfig['litter'] . 'feature.<br />If your chosen animal only has one offspring at a time this feature will not be useful to you.'));
    $radiolit = new XoopsFormRadio('<b>Use add a ' . $moduleConfig['litter'] . ' feature</b>', 'uselitter', $value = $moduleConfig['uselitter']);
    $radiolit->addOption(1, $name = 'yes');
    $radiolit->addOption(0, $name = 'no');
    $form->addElement($radiolit);
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set if you would like to display the brothers & sisters field on the detailed ' . $moduleConfig['animalType'] . ' information page.'));
    $radioch = new XoopsFormRadio('<b>Show ' . $moduleConfig['children'] . ' field</b>', 'pups', $value = $moduleConfig['pups']);
    $radioch->addOption(1, $name = 'yes');
    $radioch->addOption(0, $name = 'no');
    $form->addElement($radioch);
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set if you would like to display the ' . $moduleConfig['children'] . ' field on the detailed ' . $moduleConfig['animalType'] . ' information page.'));
    $form->addElement(new XoopsFormButton('', 'button_id', 'Submit', 'submit'));
    $xoopsTpl->assign('form', $form->render());
}

function settingssave()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form     = '';
    $settings = array('perpage', 'ownerbreeder', 'brothers', 'uselitter', 'pups');
    foreach ($_POST as $key => $values) {

        if (in_array($key, $settings)) {
            //          $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $values . "' WHERE conf_name = '" . $key . "'";

            $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $GLOBALS['xoopsDB']->escape($values) . "' WHERE conf_name = '" . $GLOBALS['xoopsDB']->escape($key) . "'";
            $GLOBALS['xoopsDB']->query($query);
        }
    }
    $form .= 'Your settings have been saved.<hr>';
    $xoopsTpl->assign('form', $form);
}

function lang()
{
    global $xoopsTpl, $moduleConfig;
function myFunction($a, $b) {
    // Do something
}
    include XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
    $form = new XoopsThemeForm('Language options', 'language', 'tools.php?op=langsave', 'POST');
    $form->addElement(new XoopsFormHiddenToken($name = 'XOOPS_TOKEN_REQUEST', $timeout = 360));
    $form->addElement(new XoopsFormText('<b>type of animal</b>', 'animalType', $size = 50, $maxsize = 255, $value = $moduleConfig['animalType']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the animal type which will be used in the application.<br /><i>example : </i>snake, pigeon, dog, owl<br /><br />The value should fit in the sentences below.<br />Please add optional information for this <b>' . $moduleConfig['animalType'] . '</b>.<br />Select the first letter of the <b>' . $moduleConfig['animalType'] . '</b>.'));
    $form->addElement(new XoopsFormText('<b>type of animal</b>', 'animalTypes', $size = 50, $maxsize = 255, $value = $value = $moduleConfig['animalTypes']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the animal type which will be used in the application.<br />This field is the plural of the previous field<br /><i>example : </i>snakes, pigeons, dogs, owls<br /><br />The value should fit in the sentence below.<br />No <b>' . $moduleConfig['animalTypes'] . '</b> meeting your query have been found.'));
    $form->addElement(new XoopsFormText('<b>male</b>', 'male', $size = 50, $maxsize = 255, $value = $moduleConfig['male']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the name used for the male animal.<br /><i>example : </i>male, buck, sire etc.'));
    $form->addElement(new XoopsFormText('<b>female</b>', 'female', $size = 50, $maxsize = 255, $value = $moduleConfig['female']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the name used for the female animal.<br /><i>example : </i>female, vixen, dam etc.'));
    $form->addElement(new XoopsFormText('<b>children</b>', 'children', $size = 50, $maxsize = 255, $value = $moduleConfig['children']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the name used for children of this type of animal (' . $moduleConfig['animalTypes'] . ').<br /><i>example : </i>pups, cubs, kittens etc.'));
    $form->addElement(new XoopsFormText('<b>mother</b>', 'mother', $size = 50, $maxsize = 255, $value = $moduleConfig['mother']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the name used for mother of this type of animal (' . $moduleConfig['animalTypes'] . ').<br /><i>example : </i>dam, mare etc.'));
    $form->addElement(new XoopsFormText('<b>father</b>', 'father', $size = 50, $maxsize = 255, $value = $moduleConfig['father']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the name used for father of this type of animal (' . $moduleConfig['animalTypes'] . ').<br /><i>example : </i>sire, stallion etc.'));
    $form->addElement(new XoopsFormText('<b>litter</b>', 'litter', $size = 50, $maxsize = 255, $value = $moduleConfig['litter']));
    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the name used for a collection of newborn animals.<br /><i>example : </i>litter, nest etc.'));
    $form->addElement(new XoopsFormTextArea('<b>Welcome text</b>', 'welcome', $value = $moduleConfig['welcome'], $rows = 15, $cols = 50));

    $form->addElement(new XoopsFormLabel(_MA_PEDIGREE_EXPLAIN, 'Use this field to set the text you would like to display for the welcome page.<br /><br />You may use the follwing variables :<br />[animalType] = ' . $moduleConfig['animalType'] . '<br />[animalTypes] =' . $moduleConfig['animalTypes'] . '<br />[numanimals] = number of animals in the database.'));
    $form->addElement(new XoopsFormButton('', 'button_id', 'Submit', 'submit'));
    $xoopsTpl->assign('form', $form->render());
}

function langsave()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $form     = '';
    $settings = array('animalType', 'animalTypes', 'male', 'female', 'children', 'mother', 'father', 'litter', 'welcome');
    foreach ($_POST as $key => $values) {

        if (in_array($key, $settings)) {
            //          $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $values . "' WHERE conf_name = '" . $key . "'";

            $query = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('config') . " SET conf_value = '" . $GLOBALS['xoopsDB']->escape($values) . "' WHERE conf_name = '" . $GLOBALS['xoopsDB']->escape($key) . "'";
            $GLOBALS['xoopsDB']->query($query);
        }
    }
    $form .= 'Your settings have been saved.<hr>';
    $xoopsTpl->assign('form', $form);
}


Push — master ( 871d94...af939e )

tools.php ➔ userfields() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

mambax7 / pedigree

Push — master ( 871d94...af939e )

tools.php ➔ userfields() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like